12379 2007-01-23 04:44:38 -0800 ASSERTION FAILED: extensions->genericContext<SVGAnimatedLength>(obj.get()) == imp (during layout tests) 2007-01-23 14:31:44 -0800 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/post-commit-leaks-powerpc-mac-os-x/builds/4500/step-leak-test/0 LayoutTestFailure, Regression P1 Blocker --- 1 mrowe zimmermann zimmermann oldest_to_newest 33135 0 mrowe 2007-01-23 04:44:38 -0800 ASSERTION FAILED: extensions->genericContext<SVGAnimatedLength>(obj.get()) == imp (/Users/buildbot/Desktop/BuildData/WebKit-BuildSlave/post-commit-leaks-powerpc-mac-os-x/build/WebKitBuild/Debug/DerivedSources/WebCore/JSSVGLinearGradientElement.cpp:104 KJS::JSValue* WebCore::JSSVGLinearGradientElement::getValueProperty(KJS::ExecState*, int) const) Segmentation fault Appears to happen on or just before svg/custom/js-update-gradient.svg. It does not reproduce 100% of the time. I've not managed to reproduce it when trying to retrieve a backtrace. 33131 1 ddkilzer 2007-01-23 04:50:20 -0800 (In reply to comment #0) > Appears to happen on or just before svg/custom/js-update-gradient.svg. It does > not reproduce 100% of the time. I've not managed to reproduce it when trying > to retrieve a backtrace. Log into the buildbot server and pick up the stack trace from ~/Library/Logs/CrashReporter/DumpRenderTree.crash.log for the time it happened. 33126 2 mrowe 2007-01-23 04:56:07 -0800 I don't have easy access to the build slave in question (that I know of), or I'd do just that :-) 33127 3 zimmermann 2007-01-23 05:16:56 -0800 [14:14] bdash: WildFox: so why does it only sometimes happen? [14:14] WildFox: bdash: well, ie. if you access mygradient.x1 from JS following happens [14:15] WildFox: the "x1" is a SVGAnimatedLength object [14:15] WildFox: we store the "context" ("mygradient") with the "x1" pointer in a hashmap [14:15] WildFox: so if you call mygradient.x1.baseVal.value it will update the right context [14:15] WildFox: (SVG DOM oddness) [14:15] WildFox: the problem is that cache is never cleared [14:15] WildFox: for single-docs, no problem [14:16] WildFox: if you open a new document, which also access mygradient.x1 you may have bad luck that the _same_ pointer is used [14:16] WildFox: same x1 pointer [14:16] bdash: WildFox: ah, right [14:16] WildFox: it's really "bad luck" if that happens [14:16] bdash: but it's what is happening ;) [14:16] WildFox: bdash: we just need to find "the right place" to clear the caches We need to find a place to clear the caches ASAP! Anyone got an idea? 33048 4 mjs 2007-01-23 09:51:46 -0800 Shouldn't each document have its own separate cache? 33015 5 12634 zimmermann 2007-01-23 12:41:53 -0800 Created attachment 12634 Initial patch Okay, it turned out there is no need for any place to "clear the cache". It would even be wrong to do that - as discussed with Maciej. I just forgot to remove the context objects from the SVGDocumentExtension cache once their corresponding JS objects get destructed. Ran layout tests 10 times now - couldn't reproduce anymore - hopefully it's fixed. 32955 6 12634 mjs 2007-01-23 14:22:27 -0800 Comment on attachment 12634 Initial patch r=me 32956 7 zimmermann 2007-01-23 14:31:44 -0800 Landed in r19058. 12634 2007-01-23 12:41:53 -0800 2007-01-23 14:22:27 -0800 Initial patch FixAssertion.diff text/plain 2734 zimmermann SW5kZXg6IGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCShyZXZpc2lvbiAxOTA0OSkKKysr IGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCSh3b3JraW5nIGNvcHkpCkBAIC03 MTcsNyArNzE3LDEzIEBACiAgICAgIyBEZXN0cnVjdG9yCiAgICAgaWYgKCEkaGFzUGFyZW50KSB7 CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiJHtjbGFzc05hbWV9Ojp+JGNsYXNzTmFtZSgp XG4iKTsKLSAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ7XG4gICAgU2NyaXB0SW50ZXJwcmV0 ZXI6OmZvcmdldERPTU9iamVjdChtX2ltcGwuZ2V0KCkpO1xufVxuXG4iKTsKKworICAgICAgICBp ZiAoJGNvZGVHZW5lcmF0b3ItPklzU1ZHQW5pbWF0ZWRUeXBlKCRpbnRlcmZhY2VOYW1lKSkgewor ICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ7XG4gICAgU1ZHRG9jdW1lbnRFeHRlbnNp b25zOjpmb3JnZXRHZW5lcmljQ29udGV4dDwkaW50ZXJmYWNlTmFtZT4obV9pbXBsLmdldCgpKTtc biIpOyAgIAorICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgU2NyaXB0SW50ZXJw cmV0ZXI6OmZvcmdldERPTU9iamVjdChtX2ltcGwuZ2V0KCkpO1xufVxuXG4iKTsKKyAgICAgICAg fSBlbHNlIHsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAie1xuICAgIFNjcmlwdElu dGVycHJldGVyOjpmb3JnZXRET01PYmplY3QobV9pbXBsLmdldCgpKTtcbn1cblxuIik7CisgICAg ICAgIH0KICAgICB9CiAKICAgICAjIERvY3VtZW50IG5lZWRzIGEgc3BlY2lhbCBkZXN0cnVjdG9y IGJlY2F1c2UgaXQncyBhIHNwZWNpYWwgY2FzZSBmb3IgY2FjaGluZy4gSXQgbmVlZHMKSW5kZXg6 IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDUwKQorKysg Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsMTcgQEAKIDIwMDctMDEtMjMgIE5p a29sYXMgWmltbWVybWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KIAorICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZXZpbCBnZW5lcmljQ29udGV4dCgp IGFzc2VydGlvbiwgd2hpY2ggb2Njb3VycyBzb21ldGltZXMgd2hlbiBydW5uaW5nIERSVC4KKyAg ICAgICAgRml4ZXM6IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzc5 CisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAg ICAgKiBrc3ZnMi9taXNjL1NWR0RvY3VtZW50RXh0ZW5zaW9ucy5oOgorICAgICAgICAoV2ViQ29y ZTo6U1ZHRG9jdW1lbnRFeHRlbnNpb25zOjpnZW5lcmljQ29udGV4dE1hcCk6CisgICAgICAgIChX ZWJDb3JlOjpTVkdEb2N1bWVudEV4dGVuc2lvbnM6OmZvcmdldEdlbmVyaWNDb250ZXh0KToKKwor MjAwNy0wMS0yMyAgTmlrb2xhcyBaaW1tZXJtYW5uICA8emltbWVybWFubkBrZGUub3JnPgorCiAg ICAgICAgIFJldmlld2VkIGJ5IFNhbS4KIAogICAgICAgICBGaXggZHluYW1pYyBjcmVhdGlvbi91 cGRhdGVzIG9mIG1hcmtlcnMsIG1hc2tzLCBjbGlwUGF0aHMsIGFuZCBzZXZlcmFsIHRpbnkgcGF0 dGVybiBpc3N1ZXMuCkluZGV4OiBrc3ZnMi9taXNjL1NWR0RvY3VtZW50RXh0ZW5zaW9ucy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGtzdmcyL21pc2MvU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmgJKHJldmlzaW9u IDE5MDQ5KQorKysga3N2ZzIvbWlzYy9TVkdEb2N1bWVudEV4dGVuc2lvbnMuaAkod29ya2luZyBj b3B5KQpAQCAtODEsNyArODEsNyBAQAogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEtl eVR5cGU+Ci0gICAgSGFzaE1hcDxjb25zdCBLZXlUeXBlKiwgY29uc3QgU1ZHRWxlbWVudCo+KiBn ZW5lcmljQ29udGV4dE1hcCgpIGNvbnN0CisgICAgc3RhdGljIEhhc2hNYXA8Y29uc3QgS2V5VHlw ZSosIGNvbnN0IFNWR0VsZW1lbnQqPiogZ2VuZXJpY0NvbnRleHRNYXAoKQogICAgIHsKICAgICAg ICAgc3RhdGljIEhhc2hNYXA8Y29uc3QgS2V5VHlwZSosIGNvbnN0IFNWR0VsZW1lbnQqPiogc19n ZW5lcmljQ29udGV4dE1hcCA9IG5ldyBIYXNoTWFwPGNvbnN0IEtleVR5cGUqLCBjb25zdCBTVkdF bGVtZW50Kj4oKTsKICAgICAgICAgcmV0dXJuIHNfZ2VuZXJpY0NvbnRleHRNYXA7CkBAIC0xNjgs NiArMTY4LDEzIEBACiAgICAgewogICAgICAgICByZXR1cm4gZ2VuZXJpY0NvbnRleHRNYXA8S2V5 VHlwZT4oKS0+Y29udGFpbnMob2JqKTsKICAgICB9CisKKyAgICAvLyBVc2VkIGJ5IHRoZSBnZW5l cmF0ZWQgSlMgd3JhcHBlcnMgb25seQorICAgIHRlbXBsYXRlPHR5cGVuYW1lIEtleVR5cGU+Cisg ICAgc3RhdGljIHZvaWQgZm9yZ2V0R2VuZXJpY0NvbnRleHQoY29uc3QgS2V5VHlwZSogb2JqKQor ICAgIHsKKyAgICAgICAgZ2VuZXJpY0NvbnRleHRNYXA8S2V5VHlwZT4oKS0+cmVtb3ZlKG9iaik7 CisgICAgfQogfTsKIAogLy8gU3BlY2lhbCBoYW5kbGluZyBmb3IgV2ViQ29yZTo6U3RyaW5nCg==