123788 2013-11-04 22:37:14 -0800 GetById->GetByOffset and PutById->PutByOffset folding should mark haveStructures since it may result in structure transition watchpoints 2013-11-05 10:51:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 947032 0 fpizlo 2013-11-04 22:37:14 -0800 This is totally asymptomatic as far as I can tell even though it's a violation of IR semantics. It just sort of "works" because this only arises if you already had a transition watchpoint for that structure, which usually ends up being good enough since watchpoints invalidate the whole function. 947033 1 216005 fpizlo 2013-11-04 22:44:03 -0800 Created attachment 216005 the patch 947248 2 216005 ggaren 2013-11-05 10:37:00 -0800 Comment on attachment 216005 the patch r=me The phrase "have structures" does not communicate this detail to me. I think by "have" you mean "speculated about, in a way which is invalid after an operation that clobbers the world". Maybe a better name would be "hasStructureSpeculations" or "hasStructuresToClobber" or "hasClobberableStructures". 947252 3 fpizlo 2013-11-05 10:45:47 -0800 (In reply to comment #2) > (From update of attachment 216005 [details]) > r=me > > The phrase "have structures" does not communicate this detail to me. I think by "have" you mean "speculated about, in a way which is invalid after an operation that clobbers the world". Maybe a better name would be "hasStructureSpeculations" or "hasStructuresToClobber" or "hasClobberableStructures". Fair point. I'll try to think of a better name. 947256 4 fpizlo 2013-11-05 10:51:17 -0800 Landed in http://trac.webkit.org/changeset/158680 216005 2013-11-04 22:44:03 -0800 2013-11-05 10:37:00 -0800 the patch blah.patch text/plain 2314 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NjQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTExLTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg R2V0QnlJZC0+R2V0QnlPZmZzZXQgYW5kIFB1dEJ5SWQtPlB1dEJ5T2Zmc2V0IGZvbGRpbmcgc2hv dWxkIG1hcmsgaGF2ZVN0cnVjdHVyZXMgc2luY2UgaXQgbWF5IHJlc3VsdCBpbiBzdHJ1Y3R1cmUg dHJhbnNpdGlvbiB3YXRjaHBvaW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTIzNzg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisgICAgICAgIAorICAgICAgICBoYXZlU3RydWN0dXJlcyBpcyB0cnVlIGlmIHRoZXJlIGFy ZSBhbnkgY3VycmVudGx5S25vd25TdHJ1Y3R1cmVzIHRoYXQgaGF2ZQorICAgICAgICBpbnRlcmVz dGluZyB2YWx1ZXMsIHNpbmNlIHRoYXQncyB0aGUgb25seSB0aW1lIHdoZW4gY2xvYmJlcmluZyBu ZWVkcyB0byBkbyB0aGluZ3MuCisgICAgICAgIEl0J3MgYSByZWFsbHkgaW1wb3J0YW50IGNvbXBp bGUtdGltZSBvcHRpbWl6YXRpb24uIEJ1dCB0aGF0IGFsc28gbWVhbnMgdGhhdCBhbnl0aW1lCisg ICAgICAgIHdlIG1pZ2h0IGNhdXNlIGN1cnJlbnRseUtub3duU3RydWN0dXJlcyB0byBnZXQgc2V0 IC0gbGlrZSB3aGVuIHdlIG1pZ2h0IGluc2VydCBzb21lCisgICAgICAgIHN0cnVjdHVyZSB0cmFu c2l0aW9uIHdhdGNocG9pbnRzIC0gd2UgbmVlZCB0byBzZXQgaGF2ZVN0cnVjdHVyZXMuIFdlIHdl cmUgZm9yZ2V0dGluZworICAgICAgICB0byBkbyB0aGF0IGZvciBHZXRCeUlkLT5HZXRCeU9mZnNl dCBhbmQgUHV0QnlJZC0+UHV0QnlPZmZzZXQgYmVjYXVzZSwgSSBndWVzcywgd2UKKyAgICAgICAg Zm9yZ290IHRoYXQgdGhvc2UgbWlnaHQgaW5zZXJ0IHN0cnVjdHVyZSB0cmFuc2l0aW9uIHdhdGNo cG9pbnRzLgorCisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6 CisgICAgICAgIChKU0M6OkRGRzo6OjpleGVjdXRlRWZmZWN0cyk6CisKIDIwMTMtMTEtMDQgIE1p Y2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihy MTU4NTg2KTogcGx1Z2lucy9yZWZjb3VudC1sZWFrcy5odG1sIGZhaWxzCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEludGVycHJldGVy SW5saW5lcy5oCShyZXZpc2lvbiAxNTg2MzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyODIs NiArMTI4Miw3IEBAIGJvb2wgQWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHkKICAg ICAgICAgICAgICAgICAgICAgZmlsdGVyKG5vZGUtPmNoaWxkMSgpLCBzdGF0dXMuc3RydWN0dXJl U2V0KCkpOwogICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgbV9zdGF0 ZS5zZXRGb3VuZENvbnN0YW50cyh0cnVlKTsKKyAgICAgICAgICAgICAgICAgICAgbV9zdGF0ZS5z ZXRIYXZlU3RydWN0dXJlcyh0cnVlKTsKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgICAgICAgICAgfQogICAgICAgICAgICAgfQpAQCAtMTQ3OSw2ICsxNDgwLDcgQEAgYm9vbCBB YnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0U3RhdGVUeQogICAgICAgICAgICAgaWYgKHN0YXR1 cy5pc1NpbXBsZVJlcGxhY2UoKSkgewogICAgICAgICAgICAgICAgIGZpbHRlcihub2RlLT5jaGls ZDEoKSwgc3RydWN0dXJlKTsKICAgICAgICAgICAgICAgICBtX3N0YXRlLnNldEZvdW5kQ29uc3Rh bnRzKHRydWUpOworICAgICAgICAgICAgICAgIG1fc3RhdGUuc2V0SGF2ZVN0cnVjdHVyZXModHJ1 ZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBp ZiAoc3RhdHVzLmlzU2ltcGxlVHJhbnNpdGlvbigpKSB7Cg==