123779 2013-11-04 20:22:35 -0800 DFG CheckArray(String) should just be a Phantom(String:) 2013-11-04 21:38:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 123783 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 946980 0 fpizlo 2013-11-04 20:22:35 -0800 Patch forthcoming. 946982 1 215990 fpizlo 2013-11-04 20:24:32 -0800 Created attachment 215990 the patch 947013 2 215990 ggaren 2013-11-04 21:35:23 -0800 Comment on attachment 215990 the patch r=me 947016 3 fpizlo 2013-11-04 21:38:23 -0800 Landed in http://trac.webkit.org/changeset/158644 215990 2013-11-04 20:24:32 -0800 2013-11-04 21:35:23 -0800 the patch blah.patch text/plain 5515 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NjM5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEzLTExLTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIENoZWNrQXJyYXkoU3RyaW5nKSBzaG91bGQganVzdCBiZSBhIFBoYW50b20oU3RyaW5nOikK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzc3OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg VGhpcyBzaG91bGQgYmUgYSBzcGVlZC11cCBzaW5jZSBQaGFudG9tKFN0cmluZzopIGlzIHNtYXJ0 IGVub3VnaCB0byB1c2UgdGhlIHN0cmluZworICAgICAgICBzdHJ1Y3R1cmUuIEl0IHNob3VsZCBh bHNvIGJlIGEgc2ltcGxpZmljYXRpb24gc2luY2UgQ2hlY2tBcnJheShTdHJpbmcpIHdhcyB0b3Rh bGx5CisgICAgICAgIHJlZHVuZGFudC4KKyAgICAgICAgCisgICAgICAgIEFsc28gRml4dXBQaGFz ZSB3YXMgYXNzdW1pbmcgdGhhdCBpdCBtYXkgc2VlIENoZWNrQXJyYXkncy4gVGhhdCdzIHdyb25n LiBJdCBjYW4KKyAgICAgICAgY3JlYXRlIENoZWNrQXJyYXkncyBidXQgaXQgd29uJ3Qgc2VlIHRo ZW0gYXMgaW5wdXQgc2luY2Ugbm8gcHJldmlvdXMgcGhhc2UgY2FuCisgICAgICAgIGNyZWF0ZSB0 aGVtLgorCisgICAgICAgICogZGZnL0RGR0ZpeHVwUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpE Rkc6OkZpeHVwUGhhc2U6OmZpeHVwTm9kZSk6CisgICAgICAgIChKU0M6OkRGRzo6Rml4dXBQaGFz ZTo6Y2hlY2tBcnJheSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y2hlY2tBcnJheSk6CisKIDIwMTMtMTEt MDQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgTmV3QXJy YXkvTmV3QXJyYXlCdWZmZXIgc2hvdWxkbid0IGJlIGNvbnN0cnVjdGluZyB3aXRoIG5lZ2F0aXZl IGluZGV4aW5nCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFz ZS5jcHAJKHJldmlzaW9uIDE1ODYzMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Rml4dXBQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgwNiwxOCArODA2LDYgQEAgcHJpdmF0 ZToKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgICAgICAKLSAgICAgICAg Y2FzZSBDaGVja0FycmF5OiB7Ci0gICAgICAgICAgICBzd2l0Y2ggKG5vZGUtPmFycmF5TW9kZSgp LnR5cGUoKSkgewotICAgICAgICAgICAgY2FzZSBBcnJheTo6U3RyaW5nOgotICAgICAgICAgICAg ICAgIGZpeEVkZ2U8U3RyaW5nVXNlPihub2RlLT5jaGlsZDEoKSk7Ci0gICAgICAgICAgICAgICAg YnJlYWs7Ci0gICAgICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAgICAgIGZpeEVkZ2U8Q2Vs bFVzZT4obm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAg ICAgfQotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICAgICAgICAgIAogICAgICAg ICBjYXNlIEFycmF5aWZ5OgogICAgICAgICBjYXNlIEFycmF5aWZ5VG9TdHJ1Y3R1cmU6IHsKICAg ICAgICAgICAgIGZpeEVkZ2U8Q2VsbFVzZT4obm9kZS0+Y2hpbGQxKCkpOwpAQCAtODg4LDYgKzg3 Niw3IEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgSW50NTJUb0RvdWJsZToKICAgICAgICAgY2Fz ZSBJbnQ1MlRvVmFsdWU6CiAgICAgICAgIGNhc2UgSW52YWxpZGF0aW9uUG9pbnQ6CisgICAgICAg IGNhc2UgQ2hlY2tBcnJheToKICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVE KCk7CiAgICAgICAgICAgICBicmVhazsKIApAQCAtMTI3NSwyOSArMTI2NCwzNSBAQCBwcml2YXRl OgogICAgIHsKICAgICAgICAgQVNTRVJUKGFycmF5TW9kZS5pc1NwZWNpZmljKCkpOwogICAgICAg ICAKLSAgICAgICAgU3RydWN0dXJlKiBzdHJ1Y3R1cmUgPSBhcnJheU1vZGUub3JpZ2luYWxBcnJh eVN0cnVjdHVyZShtX2dyYXBoLCBjb2RlT3JpZ2luKTsKKyAgICAgICAgaWYgKGFycmF5TW9kZS50 eXBlKCkgPT0gQXJyYXk6OlN0cmluZykgeworICAgICAgICAgICAgbV9pbnNlcnRpb25TZXQuaW5z ZXJ0Tm9kZSgKKyAgICAgICAgICAgICAgICBtX2luZGV4SW5CbG9jaywgU3BlY05vbmUsIFBoYW50 b20sIGNvZGVPcmlnaW4sCisgICAgICAgICAgICAgICAgRWRnZShhcnJheSwgU3RyaW5nVXNlKSk7 CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IGFy cmF5TW9kZS5vcmlnaW5hbEFycmF5U3RydWN0dXJlKG1fZ3JhcGgsIGNvZGVPcmlnaW4pOwogICAg ICAgICAKLSAgICAgICAgRWRnZSBpbmRleEVkZ2UgPSBpbmRleCA/IEVkZ2UoaW5kZXgsIEludDMy VXNlKSA6IEVkZ2UoKTsKKyAgICAgICAgICAgIEVkZ2UgaW5kZXhFZGdlID0gaW5kZXggPyBFZGdl KGluZGV4LCBJbnQzMlVzZSkgOiBFZGdlKCk7CiAgICAgICAgIAotICAgICAgICBpZiAoYXJyYXlN b2RlLmRvZXNDb252ZXJzaW9uKCkpIHsKLSAgICAgICAgICAgIGlmIChzdHJ1Y3R1cmUpIHsKLSAg ICAgICAgICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAotICAgICAgICAgICAgICAg ICAgICBtX2luZGV4SW5CbG9jaywgU3BlY05vbmUsIEFycmF5aWZ5VG9TdHJ1Y3R1cmUsIGNvZGVP cmlnaW4sCi0gICAgICAgICAgICAgICAgICAgIE9wSW5mbyhzdHJ1Y3R1cmUpLCBPcEluZm8oYXJy YXlNb2RlLmFzV29yZCgpKSwgRWRnZShhcnJheSwgQ2VsbFVzZSksIGluZGV4RWRnZSk7Ci0gICAg ICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2VydE5v ZGUoCi0gICAgICAgICAgICAgICAgICAgIG1faW5kZXhJbkJsb2NrLCBTcGVjTm9uZSwgQXJyYXlp ZnksIGNvZGVPcmlnaW4sCi0gICAgICAgICAgICAgICAgICAgIE9wSW5mbyhhcnJheU1vZGUuYXNX b3JkKCkpLCBFZGdlKGFycmF5LCBDZWxsVXNlKSwgaW5kZXhFZGdlKTsKLSAgICAgICAgICAgIH0K LSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIGlmIChzdHJ1Y3R1cmUpIHsKLSAgICAgICAg ICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAotICAgICAgICAgICAgICAgICAgICBt X2luZGV4SW5CbG9jaywgU3BlY05vbmUsIENoZWNrU3RydWN0dXJlLCBjb2RlT3JpZ2luLAotICAg ICAgICAgICAgICAgICAgICBPcEluZm8obV9ncmFwaC5hZGRTdHJ1Y3R1cmVTZXQoc3RydWN0dXJl KSksIEVkZ2UoYXJyYXksIENlbGxVc2UpKTsKKyAgICAgICAgICAgIGlmIChhcnJheU1vZGUuZG9l c0NvbnZlcnNpb24oKSkgeworICAgICAgICAgICAgICAgIGlmIChzdHJ1Y3R1cmUpIHsKKyAgICAg ICAgICAgICAgICAgICAgbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9kZSgKKyAgICAgICAgICAgICAg ICAgICAgICAgIG1faW5kZXhJbkJsb2NrLCBTcGVjTm9uZSwgQXJyYXlpZnlUb1N0cnVjdHVyZSwg Y29kZU9yaWdpbiwKKyAgICAgICAgICAgICAgICAgICAgICAgIE9wSW5mbyhzdHJ1Y3R1cmUpLCBP cEluZm8oYXJyYXlNb2RlLmFzV29yZCgpKSwgRWRnZShhcnJheSwgQ2VsbFVzZSksIGluZGV4RWRn ZSk7CisgICAgICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAgICAgbV9pbnNl cnRpb25TZXQuaW5zZXJ0Tm9kZSgKKyAgICAgICAgICAgICAgICAgICAgICAgIG1faW5kZXhJbkJs b2NrLCBTcGVjTm9uZSwgQXJyYXlpZnksIGNvZGVPcmlnaW4sCisgICAgICAgICAgICAgICAgICAg ICAgICBPcEluZm8oYXJyYXlNb2RlLmFzV29yZCgpKSwgRWRnZShhcnJheSwgQ2VsbFVzZSksIGlu ZGV4RWRnZSk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAg ICAgICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAotICAgICAgICAgICAgICAgICAg ICBtX2luZGV4SW5CbG9jaywgU3BlY05vbmUsIENoZWNrQXJyYXksIGNvZGVPcmlnaW4sCi0gICAg ICAgICAgICAgICAgICAgIE9wSW5mbyhhcnJheU1vZGUuYXNXb3JkKCkpLCBFZGdlKGFycmF5LCBD ZWxsVXNlKSk7CisgICAgICAgICAgICAgICAgaWYgKHN0cnVjdHVyZSkgeworICAgICAgICAgICAg ICAgICAgICBtX2luc2VydGlvblNldC5pbnNlcnROb2RlKAorICAgICAgICAgICAgICAgICAgICAg ICAgbV9pbmRleEluQmxvY2ssIFNwZWNOb25lLCBDaGVja1N0cnVjdHVyZSwgY29kZU9yaWdpbiwK KyAgICAgICAgICAgICAgICAgICAgICAgIE9wSW5mbyhtX2dyYXBoLmFkZFN0cnVjdHVyZVNldChz dHJ1Y3R1cmUpKSwgRWRnZShhcnJheSwgQ2VsbFVzZSkpOworICAgICAgICAgICAgICAgIH0gZWxz ZSB7CisgICAgICAgICAgICAgICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCisgICAg ICAgICAgICAgICAgICAgICAgICBtX2luZGV4SW5CbG9jaywgU3BlY05vbmUsIENoZWNrQXJyYXks IGNvZGVPcmlnaW4sCisgICAgICAgICAgICAgICAgICAgICAgICBPcEluZm8oYXJyYXlNb2RlLmFz V29yZCgpKSwgRWRnZShhcnJheSwgQ2VsbFVzZSkpOworICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAxNTg2MzApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBj b3B5KQpAQCAtNzUxLDcgKzc1MSw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNoZWNrQXJyYXko Tm9kZSogbm8KICAgICAKICAgICBzd2l0Y2ggKG5vZGUtPmFycmF5TW9kZSgpLnR5cGUoKSkgewog ICAgIGNhc2UgQXJyYXk6OlN0cmluZzoKLSAgICAgICAgZXhwZWN0ZWRDbGFzc0luZm8gPSBKU1N0 cmluZzo6aW5mbygpOworICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyAvLyBT aG91bGQgaGF2ZSBiZWVuIGEgUGhhbnRvbShTdHJpbmc6KQogICAgICAgICBicmVhazsKICAgICBj YXNlIEFycmF5OjpJbnQzMjoKICAgICBjYXNlIEFycmF5OjpEb3VibGU6Cg==