123764 2013-11-04 16:28:20 -0800 Remove PlatformCALayer::playerLayer 2013-11-04 17:21:40 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue simon.fraser oldest_to_newest 946880 0 thorton 2013-11-04 16:28:20 -0800 It's only used internally to PlatformCALayerMac, and only in one place. I'm just going to fold it into the caller. 946881 1 215967 thorton 2013-11-04 16:34:49 -0800 Created attachment 215967 patch 946912 2 215967 commit-queue 2013-11-04 17:21:38 -0800 Comment on attachment 215967 patch Clearing flags on attachment: 215967 Committed r158619: <http://trac.webkit.org/changeset/158619> 946913 3 commit-queue 2013-11-04 17:21:40 -0800 All reviewed patches have been landed. Closing bug. 215967 2013-11-04 16:34:49 -0800 2013-11-04 17:21:38 -0800 patch playerlayer.diff text/plain 5510 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhODNiYWU2Li5kMWNkNmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMTEtMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIFBsYXRmb3JtQ0FMYXllcjo6cGxheWVyTGF5ZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzc2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2EvUGxhdGZvcm1DQUxheWVyLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFj L1BsYXRmb3JtQ0FMYXllck1hYy5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL21h Yy9QbGF0Zm9ybUNBTGF5ZXJNYWMubW06CisgICAgICAgIChQbGF0Zm9ybUNBTGF5ZXJNYWM6OmNs b25lKToKKyAgICAgICAgUmVtb3ZlIHBsYXllckxheWVyKCksIGZvbGQgaXQgaW50byBjbG9uZSgp LgorCiAyMDEzLTExLTA0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAg ICAgICAgIEltcGxlbWVudCBnZW5lcmF0ZUtleSBmb3IgSE1BQyBhbmQgQUVTLUNCQwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvUGxhdGZvcm1DQUxheWVy LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9QbGF0Zm9ybUNBTGF5ZXIu aAppbmRleCBhOWNlM2Y4Li5lMDY2Yzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9QbGF0Zm9ybUNBTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYS9QbGF0Zm9ybUNBTGF5ZXIuaApAQCAtMjA4LDEwICsyMDgsNiBA QCBwcm90ZWN0ZWQ6CiAKICAgICB9CiAKLSNpZiBQTEFURk9STShNQUMpCi0gICAgdmlydHVhbCBB VlBsYXllckxheWVyKiBwbGF5ZXJMYXllcigpIGNvbnN0ID0gMDsKLSNlbmRpZgotCiAgICAgTGF5 ZXJUeXBlIG1fbGF5ZXJUeXBlOwogICAgIFJldGFpblB0cjxQbGF0Zm9ybUxheWVyPiBtX2xheWVy OwogICAgIFBsYXRmb3JtQ0FMYXllckNsaWVudCogbV9vd25lcjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBTGF5ZXJNYWMuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBTGF5ZXJN YWMuaAppbmRleCA4N2YyMWMwLi4wMzVkYTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvUGxhdGZvcm1DQUxheWVyTWFjLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1BsYXRmb3JtQ0FMYXllck1hYy5oCkBA IC0xNDQsOCArMTQ0LDYgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBQbGF0Zm9ybUNBTGF5ZXJN YWMoTGF5ZXJUeXBlLCBQbGF0Zm9ybUxheWVyKiwgUGxhdGZvcm1DQUxheWVyQ2xpZW50KiBvd25l cik7CiAKLSAgICB2aXJ0dWFsIEFWUGxheWVyTGF5ZXIgKnBsYXllckxheWVyKCkgY29uc3QgT1ZF UlJJREU7Ci0KICAgICBSZXRhaW5QdHI8TlNPYmplY3Q+IG1fZGVsZWdhdGU7CiAgICAgT3duUHRy PFBsYXRmb3JtQ0FMYXllckxpc3Q+IG1fY3VzdG9tU3VibGF5ZXJzOwogfTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBTGF5ZXJN YWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvUGxhdGZvcm1D QUxheWVyTWFjLm1tCmluZGV4IDc3NmYxZjMuLmZjOWJjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBTGF5ZXJNYWMubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1BsYXRmb3JtQ0FMYXll ck1hYy5tbQpAQCAtMjY5LDggKzI2OSwxMSBAQCBQYXNzUmVmUHRyPFBsYXRmb3JtQ0FMYXllcj4g UGxhdGZvcm1DQUxheWVyTWFjOjpjbG9uZShQbGF0Zm9ybUNBTGF5ZXJDbGllbnQqIG93bgogI2Vu ZGlmCiAKICAgICBpZiAodHlwZSA9PSBMYXllclR5cGVBVlBsYXllckxheWVyKSB7Ci0gICAgICAg IEFWUGxheWVyTGF5ZXIqIGRlc3RpbmF0aW9uUGxheWVyTGF5ZXIgPSBuZXdMYXllci0+cGxheWVy TGF5ZXIoKTsKLSAgICAgICAgQVZQbGF5ZXJMYXllciogc291cmNlUGxheWVyTGF5ZXIgPSBwbGF5 ZXJMYXllcigpOworICAgICAgICBBU1NFUlQoW25ld0xheWVyLT5wbGF0Zm9ybUxheWVyKCkgaXNL aW5kT2ZDbGFzczpnZXRBVlBsYXllckxheWVyQ2xhc3MoKV0pOworICAgICAgICBBU1NFUlQoW3Bs YXRmb3JtTGF5ZXIoKSBpc0tpbmRPZkNsYXNzOmdldEFWUGxheWVyTGF5ZXJDbGFzcygpXSk7CisK KyAgICAgICAgQVZQbGF5ZXJMYXllciogZGVzdGluYXRpb25QbGF5ZXJMYXllciA9IHN0YXRpY19j YXN0PEFWUGxheWVyTGF5ZXIgKj4obmV3TGF5ZXItPnBsYXRmb3JtTGF5ZXIoKSk7CisgICAgICAg IEFWUGxheWVyTGF5ZXIqIHNvdXJjZVBsYXllckxheWVyID0gc3RhdGljX2Nhc3Q8QVZQbGF5ZXJM YXllciAqPihwbGF0Zm9ybUxheWVyKCkpOwogICAgICAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRj aF9nZXRfbWFpbl9xdWV1ZSgpLCBeewogICAgICAgICAgICAgW2Rlc3RpbmF0aW9uUGxheWVyTGF5 ZXIgc2V0UGxheWVyOltzb3VyY2VQbGF5ZXJMYXllciBwbGF5ZXJdXTsKICAgICAgICAgfSk7CkBA IC03MjMsMTIgKzcyNiw2IEBAIFRpbGVkQmFja2luZyogUGxhdGZvcm1DQUxheWVyTWFjOjp0aWxl ZEJhY2tpbmcoKQogICAgIHJldHVybiBbdGlsZWRCYWNraW5nTGF5ZXIgdGlsZWRCYWNraW5nXTsK IH0KIAotQVZQbGF5ZXJMYXllciAqUGxhdGZvcm1DQUxheWVyTWFjOjpwbGF5ZXJMYXllcigpIGNv bnN0Ci17Ci0gICAgQVNTRVJUKFttX2xheWVyLmdldCgpIGlzS2luZE9mQ2xhc3M6Z2V0QVZQbGF5 ZXJMYXllckNsYXNzKCldKTsKLSAgICByZXR1cm4gKEFWUGxheWVyTGF5ZXIgKiltX2xheWVyLmdl dCgpOwotfQotCiBQYXNzUmVmUHRyPFBsYXRmb3JtQ0FMYXllcj4gUGxhdGZvcm1DQUxheWVyTWFj OjpjcmVhdGVDb21wYXRpYmxlTGF5ZXIoUGxhdGZvcm1DQUxheWVyOjpMYXllclR5cGUgbGF5ZXJU eXBlLCBQbGF0Zm9ybUNBTGF5ZXJDbGllbnQqIGNsaWVudCkgY29uc3QKIHsKICAgICByZXR1cm4g UGxhdGZvcm1DQUxheWVyTWFjOjpjcmVhdGUobGF5ZXJUeXBlLCBjbGllbnQpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IDM1OTlkYTAuLmYyZWUzZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0x MS0wNCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgUGxhdGZvcm1DQUxheWVyOjpwbGF5ZXJMYXllcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNzY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRm b3JtQ0FMYXllclJlbW90ZS5jcHA6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9Q bGF0Zm9ybUNBTGF5ZXJSZW1vdGUuaDoKKyAgICAgICAgUmVtb3ZlIHBsYXllckxheWVyKCkuCisK IDIwMTMtMTEtMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBb Q29jb2FdIFdyYXBwZXJzJyAtY29weVdpdGhab25lOiBzaG91bGQgY29weSBpZiB0aGUgY29sbGVj dGlvbiBpcyBtdXRhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90ZS5jcHAKaW5kZXggMTNlMjU1 Yy4uM2Y3OWVhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmNwcApAQCAtNDc2LDExICs0 NzYsNiBAQCB2b2lkIFBsYXRmb3JtQ0FMYXllclJlbW90ZTo6c2V0RWRnZUFudGlhbGlhc2luZ01h c2sodW5zaWduZWQgdmFsdWUpCiAgICAgbV9wcm9wZXJ0aWVzLm5vdGVQcm9wZXJ0aWVzQ2hhbmdl ZChSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjo6RWRnZUFudGlhbGlhc2luZ01hc2tDaGFuZ2Vk KTsKIH0KIAotQVZQbGF5ZXJMYXllciogUGxhdGZvcm1DQUxheWVyUmVtb3RlOjpwbGF5ZXJMYXll cigpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG51bGxwdHI7Ci19Ci0KIFBhc3NSZWZQdHI8UGxhdGZv cm1DQUxheWVyPiBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGU6OmNyZWF0ZUNvbXBhdGlibGVMYXllcihQ bGF0Zm9ybUNBTGF5ZXI6OkxheWVyVHlwZSBsYXllclR5cGUsIFBsYXRmb3JtQ0FMYXllckNsaWVu dCogY2xpZW50KSBjb25zdAogewogICAgIHJldHVybiBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGU6OmNy ZWF0ZShsYXllclR5cGUsIGNsaWVudCwgbV9jb250ZXh0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmggYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90 ZS5oCmluZGV4IDFmNWFmYmIuLmM3NGUwYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxheWVyUmVtb3RlLmgKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuaApA QCAtMTQ5LDggKzE0OSw2IEBAIHByb3RlY3RlZDoKICAgICBQbGF0Zm9ybUNBTGF5ZXJSZW1vdGUo V2ViQ29yZTo6UGxhdGZvcm1DQUxheWVyOjpMYXllclR5cGUsIFdlYkNvcmU6OlBsYXRmb3JtQ0FM YXllckNsaWVudCogb3duZXIsIFJlbW90ZUxheWVyVHJlZUNvbnRleHQqIGNvbnRleHQpOwogCiBw cml2YXRlOgotICAgIHZpcnR1YWwgQVZQbGF5ZXJMYXllciAqcGxheWVyTGF5ZXIoKSBjb25zdCBP VkVSUklERTsKLQogICAgIHZvaWQgZW5zdXJlQmFja2luZ1N0b3JlKCk7CiAgICAgdm9pZCByZW1v dmVTdWJsYXllcihQbGF0Zm9ybUNBTGF5ZXJSZW1vdGUqKTsKIAo=