123758 2013-11-04 15:01:46 -0800 [Win] Use VersionStamper for official builds 2013-11-04 15:24:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham oldest_to_newest 946840 0 bfulgham 2013-11-04 15:01:46 -0800 When we revised the build system for VS2010, the step that would run "VersionStamper" to set the shipping version number on the DLL was lost. This causes some internal stuff to break when we attempt to build for external users. This patch simply puts the missing command back into our post-build scripts so that the right thing happens when building an official release. 946841 1 bfulgham 2013-11-04 15:01:58 -0800 <rdar://problem/15373550> 946843 2 215957 bfulgham 2013-11-04 15:05:59 -0800 Created attachment 215957 Patch 946851 3 bfulgham 2013-11-04 15:24:37 -0800 Committed r158602: <http://trac.webkit.org/changeset/158602> 215957 2013-11-04 15:05:59 -0800 2013-11-04 15:21:38 -0800 Patch bug-123758-20131104150558.patch text/plain 2602 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTg1OTkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTExLTA0ICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIFVzZXIgVmVyc2lvblN0YW1wZXIgZm9y IG9mZmljaWFsIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIzNzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXVEYudmN4cHJvai9XVEZQb3N0QnVpbGQuY21kOiBBZGQgbWlzc2luZyBjb21t YW5kIHRvIHJ1biBWZXJzaW9uU3RhbXBlci5leGUuCisKIDIwMTMtMTEtMDEgIEplciBOb2JsZSAg PGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW1BsdWdpblByb3h5XSBBZGQgYSBzZXR0 aW5nIHRvIGRpc2FibGUgdmlkZW8gcGx1Z2luIHByb3h5IHN1cHBvcnQgaW4gSFRNTE1lZGlhRWxl bWVudC4KSW5kZXg6IFNvdXJjZS9XVEYvV1RGLnZjeHByb2ovV1RGUG9zdEJ1aWxkLmNtZAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV1RGL1dURi52Y3hwcm9qL1dURlBvc3RCdWlsZC5jbWQJKHJldmlz aW9uIDE1ODU5NSkKKysrIFNvdXJjZS9XVEYvV1RGLnZjeHByb2ovV1RGUG9zdEJ1aWxkLmNtZAko d29ya2luZyBjb3B5KQpAQCAtMSArMSwyIEBACiBpZiBleGlzdCAiJUNPTkZJR1VSQVRJT05CVUlM RERJUiVcYnVpbGRmYWlsZWQiIGRlbCAiJUNPTkZJR1VSQVRJT05CVUlMRERJUiVcYnVpbGRmYWls ZWQiCitpZiBleGlzdCAiJVdFQktJVF9MSUJSQVJJRVMlXHRvb2xzXFZlcnNpb25TdGFtcGVyXFZl cnNpb25TdGFtcGVyLmV4ZSIgIiVXRUJLSVRfTElCUkFSSUVTJVx0b29sc1xWZXJzaW9uU3RhbXBl clxWZXJzaW9uU3RhbXBlci5leGUiIC0tdmVyYm9zZSAiJVRBUkdFVFBBVEglIgpcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTg1OTkpCisrKyBTb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEz LTExLTA0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtX aW5dIFVzZSBWZXJzaW9uU3RhbXBlciBmb3Igb2ZmaWNpYWwgYnVpbGRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM3NTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdC52Y3hwcm9qL1dlYktp dC9XZWJLaXRQb3N0QnVpbGQuY21kOiBSZXN0b3JlIGNvbW1hbmQgdG8KKyAgICAgICAgY2FsbCBW ZXJzaW9uU3RhbXBlciBvbiBmaW5hbCBzdGFnZSBvZiBidWlsZC4KKwogMjAxMy0xMS0wMiAgQ2hy aXN0b3BoZSBEdW1leiAgPGNoLmR1bWV6QHNhbXN1bmcuY29tPgogCiAgICAgICAgIEVuZm9yY2VS YW5nZSBkb2Vzbid0IGVuZm9yY2UgcmFuZ2Ugb2YgYSBzaG9ydApJbmRleDogU291cmNlL1dlYktp dC9XZWJLaXQudmN4cHJvai9XZWJLaXQvV2ViS2l0UG9zdEJ1aWxkLmNtZAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktpdC9XZWJLaXRQb3N0QnVpbGQuY21k CShyZXZpc2lvbiAxNTg1OTUpCisrKyBTb3VyY2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktp dC9XZWJLaXRQb3N0QnVpbGQuY21kCSh3b3JraW5nIGNvcHkpCkBAIC0xMyw1ICsxMyw2IEBAIHhj b3B5IC95IC9kICIlQ09ORklHVVJBVElPTkJVSUxERElSJVxpbmMKIAogbWtkaXIgMj5OVUwgIiVD T05GSUdVUkFUSU9OQlVJTERESVIlXGJpbiVQbGF0Zm9ybUFyY2hpdGVjdHVyZSVcV2ViS2l0LnJl c291cmNlcyIKIHhjb3B5IC95IC9kICIlUFJPSkVDVERJUiUuLlwuLlxXZWJLaXQucmVzb3VyY2Vz XCoiICIlQ09ORklHVVJBVElPTkJVSUxERElSJVxiaW4lUGxhdGZvcm1BcmNoaXRlY3R1cmUlXFdl YktpdC5yZXNvdXJjZXMiCitpZiBleGlzdCAiJVdFQktJVF9MSUJSQVJJRVMlXHRvb2xzXFZlcnNp b25TdGFtcGVyXFZlcnNpb25TdGFtcGVyLmV4ZSIgIiVXRUJLSVRfTElCUkFSSUVTJVx0b29sc1xW ZXJzaW9uU3RhbXBlclxWZXJzaW9uU3RhbXBlci5leGUiIC0tdmVyYm9zZSAiJVRBUkdFVFBBVEgl IgogCiBpZiBleGlzdCAiJUNPTkZJR1VSQVRJT05CVUlMRERJUiVcYnVpbGRmYWlsZWQiIGRlbCAi JUNPTkZJR1VSQVRJT05CVUlMRERJUiVcYnVpbGRmYWlsZWQiCg==