123755 2013-11-04 14:13:07 -0800 Fixing MediaStreamDescriptor addSource and addTrack methods 2013-11-04 17:24:56 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thiago.lacerda thiago.lacerda commit-queue eric.carlson glenn hta jer.noble kling tommyw oldest_to_newest 946810 0 thiago.lacerda 2013-11-04 14:13:07 -0800 We must store the track and source that is passed as parameter in a RefPtr, otherwise we will refer to a null pointer. 946815 1 215952 thiago.lacerda 2013-11-04 14:22:18 -0800 Created attachment 215952 Patch 946917 2 215952 commit-queue 2013-11-04 17:24:54 -0800 Comment on attachment 215952 Patch Clearing flags on attachment: 215952 Committed r158620: <http://trac.webkit.org/changeset/158620> 946918 3 commit-queue 2013-11-04 17:24:56 -0800 All reviewed patches have been landed. Closing bug. 215952 2013-11-04 14:22:18 -0800 2013-11-04 17:24:54 -0800 Patch bug-123755-20131104192217.patch text/plain 2238 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4NTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYyZWUxMjZhODFkOWY0 YjIxMmU0NzJkM2I1MTMyZjc5OGE5YjRjMS4uNjQzYzlmZDA4NjA0YzRkMWZkNWFjMzY5ODFmMGVl YTFkYjYzMmI2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTExLTA0ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEZpeGluZyBNZWRpYVN0cmVhbURlc2NyaXB0b3IgYWRkU291cmNlIGFuZCBhZGRUcmFj ayBtZXRob2RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjM3NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZSBtdXN0IHN0b3JlIHRoZSB0cmFjayBhbmQgc291cmNlIHRoYXQgaXMgcGFzc2VkIGFzIHBh cmFtZXRlciBpbiBhIFJlZlB0ciwKKyAgICAgICAgb3RoZXJ3aXNlIHdlIHdpbGwgcmVmZXIgdG8g YSBudWxsIHBvaW50ZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAg ICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtRGVzY3JpcHRvci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpNZWRpYVN0cmVhbURlc2NyaXB0b3I6OmFkZFNvdXJjZSk6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVN0cmVhbURlc2NyaXB0b3I6OmFkZFRyYWNrKToKKwogMjAxMy0xMS0w NCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBMaXZl Tm9kZUxpc3RCYXNlIHVzZSBFbGVtZW50cyBpbnN0ZWFkIG9mIE5vZGVzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbURlc2NyaXB0b3Iu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1EZXNj cmlwdG9yLmNwcAppbmRleCAwNTY2MjY4ODBhZGYyNTJlNTk5Nzk5MTVkMGVhOGYzYzJmMTY3ZjM4 Li5mYzU3YWRhZmRlNmQ3MjM1YTM3ZDk2NDg5Y2JmMzQyYjY5Nzg0MjA1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbURlc2NyaXB0b3Iu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL01lZGlhU3RyZWFt RGVzY3JpcHRvci5jcHAKQEAgLTUyLDggKzUyLDkgQEAgUGFzc1JlZlB0cjxNZWRpYVN0cmVhbURl c2NyaXB0b3I+IE1lZGlhU3RyZWFtRGVzY3JpcHRvcjo6Y3JlYXRlKGNvbnN0IFZlY3RvcjxSZWYK ICAgICByZXR1cm4gYWRvcHRSZWYobmV3IE1lZGlhU3RyZWFtRGVzY3JpcHRvcihjcmVhdGVDYW5v bmljYWxVVUlEU3RyaW5nKCksIGF1ZGlvUHJpdmF0ZVRyYWNrcywgdmlkZW9Qcml2YXRlVHJhY2tz KSk7CiB9CiAKLXZvaWQgTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjphZGRTb3VyY2UoUGFzc1JlZlB0 cjxNZWRpYVN0cmVhbVNvdXJjZT4gc291cmNlKQordm9pZCBNZWRpYVN0cmVhbURlc2NyaXB0b3I6 OmFkZFNvdXJjZShQYXNzUmVmUHRyPE1lZGlhU3RyZWFtU291cmNlPiBwcnBTb3VyY2UpCiB7Cisg ICAgUmVmUHRyPE1lZGlhU3RyZWFtU291cmNlPiBzb3VyY2UgPSBwcnBTb3VyY2U7CiAgICAgc3dp dGNoIChzb3VyY2UtPnR5cGUoKSkgewogICAgIGNhc2UgTWVkaWFTdHJlYW1Tb3VyY2U6OkF1ZGlv OgogICAgICAgICBpZiAobV9hdWRpb1N0cmVhbVNvdXJjZXMuZmluZChzb3VyY2UpID09IG5vdEZv dW5kKQpAQCAtMTcxLDggKzE3Miw5IEBAIHZvaWQgTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjpzZXRF bmRlZCgpCiAgICAgbV9lbmRlZCA9IHRydWU7CiB9CiAKLXZvaWQgTWVkaWFTdHJlYW1EZXNjcmlw dG9yOjphZGRUcmFjayhQYXNzUmVmUHRyPE1lZGlhU3RyZWFtVHJhY2tQcml2YXRlPiB0cmFjaykK K3ZvaWQgTWVkaWFTdHJlYW1EZXNjcmlwdG9yOjphZGRUcmFjayhQYXNzUmVmUHRyPE1lZGlhU3Ry ZWFtVHJhY2tQcml2YXRlPiBwcnBUcmFjaykKIHsKKyAgICBSZWZQdHI8TWVkaWFTdHJlYW1UcmFj a1ByaXZhdGU+IHRyYWNrID0gcHJwVHJhY2s7CiAgICAgaWYgKHRyYWNrLT5lbmRlZCgpKQogICAg ICAgICByZXR1cm47CiAK