123750 2013-11-04 11:18:36 -0800 Web Inspector: localStorage inspector very slow on big values 2016-02-22 03:38:27 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED https://test2.wikipedia.org InRadar P2 Normal --- 1 hartman.wiki webkit-unassigned commit-queue joepeck timothy webkit-bug-importer oldest_to_newest 946746 0 hartman.wiki 2013-11-04 11:18:36 -0800 Currently Wikipedia is testing caching JavaScript in localStorage. In testing this, I noticed that trying to inspect localStorage using Safari becomes almost impossible. When trying to represent the value in the inspector, it seems to want to display the entire value in the row, which takes upto a minute. The inspector should be smarter about this and recognize that a very big value is not fully suite to be represented like this, but should be shown using a file like representation. 946747 1 webkit-bug-importer 2013-11-04 11:18:46 -0800 <rdar://problem/15384930> 946752 2 timothy 2013-11-04 11:36:28 -0800 I agree, the current presentation does not live up how people are using LocalStorage now. Even the Inspector itself dumps large values into LocalStorage that it can't show. Detecting large values and letting you view them full-view would be great. Thanks for the bug and Wikipedia test case! 1070366 3 hartman.wiki 2015-02-19 00:33:21 -0800 still a problem 1105766 4 hartman.wiki 2015-06-30 13:15:48 -0700 This seems possibly even worse in Safari 9 beta. 1105769 5 joepeck 2015-06-30 13:26:10 -0700 Since DOMStorage has string keys/values how about we snip the strings to something like 50-100 characters. Given: window.localStorage.key = "Really really really really really really long string"; The inspector could show something like: | "key" | "Really really really..." | With some way to fetch the completely value. This is similar to RemoteObject previews, which abbreviates strings to 100 characters. 1105834 6 timothy 2015-06-30 15:02:13 -0700 Sounds great to me! 1163276 7 hartman.wiki 2016-02-09 13:52:31 -0800 This crash still happens, and it still annoys me about once a week, when I accidentally press the localStorage tab on a wikipedia and related websites. 1163289 8 270954 joepeck 2016-02-09 14:25:54 -0800 Created attachment 270954 [PATCH] Proposed Fix 1163291 9 joepeck 2016-02-09 14:26:49 -0800 One thing worth considering is that we could have the backend truncate before sending to the frontend, avoiding sending megabytes of text over the protocol. However, we may want to update how we display things in the frontend, so this just leaves it a frontend decision to truncate for display only. 1163310 10 270954 commit-queue 2016-02-09 15:42:55 -0800 Comment on attachment 270954 [PATCH] Proposed Fix Clearing flags on attachment: 270954 Committed r196342: <http://trac.webkit.org/changeset/196342> 1163311 11 commit-queue 2016-02-09 15:42:57 -0800 All reviewed patches have been landed. Closing bug. 1166986 12 hartman.wiki 2016-02-22 03:38:27 -0800 Tested in nightly. Works like a charm !! I'm super happy with this change, thx so much for listening. 270954 2016-02-09 14:25:54 -0800 2016-02-09 15:42:55 -0800 [PATCH] Proposed Fix storage.patch text/plain 6851 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGIxNDQwOTkuLmQ4OGViODkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM2IEBACiAyMDE2LTAyLTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogbG9jYWxT dG9yYWdlIGluc3BlY3RvciB2ZXJ5IHNsb3cgb24gYmlnIHZhbHVlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNzUwCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xNTM4NDkzMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJdCBpcyBub3QgdXNlZnVsIHRvIHNob3cgdmVyeSBsYXJnZSBzdHJpbmdzIGlu IHRoZSBET00gU3RvcmFnZSBEYXRhR3JpZC4KKyAgICAgICAgVGhpcyBjaGFuZ2UgdHJ1bmNhdGVz IGRpc3BsYXkgc3RyaW5ncyB0byByb3VnaGx5IDIwMCBjaGFyYWN0ZXJzLiBJZiB0aGUKKyAgICAg ICAgZGV2ZWxvcGVyIHJlYWxseSB3YW50cyB0aGUgZnVsbCB2YWx1ZSBvZiB0aGUgc3RyaW5nIHRo ZXkgY2FuIGp1c3QgYWNjZXNzCisgICAgICAgIGl0IHRocm91Z2ggbG9jYWxTdG9yYWdlLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NU3RvcmFnZU9iamVjdC5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5ET01TdG9yYWdlT2JqZWN0LnByb3RvdHlwZS5nZXRFbnRyaWVzLmlu bmVyQ2FsbGJhY2spOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VPYmplY3QucHJv dG90eXBlLmdldEVudHJpZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VPYmpl Y3QucHJvdG90eXBlLml0ZW1VcGRhdGVkKToKKyAgICAgICAgTW9kZXJuaXplLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9ET01TdG9yYWdlQ29udGVudFZpZXcuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUNvbnRlbnRWaWV3KToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5ET01TdG9yYWdlQ29udGVudFZpZXcucHJvdG90eXBlLml0ZW1SZW1vdmVkKToKKyAgICAg ICAgTW9kZXJuaXplLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUNvbnRlbnRW aWV3LnByb3RvdHlwZS5pdGVtQWRkZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTVN0b3Jh Z2VDb250ZW50Vmlldy5wcm90b3R5cGUuaXRlbVVwZGF0ZWQpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkRPTVN0b3JhZ2VDb250ZW50Vmlldy5wcm90b3R5cGUuX3RydW5jYXRlVmFsdWUpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VDb250ZW50Vmlldy5wcm90b3R5cGUuX3BvcHVs YXRlKToKKyAgICAgICAgV2hlbmV2ZXIgd2UgZ2V0IGEgdmFsdWUgdGhhdCB3ZSB3aWxsIGRpc3Bs YXksIHRydW5jYXRlIGl0IHRvCisgICAgICAgIGp1c3QgMjAwIGNoYXJhY3RlcnMuCisKKzIwMTYt MDItMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBFeHBpcmF0aW9uIGNvbHVtbiBpbiBTdG9yYWdlIHRhYiBjYW4ndCBiZSBz b3J0ZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NDA0MwogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQ1NzIyNzI+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRE9NU3RvcmFnZU9iamVjdC5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01TdG9yYWdl T2JqZWN0LmpzCmluZGV4IDMyMTI3YWYuLjlkYTBhNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01TdG9yYWdlT2JqZWN0LmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9ET01TdG9yYWdlT2Jq ZWN0LmpzCkBAIC03MCwxMCArNzAsMTEgQEAgV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VPYmplY3Qg PSBjbGFzcyBET01TdG9yYWdlT2JqZWN0IGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamUKICAgICAg ICAgICAgIGlmIChlcnJvcikKICAgICAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgICAg IGZvciAodmFyIGVudHJ5IG9mIGVudHJpZXMpIHsKLSAgICAgICAgICAgICAgICBpZiAoIWVudHJ5 WzBdIHx8ICFlbnRyeVsxXSkKKyAgICAgICAgICAgIGZvciAobGV0IFtrZXksIHZhbHVlXSBvZiBl bnRyaWVzKSB7CisgICAgICAgICAgICAgICAgaWYgKCFrZXkgfHwgIXZhbHVlKQogICAgICAgICAg ICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgICAgICB0aGlzLl9lbnRyaWVzLnNldChl bnRyeVswXSwgZW50cnlbMV0pOworCisgICAgICAgICAgICAgICAgdGhpcy5fZW50cmllcy5zZXQo a2V5LCB2YWx1ZSk7CiAgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGNhbGxiYWNrKGVycm9y LCBlbnRyaWVzKTsKQEAgLTExMyw4ICsxMTQsNyBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZU9i amVjdCA9IGNsYXNzIERPTVN0b3JhZ2VPYmplY3QgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZQog ICAgIGl0ZW1VcGRhdGVkKGtleSwgb2xkVmFsdWUsIHZhbHVlKQogICAgIHsKICAgICAgICAgdGhp cy5fZW50cmllcy5zZXQoa2V5LCB2YWx1ZSk7Ci0gICAgICAgIHZhciBkYXRhID0ge2tleSwgb2xk VmFsdWUsIHZhbHVlfTsKLSAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2Vi SW5zcGVjdG9yLkRPTVN0b3JhZ2VPYmplY3QuRXZlbnQuSXRlbVVwZGF0ZWQsIGRhdGEpOworICAg ICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuRE9NU3RvcmFn ZU9iamVjdC5FdmVudC5JdGVtVXBkYXRlZCwge2tleSwgb2xkVmFsdWUsIHZhbHVlfSk7CiAgICAg fQogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRE9NU3RvcmFnZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRE9NU3RvcmFnZUNvbnRlbnRWaWV3LmpzCmluZGV4IGQ4MDk0MjAu LmY4ZTI0NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0RPTVN0b3JhZ2VDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01TdG9yYWdlQ29udGVudFZpZXcuanMKQEAgLTM3LDcg KzM3LDcgQEAgV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VDb250ZW50VmlldyA9IGNsYXNzIERPTVN0 b3JhZ2VDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3AKICAgICAgICAgcmVwcmVzZW50ZWRPYmpl Y3QuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZU9iamVjdC5FdmVudC5J dGVtUmVtb3ZlZCwgdGhpcy5pdGVtUmVtb3ZlZCwgdGhpcyk7CiAgICAgICAgIHJlcHJlc2VudGVk T2JqZWN0LmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VPYmplY3QuRXZl bnQuSXRlbVVwZGF0ZWQsIHRoaXMuaXRlbVVwZGF0ZWQsIHRoaXMpOwogCi0gICAgICAgIHZhciBj b2x1bW5zID0ge307CisgICAgICAgIGxldCBjb2x1bW5zID0ge307CiAgICAgICAgIGNvbHVtbnMu a2V5ID0ge3RpdGxlOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIktleSIpLCBzb3J0YWJsZTogdHJ1 ZX07CiAgICAgICAgIGNvbHVtbnMudmFsdWUgPSB7dGl0bGU6IFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiVmFsdWUiKSwgc29ydGFibGU6IHRydWV9OwogCkBAIC02OCw3ICs2OCw3IEBAIFdlYkluc3Bl Y3Rvci5ET01TdG9yYWdlQ29udGVudFZpZXcgPSBjbGFzcyBET01TdG9yYWdlQ29udGVudFZpZXcg ZXh0ZW5kcyBXZWJJbnNwCiAKICAgICBpdGVtUmVtb3ZlZChldmVudCkKICAgICB7Ci0gICAgICAg IGZvciAodmFyIG5vZGUgb2YgdGhpcy5fZGF0YUdyaWQuY2hpbGRyZW4pIHsKKyAgICAgICAgZm9y IChsZXQgbm9kZSBvZiB0aGlzLl9kYXRhR3JpZC5jaGlsZHJlbikgewogICAgICAgICAgICAgaWYg KG5vZGUuZGF0YS5rZXkgPT09IGV2ZW50LmRhdGEua2V5KQogICAgICAgICAgICAgICAgIHJldHVy biB0aGlzLl9kYXRhR3JpZC5yZW1vdmVDaGlsZChub2RlKTsKICAgICAgICAgfQpAQCAtNzYsMjcg Kzc2LDI2IEBAIFdlYkluc3BlY3Rvci5ET01TdG9yYWdlQ29udGVudFZpZXcgPSBjbGFzcyBET01T dG9yYWdlQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbnNwCiAKICAgICBpdGVtQWRkZWQoZXZlbnQp CiAgICAgewotICAgICAgICB2YXIga2V5ID0gZXZlbnQuZGF0YS5rZXk7Ci0gICAgICAgIHZhciB2 YWx1ZSA9IGV2ZW50LmRhdGEudmFsdWU7CisgICAgICAgIGxldCB7a2V5LCB2YWx1ZX0gPSBldmVu dC5kYXRhOworICAgICAgICB2YWx1ZSA9IHRoaXMuX3RydW5jYXRlVmFsdWUodmFsdWUpOwogCiAg ICAgICAgIC8vIEVuZm9yY2Uga2V5IHVuaXF1ZW5lc3MuCi0gICAgICAgIGZvciAodmFyIG5vZGUg b2YgdGhpcy5fZGF0YUdyaWQuY2hpbGRyZW4pIHsKKyAgICAgICAgZm9yIChsZXQgbm9kZSBvZiB0 aGlzLl9kYXRhR3JpZC5jaGlsZHJlbikgewogICAgICAgICAgICAgaWYgKG5vZGUuZGF0YS5rZXkg PT09IGtleSkKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICB2 YXIgZGF0YSA9IHtrZXksIHZhbHVlfTsKLSAgICAgICAgdGhpcy5fZGF0YUdyaWQuYXBwZW5kQ2hp bGQobmV3IFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUoZGF0YSwgZmFsc2UpKTsKKyAgICAgICAg dGhpcy5fZGF0YUdyaWQuYXBwZW5kQ2hpbGQobmV3IFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUo e2tleSwgdmFsdWV9LCBmYWxzZSkpOwogICAgICAgICB0aGlzLl9zb3J0RGF0YUdyaWQoKTsKICAg ICB9CiAKICAgICBpdGVtVXBkYXRlZChldmVudCkKICAgICB7Ci0gICAgICAgIHZhciBrZXkgPSBl dmVudC5kYXRhLmtleTsKLSAgICAgICAgdmFyIHZhbHVlID0gZXZlbnQuZGF0YS52YWx1ZTsKKyAg ICAgICAgbGV0IHtrZXksIHZhbHVlfSA9IGV2ZW50LmRhdGE7CisgICAgICAgIHZhbHVlID0gdGhp cy5fdHJ1bmNhdGVWYWx1ZSh2YWx1ZSk7CiAKLSAgICAgICAgdmFyIGtleUZvdW5kID0gZmFsc2U7 Ci0gICAgICAgIGZvciAodmFyIGNoaWxkTm9kZSBvZiB0aGlzLl9kYXRhR3JpZC5jaGlsZHJlbikg eworICAgICAgICBsZXQga2V5Rm91bmQgPSBmYWxzZTsKKyAgICAgICAgZm9yIChsZXQgY2hpbGRO b2RlIG9mIHRoaXMuX2RhdGFHcmlkLmNoaWxkcmVuKSB7CiAgICAgICAgICAgICBpZiAoY2hpbGRO b2RlLmRhdGEua2V5ID09PSBrZXkpIHsKICAgICAgICAgICAgICAgICAvLyBSZW1vdmUgYW55IHJv d3MgdGhhdCBhcmUgbm93IGR1cGxpY2F0ZXMuCiAgICAgICAgICAgICAgICAgaWYgKGtleUZvdW5k KSB7CkBAIC0xMjEsMTggKzEyMCwyMyBAQCBXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZUNvbnRlbnRW aWV3ID0gY2xhc3MgRE9NU3RvcmFnZUNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcAogCiAgICAg Ly8gUHJpdmF0ZQogCisgICAgX3RydW5jYXRlVmFsdWUodmFsdWUpCisgICAgeworICAgICAgICBy ZXR1cm4gdmFsdWUudHJ1bmNhdGUoMjAwKTsKKyAgICB9CisKICAgICBfcG9wdWxhdGUoKQogICAg IHsKICAgICAgICAgdGhpcy5yZXByZXNlbnRlZE9iamVjdC5nZXRFbnRyaWVzKGZ1bmN0aW9uKGVy cm9yLCBlbnRyaWVzKSB7CiAgICAgICAgICAgICBpZiAoZXJyb3IpCiAgICAgICAgICAgICAgICAg cmV0dXJuOwogCi0gICAgICAgICAgICB2YXIgbm9kZXMgPSBbXTsKLSAgICAgICAgICAgIGZvciAo dmFyIGVudHJ5IG9mIGVudHJpZXMpIHsKLSAgICAgICAgICAgICAgICBpZiAoIWVudHJ5WzBdIHx8 ICFlbnRyeVsxXSkKKyAgICAgICAgICAgIGZvciAobGV0IFtrZXksIHZhbHVlXSBvZiBlbnRyaWVz KSB7CisgICAgICAgICAgICAgICAgaWYgKCFrZXkgfHwgIXZhbHVlKQogICAgICAgICAgICAgICAg ICAgICBjb250aW51ZTsKLSAgICAgICAgICAgICAgICB2YXIgZGF0YSA9IHtrZXk6IGVudHJ5WzBd LCB2YWx1ZTogZW50cnlbMV19OwotICAgICAgICAgICAgICAgIHZhciBub2RlID0gbmV3IFdlYklu c3BlY3Rvci5EYXRhR3JpZE5vZGUoZGF0YSwgZmFsc2UpOworCisgICAgICAgICAgICAgICAgdmFs dWUgPSB0aGlzLl90cnVuY2F0ZVZhbHVlKHZhbHVlKTsKKyAgICAgICAgICAgICAgICBsZXQgbm9k ZSA9IG5ldyBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlKHtrZXksIHZhbHVlfSwgZmFsc2UpOwog ICAgICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmFwcGVuZENoaWxkKG5vZGUpOwogICAgICAg ICAgICAgfQogCkBAIC0xNDQsNyArMTQ4LDcgQEAgV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VDb250 ZW50VmlldyA9IGNsYXNzIERPTVN0b3JhZ2VDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3AKIAog ICAgIF9zb3J0RGF0YUdyaWQoKQogICAgIHsKLSAgICAgICAgdmFyIHNvcnRDb2x1bW5JZGVudGlm aWVyID0gdGhpcy5fZGF0YUdyaWQuc29ydENvbHVtbklkZW50aWZpZXIgfHwgImtleSI7CisgICAg ICAgIGxldCBzb3J0Q29sdW1uSWRlbnRpZmllciA9IHRoaXMuX2RhdGFHcmlkLnNvcnRDb2x1bW5J ZGVudGlmaWVyIHx8ICJrZXkiOwogCiAgICAgICAgIGZ1bmN0aW9uIGNvbXBhcmF0b3IoYSwgYikK ICAgICAgICAgewo=