123743 2013-11-04 09:24:41 -0800 [CSS Shapes] image valued shape element margin can cause an ASSERT fail 2013-11-04 14:37:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116348 1 giles_joplin giles_joplin commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 946693 0 giles_joplin 2013-11-04 09:24:41 -0800 Specifying a non-zero shape-margin value for an image with an above shape-image-threshold pixels 0,0 (for example) will cause an assertion failure. 946739 1 215932 giles_joplin 2013-11-04 11:02:43 -0800 Created attachment 215932 Test case. The attached test case demonstrates that the problem is due to specifying a non-zero margin (not shape-margin) for the shape-outside element. 946767 2 215940 giles_joplin 2013-11-04 12:16:44 -0800 Created attachment 215940 Patch When margin-top is specified for a shape's element, the Y coordinates passed to RasterShapeIntervals::getExcludedIntervals() may be negative. This is because the incoming logical coordinates are relative to the content or padding box, depending on the box-sizing property. The RasterShape::getExcludedIntervals() method now clips the incoming Y coordinates to the shape's bounds. 946827 3 215940 commit-queue 2013-11-04 14:37:51 -0800 Comment on attachment 215940 Patch Clearing flags on attachment: 215940 Committed r158596: <http://trac.webkit.org/changeset/158596> 946828 4 commit-queue 2013-11-04 14:37:53 -0800 All reviewed patches have been landed. Closing bug. 215932 2013-11-04 11:02:43 -0800 2013-11-04 11:02:43 -0800 Test case. test.html text/html 412 giles_joplin PCFET0NUWVBFIGh0bWw+CjxodG1sPiAgCjxzdHlsZT4KI2ltYWdlLXZhbHVlZC1zaGFwZSB7CiAg ICAtd2Via2l0LXNoYXBlLW91dHNpZGU6IHVybCgiZGF0YTppbWFnZS9zdmcreG1sO3V0ZjgsPHN2 ZyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHdpZHRoPScxMDBweCcgaGVpZ2h0 PScxMDBweCc+PHJlY3QgeD0nMCcgeT0nMCcgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAnIGZpbGw9 J2dyZWVuJy8+PC9zdmc+Iik7CiAgICBtYXJnaW46IDMwcHg7CiAgICBmbG9hdDogbGVmdDsKfQo8 L3N0eWxlPgo8Ym9keT4KICA8ZGl2IGlkPSJpbWFnZS12YWx1ZWQtc2hhcGUiIHdpZHRoPSIxMDBw eCIgaGVpZ2h0PSIxMDBweCI+PC9kaXY+CiAgSGVsbG8gV29ybGQKICA8YnI+CiAgPGJyPgo8L2Jv ZHk+CjwvaHRtbD4KCg== 215940 2013-11-04 12:16:44 -0800 2013-11-04 14:37:51 -0800 Patch tmp.patch text/plain 4944 giles_joplin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMWJmNjFlLi5iZDExOTYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTEt MDQgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBTaGFw ZXNdIGltYWdlIHZhbHVlZCBzaGFwZSBlbGVtZW50IG1hcmdpbiBjYW4gY2F1c2UgYW4gQVNTRVJU IGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy Mzc0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZl cmlmeSB0aGF0IGFuIGVsZW1lbnQgd2l0aCBhbiBpbWFnZSB2YWx1ZWQgc2hhcGUgYW5kIGEgbm9u LW5lZ2F0aXZlIG1hcmdpbgorICAgICAgICBkb2VzIG5vdCBjYXVzZSBhbiBhc3NlcnRpb24gZmFp bHVyZS4KKworICAgICAgICAqIGZhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBl LW91dHNpZGUtZmxvYXRzLW1hcmdpbi1jcmFzaC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0 cy1tYXJnaW4tY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTMtMTEtMDQgIFJvYmVydCBQbG9jaWVu bmlrICA8ci5wbG9jaWVubmlrQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIGFjY2Vzc2li aWxpdHkvdGV4dGFyZWEtbGluZS1mb3ItaW5kZXguaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRz aWRlLWZsb2F0cy1tYXJnaW4tY3Jhc2gtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv c2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtZmxvYXRzLW1hcmdpbi1j cmFzaC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjA5 MmM1MjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9zaGFwZS1v dXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1tYXJnaW4tY3Jhc2gtZXhwZWN0ZWQu aHRtbApAQCAtMCwwICsxLDI1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPiAgCis8c3R5bGU+ Cisjd3JhcHBlZC10ZXh0IHsKKyAgICBmb250LXNpemU6IDMwcHg7CisgICAgbGluZS1oZWlnaHQ6 IDE7Cit9CisKKyNpbWFnZS12YWx1ZWQtc2hhcGUgeworICAgIGZsb2F0OiBsZWZ0OworICAgIHdp ZHRoOiAxMDBweDsKKyAgICBoZWlnaHQ6IDEwMHB4OworICAgIG1hcmdpbi1sZWZ0OiAzMHB4Owor ICAgIGJhY2tncm91bmQtaW1hZ2U6IHVybCgiZGF0YTppbWFnZS9zdmcreG1sO3V0ZjgsPHN2ZyB4 bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHdpZHRoPScxMDBweCcgaGVpZ2h0PScx MDBweCc+PHJlY3QgeD0nMCcgeT0nMCcgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAnIGZpbGw9J2dy ZWVuJy8+PC9zdmc+Iik7CisgICAgYmFja2dyb3VuZC1yZXBlYXQ6IG5vLXJlcGVhdDsKK30KKzwv c3R5bGU+Cis8Ym9keT4KKyAgPHA+VGhlIEEtQyB0ZXh0IHNob3VsZCBhcHBlYXIgYWJvdmUgYW5k IHRoZW4gdG8gdGhlIHJpZ2h0IG9mIHRoZSBncmVlbiByZWN0YW5nbGUuIFRoaXMgdGVzdCBzaG91 bGQgbm90IGNyYXNoLjwvcD4KKyAgPGRpdiBpZD0id3JhcHBlZC10ZXh0Ij4KKyAgICA8ZGl2IHN0 eWxlPSJoZWlnaHQ6IDMwcHgiPkE8L2Rpdj4KKyAgICA8ZGl2IGlkPSJpbWFnZS12YWx1ZWQtc2hh cGUiPjwvZGl2PkI8YnI+QworICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNp ZGUtZmxvYXRzLW1hcmdpbi1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hh cGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1mbG9hdHMtbWFyZ2luLWNyYXNoLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNDk3OTc5ZAotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBl LW91dHNpZGUtZmxvYXRzLW1hcmdpbi1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMjUgQEAKKzwhRE9D VFlQRSBodG1sPgorPGh0bWw+ICAKKzxzdHlsZT4KKyN3cmFwcGVkLXRleHQgeworICAgIGZvbnQt c2l6ZTogMzBweDsKKyAgICBsaW5lLWhlaWdodDogMTsKK30KKworI2ltYWdlLXZhbHVlZC1zaGFw ZSB7CisgICAgLXdlYmtpdC1zaGFwZS1vdXRzaWRlOiB1cmwoImRhdGE6aW1hZ2Uvc3ZnK3htbDt1 dGY4LDxzdmcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnJyB3aWR0aD0nMTAwcHgn IGhlaWdodD0nMTAwcHgnPjxyZWN0IHg9JzAnIHk9JzAnIHdpZHRoPScxMDAnIGhlaWdodD0nMTAw JyBmaWxsPSdncmVlbicvPjwvc3ZnPiIpOworICAgIG1hcmdpbjogMzBweDsKKyAgICBmbG9hdDog bGVmdDsKKyAgICB3aWR0aDogMTAwcHg7CisgICAgaGVpZ2h0OiAxMDBweDsKKyAgICBiYWNrZ3Jv dW5kLWltYWdlOiB1cmwoImRhdGE6aW1hZ2Uvc3ZnK3htbDt1dGY4LDxzdmcgeG1sbnM9J2h0dHA6 Ly93d3cudzMub3JnLzIwMDAvc3ZnJyB3aWR0aD0nMTAwcHgnIGhlaWdodD0nMTAwcHgnPjxyZWN0 IHg9JzAnIHk9JzAnIHdpZHRoPScxMDAnIGhlaWdodD0nMTAwJyBmaWxsPSdncmVlbicvPjwvc3Zn PiIpOworICAgIGJhY2tncm91bmQtcmVwZWF0OiBuby1yZXBlYXQ7Cit9Cis8L3N0eWxlPgorPGJv ZHk+CisgIDxwPlRoZSBBLUMgdGV4dCBzaG91bGQgYXBwZWFyIGFib3ZlIGFuZCB0aGVuIHRvIHRo ZSByaWdodCBvZiB0aGUgZ3JlZW4gcmVjdGFuZ2xlLiBUaGlzIHRlc3Qgc2hvdWxkIG5vdCBjcmFz aC48L3A+CisgIDxkaXYgaWQ9IndyYXBwZWQtdGV4dCI+CisgICAgPGRpdiBpZD0iaW1hZ2UtdmFs dWVkLXNoYXBlIj48L2Rpdj5BPGJyPkI8YnI+QworICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZjdmMGViLi5hMTc4OGM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMTEtMDQgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAg ICAgW0NTUyBTaGFwZXNdIGltYWdlIHZhbHVlZCBzaGFwZSBlbGVtZW50IG1hcmdpbiBjYW4gY2F1 c2UgYW4gQVNTRVJUIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMzc0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdoZW4gbWFyZ2luLXRvcCBpcyBzcGVjaWZpZWQgZm9yIGEgc2hhcGUncyBlbGVt ZW50LCB0aGUgWSBjb29yZGluYXRlcyBwYXNzZWQKKyAgICAgICAgdG8gUmFzdGVyU2hhcGVJbnRl cnZhbHM6OmdldEV4Y2x1ZGVkSW50ZXJ2YWxzKCkgbWF5IGJlIG5lZ2F0aXZlLiBUaGlzIGlzCisg ICAgICAgIGJlY2F1c2UgdGhlIGluY29taW5nIGxvZ2ljYWwgY29vcmRpbmF0ZXMgYXJlIHJlbGF0 aXZlIHRvIHRoZSBjb250ZW50IG9yCisgICAgICAgIHBhZGRpbmcgYm94LCBkZXBlbmRpbmcgb24g dGhlIGJveC1zaXppbmcgcHJvcGVydHkuIFRoZSBSYXN0ZXJTaGFwZTo6Z2V0RXhjbHVkZWRJbnRl cnZhbHMoKQorICAgICAgICBtZXRob2Qgbm93IGNsaXBzIHRoZSBpbmNvbWluZyBZIGNvb3JkaW5h dGVzIHRvIHRoZSBzaGFwZSdzIGJvdW5kcyBiZWZvcmUKKyAgICAgICAgYWNjZXNzaW5nIHRoZSBz aGFwZSdzIGludGVydmFscy4KKworICAgICAgICBUZXN0OiBmYXN0L3NoYXBlcy9zaGFwZS1vdXRz aWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWZsb2F0cy1tYXJnaW4tY3Jhc2guaHRtbAorCisgICAg ICAgICogcmVuZGVyaW5nL3NoYXBlcy9SYXN0ZXJTaGFwZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSYXN0ZXJTaGFwZUludGVydmFsczo6Z2V0RXhjbHVkZWRJbnRlcnZhbHMpOgorCiAyMDEzLTEx LTA0ICBQcnplbXlzbGF3IFN6eW1hbnNraSAgPHAuc3p5bWFuc2tpM0BzYW1zdW5nLmNvbT4KIAog ICAgICAgICBbVGV4bWFwXSBSZW1vdmUgcmVkdW5kYW50IGNhbGxzIGluIENvb3JkaW5hdGVkR3Jh cGhpY3NTY2VuZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3NoYXBlcy9S YXN0ZXJTaGFwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNo YXBlLmNwcAppbmRleCAzYWEwNjVkLi5iY2NhMGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBlLmNwcApAQCAtMjA1LDYgKzIwNSw5IEBAIHZvaWQg UmFzdGVyU2hhcGVJbnRlcnZhbHM6OmdldEV4Y2x1ZGVkSW50ZXJ2YWxzKGludCB5MSwgaW50IHky LCBJbnRTaGFwZUludGVydmFsCiAgICAgaWYgKHkyIDwgYm91bmRzKCkueSgpIHx8IHkxID49IGJv dW5kcygpLm1heFkoKSkKICAgICAgICAgcmV0dXJuOwogCisgICAgeTEgPSBzdGQ6Om1heCh5MSwg Ym91bmRzKCkueSgpKTsKKyAgICB5MiA9IHN0ZDo6bWluKHkyLCBib3VuZHMoKS5tYXhZKCkpOwor CiAgICAgZm9yIChpbnQgeSA9IHkxOyB5IDwgeTI7ICB5KyspIHsKICAgICAgICAgaWYgKGludGVy dmFsc0F0KHkpLmlzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybjsK