123737 code 2013-11-04 04:39:23 -0800 [Texmap] Removing of a redundant code 2019-09-25 20:44:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 p.szymanski3 keith_miller cmarcelo commit-queue keith_miller kondapallykalyan luiz noam webkit-bug-importer oldest_to_newest 946629 0 p.szymanski3 2013-11-04 04:39:23 -0800 After few refactor patches it is an unused code which can be removed 946633 1 215912 p.szymanski3 2013-11-04 04:44:30 -0800 Created attachment 215912 Redundant code 946641 2 215912 noam 2013-11-04 05:04:28 -0800 Comment on attachment 215912 Redundant code View in context: https://bugs.webkit.org/attachment.cgi?id=215912&action=review > Source/WebCore/ChangeLog:3 > + [Texmap] Removing a redundant code Remove redundant calls in CoordinatedGraphicsScene > Source/WebCore/ChangeLog:8 > + It is some unused code left after few refactoring patches. It is -> Removing 946642 3 215914 p.szymanski3 2013-11-04 05:42:42 -0800 Created attachment 215914 Redundant code 946643 4 p.szymanski3 2013-11-04 05:43:49 -0800 (In reply to comment #2) > (From update of attachment 215912 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215912&action=review > > > Source/WebCore/ChangeLog:3 > > + [Texmap] Removing a redundant code > > Remove redundant calls in CoordinatedGraphicsScene > > > Source/WebCore/ChangeLog:8 > > + It is some unused code left after few refactoring patches. > > It is -> Removing Thank you for your review. Changes updated 946656 5 215914 commit-queue 2013-11-04 06:56:29 -0800 Comment on attachment 215914 Redundant code Clearing flags on attachment: 215914 Committed r158574: <http://trac.webkit.org/changeset/158574> 946657 6 commit-queue 2013-11-04 06:56:31 -0800 All reviewed patches have been landed. Closing bug. 1574331 7 keith_miller 2019-09-25 19:33:27 -0700 Reopening to attach new patch. 1574342 8 keith_miller 2019-09-25 20:43:06 -0700 Ugh, WebKit-patch freaked out and reopened this... sorry for the spam. 1574343 9 webkit-bug-importer 2019-09-25 20:44:18 -0700 <rdar://problem/55730145> 215912 2013-11-04 04:44:30 -0800 2013-11-04 05:42:57 -0800 Redundant code texmap_redundantCode.patch text/plain 2316 p.szymanski3 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYWEzMWRlLi43NDllMWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMTEtMDQgIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtUZXhtYXBdIFJlbW92aW5nIGEgcmVkdW5kYW50IGNvZGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzczNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIHNvbWUg dW51c2VkIGNvZGUgbGVmdCBhZnRlciBmZXcgcmVmYWN0b3JpbmcgcGF0Y2hlcy4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgZXhpc3Rpbmcgb25lcy4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzU2Nl bmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjpwYWlu dFRvQ3VycmVudEdMQ29udGV4dCk6CisKIDIwMTMtMTEtMDQgIFNhbnRvc2ggTWFodG8gIDxzYW50 b3NoLm1hQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFt3ZWJjb3JlL2RvbV0gUmVtb3ZlIGV4dHJh IGhlYWRlciBpbmNsdWRlcyBmcm9tIGNwcCBmaWxlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBo aWNzU2NlbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nv b3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAKaW5kZXggYzE1MTc3YS4uODY2 Mjc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3Jh cGhpY3NTY2VuZS5jcHAKQEAgLTgzLDEzICs4Myw4IEBAIHZvaWQgQ29vcmRpbmF0ZWRHcmFwaGlj c1NjZW5lOjpwYWludFRvQ3VycmVudEdMQ29udGV4dChjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJp CiAgICAgaWYgKCFjdXJyZW50Um9vdExheWVyKQogICAgICAgICByZXR1cm47CiAKLSAgICBUZXh0 dXJlTWFwcGVyTGF5ZXIqIGxheWVyID0gY3VycmVudFJvb3RMYXllcjsKLQotICAgIGlmICghbGF5 ZXIpCi0gICAgICAgIHJldHVybjsKLQotICAgIGxheWVyLT5zZXRUZXh0dXJlTWFwcGVyKG1fdGV4 dHVyZU1hcHBlci5nZXQoKSk7Ci0gICAgbGF5ZXItPmFwcGx5QW5pbWF0aW9uc1JlY3Vyc2l2ZWx5 KCk7CisgICAgY3VycmVudFJvb3RMYXllci0+c2V0VGV4dHVyZU1hcHBlcihtX3RleHR1cmVNYXBw ZXIuZ2V0KCkpOworICAgIGN1cnJlbnRSb290TGF5ZXItPmFwcGx5QW5pbWF0aW9uc1JlY3Vyc2l2 ZWx5KCk7CiAgICAgbV90ZXh0dXJlTWFwcGVyLT5iZWdpblBhaW50aW5nKFBhaW50RmxhZ3MpOwog ICAgIG1fdGV4dHVyZU1hcHBlci0+YmVnaW5DbGlwKFRyYW5zZm9ybWF0aW9uTWF0cml4KCksIGNs aXBSZWN0KTsKIApAQCAtMTA1LDEyICsxMDAsMTIgQEAgdm9pZCBDb29yZGluYXRlZEdyYXBoaWNz U2NlbmU6OnBhaW50VG9DdXJyZW50R0xDb250ZXh0KGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cmkK ICAgICAgICAgY3VycmVudFJvb3RMYXllci0+c2V0VHJhbnNmb3JtKG1hdHJpeCk7CiAgICAgfQog Ci0gICAgbGF5ZXItPnBhaW50KCk7CisgICAgY3VycmVudFJvb3RMYXllci0+cGFpbnQoKTsKICAg ICBtX2Zwc0NvdW50ZXIudXBkYXRlRlBTQW5kRGlzcGxheShtX3RleHR1cmVNYXBwZXIuZ2V0KCks IGNsaXBSZWN0LmxvY2F0aW9uKCksIG1hdHJpeCk7CiAgICAgbV90ZXh0dXJlTWFwcGVyLT5lbmRD bGlwKCk7CiAgICAgbV90ZXh0dXJlTWFwcGVyLT5lbmRQYWludGluZygpOwogCi0gICAgaWYgKGxh eWVyLT5kZXNjZW5kYW50c09yU2VsZkhhdmVSdW5uaW5nQW5pbWF0aW9ucygpKQorICAgIGlmIChj dXJyZW50Um9vdExheWVyLT5kZXNjZW5kYW50c09yU2VsZkhhdmVSdW5uaW5nQW5pbWF0aW9ucygp KQogICAgICAgICBkaXNwYXRjaE9uTWFpblRocmVhZChiaW5kKCZDb29yZGluYXRlZEdyYXBoaWNz U2NlbmU6OnVwZGF0ZVZpZXdwb3J0LCB0aGlzKSk7CiB9CiAK 215914 2013-11-04 05:42:42 -0800 2013-11-04 06:56:29 -0800 Redundant code texmap_redundantCode.patch text/plain 2334 p.szymanski3 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNWU5NTA2Li5hMzBhNGE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMTEtMDQgIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtUZXhtYXBdIFJlbW92ZSByZWR1bmRhbnQgY2FsbHMgaW4gQ29v cmRpbmF0ZWRHcmFwaGljc1NjZW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjM3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmluZyB1bnVzZWQgY29kZSBsZWZ0IGFmdGVyIGZldyByZWZhY3Rv cmluZyBwYXRjaGVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGlu ZyBvbmVzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVk L0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb29yZGlu YXRlZEdyYXBoaWNzU2NlbmU6OnBhaW50VG9DdXJyZW50R0xDb250ZXh0KToKKwogMjAxMy0xMS0w NCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ1NTUHJpbWl0 aXZlVmFsdWUgY29sb3IgY29uc3RydWN0b3JzIHNob3VsZCByZXR1cm4gUGFzc1JlZi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRl ZC9Db29yZGluYXRlZEdyYXBoaWNzU2NlbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAK aW5kZXggYzE1MTc3YS4uODY2Mjc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5h dGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NTY2VuZS5jcHAKQEAgLTgzLDEzICs4Myw4IEBAIHZvaWQg Q29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lOjpwYWludFRvQ3VycmVudEdMQ29udGV4dChjb25zdCBU cmFuc2Zvcm1hdGlvbk1hdHJpCiAgICAgaWYgKCFjdXJyZW50Um9vdExheWVyKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBUZXh0dXJlTWFwcGVyTGF5ZXIqIGxheWVyID0gY3VycmVudFJvb3RMYXll cjsKLQotICAgIGlmICghbGF5ZXIpCi0gICAgICAgIHJldHVybjsKLQotICAgIGxheWVyLT5zZXRU ZXh0dXJlTWFwcGVyKG1fdGV4dHVyZU1hcHBlci5nZXQoKSk7Ci0gICAgbGF5ZXItPmFwcGx5QW5p bWF0aW9uc1JlY3Vyc2l2ZWx5KCk7CisgICAgY3VycmVudFJvb3RMYXllci0+c2V0VGV4dHVyZU1h cHBlcihtX3RleHR1cmVNYXBwZXIuZ2V0KCkpOworICAgIGN1cnJlbnRSb290TGF5ZXItPmFwcGx5 QW5pbWF0aW9uc1JlY3Vyc2l2ZWx5KCk7CiAgICAgbV90ZXh0dXJlTWFwcGVyLT5iZWdpblBhaW50 aW5nKFBhaW50RmxhZ3MpOwogICAgIG1fdGV4dHVyZU1hcHBlci0+YmVnaW5DbGlwKFRyYW5zZm9y bWF0aW9uTWF0cml4KCksIGNsaXBSZWN0KTsKIApAQCAtMTA1LDEyICsxMDAsMTIgQEAgdm9pZCBD b29yZGluYXRlZEdyYXBoaWNzU2NlbmU6OnBhaW50VG9DdXJyZW50R0xDb250ZXh0KGNvbnN0IFRy YW5zZm9ybWF0aW9uTWF0cmkKICAgICAgICAgY3VycmVudFJvb3RMYXllci0+c2V0VHJhbnNmb3Jt KG1hdHJpeCk7CiAgICAgfQogCi0gICAgbGF5ZXItPnBhaW50KCk7CisgICAgY3VycmVudFJvb3RM YXllci0+cGFpbnQoKTsKICAgICBtX2Zwc0NvdW50ZXIudXBkYXRlRlBTQW5kRGlzcGxheShtX3Rl eHR1cmVNYXBwZXIuZ2V0KCksIGNsaXBSZWN0LmxvY2F0aW9uKCksIG1hdHJpeCk7CiAgICAgbV90 ZXh0dXJlTWFwcGVyLT5lbmRDbGlwKCk7CiAgICAgbV90ZXh0dXJlTWFwcGVyLT5lbmRQYWludGlu ZygpOwogCi0gICAgaWYgKGxheWVyLT5kZXNjZW5kYW50c09yU2VsZkhhdmVSdW5uaW5nQW5pbWF0 aW9ucygpKQorICAgIGlmIChjdXJyZW50Um9vdExheWVyLT5kZXNjZW5kYW50c09yU2VsZkhhdmVS dW5uaW5nQW5pbWF0aW9ucygpKQogICAgICAgICBkaXNwYXRjaE9uTWFpblRocmVhZChiaW5kKCZD b29yZGluYXRlZEdyYXBoaWNzU2NlbmU6OnVwZGF0ZVZpZXdwb3J0LCB0aGlzKSk7CiB9CiAK