123674 2013-11-02 10:59:49 -0700 Fix MSVC warning about unary minus operator 2013-11-02 20:15:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue oldest_to_newest 946247 0 paroga 2013-11-02 10:59:49 -0700 Fix MSVC warning about unary minus operator 946248 1 215817 paroga 2013-11-02 11:03:20 -0700 Created attachment 215817 Patch 946366 2 215817 darin 2013-11-02 19:48:13 -0700 Comment on attachment 215817 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215817&action=review > Source/JavaScriptCore/jit/Repatch.cpp:864 > + stubJit.loadPtr(MacroAssembler::Address(scratchGPR3, -static_cast<ptrdiff_t>(offset + sizeof(JSValue) + sizeof(void*))), scratchGPR2); > + stubJit.storePtr(scratchGPR2, MacroAssembler::Address(scratchGPR1, -static_cast<ptrdiff_t>(offset + sizeof(JSValue) + sizeof(void*)))); I think ssize_t would be better than ptrdiff_t here, but maybe Windows doesn’t even have that type. 946372 3 215817 commit-queue 2013-11-02 20:15:07 -0700 Comment on attachment 215817 Patch Clearing flags on attachment: 215817 Committed r158516: <http://trac.webkit.org/changeset/158516> 946373 4 commit-queue 2013-11-02 20:15:08 -0700 All reviewed patches have been landed. Closing bug. 215817 2013-11-02 11:03:20 -0700 2013-11-02 20:15:07 -0700 Patch bug-123674-20131102190321.patch text/plain 2300 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YTU5NDdjNjA0N2Q3NjhmNDRjNmU4Yzg0MjU5ZDA0ODUxMGM3NzIyLi5kMDdmMWI4YTA0ZDI3MGQ2 ZDBiY2ZhNjIwMWFhZjUzMTNmZjRkODI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxMy0xMS0wMiAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0 Lm9yZz4KIAorICAgICAgICBGaXggTVNWQyB3YXJuaW5nIGFib3V0IHVuYXJ5IG1pbnVzIG9wZXJh dG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM2 NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu Z2Ugc29tZSBzdGF0aWNfY2FzdDw+IHRvIHNpbGVuY2UgdGhlIGZvbGxvd2luZyB3YXJuaW5nIG9m IE1pY3Jvc29mdCBjb21waWxlcjoKKyAgICAgICAgd2FybmluZyBDNDE0NjogdW5hcnkgbWludXMg b3BlcmF0b3IgYXBwbGllZCB0byB1bnNpZ25lZCB0eXBlLCByZXN1bHQgc3RpbGwgdW5zaWduZWQK KworICAgICAgICAqIGppdC9SZXBhdGNoLmNwcDoKKyAgICAgICAgKEpTQzo6ZW1pdFB1dFRyYW5z aXRpb25TdHViKToKKworMjAxMy0xMS0wMiAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Vi a2l0Lm9yZz4KKwogICAgICAgICBWYXJpb3VzIHNtYWxsIFdpbkNFIGJ1aWxkIGZpeGVzCiAKICAg ICAgICAgKiBqc2MuY3BwOgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9S ZXBhdGNoLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAKaW5kZXgg YmJmOTBhYzY4ZTk4ZDkyZjQ0ZWExNDdkMjE5N2E4M2Q4YTMzNThiYy4uZDk0YTIwZDE4Y2Q0MjVm Yzg2ZGZkZDYwMzc3NWMwYzIyMjdmYzc0MyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9SZXBhdGNoLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0 Y2guY3BwCkBAIC04NTksOSArODU5LDkgQEAgc3RhdGljIHZvaWQgZW1pdFB1dFRyYW5zaXRpb25T dHViKAogICAgICAgICAgICAgc3R1YkppdC5hZGRQdHIoTWFjcm9Bc3NlbWJsZXI6OkFic29sdXRl QWRkcmVzcygmY29waWVkQWxsb2NhdG9yLT5tX2N1cnJlbnRQYXlsb2FkRW5kKSwgc2NyYXRjaEdQ UjEpOwogICAgICAgICAgICAgc3R1YkppdC5hZGRQdHIoTWFjcm9Bc3NlbWJsZXI6OlRydXN0ZWRJ bW0zMihzaXplb2YoSlNWYWx1ZSkpLCBzY3JhdGNoR1BSMSk7CiAgICAgICAgICAgICAvLyBXZSBo YXZlIHNjcmF0Y2hHUFIxID0gbmV3IHN0b3JhZ2UsIHNjcmF0Y2hHUFIzID0gb2xkIHN0b3JhZ2Us IHNjcmF0Y2hHUFIyID0gYXZhaWxhYmxlCi0gICAgICAgICAgICBmb3IgKHB0cmRpZmZfdCBvZmZz ZXQgPSAwOyBvZmZzZXQgPCBzdGF0aWNfY2FzdDxwdHJkaWZmX3Q+KG9sZFNpemUpOyBvZmZzZXQg Kz0gc2l6ZW9mKHZvaWQqKSkgewotICAgICAgICAgICAgICAgIHN0dWJKaXQubG9hZFB0cihNYWNy b0Fzc2VtYmxlcjo6QWRkcmVzcyhzY3JhdGNoR1BSMywgLShvZmZzZXQgKyBzaXplb2YoSlNWYWx1 ZSkgKyBzaXplb2Yodm9pZCopKSksIHNjcmF0Y2hHUFIyKTsKLSAgICAgICAgICAgICAgICBzdHVi Sml0LnN0b3JlUHRyKHNjcmF0Y2hHUFIyLCBNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhzY3JhdGNo R1BSMSwgLShvZmZzZXQgKyBzaXplb2YoSlNWYWx1ZSkgKyBzaXplb2Yodm9pZCopKSkpOworICAg ICAgICAgICAgZm9yIChzaXplX3Qgb2Zmc2V0ID0gMDsgb2Zmc2V0IDwgb2xkU2l6ZTsgb2Zmc2V0 ICs9IHNpemVvZih2b2lkKikpIHsKKyAgICAgICAgICAgICAgICBzdHViSml0LmxvYWRQdHIoTWFj cm9Bc3NlbWJsZXI6OkFkZHJlc3Moc2NyYXRjaEdQUjMsIC1zdGF0aWNfY2FzdDxwdHJkaWZmX3Q+ KG9mZnNldCArIHNpemVvZihKU1ZhbHVlKSArIHNpemVvZih2b2lkKikpKSwgc2NyYXRjaEdQUjIp OworICAgICAgICAgICAgICAgIHN0dWJKaXQuc3RvcmVQdHIoc2NyYXRjaEdQUjIsIE1hY3JvQXNz ZW1ibGVyOjpBZGRyZXNzKHNjcmF0Y2hHUFIxLCAtc3RhdGljX2Nhc3Q8cHRyZGlmZl90PihvZmZz ZXQgKyBzaXplb2YoSlNWYWx1ZSkgKyBzaXplb2Yodm9pZCopKSkpOwogICAgICAgICAgICAgfQog ICAgICAgICB9CiAgICAgICAgIAo=