123671 2013-11-02 10:44:57 -0700 [Cocoa] Wrappers mishandle NULL values in arrays and dictionaries 2013-11-02 14:54:18 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz commit-queue oldest_to_newest 946239 0 mitz 2013-11-02 10:44:57 -0700 [Cocoa] Wrappers mishandle NULL values in arrays and dictionaries 946241 1 215813 mitz 2013-11-02 10:46:57 -0700 Created attachment 215813 Represent NULL values by NSNull 946309 2 215813 darin 2013-11-02 14:24:12 -0700 Comment on attachment 215813 Represent NULL values by NSNull It’s a little peculiar that we turn a nullptr into an NSNull on the way out, but we don’t turn an NSNull into a nullptr on the way in. 946310 3 215813 darin 2013-11-02 14:24:33 -0700 Comment on attachment 215813 Represent NULL values by NSNull I guess maybe there’s no “way in” if these are immutable, so my comment was wrong. 946313 4 215813 commit-queue 2013-11-02 14:54:16 -0700 Comment on attachment 215813 Represent NULL values by NSNull Clearing flags on attachment: 215813 Committed r158500: <http://trac.webkit.org/changeset/158500> 946314 5 commit-queue 2013-11-02 14:54:18 -0700 All reviewed patches have been landed. Closing bug. 215813 2013-11-02 10:46:57 -0700 2013-11-02 14:54:16 -0700 Represent NULL values by NSNull bug-123671-20131102104659.patch text/plain 2841 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODQ5MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTAyICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBXcmFwcGVycyBtaXNo YW5kbGUgTlVMTCB2YWx1ZXMgaW4gYXJyYXlzIGFuZCBkaWN0aW9uYXJpZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzY3MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0NvY29hL1dLTlNB cnJheS5tbToKKyAgICAgICAgKC1bV0tOU0FycmF5IG9iamVjdEF0SW5kZXg6XSk6IFJlcHJlc2Vu dCBhIE5VTEwgb2JqZWN0IGFzIE5TTnVsbC4KKyAgICAgICAgKiBTaGFyZWQvQ29jb2EvV0tOU0Rp Y3Rpb25hcnkubW06CisgICAgICAgICgtW1dLTlNEaWN0aW9uYXJ5IG9iamVjdEZvcktleTpdKTog UmVwcmVzZW50IGEgTlVMTCB2YWx1ZSBhcyBOU051bGwuCisgICAgICAgICogU2hhcmVkL0ltbXV0 YWJsZURpY3Rpb25hcnkuaDoKKyAgICAgICAgKFdlYktpdDo6SW1tdXRhYmxlRGljdGlvbmFyeTo6 Z2V0KTogQWRkZWQgdGhpcyBvdmVybG9hZCB0aGF0IHJldHVybnMgd2hldGhlciB0aGUga2V5IGV4 aXN0cy4KKwogMjAxMy0xMS0wMiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAg ICAgICAgIFtDb2NvYV0gQWRkIFdLTlNEaWN0aW9uYXJ5CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9T aGFyZWQvSW1tdXRhYmxlRGljdGlvbmFyeS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1NoYXJlZC9JbW11dGFibGVEaWN0aW9uYXJ5LmgJKHJldmlzaW9uIDE1ODQ4OCkKKysrIFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9JbW11dGFibGVEaWN0aW9uYXJ5LmgJKHdvcmtpbmcgY29weSkKQEAg LTczLDYgKzczLDEzIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1fbWFwLmdldChrZXkpOwog ICAgIH0KIAorICAgIEFQSU9iamVjdCogZ2V0KGNvbnN0IFN0cmluZyYga2V5LCBib29sJiBleGlz dHMpCisgICAgeworICAgICAgICBjb25zdCBhdXRvJiBpdCA9IG1fbWFwLmZpbmQoa2V5KTsKKyAg ICAgICAgZXhpc3RzID0gaXQgIT0gbV9tYXAuZW5kKCk7CisgICAgICAgIHJldHVybiBpdC0+dmFs dWUuZ2V0KCk7CisgICAgfQorCiAgICAgUGFzc1JlZlB0cjxJbW11dGFibGVBcnJheT4ga2V5cygp IGNvbnN0OwogCiAgICAgc2l6ZV90IHNpemUoKSB7IHJldHVybiBtX21hcC5zaXplKCk7IH0KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db2NvYS9XS05TQXJyYXkubW0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0NvY29hL1dLTlNBcnJheS5tbQkocmV2aXNpb24gMTU4 NDg4KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0NvY29hL1dLTlNBcnJheS5tbQkod29ya2lu ZyBjb3B5KQpAQCAtNTAsNyArNTAsOCBAQCAtIChOU1VJbnRlZ2VyKWNvdW50CiAKIC0gKGlkKW9i amVjdEF0SW5kZXg6KE5TVUludGVnZXIpaQogewotICAgIHJldHVybiByZWludGVycHJldF9jYXN0 PEltbXV0YWJsZUFycmF5Kj4oJl9hcnJheSktPmF0KGkpLT53cmFwcGVyKCk7CisgICAgQVBJT2Jq ZWN0KiBvYmplY3QgPSByZWludGVycHJldF9jYXN0PEltbXV0YWJsZUFycmF5Kj4oJl9hcnJheSkt PmF0KGkpOworICAgIHJldHVybiBvYmplY3QgPyBvYmplY3QtPndyYXBwZXIoKSA6IFtOU051bGwg bnVsbF07CiB9CiAKICNwcmFnbWEgbWFyayBOU0NvcHlpbmcgcHJvdG9jb2wgaW1wbGVtZW50YXRp b24KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db2NvYS9XS05TRGljdGlvbmFyeS5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29jb2EvV0tOU0RpY3Rpb25hcnku bW0JKHJldmlzaW9uIDE1ODQ4OSkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db2NvYS9XS05T RGljdGlvbmFyeS5tbQkod29ya2luZyBjb3B5KQpAQCAtNjEsMTAgKzYxLDEyIEBAIC0gKGlkKW9i amVjdEZvcktleTooaWQpa2V5CiAgICAgaWYgKCFba2V5IGlzS2luZE9mQ2xhc3M6W05TU3RyaW5n IGNsYXNzXV0pCiAgICAgICAgIHJldHVybiBuaWw7CiAKLSAgICBpZiAoQVBJT2JqZWN0KiB2YWx1 ZSA9IHJlaW50ZXJwcmV0X2Nhc3Q8SW1tdXRhYmxlRGljdGlvbmFyeSo+KCZfZGljdGlvbmFyeSkt PmdldCgoTlNTdHJpbmcgKilrZXkpKQotICAgICAgICByZXR1cm4gdmFsdWUtPndyYXBwZXIoKTsK KyAgICBib29sIGV4aXN0czsKKyAgICBBUElPYmplY3QqIHZhbHVlID0gcmVpbnRlcnByZXRfY2Fz dDxJbW11dGFibGVEaWN0aW9uYXJ5Kj4oJl9kaWN0aW9uYXJ5KS0+Z2V0KChOU1N0cmluZyAqKWtl eSwgZXhpc3RzKTsKKyAgICBpZiAoIWV4aXN0cykKKyAgICAgICAgcmV0dXJuIG5pbDsKIAotICAg IHJldHVybiBuaWw7CisgICAgcmV0dXJuIHZhbHVlID8gdmFsdWUtPndyYXBwZXIoKSA6IFtOU051 bGwgbnVsbF07CiB9CiAKIC0gKE5TRW51bWVyYXRvciAqKWtleUVudW1lcmF0b3IK