123664 2013-11-02 06:46:56 -0700 Generated color wheel displays incorrectly (regressed in r155567) 2013-11-03 20:22:44 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts fpizlo barraclough fpizlo ggaren mark.lam mhahnenberg msaboff nrotem oliver sam webkit-bug-importer oldest_to_newest 946209 0 215807 graouts 2013-11-02 06:46:56 -0700 Created attachment 215807 Color wheel test case The attached test case where we draw a color wheel programmatically using the CanvasRenderingContext2D API renders incorrectly on ToT where it used to work fine. Regressing shows that this rendered as expected as of r155565 and incorrectly with r155567, r155567 was untested but given it's a Windows-specific fix, it's likely that this regressed in http://trac.webkit.org/changeset/155567, a code change introduced to fix https://bugs.webkit.org/show_bug.cgi?id=121141. 946210 1 webkit-bug-importer 2013-11-02 06:47:10 -0700 <rdar://problem/15377184> 946230 2 fpizlo 2013-11-02 10:08:47 -0700 Looks like a fun bug! 946519 3 fpizlo 2013-11-03 17:48:22 -0800 Yeah, it's obviously a miscompile in hsl2rgb(). 946521 4 215883 fpizlo 2013-11-03 18:12:33 -0800 Created attachment 215883 the patch 946534 5 fpizlo 2013-11-03 20:22:44 -0800 Landed in http://trac.webkit.org/changeset/158556 215807 2013-11-02 06:46:56 -0700 2013-11-03 18:12:33 -0800 Color wheel test case colorwheel.html text/html 1506 graouts PHNjcmlwdD4KdmFyIGRpbWVuc2lvbiA9IDMwMDsgLy8gSG93IGJpZyBhbiBpbWFnZSB5b3Ugd2Fu dC4gVGhlIGNpcmNsZSByYWRpdXMgd2lsbCBiZSB0aGlzLzIuCnZhciBpbm5lclJhZGl1cyA9IDA7 IC8vIFJhZGl1cyBvZiB0aGUgaW5uZXIgY2lyY2xlICh3aGljaCB3aWxsIGJlIHdoaXRlKS4KCmZ1 bmN0aW9uIGhzbDJyZ2IoaCwgcywgbCkgewogIGggKj0gNjsKICBzID0gWwogICAgbCArPSBzICo9 IGwgPCAuNSA/CiAgICAgIGwgOgogICAgICAxIC0gbCwKICAgIGwgLSBoICUgMSAqIHMgKiAyLAog ICAgbCAtPSBzICo9IDIsCiAgICBsLAogICAgbCArIGggJSAxICogcywKICAgIGwgKyBzCiAgXTsK ICByZXR1cm5bCiAgICBzWyB+fmggICAgJSA2IF0sICAvLyByZWQKICAgIHNbIChofDE2KSAlIDYg XSwgIC8vIGdyZWVuCiAgICBzWyAoaHw4KSAgJSA2IF0gICAvLyBzbHVlCiAgXQp9Cgp2YXIgY2Vu dGVyID0gZGltZW5zaW9uIC8gMjsKdmFyIGMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJjYW52 YXMiKTsKYy53aWR0aCA9IGRpbWVuc2lvbjsKYy5oZWlnaHQgPSBkaW1lbnNpb247CnZhciBjdHgg PSBjLmdldENvbnRleHQoIjJkIik7CmN0eC5maWxsU3R5bGUgPSAid2hpdGUiOwpjdHguZmlsbFJl Y3QoMCwgMCwgZGltZW5zaW9uLCBkaW1lbnNpb24pOwoKdmFyIGltYWdlRGF0YSA9IGN0eC5nZXRJ bWFnZURhdGEoMCwgMCwgZGltZW5zaW9uLCBkaW1lbnNpb24pOwp2YXIgZGF0YSA9IGltYWdlRGF0 YS5kYXRhOwpmb3IgKHZhciBqPTA7IGogPCBkaW1lbnNpb247IGorKykgewogIGZvciAodmFyIGk9 MDsgaSA8IGRpbWVuc2lvbjsgaSsrKSB7CiAgICB2YXIgcG9zID0gKGogKiBkaW1lbnNpb24gKyBp KSAqIDQ7CiAgICB2YXIgeERpcyA9IGkgLSBjZW50ZXI7CiAgICB2YXIgeURpcyA9IGogLSBjZW50 ZXI7CiAgICB2YXIgZGlzdGFuY2UgPSBNYXRoLnNxcnQoeERpcyAqIHhEaXMgKyB5RGlzICogeURp cyk7CgogICAgLy8gU2hvdWxkIGRvIGFudGlhbGlhc2luZyBoZXJlIQogICAgaWYgKGRpc3RhbmNl ID4gY2VudGVyKSB7CiAgICAgIGNvbnRpbnVlOwogICAgfQoKICAgIHZhciBoID0gKE1hdGguYXRh bjIoaiAtIGNlbnRlciwgaSAtIGNlbnRlcikgKyBNYXRoLlBJKSAvICgyICogTWF0aC5QSSk7CiAg ICB2YXIgbCA9IDEuMCAtIChNYXRoLm1heCgwLCBkaXN0YW5jZSAtIGlubmVyUmFkaXVzKSAqIDAu NSAvIChjZW50ZXIgLSBpbm5lclJhZGl1cykpOwogICAgdmFyIHMgPSAxLjA7CgogICAgdmFyIHJn YiA9IGhzbDJyZ2IoaCxzLGwpOwogICAgZGF0YVtwb3NdID0gcmdiWzBdICogMjU1OwogICAgZGF0 YVtwb3MgKyAxXSA9IHJnYlsxXSAqIDI1NTsKICAgIGRhdGFbcG9zICsgMl0gPSByZ2JbMl0gKiAy NTU7CiAgfQp9CmN0eC5wdXRJbWFnZURhdGEoaW1hZ2VEYXRhLCAwLCAwKTsKCndpbmRvdy5hZGRF dmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24gKCkgewogIGRvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQoYyk7Cn0pOwoKPC9zY3JpcHQ+ 215883 2013-11-03 18:12:33 -0800 2013-11-03 19:59:38 -0800 the patch blah.patch text/plain 3935 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NTUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTExLTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg R2VuZXJhdGVkIGNvbG9yIHdoZWVsIGRpc3BsYXlzIGluY29ycmVjdGx5IChyZWdyZXNzZWQgaW4g cjE1NTU2NykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMzY2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEludGVyZXN0aW5nbHksIHIxNTU1NjcganVzdCAidW4tYnJva2UiIHRoZSBhdHRlbXB0IHRvIGNv bnN0YW50LWZvbGQgQXJpdGhNb2QsIGJ1dAorICAgICAgICB0aGF0IGNvbnN0YW50IGZvbGRpbmcg d2FzIGp1c3Qgd3JvbmcgdG8gYmVnaW4gd2l0aC4gVGhlcmUgaXMgbm8gZXZpZGVuY2UgdGhhdCB0 aGlzCisgICAgICAgIGNvbnN0YW50IGZvbGRpbmcgcnVsZSBpcyBwcm9maXRhYmxlLiBJJ20gcmVt b3ZpbmcgaXQgaW5zdGVhZCBvZiB0cnlpbmcgdG8gdGhpbmsKKyAgICAgICAgYWJvdXQgd2hhdCBp dCBtZWFucyBmb3IgaXQgdG8gYmUgY29ycmVjdC4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFj dEludGVycHJldGVySW5saW5lcy5oOgorICAgICAgICAoSlNDOjpERkc6Ojo6ZXhlY3V0ZUVmZmVj dHMpOgorCiAyMDEzLTExLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBBc3NlcnRpb24gZmFpbHVyZSBpbiBub24tSklUJ2VkIExMSW50IG9uIEFSTSBUaHVtYi4K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklu bGluZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3Ry YWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgJKHJldmlzaW9uIDE1ODUyMSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaAkod29ya2luZyBj b3B5KQpAQCAtNDgyLDEwICs0ODIsNiBAQCBib29sIEFic3RyYWN0SW50ZXJwcmV0ZXI8QWJzdHJh Y3RTdGF0ZVR5CiAgICAgY2FzZSBBcml0aE1vZDogewogICAgICAgICBKU1ZhbHVlIGxlZnQgPSBm b3JOb2RlKG5vZGUtPmNoaWxkMSgpKS52YWx1ZSgpOwogICAgICAgICBKU1ZhbHVlIHJpZ2h0ID0g Zm9yTm9kZShub2RlLT5jaGlsZDIoKSkudmFsdWUoKTsKLSAgICAgICAgaWYgKG5vZGUtPm9wKCkg PT0gQXJpdGhNb2QgJiYgcmlnaHQgJiYgcmlnaHQuaXNOdW1iZXIoKSAmJiByaWdodC5hc051bWJl cigpID09IDEpIHsKLSAgICAgICAgICAgIHNldENvbnN0YW50KG5vZGUsIEpTVmFsdWUoMCkpOwot ICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KICAgICAgICAgaWYgKGxlZnQgJiYgcmlnaHQg JiYgbGVmdC5pc051bWJlcigpICYmIHJpZ2h0LmlzTnVtYmVyKCkpIHsKICAgICAgICAgICAgIGRv dWJsZSBhID0gbGVmdC5hc051bWJlcigpOwogICAgICAgICAgICAgZG91YmxlIGIgPSByaWdodC5h c051bWJlcigpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NTUxKQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTEtMDMgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBHZW5lcmF0ZWQgY29sb3Igd2hl ZWwgZGlzcGxheXMgaW5jb3JyZWN0bHkgKHJlZ3Jlc3NlZCBpbiByMTU1NTY3KQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNjY0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICAqIGpzL2RmZy1t b2QtMS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL2RmZy1tb2QtMS5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBqcy9zY3JpcHQtdGVzdHMvZGZnLW1vZC0xLmpzOiBBZGRlZC4KKyAg ICAgICAgKGZvbyk6CisKIDIwMTMtMTEtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUu Y29tPgogCiAgICAgICAgIE9wdGltaXplIGJhc2VsaW5lczogZmFzdC9mb3JtcwpJbmRleDogTGF5 b3V0VGVzdHMvanMvZGZnLW1vZC0xLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9qcy9kZmctbW9kLTEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvanMvZGZnLW1vZC0xLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEx IEBACitUZXN0cyB0aGF0IHRoZSBERkcgaGFuZGxlcyB4ICUgMSBjb3JyZWN0bHkuCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGZvbygtNS41KSBpcyAtMC41IG9uIGFsbCBp dGVyYXRpb25zIGluY2x1ZGluZyBhZnRlciBERkcgdGllci11cC4KK1BBU1MgMSAvIGZvbygtMSkg aXMgLUluZmluaXR5IG9uIGFsbCBpdGVyYXRpb25zIGluY2x1ZGluZyBhZnRlciBERkcgdGllci11 cC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCklu ZGV4OiBMYXlvdXRUZXN0cy9qcy9kZmctbW9kLTEuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9qcy9kZmctbW9kLTEuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2pzL2Rm Zy1tb2QtMS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9DVFlQRSBI VE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2Ny aXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9kZmctbW9kLTEuanMiPjwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgor PC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2RmZy1t b2QtMS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvZGZnLW1v ZC0xLmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2RmZy1t b2QtMS5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDggQEAKK2Rlc2NyaXB0aW9uKAorIlRl c3RzIHRoYXQgdGhlIERGRyBoYW5kbGVzIHggJSAxIGNvcnJlY3RseS4iCispOworCitmdW5jdGlv biBmb28oeCkgeyByZXR1cm4geCAlIDE7IH0KKworZGZnU2hvdWxkQmUoZm9vLCAiZm9vKC01LjUp IiwgIi0wLjUiKTsKK2RmZ1Nob3VsZEJlKGZvbywgIjEgLyBmb28oLTEpIiwgIi1JbmZpbml0eSIp Owo=