123658 2013-11-01 23:06:01 -0700 [WK2] Update WebGeolocationManager to support multiple WebContent processes 2013-11-04 15:01:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin andersca oldest_to_newest 946178 0 benjamin 2013-11-01 23:06:01 -0700 [WK2] Update WebGeolocationManager to support multiple WebContent processes 946180 1 215797 benjamin 2013-11-01 23:10:12 -0700 Created attachment 215797 Patch 946820 2 215797 andersca 2013-11-04 14:26:10 -0800 Comment on attachment 215797 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215797&action=review > Source/WebKit2/UIProcess/WebContext.cpp:685 > + static_cast<WebContextSupplement*>(supplement<WebGeolocationManagerProxy>())->processDidClose(process); Don’t you want to call this on all the WebContextSupplements? > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.h:72 > + HashSet<const CoreIPC::Connection::Client*> m_updateRequesters; Instead of using a HashSet, could you simply have a counter that keeps track of the number of requests? 946831 3 benjamin 2013-11-04 14:40:46 -0800 (In reply to comment #2) > (From update of attachment 215797 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215797&action=review > > > Source/WebKit2/UIProcess/WebContext.cpp:685 > > + static_cast<WebContextSupplement*>(supplement<WebGeolocationManagerProxy>())->processDidClose(process); > > Don’t you want to call this on all the WebContextSupplements? The other WebContextSupplement do not support multiple WebProcess. They track the state as if there was a single process communicating with them. As a result, they do very bad things on processDidClose(). (I filed <rdar://problem/15376383>) > > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.h:72 > > + HashSet<const CoreIPC::Connection::Client*> m_updateRequesters; > > Instead of using a HashSet, could you simply have a counter that keeps track of the number of requests? The HashSet is a defensive mechanism against mistake in the WebProcess. If for any reason the GeolocationController starts or stops querying twice, the HashSet ensure the state on the UIProcess remains valid. 946839 4 benjamin 2013-11-04 15:01:23 -0800 Committed r158600: <http://trac.webkit.org/changeset/158600> 215797 2013-11-01 23:10:12 -0700 2013-11-04 14:42:19 -0800 Patch bug-123658-20131101231011.patch text/plain 7588 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4NDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmZmYTdlODdlMWFiZWMw YjU1MzhjNGQ2OGZmZmVlNjM3MGNmNTY0MC4uODFhMDM0YWNjNTFjZjdkMzk3MmY3ODhiMTI2NjZl M2Y3MjI0NGY1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTExLTAxICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFVwZGF0 ZSBXZWJHZW9sb2NhdGlvbk1hbmFnZXIgdG8gc3VwcG9ydCBtdWx0aXBsZSBXZWJDb250ZW50IHBy b2Nlc3NlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIzNjU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2hhbmdlIFdlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5IHRvIHRyYWNrIHdoaWNoIFdlYlByb2Nl c3NQcm94eSBuZWVkcyBnZW9sb2NhdGlvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250 ZXh0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6ZGlzY29ubmVjdFByb2Nlc3Mp OgorICAgICAgICBXZWJDb250ZXh0OjpkaXNjb25uZWN0UHJvY2VzcyBkb2VzIG5vdCBoYW5kbGUg Q29udGV4dFN1cHBsZW1lbnQgeWV0IHdoZW4gdXNpbmcgbXVsdGlwbGUKKyAgICAgICAgV2ViQ29u dGVudCBwcm9jZXNzZXMuIEFkZCBhbiBleHBsaWNpdCBjYWxsIGZvciBXZWJHZW9sb2NhdGlvbk1h bmFnZXJQcm94eSBhcyBhIHRlbXBvcmFyeQorICAgICAgICBzb2x1dGlvbi4KKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5OjpXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94 eSk6CisgICAgICAgIChXZWJLaXQ6OldlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5Ojpjb250ZXh0 RGVzdHJveWVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHk6 OnByb2Nlc3NEaWRDbG9zZSk6CisgICAgICAgIChXZWJLaXQ6OldlYkdlb2xvY2F0aW9uTWFuYWdl clByb3h5OjpzdGFydFVwZGF0aW5nKToKKyAgICAgICAgKFdlYktpdDo6V2ViR2VvbG9jYXRpb25N YW5hZ2VyUHJveHk6OnN0b3BVcGRhdGluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYkdlb2xvY2F0 aW9uTWFuYWdlclByb3h5OjpyZW1vdmVSZXF1ZXN0ZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9X ZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJHZW9s b2NhdGlvbk1hbmFnZXJQcm94eS5tZXNzYWdlcy5pbjoKKwogMjAxMy0xMS0wMSAgQmVuamFtaW4g UG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dLMl0gQ3JlYXRlIGEg dW5pcXVlIGlkZW50aWZpZXIgZm9yIFdlYlBhZ2VHcm91cCBpZiB0aGUgaW5wdXQgbmFtZSBpcyBl bXB0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCmluZGV4IDM1MmU1MzM5 YTI2OTJkOTlhZjA5NmY5YTNhNDA5YzBhY2QwNWUzYmMuLjVlZWY1Y2Y1MmY2ZDFjZGFkZTkzMzU3 ZjRkOTM5NjhiOGRkYjRlNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5j cHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEwLCAyMDExLCAyMDEy IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMCwg MjAxMSwgMjAxMiwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICog UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv ciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0 aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTY4MSw2ICs2ODEsOSBAQCB2b2lkIFdlYkNvbnRl eHQ6OmRpc2Nvbm5lY3RQcm9jZXNzKFdlYlByb2Nlc3NQcm94eSogcHJvY2VzcykKICAgICAgICAg UmVmUHRyPFdlYlByb2Nlc3NQcm94eT4gcHJvdGVjdChwcm9jZXNzKTsKICAgICAgICAgaWYgKG1f cHJvY2Vzc1dpdGhQYWdlQ2FjaGUgPT0gcHJvY2VzcykKICAgICAgICAgICAgIG1fcHJvY2Vzc1dp dGhQYWdlQ2FjaGUgPSAwOworCisgICAgICAgIHN0YXRpY19jYXN0PFdlYkNvbnRleHRTdXBwbGVt ZW50Kj4oc3VwcGxlbWVudDxXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eT4oKSktPnByb2Nlc3NE aWRDbG9zZShwcm9jZXNzKTsKKwogICAgICAgICBtX3Byb2Nlc3Nlcy5yZW1vdmUobV9wcm9jZXNz ZXMuZmluZChwcm9jZXNzKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHkuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5LmNwcApp bmRleCA1ZjU0MDgwMjQxMGI2NDQxMmRjZDQ5NTQwZGU3ZTZhZTQwYTI4NDZlLi42NGVkZjhhYzA3 Y2NjM2YyYjYyZDA4NDUzMTIyYWYzZDdhNzAzNDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHkuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eS5jcHAKQEAgLTQ0LDE1 ICs0NCwxMCBAQCBQYXNzUmVmUHRyPFdlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5PiBXZWJHZW9s b2NhdGlvbk1hbmFnZXJQcm94eTo6Y3JlYXRlKFdlYkNvbgogCiBXZWJHZW9sb2NhdGlvbk1hbmFn ZXJQcm94eTo6V2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHkoV2ViQ29udGV4dCogY29udGV4dCkK ICAgICA6IFdlYkNvbnRleHRTdXBwbGVtZW50KGNvbnRleHQpCi0gICAgLCBtX2lzVXBkYXRpbmco ZmFsc2UpCiB7CiAgICAgV2ViQ29udGV4dFN1cHBsZW1lbnQ6OmNvbnRleHQoKS0+YWRkTWVzc2Fn ZVJlY2VpdmVyKE1lc3NhZ2VzOjpXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eTo6bWVzc2FnZVJl Y2VpdmVyTmFtZSgpLCB0aGlzKTsKIH0KIAotV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHk6On5X ZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eSgpCi17Ci19Ci0KIHZvaWQgV2ViR2VvbG9jYXRpb25N YW5hZ2VyUHJveHk6OmluaXRpYWxpemVQcm92aWRlcihjb25zdCBXS0dlb2xvY2F0aW9uUHJvdmlk ZXIqIHByb3ZpZGVyKQogewogICAgIG1fcHJvdmlkZXIuaW5pdGlhbGl6ZShwcm92aWRlcik7CkBA IC02MiwxMiArNTcsMTMgQEAgdm9pZCBXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eTo6aW5pdGlh bGl6ZVByb3ZpZGVyKGNvbnN0IFdLR2VvbG9jYXRpb25Qcm92aWRlcioKIAogdm9pZCBXZWJHZW9s b2NhdGlvbk1hbmFnZXJQcm94eTo6Y29udGV4dERlc3Ryb3llZCgpCiB7Ci0gICAgc3RvcFVwZGF0 aW5nKCk7CisgICAgbV91cGRhdGVSZXF1ZXN0ZXJzLmNsZWFyKCk7CisgICAgbV9wcm92aWRlci5z dG9wVXBkYXRpbmcodGhpcyk7CiB9CiAKLXZvaWQgV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHk6 OnByb2Nlc3NEaWRDbG9zZShXZWJQcm9jZXNzUHJveHkqKQordm9pZCBXZWJHZW9sb2NhdGlvbk1h bmFnZXJQcm94eTo6cHJvY2Vzc0RpZENsb3NlKFdlYlByb2Nlc3NQcm94eSogd2ViUHJvY2Vzc1By b3h5KQogewotICAgIHN0b3BVcGRhdGluZygpOworICAgIHJlbW92ZVJlcXVlc3Rlcih3ZWJQcm9j ZXNzUHJveHkpOwogfQogCiB2b2lkIFdlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5OjpyZWZXZWJD b250ZXh0U3VwcGxlbWVudCgpCkBAIC05NiwyMiArOTIsMjUgQEAgdm9pZCBXZWJHZW9sb2NhdGlv bk1hbmFnZXJQcm94eTo6cHJvdmlkZXJEaWRGYWlsVG9EZXRlcm1pbmVQb3NpdGlvbihjb25zdCBT dHJpbmcKICAgICBjb250ZXh0KCktPnNlbmRUb0FsbFByb2Nlc3NlcyhNZXNzYWdlczo6V2ViR2Vv bG9jYXRpb25NYW5hZ2VyOjpEaWRGYWlsVG9EZXRlcm1pbmVQb3NpdGlvbihlcnJvck1lc3NhZ2Up KTsKIH0KIAotdm9pZCBXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eTo6c3RhcnRVcGRhdGluZygp Cit2b2lkIFdlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5OjpzdGFydFVwZGF0aW5nKENvcmVJUEM6 OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24pCiB7Ci0gICAgaWYgKG1faXNVcGRhdGluZykKLSAgICAg ICAgcmV0dXJuOwotCi0gICAgbV9wcm92aWRlci5zdGFydFVwZGF0aW5nKHRoaXMpOwotICAgIG1f aXNVcGRhdGluZyA9IHRydWU7CisgICAgYm9vbCB3YXNVcGRhdGluZyA9ICFtX3VwZGF0ZVJlcXVl c3RlcnMuaXNFbXB0eSgpOworICAgIG1fdXBkYXRlUmVxdWVzdGVycy5hZGQoY29ubmVjdGlvbi0+ Y2xpZW50KCkpOworICAgIGlmICghd2FzVXBkYXRpbmcpCisgICAgICAgIG1fcHJvdmlkZXIuc3Rh cnRVcGRhdGluZyh0aGlzKTsKIH0KIAotdm9pZCBXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eTo6 c3RvcFVwZGF0aW5nKCkKK3ZvaWQgV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHk6OnN0b3BVcGRh dGluZyhDb3JlSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uKQogewotICAgIGlmICghbV9pc1Vw ZGF0aW5nKQotICAgICAgICByZXR1cm47CisgICAgcmVtb3ZlUmVxdWVzdGVyKGNvbm5lY3Rpb24t PmNsaWVudCgpKTsKK30KIAotICAgIG1fcHJvdmlkZXIuc3RvcFVwZGF0aW5nKHRoaXMpOwotICAg IG1faXNVcGRhdGluZyA9IGZhbHNlOwordm9pZCBXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eTo6 cmVtb3ZlUmVxdWVzdGVyKGNvbnN0IENvcmVJUEM6OkNvbm5lY3Rpb246OkNsaWVudCogY2xpZW50 KQoreworICAgIGJvb2wgd2FzVXBkYXRpbmcgPSAhbV91cGRhdGVSZXF1ZXN0ZXJzLmlzRW1wdHko KTsKKyAgICBtX3VwZGF0ZVJlcXVlc3RlcnMucmVtb3ZlKGNsaWVudCk7CisgICAgaWYgKHdhc1Vw ZGF0aW5nICYmIG1fdXBkYXRlUmVxdWVzdGVycy5pc0VtcHR5KCkpCisgICAgICAgIG1fcHJvdmlk ZXIuc3RvcFVwZGF0aW5nKHRoaXMpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94 eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5 LmgKaW5kZXggYTJkOTdjNmVhMTA2NjdkNjY5MjUxMzYxZjI5YmYwNjM2YzcwNGRiYS4uODZlNDli NTQ0NDkyNzVjNjRmNmZkMzI4MTlmODVhMTJlMTM3ZWVmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5LmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5LmgKQEAgLTI3LDkg KzI3LDExIEBACiAjZGVmaW5lIFdlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5X2gKIAogI2luY2x1 ZGUgIkFQSU9iamVjdC5oIgorI2luY2x1ZGUgIkNvbm5lY3Rpb24uaCIKICNpbmNsdWRlICJNZXNz YWdlUmVjZWl2ZXIuaCIKICNpbmNsdWRlICJXZWJDb250ZXh0U3VwcGxlbWVudC5oIgogI2luY2x1 ZGUgIldlYkdlb2xvY2F0aW9uUHJvdmlkZXIuaCIKKyNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgog I2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAg LTQyLDcgKzQ0LDYgQEAgcHVibGljOgogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBzdXBwbGVtZW50 TmFtZSgpOwogCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8V2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJv eHk+IGNyZWF0ZShXZWJDb250ZXh0Kik7Ci0gICAgdmlydHVhbCB+V2ViR2VvbG9jYXRpb25NYW5h Z2VyUHJveHkoKTsKIAogICAgIHZvaWQgaW5pdGlhbGl6ZVByb3ZpZGVyKGNvbnN0IFdLR2VvbG9j YXRpb25Qcm92aWRlciopOwogCkBAIC02NCwxMCArNjUsMTEgQEAgcHJpdmF0ZToKICAgICAvLyBD b3JlSVBDOjpNZXNzYWdlUmVjZWl2ZXIKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZU1lc3Nh Z2UoQ29yZUlQQzo6Q29ubmVjdGlvbiosIENvcmVJUEM6Ok1lc3NhZ2VEZWNvZGVyJikgT1ZFUlJJ REU7CiAKLSAgICB2b2lkIHN0YXJ0VXBkYXRpbmcoKTsKLSAgICB2b2lkIHN0b3BVcGRhdGluZygp OworICAgIHZvaWQgc3RhcnRVcGRhdGluZyhDb3JlSVBDOjpDb25uZWN0aW9uKik7CisgICAgdm9p ZCBzdG9wVXBkYXRpbmcoQ29yZUlQQzo6Q29ubmVjdGlvbiopOworICAgIHZvaWQgcmVtb3ZlUmVx dWVzdGVyKGNvbnN0IENvcmVJUEM6OkNvbm5lY3Rpb246OkNsaWVudCopOwogCi0gICAgYm9vbCBt X2lzVXBkYXRpbmc7CisgICAgSGFzaFNldDxjb25zdCBDb3JlSVBDOjpDb25uZWN0aW9uOjpDbGll bnQqPiBtX3VwZGF0ZVJlcXVlc3RlcnM7CiAKICAgICBXZWJHZW9sb2NhdGlvblByb3ZpZGVyIG1f cHJvdmlkZXI7CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkdl b2xvY2F0aW9uTWFuYWdlclByb3h5Lm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkdlb2xvY2F0aW9uTWFuYWdlclByb3h5Lm1lc3NhZ2VzLmluCmluZGV4IGZlNWEyNzMw MGQzYmJlMTczZmE1MDcyZTM5MjJhYWE5YTNjZDk5NzcuLjE1NDA2Nzc5ZmNlZmE5ZWMxZTZjNTVm NjljMDY0YjkzYmE0OGM3MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eS5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHkubWVzc2FnZXMuaW4KQEAgLTEs NCArMSw0IEBACi0jIENvcHlyaWdodCAoQykgMjAxMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAxMSwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTIxLDYgKzIxLDYgQEAK ICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP RiBTVUNIIERBTUFHRS4KIAogbWVzc2FnZXMgLT4gV2ViR2VvbG9jYXRpb25NYW5hZ2VyUHJveHkg ewotICAgIFN0YXJ0VXBkYXRpbmcoKTsKLSAgICBTdG9wVXBkYXRpbmcoKTsKKyAgICBTdGFydFVw ZGF0aW5nKCkgV2FudHNDb25uZWN0aW9uCisgICAgU3RvcFVwZGF0aW5nKCkgV2FudHNDb25uZWN0 aW9uCiB9Cg==