123651 2013-11-01 17:55:05 -0700 Remote Layer Tree: Crashes allocating incredibly large backing store for tiled backing layers 2013-11-01 19:21:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue simon.fraser oldest_to_newest 946126 0 thorton 2013-11-01 17:55:05 -0700 It's easy to crash on IE Flying Images if you increase the number of images a bit. Tiled backing layers shouldn't have backing store themselves! But they do, because of a silly mistake in http://trac.webkit.org/changeset/158417... we can't dirty the whole layer if we have no existing front buffer if we have no paints, because that will lead to layers which were never setNeedsDisplay()'d getting backing store. Added back an assertion that will catch this, too. Probably we should strengthen the mechanism that causes never-setNeedsDisplay'd layers from getting backing store. 946127 1 215788 thorton 2013-11-01 17:56:27 -0700 Created attachment 215788 patch 946165 2 215788 commit-queue 2013-11-01 19:21:10 -0700 Comment on attachment 215788 patch Clearing flags on attachment: 215788 Committed r158481: <http://trac.webkit.org/changeset/158481> 946166 3 commit-queue 2013-11-01 19:21:12 -0700 All reviewed patches have been landed. Closing bug. 215788 2013-11-01 17:56:27 -0700 2013-11-01 19:21:10 -0700 patch 2.diff text/plain 2142 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNzNjNjE0Li44YTVkODk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTEtMDEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3RlIExheWVyIFRyZWU6IENyYXNoZXMgYWxsb2NhdGluZyBpbmNyZWRpYmx5 IGxhcmdlIGJhY2tpbmcgc3RvcmUgZm9yIHRpbGVkIGJhY2tpbmcgbGF5ZXJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM2NTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9tYWMvUmVtb3Rl TGF5ZXJCYWNraW5nU3RvcmUubW06CisgICAgICAgIChSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6 ZGlzcGxheSk6CisgICAgICAgIChSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6ZHJhd0luQ29udGV4 dCk6CisgICAgICAgIFdlIGNhbid0IGRpcnR5IHRoZSB3aG9sZSBsYXllciBpZiB3ZSBoYXZlIG5v IGV4aXN0aW5nIGZyb250IGJ1ZmZlciBpZgorICAgICAgICB3ZSBoYXZlIG5vIHBhaW50cywgYmVj YXVzZSB0aGF0IHdpbGwgbGVhZCB0byBsYXllcnMgd2hpY2ggd2VyZSBuZXZlcgorICAgICAgICBz ZXROZWVkc0Rpc3BsYXkoKSdkIGdldHRpbmcgYmFja2luZyBzdG9yZS4gQWRkZWQgYmFjayBhbiBh c3NlcnRpb24KKyAgICAgICAgdGhhdCB3aWxsIGNhdGNoIHRoaXMsIHRvby4KKwogMjAxMy0xMS0w MSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gV0tP YmplY3Qgc2VlbXMgdG8gYmUgaW5pdGlhbGl6aW5nIGl0cyB0YXJnZXQgaW4gYSB0aHJlYWQtc2Fm ZSBtYW5uZXIsIGJ1dCByZWFsbHkgaXMgbm90CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvbWFjL1JlbW90ZUxheWVyQmFja2luZ1N0b3JlLm1tIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL21hYy9SZW1vdGVMYXllckJhY2tpbmdTdG9yZS5tbQppbmRleCA1NTMwNjY5Li4zZjNlMWE4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1JlbW90ZUxheWVyQmFja2lu Z1N0b3JlLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5ZXJCYWNr aW5nU3RvcmUubW0KQEAgLTE5MiwxMiArMTkyLDEyIEBAIGJvb2wgUmVtb3RlTGF5ZXJCYWNraW5n U3RvcmU6OmRpc3BsYXkoKQogICAgICAgICByZXR1cm4gcHJldmlvdXNseURyZXdDb250ZW50czsK ICAgICB9CiAKLSAgICBpZiAoIWhhc0Zyb250QnVmZmVyKCkpCi0gICAgICAgIG1fZGlydHlSZWdp b24udW5pdGUoSW50UmVjdChJbnRQb2ludCgpLCBtX3NpemUpKTsKLQogICAgIGlmIChtX2RpcnR5 UmVnaW9uLmlzRW1wdHkoKSB8fCBtX3NpemUuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAKKyAgICBpZiAoIWhhc0Zyb250QnVmZmVyKCkpCisgICAgICAgIG1fZGlydHlSZWdpb24u dW5pdGUoSW50UmVjdChJbnRQb2ludCgpLCBtX3NpemUpKTsKKwogICAgIGlmIChtX2xheWVyLT5v d25lcigpLT5wbGF0Zm9ybUNBTGF5ZXJTaG93UmVwYWludENvdW50ZXIobV9sYXllcikpIHsKICAg ICAgICAgSW50UmVjdCBpbmRpY2F0b3JSZWN0ID0gbWFwVG9Db250ZW50Q29vcmRpbmF0ZXMoSW50 UmVjdCgwLCAwLCA1MiwgMjcpKTsKICAgICAgICAgbV9kaXJ0eVJlZ2lvbi51bml0ZShpbmRpY2F0 b3JSZWN0KTsKQEAgLTI4OSw2ICsyODksNyBAQCB2b2lkIFJlbW90ZUxheWVyQmFja2luZ1N0b3Jl OjpkcmF3SW5Db250ZXh0KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCkKICAgICAgICAgY2FzZSBQ bGF0Zm9ybUNBTGF5ZXI6OkxheWVyVHlwZVJvb3RMYXllcjoKICAgICAgICAgY2FzZSBQbGF0Zm9y bUNBTGF5ZXI6OkxheWVyVHlwZUFWUGxheWVyTGF5ZXI6CiAgICAgICAgIGNhc2UgUGxhdGZvcm1D QUxheWVyOjpMYXllclR5cGVDdXN0b206CisgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKICAgICAgICAgICAgIGJyZWFrOwogICAgIH07CiAK