123645 2013-11-01 15:58:06 -0700 CSSAspectRatioValue construction helper should return PassRef. 2013-11-01 18:01:36 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn gyuyoung.kim kling macpherson menard oldest_to_newest 946072 0 kling 2013-11-01 15:58:06 -0700 CSSAspectRatioValue construction helper should return PassRef. 946074 1 215773 kling 2013-11-01 15:58:47 -0700 Created attachment 215773 Patch 946086 2 215773 darin 2013-11-01 16:14:21 -0700 Comment on attachment 215773 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS!? No file list? > Source/WebCore/css/CSSAspectRatioValue.h:52 > + explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue) Two arguments -- no need for explicit, which only affects things with one argument. 946088 3 kling 2013-11-01 16:15:54 -0700 (In reply to comment #2) > (From update of attachment 215773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215773&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > OOPS!? > > No file list? > > > Source/WebCore/css/CSSAspectRatioValue.h:52 > > + explicit CSSAspectRatioValue(float numeratorValue, float denominatorValue) > > Two arguments -- no need for explicit, which only affects things with one argument. Urgh. Hardcore rush job. :| 946117 4 215783 kling 2013-11-01 17:23:16 -0700 Created attachment 215783 Patch for landing 946118 5 215784 kling 2013-11-01 17:29:45 -0700 Created attachment 215784 Patch for landing 946130 6 215784 commit-queue 2013-11-01 18:01:33 -0700 Comment on attachment 215784 Patch for landing Clearing flags on attachment: 215784 Committed r158469: <http://trac.webkit.org/changeset/158469> 946131 7 commit-queue 2013-11-01 18:01:36 -0700 All reviewed patches have been landed. Closing bug. 215773 2013-11-01 15:58:47 -0700 2013-11-01 17:23:16 -0700 Patch bug-123645.diff text/plain 1675 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNWJjM2E1Li5kNWNjNDAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTMtMTEtMDEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIENTU0FzcGVjdFJhdGlvVmFsdWUgY29uc3RydWN0aW9uIGhlbHBlciBzaG91bGQgcmV0dXJu IFBhc3NSZWYuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjM2NDU+CisKKyAgICAg ICAgY3JlYXRlKCkgbmV2ZXIgcmV0dXJucyBudWxscHRyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyAoT09QUyEpLgorCisyMDEzLTExLTAxICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv bT4KKwogICAgICAgICBjcmVhdGVGb250RmFjZVZhbHVlKCkgc2hvdWxkIGJlIHNtYXJ0ZXIgYWJv dXQgb3Zlcmdyb3duIGNhY2hlLgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTIzNjQz PgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQXNwZWN0UmF0aW9WYWx1ZS5o IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0FzcGVjdFJhdGlvVmFsdWUuaAppbmRleCBhMjc4MWY2 Li4wMTM4NzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQXNwZWN0UmF0aW9W YWx1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NBc3BlY3RSYXRpb1ZhbHVlLmgKQEAg LTM2LDkgKzM2LDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBDU1NBc3BlY3RSYXRp b1ZhbHVlIDogcHVibGljIENTU1ZhbHVlIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1JlZlB0 cjxDU1NBc3BlY3RSYXRpb1ZhbHVlPiBjcmVhdGUoZmxvYXQgbnVtZXJhdG9yVmFsdWUsIGZsb2F0 IGRlbm9taW5hdG9yVmFsdWUpCisgICAgc3RhdGljIFBhc3NSZWY8Q1NTQXNwZWN0UmF0aW9WYWx1 ZT4gY3JlYXRlKGZsb2F0IG51bWVyYXRvclZhbHVlLCBmbG9hdCBkZW5vbWluYXRvclZhbHVlKQog ICAgIHsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBDU1NBc3BlY3RSYXRpb1ZhbHVlKG51 bWVyYXRvclZhbHVlLCBkZW5vbWluYXRvclZhbHVlKSk7CisgICAgICAgIHJldHVybiBhZG9wdFJl ZigqbmV3IENTU0FzcGVjdFJhdGlvVmFsdWUobnVtZXJhdG9yVmFsdWUsIGRlbm9taW5hdG9yVmFs dWUpKTsKICAgICB9CiAKICAgICBTdHJpbmcgY3VzdG9tQ1NTVGV4dCgpIGNvbnN0OwpAQCAtNDks NyArNDksNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBlcXVhbHMoY29uc3QgQ1NTQXNwZWN0UmF0aW9W YWx1ZSYpIGNvbnN0OwogCiBwcml2YXRlOgotICAgIENTU0FzcGVjdFJhdGlvVmFsdWUoZmxvYXQg bnVtZXJhdG9yVmFsdWUsIGZsb2F0IGRlbm9taW5hdG9yVmFsdWUpCisgICAgZXhwbGljaXQgQ1NT QXNwZWN0UmF0aW9WYWx1ZShmbG9hdCBudW1lcmF0b3JWYWx1ZSwgZmxvYXQgZGVub21pbmF0b3JW YWx1ZSkKICAgICAgICAgOiBDU1NWYWx1ZShBc3BlY3RSYXRpb0NsYXNzKQogICAgICAgICAsIG1f bnVtZXJhdG9yVmFsdWUobnVtZXJhdG9yVmFsdWUpCiAgICAgICAgICwgbV9kZW5vbWluYXRvclZh bHVlKGRlbm9taW5hdG9yVmFsdWUpCg== 215783 2013-11-01 17:23:16 -0700 2013-11-01 17:29:45 -0700 Patch for landing land-123645.diff text/plain 1407 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MmExNjczLi4yMDZlNWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTMtMTEtMDEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIENTU0FzcGVjdFJhdGlvVmFsdWUgY29uc3RydWN0aW9uIGhlbHBlciBzaG91bGQgcmV0dXJu IFBhc3NSZWYuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjM2NDU+CisKKyAgICAg ICAgUmV0dXJuIFBhc3NSZWYgaW5zdGVhZCBvZiBQYXNzUmVmUHRyIGZyb20gZnVuY3Rpb25zIHRo YXQgcmV0dXJuCisgICAgICAgIG93bmVyc2hpcC1wYXNzaW5nIHBvaW50ZXJzIHRoYXQgYXJlIGtu b3duIHRvIGJlIG5vbi1udWxsLgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor CisyMDEzLTExLTAxICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAg ICBOZXV0ZXIgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQgaW4gR0xPQkFMX0ZBU1RNQUxMT0NfTkVX IGJ1aWxkcy4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyMzYzOT4KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0FzcGVjdFJhdGlvVmFsdWUuaCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NBc3BlY3RSYXRpb1ZhbHVlLmgKaW5kZXggYTI3ODFmNi4uZmI1ODJlNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0FzcGVjdFJhdGlvVmFsdWUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQXNwZWN0UmF0aW9WYWx1ZS5oCkBAIC0zNiw5ICszNiw5 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgQ1NTQXNwZWN0UmF0aW9WYWx1ZSA6IHB1 YmxpYyBDU1NWYWx1ZSB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8Q1NTQXNwZWN0 UmF0aW9WYWx1ZT4gY3JlYXRlKGZsb2F0IG51bWVyYXRvclZhbHVlLCBmbG9hdCBkZW5vbWluYXRv clZhbHVlKQorICAgIHN0YXRpYyBQYXNzUmVmPENTU0FzcGVjdFJhdGlvVmFsdWU+IGNyZWF0ZShm bG9hdCBudW1lcmF0b3JWYWx1ZSwgZmxvYXQgZGVub21pbmF0b3JWYWx1ZSkKICAgICB7Ci0gICAg ICAgIHJldHVybiBhZG9wdFJlZihuZXcgQ1NTQXNwZWN0UmF0aW9WYWx1ZShudW1lcmF0b3JWYWx1 ZSwgZGVub21pbmF0b3JWYWx1ZSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBDU1NB c3BlY3RSYXRpb1ZhbHVlKG51bWVyYXRvclZhbHVlLCBkZW5vbWluYXRvclZhbHVlKSk7CiAgICAg fQogCiAgICAgU3RyaW5nIGN1c3RvbUNTU1RleHQoKSBjb25zdDsK 215784 2013-11-01 17:29:45 -0700 2013-11-01 18:01:33 -0700 Patch for landing land-123645.diff text/plain 1407 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MmExNjczLi4yMDZlNWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTMtMTEtMDEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIENTU0FzcGVjdFJhdGlvVmFsdWUgY29uc3RydWN0aW9uIGhlbHBlciBzaG91bGQgcmV0dXJu IFBhc3NSZWYuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjM2NDU+CisKKyAgICAg ICAgUmV0dXJuIFBhc3NSZWYgaW5zdGVhZCBvZiBQYXNzUmVmUHRyIGZyb20gZnVuY3Rpb25zIHRo YXQgcmV0dXJuCisgICAgICAgIG93bmVyc2hpcC1wYXNzaW5nIHBvaW50ZXJzIHRoYXQgYXJlIGtu b3duIHRvIGJlIG5vbi1udWxsLgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgor CisyMDEzLTExLTAxICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAg ICBOZXV0ZXIgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQgaW4gR0xPQkFMX0ZBU1RNQUxMT0NfTkVX IGJ1aWxkcy4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyMzYzOT4KIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0FzcGVjdFJhdGlvVmFsdWUuaCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NBc3BlY3RSYXRpb1ZhbHVlLmgKaW5kZXggYTI3ODFmNi4uZmI1ODJlNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0FzcGVjdFJhdGlvVmFsdWUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTQXNwZWN0UmF0aW9WYWx1ZS5oCkBAIC0zNiw5ICszNiw5 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgQ1NTQXNwZWN0UmF0aW9WYWx1ZSA6IHB1 YmxpYyBDU1NWYWx1ZSB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8Q1NTQXNwZWN0 UmF0aW9WYWx1ZT4gY3JlYXRlKGZsb2F0IG51bWVyYXRvclZhbHVlLCBmbG9hdCBkZW5vbWluYXRv clZhbHVlKQorICAgIHN0YXRpYyBQYXNzUmVmPENTU0FzcGVjdFJhdGlvVmFsdWU+IGNyZWF0ZShm bG9hdCBudW1lcmF0b3JWYWx1ZSwgZmxvYXQgZGVub21pbmF0b3JWYWx1ZSkKICAgICB7Ci0gICAg ICAgIHJldHVybiBhZG9wdFJlZihuZXcgQ1NTQXNwZWN0UmF0aW9WYWx1ZShudW1lcmF0b3JWYWx1 ZSwgZGVub21pbmF0b3JWYWx1ZSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBDU1NB c3BlY3RSYXRpb1ZhbHVlKG51bWVyYXRvclZhbHVlLCBkZW5vbWluYXRvclZhbHVlKSk7CiAgICAg fQogCiAgICAgU3RyaW5nIGN1c3RvbUNTU1RleHQoKSBjb25zdDsK