123627 2013-11-01 12:16:22 -0700 Don't use the C API in WKRemoteObjectCoder 2013-11-01 12:33:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 945975 0 andersca 2013-11-01 12:16:22 -0700 Don't use the C API in WKRemoteObjectCoder 945978 1 215748 andersca 2013-11-01 12:19:46 -0700 Created attachment 215748 Patch 945980 2 andersca 2013-11-01 12:33:51 -0700 Committed r158448: <http://trac.webkit.org/changeset/158448> 215748 2013-11-01 12:19:46 -0700 2013-11-01 12:23:21 -0700 Patch bug-123627-20131101121945.patch text/plain 5322 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjYyNzBmYjBmYmQzOWM4 OTJmYTUyODk5Y2ViOTQyOTFiMDI0ODUyYS4uZDVlMTU4MzFhY2I5OWEyMWFiNTIxNWRlYWNiMWM5 MTliY2YwMzRkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTExLTAxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgdXNlIHRo ZSBDIEFQSSBpbiBXS1JlbW90ZU9iamVjdENvZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM2MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RD b2Rlci5tbToKKyAgICAgICAgKC1bV0tSZW1vdGVPYmplY3RFbmNvZGVyIGluaXRdKToKKyAgICAg ICAgKC1bV0tSZW1vdGVPYmplY3RFbmNvZGVyIGVuY29kZUJ5dGVzOmxlbmd0aDpmb3JLZXk6XSk6 CisgICAgICAgICgtW1dLUmVtb3RlT2JqZWN0RW5jb2RlciBfZW5jb2RlT2JqZWN0Rm9yS2V5OnVz aW5nQmxvY2s6XSk6CisgICAgICAgICogU2hhcmVkL0ltbXV0YWJsZURpY3Rpb25hcnkuaDoKKyAg ICAgICAgKiBTaGFyZWQvTXV0YWJsZURpY3Rpb25hcnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpN dXRhYmxlRGljdGlvbmFyeTo6YWRkKToKKyAgICAgICAgKFdlYktpdDo6TXV0YWJsZURpY3Rpb25h cnk6OnNldCk6CisgICAgICAgICogU2hhcmVkL011dGFibGVEaWN0aW9uYXJ5Lmg6CisKIDIwMTMt MTAtMzEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAg Rml4IGEgdHlwby9yZXZpZXcgY29tbWVudCBmcm9tIERhbiwgaW4gaHR0cDovL3RyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvMTU4NDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0KaW5kZXggODhkYTc1Y2YyZTk2ODQ5NjZl ODkwNWU5OTZmMzJhN2U3ZTBkMzMxMC4uNjBkMGZmNDgwNDEyMDAyMjZiZTlhMTIzZGRiMjAxZTFi M2VmMTAwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1Jl bW90ZU9iamVjdENvZGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2Ev V0tSZW1vdGVPYmplY3RDb2Rlci5tbQpAQCAtMjYsMjEgKzI2LDIxIEBACiAjaW1wb3J0ICJjb25m aWcuaCIKICNpbXBvcnQgIldLUmVtb3RlT2JqZWN0Q29kZXIuaCIKIAotI2ltcG9ydCAiV0tEYXRh LmgiCi0jaW1wb3J0ICJXS011dGFibGVEaWN0aW9uYXJ5LmgiCi0jaW1wb3J0ICJXS051bWJlci5o IgotI2ltcG9ydCAiV0tSZXRhaW5QdHIuaCIKLSNpbXBvcnQgIldLU3RyaW5nQ0YuaCIKKyNpbXBv cnQgIk11dGFibGVEaWN0aW9uYXJ5LmgiCisjaW1wb3J0ICJXZWJEYXRhLmgiCisjaW1wb3J0IDx3 dGYvVGVtcG9yYXJ5Q2hhbmdlLmg+CiAKICNpZiBXS19BUElfRU5BQkxFRAogCit1c2luZyBuYW1l c3BhY2UgV2ViS2l0OworCiBAaW50ZXJmYWNlIE5TTWV0aG9kU2lnbmF0dXJlIChEZXRhaWxzKQog LSAoTlNTdHJpbmcgKilfdHlwZVN0cmluZzsKIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdLUmVt b3RlT2JqZWN0RW5jb2RlciB7Ci0gICAgV0tSZXRhaW5QdHI8V0tNdXRhYmxlRGljdGlvbmFyeVJl Zj4gX3Jvb3REaWN0aW9uYXJ5OwotICAgIFdLTXV0YWJsZURpY3Rpb25hcnlSZWYgX2N1cnJlbnRE aWN0aW9uYXJ5OworICAgIFJlZlB0cjxNdXRhYmxlRGljdGlvbmFyeT4gX3Jvb3REaWN0aW9uYXJ5 OworICAgIE11dGFibGVEaWN0aW9uYXJ5KiBfY3VycmVudERpY3Rpb25hcnk7CiB9CiAKIC0gKGlk KWluaXQKQEAgLTQ4LDcgKzQ4LDcgQEAKICAgICBpZiAoIShzZWxmID0gW3N1cGVyIGluaXRdKSkK ICAgICAgICAgcmV0dXJuIG5pbDsKIAotICAgIF9yb290RGljdGlvbmFyeSA9IGFkb3B0V0soV0tN dXRhYmxlRGljdGlvbmFyeUNyZWF0ZSgpKTsKKyAgICBfcm9vdERpY3Rpb25hcnkgPSBNdXRhYmxl RGljdGlvbmFyeTo6Y3JlYXRlKCk7CiAgICAgX2N1cnJlbnREaWN0aW9uYXJ5ID0gX3Jvb3REaWN0 aW9uYXJ5LmdldCgpOwogCiAgICAgcmV0dXJuIHNlbGY7CkBAIC05NywyMiArOTcsMTYgQEAKIAog LSAodm9pZCllbmNvZGVCeXRlczooY29uc3QgdWludDhfdCAqKWJ5dGVzIGxlbmd0aDooTlNVSW50 ZWdlcilsZW5ndGggZm9yS2V5OihOU1N0cmluZyAqKWtleQogewotICAgIGF1dG8gZGF0YSA9IGFk b3B0V0soV0tEYXRhQ3JlYXRlKGJ5dGVzLCBsZW5ndGgpKTsKLSAgICBhdXRvIGtleVN0cmluZyA9 IGFkb3B0V0soV0tTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmcoKENGU3RyaW5nUmVmKWtleSkpOwot Ci0gICAgV0tEaWN0aW9uYXJ5U2V0SXRlbShfY3VycmVudERpY3Rpb25hcnksIGtleVN0cmluZy5n ZXQoKSwgZGF0YS5nZXQoKSk7CisgICAgX2N1cnJlbnREaWN0aW9uYXJ5LT5zZXQoa2V5LCBXZWJE YXRhOjpjcmVhdGUoYnl0ZXMsIGxlbmd0aCkpOwogfQogCiAtICh2b2lkKV9lbmNvZGVPYmplY3RG b3JLZXk6KE5TU3RyaW5nICopa2V5IHVzaW5nQmxvY2s6KHZvaWQgKF4pKCkpYmxvY2sKIHsKLSAg ICBhdXRvIGRpY3Rpb25hcnkgPSBhZG9wdFdLKFdLTXV0YWJsZURpY3Rpb25hcnlDcmVhdGUoKSk7 Ci0gICAgYXV0byBrZXlTdHJpbmcgPSBhZG9wdFdLKFdLU3RyaW5nQ3JlYXRlV2l0aENGU3RyaW5n KChDRlN0cmluZ1JlZilrZXkpKTsKLQotICAgIFdLRGljdGlvbmFyeVNldEl0ZW0oX2N1cnJlbnRE aWN0aW9uYXJ5LCBrZXlTdHJpbmcuZ2V0KCksIGRpY3Rpb25hcnkuZ2V0KCkpOworICAgIFJlZlB0 cjxNdXRhYmxlRGljdGlvbmFyeT4gZGljdGlvbmFyeSA9IE11dGFibGVEaWN0aW9uYXJ5OjpjcmVh dGUoKTsKKyAgICBUZW1wb3JhcnlDaGFuZ2U8TXV0YWJsZURpY3Rpb25hcnkqPiBkaWN0aW9uYXJ5 Q2hhbmdlKF9jdXJyZW50RGljdGlvbmFyeSwgZGljdGlvbmFyeS5nZXQoKSk7CiAKLSAgICBXS011 dGFibGVEaWN0aW9uYXJ5UmVmIHByZXZpb3VzRGljdGlvbmFyeSA9IF9jdXJyZW50RGljdGlvbmFy eTsKKyAgICBkaWN0aW9uYXJ5LT5zZXQoa2V5LCBkaWN0aW9uYXJ5LnJlbGVhc2UoKSk7CiAgICAg YmxvY2soKTsKLSAgICBfY3VycmVudERpY3Rpb25hcnkgPSBwcmV2aW91c0RpY3Rpb25hcnk7CiB9 CiAKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9JbW11dGFibGVEaWN0 aW9uYXJ5LmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvSW1tdXRhYmxlRGljdGlvbmFyeS5oCmlu ZGV4IGY3ZjA1NzJmNTBhNmNkM2M3OTQwNzU2OGVhZmU2ZjE0YzM0OGMyM2EuLjFlOTc3ZTFkNzAy ZGJlYWNkNGYyZTBkZTk5Y2YwMDE4MzNmYmE3N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9JbW11dGFibGVEaWN0aW9uYXJ5LmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVk L0ltbXV0YWJsZURpY3Rpb25hcnkuaApAQCAtODEsNyArODEsNyBAQCBwdWJsaWM6CiAKIHByb3Rl Y3RlZDoKICAgICBJbW11dGFibGVEaWN0aW9uYXJ5KCk7Ci0gICAgSW1tdXRhYmxlRGljdGlvbmFy eShNYXBUeXBlJiBtYXApOworICAgIGV4cGxpY2l0IEltbXV0YWJsZURpY3Rpb25hcnkoTWFwVHlw ZSYpOwogCiAgICAgTWFwVHlwZSBtX21hcDsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvTXV0YWJsZURpY3Rpb25hcnkuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL011 dGFibGVEaWN0aW9uYXJ5LmNwcAppbmRleCBhYzY5Yjc2YTNiMjRhZjdlYzE2YWU5NzczNzljNTFh NmUzZGUzZGRiLi4zOGJmMWI1MWQ2NDVkZjQ1MzRhNjQzOTI4OWI5MjlhOTBkNTFiMmE3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvTXV0YWJsZURpY3Rpb25hcnkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9NdXRhYmxlRGljdGlvbmFyeS5jcHAKQEAgLTM2LDEzICsz NiwxMyBAQCBNdXRhYmxlRGljdGlvbmFyeTo6fk11dGFibGVEaWN0aW9uYXJ5KCkKIHsKIH0KIAot Ym9vbCBNdXRhYmxlRGljdGlvbmFyeTo6YWRkKGNvbnN0IFN0cmluZyYga2V5LCBBUElPYmplY3Qq IGl0ZW0pCitib29sIE11dGFibGVEaWN0aW9uYXJ5OjphZGQoY29uc3QgU3RyaW5nJiBrZXksIFBh c3NSZWZQdHI8QVBJT2JqZWN0PiBpdGVtKQogewogICAgIE1hcFR5cGU6OkFkZFJlc3VsdCByZXN1 bHQgPSBtX21hcC5hZGQoa2V5LCBpdGVtKTsKICAgICByZXR1cm4gcmVzdWx0LmlzTmV3RW50cnk7 CiB9CiAKLWJvb2wgTXV0YWJsZURpY3Rpb25hcnk6OnNldChjb25zdCBTdHJpbmcmIGtleSwgQVBJ T2JqZWN0KiBpdGVtKQorYm9vbCBNdXRhYmxlRGljdGlvbmFyeTo6c2V0KGNvbnN0IFN0cmluZyYg a2V5LCBQYXNzUmVmUHRyPEFQSU9iamVjdD4gaXRlbSkKIHsKICAgICBNYXBUeXBlOjpBZGRSZXN1 bHQgcmVzdWx0ID0gbV9tYXAuc2V0KGtleSwgaXRlbSk7CiAgICAgcmV0dXJuIHJlc3VsdC5pc05l d0VudHJ5OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL011dGFibGVEaWN0aW9u YXJ5LmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvTXV0YWJsZURpY3Rpb25hcnkuaAppbmRleCA1 ODk4Y2I3MmY3ZjA0MzkzMjcxNzQxMmNhYmQ3MTAxYThmMTQ5YzI1Li5jNTlkNzZiOGI0MTI2ZDA5 N2VmZjY0OWY3YmE5NTc2OTE3ZDJhZDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvTXV0YWJsZURpY3Rpb25hcnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvTXV0YWJs ZURpY3Rpb25hcnkuaApAQCAtNDEsOCArNDEsOCBAQCBwdWJsaWM6CiAKICAgICB+TXV0YWJsZURp Y3Rpb25hcnkoKTsKIAotICAgIGJvb2wgYWRkKGNvbnN0IFN0cmluZyYga2V5LCBBUElPYmplY3Qq KTsKLSAgICBib29sIHNldChjb25zdCBTdHJpbmcmIGtleSwgQVBJT2JqZWN0Kik7CisgICAgYm9v bCBhZGQoY29uc3QgU3RyaW5nJiBrZXksIFBhc3NSZWZQdHI8QVBJT2JqZWN0Pik7CisgICAgYm9v bCBzZXQoY29uc3QgU3RyaW5nJiBrZXksIFBhc3NSZWZQdHI8QVBJT2JqZWN0Pik7CiAgICAgdm9p ZCByZW1vdmUoY29uc3QgU3RyaW5nJiBrZXkpOwogCiAgICAgdmlydHVhbCBib29sIGlzTXV0YWJs ZSgpIHsgcmV0dXJuIHRydWU7IH0K