123605 2013-10-31 17:34:31 -0700 FTL Int32ToDouble should handle the forward type check case where you need a recovery 2013-10-31 17:44:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 945779 0 fpizlo 2013-10-31 17:34:31 -0700 Patch forthcoming. 945783 1 215701 fpizlo 2013-10-31 17:36:49 -0700 Created attachment 215701 the patch 945784 2 nrotem 2013-10-31 17:39:24 -0700 LGTM. 945786 3 215701 mhahnenberg 2013-10-31 17:43:09 -0700 Comment on attachment 215701 the patch r=me 945787 4 fpizlo 2013-10-31 17:44:20 -0700 Landed in http://trac.webkit.org/changeset/158412 215701 2013-10-31 17:36:49 -0700 2013-10-31 17:43:08 -0700 the patch blah.patch text/plain 3902 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4NDExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTEwLTMxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIEludDMyVG9Eb3VibGUgc2hvdWxkIGhhbmRsZSB0aGUgZm9yd2FyZCB0eXBlIGNoZWNrIGNh c2Ugd2hlcmUgeW91IG5lZWQgYSByZWNvdmVyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNjA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJZiB5b3UgaGF2ZSBhIEludDMyVG9Eb3VibGUg dGhhdCBuZWVkcyB0byBkbyBhIHR5cGUgY2hlY2sgYW5kIGl0J3MgcmVxdWlyZWQgdG8gZG8gYQor ICAgICAgICBmb3J3YXJkIGV4aXQsIHRoZW4gaXQgbmVlZHMgdG8gbWFudWFsbHkgcGFzcyBpbiBh IHZhbHVlIHJlY292ZXJ5IGZvciBpdHNlbGYgaW4gdGhlCisgICAgICAgIE9TUiBleGl0IC0gc2lu Y2UgdGhpcyBpcyBvbmUgb2YgdGhvc2UgZm9yd2FyZC1leGl0aW5nIG5vZGVzIHRoYXQgZG9lc24n dCBoYXZlIGEKKyAgICAgICAgcHJlY2VkaW5nIE1vdkhpbnQuCisKKyAgICAgICAgKiBmdGwvRlRM TG93ZXJERkdUb0xMVk0uY3BwOgorICAgICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9MTFZNOjpj b21waWxlSW50MzJUb0RvdWJsZSk6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06 OmZvcndhcmRUeXBlQ2hlY2spOgorCiAyMDEzLTEwLTMxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgRlRMIHNob3VsZCBpbXBsZW1lbnQgSW52YWxpZGF0aW9uUG9p bnQgaW4gdGVybXMgb2YgbGx2bS5zdGFja21hcApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHJldmlzaW9uIDE1ODQwNSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMDkxLDE0ICsxMDkxLDQwIEBAIHByaXZhdGU6CiAgICAgCiAgICAgdm9pZCBjb21w aWxlSW50MzJUb0RvdWJsZSgpCiAgICAgewotICAgICAgICAvLyBUaGlzIG5vZGUgaXMgdHJpY2t5 IHRvIGNvbXBpbGUgaW4gdGhlIERGRyBiYWNrZW5kIGJlY2F1c2UgaXQgdHJpZXMgdG8KLSAgICAg ICAgLy8gYXZvaWQgY29udmVydGluZyBjaGlsZDEgdG8gYSBkb3VibGUgaW4tcGxhY2UsIGFzIHRo YXQgd291bGQgbWFrZSBzdWJzZXF1ZW50Ci0gICAgICAgIC8vIGludCB1c2VzIG9mIG9mIGNoaWxk MSBmYWlsLiBCdXQgdGhlIEZUTCBuZWVkcyBubyBzdWNoIHNwZWNpYWwgbWFnaWMsIHNpbmNlCi0g ICAgICAgIC8vIHVubGlrZSB0aGUgREZHIGJhY2tlbmQsIHRoZSBGVEwgYWxsb3dzIGVhY2ggbm9k ZSB0byBoYXZlIG11bHRpcGxlCi0gICAgICAgIC8vIGNvbnRlbXBvcmFuZW91cyBsb3ctbGV2ZWwg cmVwcmVzZW50YXRpb25zLiBTbywgdGhpcyBnaXZlcyBjaGlsZDEgYSBkb3VibGUKLSAgICAgICAg Ly8gcmVwcmVzZW50YXRpb24gYW5kIHRoZW4gZm9yd2FyZHMgdGhhdCByZXByZXNlbnRhdGlvbiB0 byBtX25vZGUuCisgICAgICAgIGlmICghbV9pbnRlcnByZXRlci5uZWVkc1R5cGVDaGVjayhtX25v ZGUtPmNoaWxkMSgpLCBTcGVjRnVsbE51bWJlcikKKyAgICAgICAgICAgIHx8IG1fbm9kZS0+c3Bl Y3VsYXRpb25EaXJlY3Rpb24oKSA9PSBCYWNrd2FyZFNwZWN1bGF0aW9uKSB7CisgICAgICAgICAg ICBzZXREb3VibGUobG93RG91YmxlKG1fbm9kZS0+Y2hpbGQxKCkpKTsKKyAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgTFZhbHVlIGJveGVkVmFsdWUgPSBs b3dKU1ZhbHVlKG1fbm9kZS0+Y2hpbGQxKCksIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbik7Cisg ICAgICAgIAorICAgICAgICBMQmFzaWNCbG9jayBpbnRDYXNlID0gRlRMX05FV19CTE9DSyhtX291 dCwgKCJEb3VibGUgdW5ib3hpbmcgaW50IGNhc2UiKSk7CisgICAgICAgIExCYXNpY0Jsb2NrIGRv dWJsZUNhc2UgPSBGVExfTkVXX0JMT0NLKG1fb3V0LCAoIkRvdWJsZSB1bmJveGluZyBkb3VibGUg Y2FzZSIpKTsKKyAgICAgICAgTEJhc2ljQmxvY2sgY29udGludWF0aW9uID0gRlRMX05FV19CTE9D SyhtX291dCwgKCJEb3VibGUgdW5ib3hpbmcgY29udGludWF0aW9uIikpOworICAgICAgICAKKyAg ICAgICAgbV9vdXQuYnJhbmNoKGlzTm90SW50MzIoYm94ZWRWYWx1ZSksIGRvdWJsZUNhc2UsIGlu dENhc2UpOwogICAgICAgICAKLSAgICAgICAgc2V0RG91YmxlKGxvd0RvdWJsZShtX25vZGUtPmNo aWxkMSgpKSk7CisgICAgICAgIExCYXNpY0Jsb2NrIGxhc3ROZXh0ID0gbV9vdXQuYXBwZW5kVG8o aW50Q2FzZSwgZG91YmxlQ2FzZSk7CisgICAgICAgIAorICAgICAgICBWYWx1ZUZyb21CbG9jayBp bnRUb0RvdWJsZSA9IG1fb3V0LmFuY2hvcigKKyAgICAgICAgICAgIG1fb3V0LmludFRvRG91Ymxl KHVuYm94SW50MzIoYm94ZWRWYWx1ZSkpKTsKKyAgICAgICAgbV9vdXQuanVtcChjb250aW51YXRp b24pOworICAgICAgICAKKyAgICAgICAgbV9vdXQuYXBwZW5kVG8oZG91YmxlQ2FzZSwgY29udGlu dWF0aW9uKTsKKworICAgICAgICBmb3J3YXJkVHlwZUNoZWNrKAorICAgICAgICAgICAganNWYWx1 ZVZhbHVlKGJveGVkVmFsdWUpLCBtX25vZGUtPmNoaWxkMSgpLCBTcGVjRnVsbE51bWJlciwKKyAg ICAgICAgICAgIGlzQ2VsbE9yTWlzYyhib3hlZFZhbHVlKSwganNWYWx1ZVZhbHVlKGJveGVkVmFs dWUpKTsKKyAgICAgICAgCisgICAgICAgIFZhbHVlRnJvbUJsb2NrIHVuYm94ZWREb3VibGUgPSBt X291dC5hbmNob3IodW5ib3hEb3VibGUoYm94ZWRWYWx1ZSkpOworICAgICAgICBtX291dC5qdW1w KGNvbnRpbnVhdGlvbik7CisgICAgICAgIAorICAgICAgICBtX291dC5hcHBlbmRUbyhjb250aW51 YXRpb24sIGxhc3ROZXh0KTsKKyAgICAgICAgCisgICAgICAgIExWYWx1ZSByZXN1bHQgPSBtX291 dC5waGkobV9vdXQuZG91YmxlVHlwZSwgaW50VG9Eb3VibGUsIHVuYm94ZWREb3VibGUpOworICAg ICAgICAKKyAgICAgICAgc2V0RG91YmxlKHJlc3VsdCk7CiAgICAgfQogICAgIAogICAgIHZvaWQg Y29tcGlsZUNoZWNrU3RydWN0dXJlKCkKQEAgLTI0MTEsMTEgKzI0MzcsMTEgQEAgcHJpdmF0ZToK ICAgICAKICAgICB2b2lkIGZvcndhcmRUeXBlQ2hlY2soCiAgICAgICAgIEZvcm1hdHRlZFZhbHVl IGxvd1ZhbHVlLCBFZGdlIGhpZ2hWYWx1ZSwgU3BlY3VsYXRlZFR5cGUgdHlwZXNQYXNzZWRUaHJv dWdoLAotICAgICAgICBMVmFsdWUgZmFpbENvbmRpdGlvbikKKyAgICAgICAgTFZhbHVlIGZhaWxD b25kaXRpb24sIGNvbnN0IEZvcm1hdHRlZFZhbHVlJiByZWNvdmVyeSkKICAgICB7CiAgICAgICAg IGFwcGVuZFR5cGVDaGVjaygKICAgICAgICAgICAgIGxvd1ZhbHVlLCBoaWdoVmFsdWUsIHR5cGVz UGFzc2VkVGhyb3VnaCwgZmFpbENvbmRpdGlvbiwgRm9yd2FyZFNwZWN1bGF0aW9uLAotICAgICAg ICAgICAgRm9ybWF0dGVkVmFsdWUoKSk7CisgICAgICAgICAgICByZWNvdmVyeSk7CiAgICAgfQog ICAgIAogICAgIHZvaWQgdHlwZUNoZWNrKAo=