123599 2013-10-31 17:20:02 -0700 std::function prefers nullptr 2013-10-31 17:59:31 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 8 RESOLVED FIXED P2 Trivial --- 1 alex.christensen webkit-unassigned andersca bfulgham commit-queue roger_fong oldest_to_newest 945764 0 alex.christensen 2013-10-31 17:20:02 -0700 Hooray for C++11! In order to get WebKit to compile with VS2012, we're going to have to be careful with our std::function usage. Setting it to 0 causes all kinds of nasty template compile problems, but setting it to nullptr makes everybody happy. 945766 1 bfulgham 2013-10-31 17:21:36 -0700 These should probably be safe to apply as we go, since nullptr is probably the "right" thing to be using anyway. 945769 2 215695 alex.christensen 2013-10-31 17:22:16 -0700 Created attachment 215695 Patch 945775 3 215695 bfulgham 2013-10-31 17:27:37 -0700 Comment on attachment 215695 Patch r=me 945794 4 215695 commit-queue 2013-10-31 17:59:30 -0700 Comment on attachment 215695 Patch Clearing flags on attachment: 215695 Committed r158414: <http://trac.webkit.org/changeset/158414> 945795 5 commit-queue 2013-10-31 17:59:31 -0700 All reviewed patches have been landed. Closing bug. 215695 2013-10-31 17:22:16 -0700 2013-10-31 17:59:30 -0700 Patch bug-123599-20131031182219.patch text/plain 2127 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODQwOSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTMx ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAg Q29tcGlsZSBmaXggZm9yIFZTMjAxMi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyMzU5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3Bw OgorICAgICAgICAoV2ViRnJhbWVMb2FkZXJDbGllbnQ6OldlYkZyYW1lUG9saWN5TGlzdGVuZXJQ cml2YXRlOjpXZWJGcmFtZVBvbGljeUxpc3RlbmVyUHJpdmF0ZSk6CisgICAgICAgIChXZWJGcmFt ZUxvYWRlckNsaWVudDo6Y2FuY2VsUG9saWN5Q2hlY2spOgorICAgICAgICAoV2ViRnJhbWVMb2Fk ZXJDbGllbnQ6OnJlY2VpdmVkUG9saWN5RGVjaXNpb24pOgorICAgICAgICBVc2UgbnVsbHB0ciBp bnN0ZWFkIG9mIDAgZm9yIG1fcG9saWN5RnVuY3Rpb24sIHdoaWNoIGlzIGEgc3RkOjpmdW5jdGlv bi4KKwogMjAxMy0xMC0zMSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBbV0lOXSBNYWtlIFdlYkhpc3RvcnkgY29tcGlsZSB3aXRob3V0IFVTRShDRikK SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xp ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9X ZWJGcmFtZUxvYWRlckNsaWVudC5jcHAJKHJldmlzaW9uIDE1ODQwOSkKKysrIFNvdXJjZS9XZWJL aXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtOTMsNyArOTMsNyBAQCBzdGF0aWMgV2ViRGF0YVNvdXJjZSogZ2V0V2ViRGF0YVNv dXJjZShECiBjbGFzcyBXZWJGcmFtZUxvYWRlckNsaWVudDo6V2ViRnJhbWVQb2xpY3lMaXN0ZW5l clByaXZhdGUgewogcHVibGljOgogICAgIFdlYkZyYW1lUG9saWN5TGlzdGVuZXJQcml2YXRlKCkg Ci0gICAgICAgIDogbV9wb2xpY3lGdW5jdGlvbigwKQorICAgICAgICA6IG1fcG9saWN5RnVuY3Rp b24obnVsbHB0cikKICAgICB7IAogICAgIH0KIApAQCAtMTM0Nyw3ICsxMzQ3LDcgQEAgdm9pZCBX ZWJGcmFtZUxvYWRlckNsaWVudDo6Y2FuY2VsUG9saWN5QwogICAgICAgICBtX3BvbGljeUxpc3Rl bmVyUHJpdmF0ZS0+bV9wb2xpY3lMaXN0ZW5lciA9IDA7CiAgICAgfQogCi0gICAgbV9wb2xpY3lM aXN0ZW5lclByaXZhdGUtPm1fcG9saWN5RnVuY3Rpb24gPSAwOworICAgIG1fcG9saWN5TGlzdGVu ZXJQcml2YXRlLT5tX3BvbGljeUZ1bmN0aW9uID0gbnVsbHB0cjsKIH0KIAogQ09NUHRyPFdlYkZy YW1lUG9saWN5TGlzdGVuZXI+IFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpzZXRVcFBvbGljeUxpc3Rl bmVyKFdlYkNvcmU6OkZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24pCkBAIC0xMzc0LDcgKzEz NzQsNyBAQCB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50OjpyZWNlaXZlZFBvbGljCiAgICAgRnJh bWVQb2xpY3lGdW5jdGlvbiBmdW5jdGlvbiA9IG1fcG9saWN5TGlzdGVuZXJQcml2YXRlLT5tX3Bv bGljeUZ1bmN0aW9uOwogCiAgICAgbV9wb2xpY3lMaXN0ZW5lclByaXZhdGUtPm1fcG9saWN5TGlz dGVuZXIgPSAwOwotICAgIG1fcG9saWN5TGlzdGVuZXJQcml2YXRlLT5tX3BvbGljeUZ1bmN0aW9u ID0gMDsKKyAgICBtX3BvbGljeUxpc3RlbmVyUHJpdmF0ZS0+bV9wb2xpY3lGdW5jdGlvbiA9IG51 bGxwdHI7CiAKICAgICBGcmFtZSogY29yZUZyYW1lID0gY29yZShtX3dlYkZyYW1lKTsKICAgICBB U1NFUlQoY29yZUZyYW1lKTsK