123595 2013-10-31 16:20:08 -0700 [CSS Shapes] Fix typo in simple-polygon.js LayoutTest helper 2013-11-01 16:37:06 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 giles_joplin giles_joplin commit-queue oldest_to_newest 945741 0 giles_joplin 2013-10-31 16:20:08 -0700 The lineHeight parameter to generatePolygonContentString() is 'lineheight'. It should be lineHeight. This typo was found by SteveBlock@chromium.org - https://codereview.chromium.org/53583005/ 945746 1 215690 giles_joplin 2013-10-31 16:25:51 -0700 Created attachment 215690 Patch 945758 2 215690 darin 2013-10-31 17:01:32 -0700 Comment on attachment 215690 Patch Is this making some tests fail? If not, why not? 946083 3 giles_joplin 2013-11-01 16:10:53 -0700 (In reply to comment #2) > (From update of attachment 215690 [details]) > Is this making some tests fail? If not, why not? A global called lineHeight was being set (correctly) in the test cases that used this code, so it wasn't causing any tests to fail. 946098 4 215690 commit-queue 2013-11-01 16:37:05 -0700 Comment on attachment 215690 Patch Clearing flags on attachment: 215690 Committed r158466: <http://trac.webkit.org/changeset/158466> 946099 5 commit-queue 2013-11-01 16:37:06 -0700 All reviewed patches have been landed. Closing bug. 215690 2013-10-31 16:25:51 -0700 2013-11-01 16:37:04 -0700 Patch tmp.patch text/plain 1369 giles_joplin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyYmY5Mjc3Li5jZjI4NzkxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTAt MzEgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBTaGFw ZXNdIEZpeCB0eXBvIGluIHNpbXBsZS1wb2x5Z29uLmpzIExheW91dFRlc3QgaGVscGVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM1OTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qvc2hhcGVz L3Jlc291cmNlcy9zaW1wbGUtcG9seWdvbi5qczoKKyAgICAgICAgKGdlbmVyYXRlUG9seWdvbkNv bnRlbnRTdHJpbmcpOiBGaXhlZCBhIHR5cG86IHRoZSBsaW5lSGVpZ2h0IHBhcmFtZXRlciBnZW5l cmF0ZVBvbHlnb25Db250ZW50U3RyaW5nKCkgaXMgbm93IGxpbmVIZWlnaHQuCisKIDIwMTMtMTAt MzAgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAg IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgc2hvdWxkIGJlIGNvbnNpc3RlbnQgaW4gV2luZG93 Lm9wZW4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3Jlc291cmNlcy9zaW1w bGUtcG9seWdvbi5qcyBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3Jlc291cmNlcy9zaW1wbGUt cG9seWdvbi5qcwppbmRleCBiNDI3MDE3Li5jZWIzYjYxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L3NoYXBlcy9yZXNvdXJjZXMvc2ltcGxlLXBvbHlnb24uanMKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9zaGFwZXMvcmVzb3VyY2VzL3NpbXBsZS1wb2x5Z29uLmpzCkBAIC0xMDcsNyArMTA3 LDcgQEAgZnVuY3Rpb24gcG9seWdvbkxpbmVJbnRlcmNlcHRzKHBvbHlnb24sIHksIGxpbmVIZWln aHQpIHsKIC8vIHdpdGggdGhlIHRoZSBwb2x5Z29uJ3MgYm91bmRzIG1pbmltdW0gWSB2YWx1ZSwg YW5kIGVhY2ggbGluZSBvZiBjaGFyYWN0ZXJzIGZpbGxzIHRoZSBpbnRlcmlvcgogLy8gb2YgdGhl IHBvbHlnb24uCiAKLWZ1bmN0aW9uIGdlbmVyYXRlUG9seWdvbkNvbnRlbnRTdHJpbmcocG9seWdv biwgbGluZWhlaWdodCkgeworZnVuY3Rpb24gZ2VuZXJhdGVQb2x5Z29uQ29udGVudFN0cmluZyhw b2x5Z29uLCBsaW5lSGVpZ2h0KSB7CiAgICAgdmFyIHJlc3VsdCA9ICIiOwogCiAgICAgZm9yICh2 YXIgeSA9IHBvbHlnb24ubWluWTsgeSA8IHBvbHlnb24ubWF4WTsgeSArPSBsaW5lSGVpZ2h0KSB7 Cg==