123594 2013-10-31 16:10:49 -0700 Web Inspector: Clean up a few Inspector interfaces 2013-10-31 19:03:20 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 945737 0 joepeck 2013-10-31 16:10:49 -0700 A little bit of cleanup making some methods const. Noticed while making the other recent changes. 945738 1 webkit-bug-importer 2013-10-31 16:11:08 -0700 <rdar://problem/15367279> 945740 2 215689 joepeck 2013-10-31 16:12:03 -0700 Created attachment 215689 [PATCH] Proposed Fix 945819 3 215689 commit-queue 2013-10-31 19:03:18 -0700 Comment on attachment 215689 [PATCH] Proposed Fix Clearing flags on attachment: 215689 Committed r158421: <http://trac.webkit.org/changeset/158421> 945820 4 commit-queue 2013-10-31 19:03:20 -0700 All reviewed patches have been landed. Closing bug. 215689 2013-10-31 16:12:03 -0700 2013-10-31 19:03:17 -0700 [PATCH] Proposed Fix cleanup.patch text/plain 7322 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNWRhNzA2Li41NDBiYjk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTMtMTAtMzEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDbGVhbiB1cCBhIGZldyBJbnNwZWN0b3IgaW50ZXJmYWNl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJD b3JlLmV4cC5pbjoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0LmNwcDoK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQmFzZUFnZW50Lmg6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JCYXNlQWdlbnRJbnRlcmZhY2U6Om5hbWUpOgorICAgICAgICAqIGluc3Bl Y3Rvci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNw ZWN0b3JDb25zb2xlQWdlbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnNvbGVB Z2VudDo6ZW5hYmxlZCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6cHJvZmlsZXJFbmFi bGVkKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oOgorICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcDoKKyAgICAgICAgKiBpbnNw ZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5oOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVj dG9yRGVidWdnZXJBZ2VudDo6ZW5hYmxlZCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rv clJ1bnRpbWVBZ2VudC5oOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUnVudGltZUFnZW50 OjplbmFibGVkKToKKworMjAxMy0xMC0zMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnZlcnQgc29tZSBJbnNwZWN0b3JP YmplY3QgbWVtYmVyIHZhcmlhYmxlcyB0byBIYXNoU2V0L0hhc2hNYXAKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzU3OQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhw LmluCmluZGV4IDJmYTg2MzAuLjI4ZjNiYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZXhwLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCkBAIC0yNjM2 LDcgKzI2MzYsNiBAQCBfX1pON1dlYkNvcmUxNkhUTUxJbnB1dEVsZW1lbnQyNXNlbGVjdENvbG9y SW5Db2xvckNob29zZXJFUktOU181Q29sb3JFCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKIF9fWk43 V2ViQ29yZTE1SW5zcGVjdG9yQ2xpZW50MzFkb0Rpc3BhdGNoTWVzc2FnZU9uRnJvbnRlbmRQYWdl RVBOU180UGFnZUVSS04zV1RGNlN0cmluZ0UKIF9fWk43V2ViQ29yZTE3SW5zcGVjdG9yQ291bnRl cnMxMmNvdW50ZXJWYWx1ZUVOUzBfMTFDb3VudGVyVHlwZUUKLV9fWk43V2ViQ29yZTE5SW5zcGVj dG9yQ29udHJvbGxlcjE1cHJvZmlsZXJFbmFibGVkRXYKIF9fWk43V2ViQ29yZTE5SW5zcGVjdG9y Q29udHJvbGxlcjE1Y29ubmVjdEZyb250ZW5kRVBOU18yNEluc3BlY3RvckZyb250ZW5kQ2hhbm5l bEUKIF9fWk43V2ViQ29yZTE5SW5zcGVjdG9yQ29udHJvbGxlcjE4ZGlzY29ubmVjdEZyb250ZW5k RXYKIF9fWk43V2ViQ29yZTE5SW5zcGVjdG9yQ29udHJvbGxlcjE4c2V0UHJvZmlsZXJFbmFibGVk RWIKQEAgLTI2ODIsNiArMjY4MSw3IEBAIF9fWk43V2ViQ29yZTlET01XaW5kb3c1Y2xvc2VFUE5T XzIyU2NyaXB0RXhlY3V0aW9uQ29udGV4dEUKIF9fWk43V2ViQ29yZTE5SW5zcGVjdG9yQ29udHJv bGxlcjEzZGlkQmVnaW5GcmFtZUV2CiBfX1pON1dlYkNvcmUxOUluc3BlY3RvckNvbnRyb2xsZXIx NGRpZENhbmNlbEZyYW1lRXYKIF9fWk5LN1dlYkNvcmUxOUluc3BlY3RvckNvbnRyb2xsZXIxM2Ry YXdIaWdobGlnaHRFUk5TXzE1R3JhcGhpY3NDb250ZXh0RQorX19aTks3V2ViQ29yZTE5SW5zcGVj dG9yQ29udHJvbGxlcjE1cHJvZmlsZXJFbmFibGVkRXYKIF9fWk5LN1dlYkNvcmU5RE9NV2luZG93 OGRvY3VtZW50RXYKIF9fWk43V2ViQ29yZTE0U2NoZW1lUmVnaXN0cnkyN3Nob3VsZFRyZWF0VVJM U2NoZW1lQXNMb2NhbEVSS04zV1RGNlN0cmluZ0UKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0SG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0LmNwcAppbmRleCAyNTAyNjk0Li5lZjUzM2Fh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0LmNw cApAQCAtMTY4LDcgKzE2OCw2IEBAIFNjcmlwdERlYnVnU2VydmVyJiBJbmplY3RlZFNjcmlwdEhv c3Q6OnNjcmlwdERlYnVnU2VydmVyKCkKIH0KICNlbmRpZgogCi0KIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShJTlNQRUNUT1IpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFzZUFnZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yQmFzZUFnZW50LmgKaW5kZXggNzdlOThmMC4uOTQ4M2JkNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckJhc2VBZ2VudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYXNlQWdlbnQuaApAQCAtNTIs NyArNTIsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHJlZ2lzdGVySW5EaXNwYXRjaGVy KEluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyKikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBkaXNj YXJkQWdlbnQoKSB7IH0KIAotICAgIFN0cmluZyBuYW1lKCkgeyByZXR1cm4gbV9uYW1lOyB9Cisg ICAgU3RyaW5nIG5hbWUoKSBjb25zdCB7IHJldHVybiBtX25hbWU7IH0KIAogcHJvdGVjdGVkOgog ICAgIEluc3RydW1lbnRpbmdBZ2VudHMqIG1faW5zdHJ1bWVudGluZ0FnZW50czsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2VudC5jcHAKaW5kZXgg NjdkMDI2NS4uNjY1OWFmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNvbnNvbGVBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNvbnNvbGVBZ2VudC5jcHAKQEAgLTI2LDE1ICsyNiwxNiBAQAogI2luY2x1ZGUgImNv bmZpZy5oIgogCiAjaWYgRU5BQkxFKElOU1BFQ1RPUikKKwogI2luY2x1ZGUgIkluc3BlY3RvckNv bnNvbGVBZ2VudC5oIgogCi0jaW5jbHVkZSAiSW5zdHJ1bWVudGluZ0FnZW50cy5oIgogI2luY2x1 ZGUgIkNvbnNvbGUuaCIKICNpbmNsdWRlICJDb25zb2xlTWVzc2FnZS5oIgogI2luY2x1ZGUgIkRP TVdpbmRvdy5oIgogI2luY2x1ZGUgIkluamVjdGVkU2NyaXB0SG9zdC5oIgogI2luY2x1ZGUgIklu amVjdGVkU2NyaXB0TWFuYWdlci5oIgogI2luY2x1ZGUgIkluc3BlY3RvckZyb250ZW5kLmgiCisj aW5jbHVkZSAiSW5zdHJ1bWVudGluZ0FnZW50cy5oIgogI2luY2x1ZGUgIlJlc291cmNlRXJyb3Iu aCIKICNpbmNsdWRlICJSZXNvdXJjZVJlc3BvbnNlLmgiCiAjaW5jbHVkZSAiU2NyaXB0QXJndW1l bnRzLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29u c29sZUFnZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFn ZW50LmgKaW5kZXggMmE2ZDA4NC4uMWJiM2Q4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JDb25zb2xlQWdlbnQuaApAQCAtNjIsNyArNjIsNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIGVuYWJsZShFcnJvclN0cmluZyopOwogICAgIHZpcnR1YWwgdm9p ZCBkaXNhYmxlKEVycm9yU3RyaW5nKik7CiAgICAgdmlydHVhbCB2b2lkIGNsZWFyTWVzc2FnZXMo RXJyb3JTdHJpbmcqKTsKLSAgICBib29sIGVuYWJsZWQoKSB7IHJldHVybiBtX2VuYWJsZWQ7IH0K KyAgICBib29sIGVuYWJsZWQoKSBjb25zdCB7IHJldHVybiBtX2VuYWJsZWQ7IH0KICAgICB2b2lk IHJlc2V0KCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0RnJvbnRlbmQoSW5zcGVjdG9yRnJvbnRl bmQqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250 cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVy LmNwcAppbmRleCBlZWYyZGRiLi4zYzllNmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0zNTUsNyArMzU1LDcgQEAgTm9kZSog SW5zcGVjdG9yQ29udHJvbGxlcjo6aGlnaGxpZ2h0ZWROb2RlKCkgY29uc3QKIH0KIAogI2lmIEVO QUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQotYm9vbCBJbnNwZWN0b3JDb250cm9sbGVyOjpwcm9m aWxlckVuYWJsZWQoKQorYm9vbCBJbnNwZWN0b3JDb250cm9sbGVyOjpwcm9maWxlckVuYWJsZWQo KSBjb25zdAogewogICAgIHJldHVybiBtX3Byb2ZpbGVyQWdlbnQtPmVuYWJsZWQoKTsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCmluZGV4IDhj MjY2MjIuLmQ0Mjk3ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuaApAQCAtMTEwLDcgKzExMCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGV2YWx1 YXRlRm9yVGVzdEluRnJvbnRlbmQobG9uZyBjYWxsSWQsIGNvbnN0IFN0cmluZyYgc2NyaXB0KTsK IAogI2lmIEVOQUJMRShKQVZBU0NSSVBUX0RFQlVHR0VSKQotICAgIGJvb2wgcHJvZmlsZXJFbmFi bGVkKCk7CisgICAgYm9vbCBwcm9maWxlckVuYWJsZWQoKSBjb25zdDsKICAgICB2b2lkIHNldFBy b2ZpbGVyRW5hYmxlZChib29sKTsKIAogICAgIHZvaWQgcmVzdW1lKCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKaW5kZXggYjA4 ODJlNC4uYTg2ZDYyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckRlYnVnZ2VyQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JEZWJ1Z2dlckFnZW50LmNwcApAQCAtMTAzLDExICsxMDMsNiBAQCB2b2lkIEluc3BlY3Rv ckRlYnVnZ2VyQWdlbnQ6OmRpc2FibGUoKQogICAgIG1fZW5hYmxlZCA9IGZhbHNlOwogfQogCi1i b29sIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmVuYWJsZWQoKQotewotICAgIHJldHVybiBtX2Vu YWJsZWQ7Ci19Ci0KIHZvaWQgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6Y2F1c2VzUmVjb21waWxh dGlvbihFcnJvclN0cmluZyosIGJvb2wqIHJlc3VsdCkKIHsKICAgICAqcmVzdWx0ID0gc2NyaXB0 RGVidWdTZXJ2ZXIoKS5jYXVzZXNSZWNvbXBpbGF0aW9uKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5oIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuaAppbmRleCA2N2YzNjFkLi41MjY4 ZGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdn ZXJBZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dl ckFnZW50LmgKQEAgLTE0NSw3ICsxNDUsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCByZXNldCgp OwogCiBwcml2YXRlOgotICAgIGJvb2wgZW5hYmxlZCgpOworICAgIGJvb2wgZW5hYmxlZCgpIGNv bnN0IHsgcmV0dXJuIG1fZW5hYmxlZDsgfTsKIAogICAgIFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6 OkFycmF5PFR5cGVCdWlsZGVyOjpEZWJ1Z2dlcjo6Q2FsbEZyYW1lPj4gY3VycmVudENhbGxGcmFt ZXMoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJ1 bnRpbWVBZ2VudC5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJ1bnRpbWVB Z2VudC5oCmluZGV4IDk1NjYxMmYuLmQzNWIzNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JSdW50aW1lQWdlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yUnVudGltZUFnZW50LmgKQEAgLTU3LDcgKzU3LDcgQEAgY2xhc3Mg SW5zcGVjdG9yUnVudGltZUFnZW50IDogcHVibGljIEluc3BlY3RvckJhc2VBZ2VudDxJbnNwZWN0 b3JSdW50aW1lQWdlbnQ+LAogcHVibGljOgogICAgIHZpcnR1YWwgfkluc3BlY3RvclJ1bnRpbWVB Z2VudCgpOwogCi0gICAgYm9vbCBlbmFibGVkKCkgeyByZXR1cm4gbV9lbmFibGVkOyB9CisgICAg Ym9vbCBlbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9lbmFibGVkOyB9CiAgICAgLy8gUGFydCBv ZiB0aGUgcHJvdG9jb2wuCiAgICAgdmlydHVhbCB2b2lkIGVuYWJsZShFcnJvclN0cmluZyopIHsg bV9lbmFibGVkID0gdHJ1ZTsgfQogICAgIHZpcnR1YWwgdm9pZCBkaXNhYmxlKEVycm9yU3RyaW5n KikgeyBtX2VuYWJsZWQgPSBmYWxzZTsgfQo=