123593 2013-10-31 15:33:47 -0700 [MSE] [Mac] Disclaim support for MSE in AVFoundation and QTKit engines 2013-11-04 14:47:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson glenn oldest_to_newest 945720 0 jer.noble 2013-10-31 15:33:47 -0700 [MSE] [Mac] Disclaim support for MSE in AVFoundation and QTKit engines 945721 1 215682 jer.noble 2013-10-31 15:35:42 -0700 Created attachment 215682 Patch 945913 2 215682 eric.carlson 2013-11-01 10:01:27 -0700 Comment on attachment 215682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215682&action=review If the other ports don't already do this, you should file bugs. > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:201 > +void MediaPlayerPrivateAVFoundation::load(const String&, PassRefPtr<HTMLMediaSource>) "PassRefPtr<HTMLMediaSource>" this will change soon, right :-) 946833 3 jer.noble 2013-11-04 14:47:40 -0800 Committed r158597: <http://trac.webkit.org/changeset/158597> 215682 2013-10-31 15:35:42 -0700 2013-11-01 10:01:27 -0700 Patch bug-123593-20131031153542.patch text/plain 5899 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2I2MjM3MWRlYzI3YjEw NWQ1M2U4ZWI1N2ZkMjUyYWI3NGZkODVlZi4uOTk1ODk4NDg3YWFhMjViMzA4NzU4OTJhOTA0YWNh Y2M1NzM2ODk3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTEwLTMxICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdIFtNYWNdIERpc2Ns YWltIHN1cHBvcnQgZm9yIE1TRSBpbiBBVkZvdW5kYXRpb24gYW5kIFFUS2l0IGVuZ2luZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzU5MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltbWVkaWF0ZWx5 IGZhaWwgaWYgYXNrZWQgdG8gbG9hZCBhIE1lZGlhIFNvdXJjZSBpbiBlbmdpbmVzIHdoaWNoIGRv IG5vdCBzdXBwb3J0CisgICAgICAgIHRoZW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6bG9hZCk6CisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFW Rm91bmRhdGlvbi5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9v YmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW06CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpzdXBwb3J0c1R5cGUpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtp dC5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Ojpsb2FkKToK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpzdXBwb3J0c1R5cGUp OgorCiAyMDEzLTEwLTMxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCB0eXBvIGZpeCBhZnRlciAxNTgzODYuIChidWlsZGZpeCBhZnRl ciByMTU4MzY1KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uLmNwcAppbmRleCBmYWNhMDk2ZjM4YzUzZmY2NTgwNTFjZjBjMGI4MDA3MWEx NWYxOTg2Li4xYWViYjQ5Nzc3ZWRjZDE0NTVlNGM0ZjFhMDk2ZGZmNDRlZGU2ZDRhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmNw cApAQCAtMTk3LDYgKzE5NywxNSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlv bjo6bG9hZChjb25zdCBTdHJpbmcmIHVybCkKICAgICBzZXRQcmVsb2FkKG1fcHJlbG9hZCk7CiB9 CiAKKyNpZiBFTkFCTEUoTUVESUFfU09VUkNFKQordm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZv dW5kYXRpb246OmxvYWQoY29uc3QgU3RyaW5nJiwgUGFzc1JlZlB0cjxIVE1MTWVkaWFTb3VyY2U+ KQoreworICAgIG1fbmV0d29ya1N0YXRlID0gTWVkaWFQbGF5ZXI6OkZvcm1hdEVycm9yOworICAg IG1fcGxheWVyLT5uZXR3b3JrU3RhdGVDaGFuZ2VkKCk7Cit9CisjZW5kaWYKKworCiB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6cGxheWFiaWxpdHlLbm93bigpCiB7CiAgICAg TE9HKE1lZGlhLCAiTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uOjpwbGF5YWJpbGl0eUtu b3duKCVwKSIsIHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJp dmF0ZUFWRm91bmRhdGlvbi5oCmluZGV4IDE0NzU0MDFmMTJiY2VlNjYzZDYxNDQ2Zjc2Y2YwMGFl NGFmNGY5OGYuLjdkMTliZmZhMmU5YjdkNzQ4NWJhY2RkMTc1ZGY0YWNlYzcwNTE5MDcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRp YVBsYXllclByaXZhdGVBVkZvdW5kYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9hdmZvdW5kYXRpb24vTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uLmgK QEAgLTEzMCw3ICsxMzAsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgLy8gTWVkaWFQbGF5ZXJQcml2YXRl UHJpdmF0ZUludGVyZmFjZSBvdmVycmlkZXMuCiAgICAgdmlydHVhbCB2b2lkIGxvYWQoY29uc3Qg U3RyaW5nJiB1cmwpIE9WRVJSSURFOwogI2lmIEVOQUJMRShNRURJQV9TT1VSQ0UpCi0gICAgdmly dHVhbCB2b2lkIGxvYWQoY29uc3QgU3RyaW5nJiwgUGFzc1JlZlB0cjxIVE1MTWVkaWFTb3VyY2U+ KSB7IH07CisgICAgdmlydHVhbCB2b2lkIGxvYWQoY29uc3QgU3RyaW5nJiwgUGFzc1JlZlB0cjxI VE1MTWVkaWFTb3VyY2U+KTsKICNlbmRpZgogICAgIHZpcnR1YWwgdm9pZCBjYW5jZWxMb2FkKCkg PSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQppbmRleCAzZjBiYWE5NjJhOWNkYTVlM2ZhNDZm ZTc5NTg3ODEwYmI1MjA1OTQ4Li5jM2NhY2I5Y2RlMjhjZThjYjVlNTBhNDJlZDBhNDljYjc5NTgy ZWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxh eWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KQEAgLTkwNCw2ICs5MDQsMTEgQEAgTWVkaWFQ bGF5ZXI6OlN1cHBvcnRzVHlwZSBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjpz dXBwb3J0c1R5cGUoY29uc3QKICAgICAvLyAyLiBSZXR1cm4gIm1heWJlIiBvciAicHJvYmFibHki IGFzIGFwcHJvcHJpYXRlIHBlciB0aGUgZXhpc3Rpbmcgc3BlY2lmaWNhdGlvbiBvZiBjYW5QbGF5 VHlwZSgpLgogI2VuZGlmCiAKKyNpZiBFTkFCTEUoTUVESUFfU09VUkNFKQorICAgIGlmIChwYXJh bWV0ZXJzLmlzTWVkaWFTb3VyY2UpCisgICAgICAgIHJldHVybiBNZWRpYVBsYXllcjo6SXNOb3RT dXBwb3J0ZWQ7CisjZW5kaWYKKwogICAgIGlmICghbWltZVR5cGVDYWNoZSgpLmNvbnRhaW5zKHBh cmFtZXRlcnMudHlwZSkpCiAgICAgICAgIHJldHVybiBNZWRpYVBsYXllcjo6SXNOb3RTdXBwb3J0 ZWQ7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9N ZWRpYVBsYXllclByaXZhdGVRVEtpdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0LmgKaW5kZXggNDdkYjhhZjMwMTY5YjcwZjIw ZDU4MTJiYTk5MWI2YzMxYTJiNTg0NS4uMjgyYmVhNjUxMjI1NzQwZjBmNGQzYWU3ZDQ3ODNmN2Rj ODYyODVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFj L01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0LmgKQEAgLTk1LDcgKzk1LDcgQEAg cHJpdmF0ZToKICAgICAKICAgICB2b2lkIGxvYWQoY29uc3QgU3RyaW5nJiB1cmwpOwogI2lmIEVO QUJMRShNRURJQV9TT1VSQ0UpCi0gICAgdmlydHVhbCB2b2lkIGxvYWQoY29uc3QgU3RyaW5nJiwg UGFzc1JlZlB0cjxIVE1MTWVkaWFTb3VyY2U+KSB7IH07CisgICAgdmlydHVhbCB2b2lkIGxvYWQo Y29uc3QgU3RyaW5nJiwgUGFzc1JlZlB0cjxIVE1MTWVkaWFTb3VyY2U+KTsKICNlbmRpZgogICAg IHZvaWQgY2FuY2VsTG9hZCgpOwogICAgIHZvaWQgbG9hZEludGVybmFsKGNvbnN0IFN0cmluZyYg dXJsKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9N ZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbQppbmRleCA3Yjc0ZTdkZWVkMjc5ZmY4 MTJkNjBlMzI4OTcxMjA3ZDk0NGMxMmU2Li5lOWU4NTI5NmM0MWEzODhhNjg3OTQyMjA0NGE2Mjkx NTRkZTk3ZDQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tCkBAIC02NjksNiArNjY5 LDE1IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQ6OmxvYWRJbnRlcm5hbChjb25zdCBT dHJpbmcmIHVybCkKICAgICBbbV9vYmpjT2JzZXJ2ZXIuZ2V0KCkgc2V0RGVsYXlDYWxsYmFja3M6 Tk9dOwogfQogCisjaWYgRU5BQkxFKE1FRElBX1NPVVJDRSkKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlUVRLaXQ6OmxvYWQoY29uc3QgU3RyaW5nJiwgUGFzc1JlZlB0cjxIVE1MTWVkaWFTb3VyY2U+ KQoreworICAgIG1fbmV0d29ya1N0YXRlID0gTWVkaWFQbGF5ZXI6OkZvcm1hdEVycm9yOworICAg IG1fcGxheWVyLT5uZXR3b3JrU3RhdGVDaGFuZ2VkKCk7Cit9CisjZW5kaWYKKworCiB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpwcmVwYXJlVG9QbGF5KCkKIHsKICAgICBMT0coTWVkaWEs ICJNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6cHJlcGFyZVRvUGxheSglcCkiLCB0aGlzKTsKQEAg LTE0NjYsNiArMTQ3NSwxMSBAQCBNZWRpYVBsYXllcjo6U3VwcG9ydHNUeXBlIE1lZGlhUGxheWVy UHJpdmF0ZVFUS2l0OjpzdXBwb3J0c1R5cGUoY29uc3QgTWVkaWFFbmdpbgogICAgICAgICByZXR1 cm4gTWVkaWFQbGF5ZXI6OklzTm90U3VwcG9ydGVkOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoTUVE SUFfU09VUkNFKQorICAgIGlmIChwYXJhbWV0ZXJzLmlzTWVkaWFTb3VyY2UpCisgICAgICAgIHJl dHVybiBNZWRpYVBsYXllcjo6SXNOb3RTdXBwb3J0ZWQ7CisjZW5kaWYKKwogICAgIC8vIE9ubHkg cmV0dXJuICJJc1N1cHBvcnRlZCIgaWYgdGhlcmUgaXMgbm8gY29kZWNzIHBhcmFtZXRlciBmb3Ig bm93IGFzIHRoZXJlIGlzIG5vIHdheSB0byBhc2sgUVQgaWYgaXQgc3VwcG9ydHMgYW4KICAgICAv LyBleHRlbmRlZCBNSU1FIHR5cGUgeWV0LgogCg==