123589 2013-10-31 13:31:21 -0700 Web Inspector: Breakpoints in auto-formatted JavaScript editors are not working 2013-10-31 16:10:24 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 945662 0 joepeck 2013-10-31 13:31:21 -0700 Looks like the recent change to allow editing pretty-printed resources has an unintended side effect here. 945663 1 joepeck 2013-10-31 13:32:43 -0700 Updated the title to be clearer. Breakpoints in auto-formatted JS resources are not working, because the formatterSourceMap is getting cleared. The file appears as if it is not pretty-printed, even though it is. 945664 2 webkit-bug-importer 2013-10-31 13:33:07 -0700 <rdar://problem/15365257> 945724 3 215683 joepeck 2013-10-31 15:38:01 -0700 Created attachment 215683 [PATCH] Proposed Fix 945725 4 joepeck 2013-10-31 15:40:42 -0700 STEPS TO REPRODUCE: 1. Inspect <http://bogojoker.com/shell/> 2. Select easySlider.min.js in resource sidebar => file should auto format, pretty print button should be blue, breakpoints should work past line 4. 945735 5 215683 commit-queue 2013-10-31 16:10:22 -0700 Comment on attachment 215683 [PATCH] Proposed Fix Clearing flags on attachment: 215683 Committed r158404: <http://trac.webkit.org/changeset/158404> 945736 6 commit-queue 2013-10-31 16:10:24 -0700 All reviewed patches have been landed. Closing bug. 215683 2013-10-31 15:38:01 -0700 2013-10-31 16:10:22 -0700 [PATCH] Proposed Fix auto.patch text/plain 3065 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ0OTdjZmYuLjcxNDdiNTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEzLTEwLTMxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQnJlYWtw b2ludHMgaW4gYXV0by1mb3JtYXR0ZWQgSmF2YVNjcmlwdCBlZGl0b3JzIGFyZSBub3Qgd29ya2lu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTg5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGlu dGVybmFsIHRoaXMuX2lnbm9yZUNvZGVNaXJyb3JDb250ZW50RGlkQ2hhbmdlRXZlbnQgZmxhZyB3 YXMgYmVpbmcgdXNlZAorICAgICAgICBpbiB0d28gcGxhY2VzIHRoYXQgY291bGQgYmUgbmVzdGVk LCBtZWFuaW5nIHRoZSBmbGFnIHdhcyBkZWxldGVkIHdoaWxlIGl0CisgICAgICAgIHdhcyBzdGls bCBleHBlY3RlZCB0byBiZSBzZXQuIENoYW5nZSBpdCBpbnN0ZWFkIHRvIGEgY291bnRlciwgdG8g aGFuZGxlIG5lc3RpbmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1RleHRFZGl0b3IuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvcik6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGV4dEVkaXRvci5wcm90b3R5cGUuc2V0IHN0cmluZyk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGV4dEVkaXRvci5wcm90b3R5cGUuc2V0IGZvcm1hdHRlZCk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUuX2NvbnRlbnRDaGFuZ2VkKToKKworMjAxMy0xMC0z MSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IFJlbW92ZSBzdGFsZSBvcHRpb25hbCBuYXRpdmUgbWVtb3J5IGluc3RydW1lbnRh dGlvbiBwcm90b2NvbCBwYXJhbXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMzU1MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9UZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVGV4dEVkaXRvci5qcwppbmRleCA0ZGE2MmNlLi43NDZiZTY5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXh0RWRpdG9yLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1RleHRFZGl0b3IuanMKQEAgLTYx LDYgKzYxLDcgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IgPSBmdW5jdGlvbihlbGVtZW50LCBt aW1lVHlwZSwgZGVsZWdhdGUpCiAgICAgdGhpcy5fc2VhcmNoUXVlcnkgPSBudWxsOwogICAgIHRo aXMuX3NlYXJjaFJlc3VsdHMgPSBbXTsKICAgICB0aGlzLl9jdXJyZW50U2VhcmNoUmVzdWx0SW5k ZXggPSAtMTsKKyAgICB0aGlzLl9pZ25vcmVDb2RlTWlycm9yQ29udGVudERpZENoYW5nZUV2ZW50 ID0gMDsKIAogICAgIHRoaXMuX2Zvcm1hdHRlZCA9IGZhbHNlOwogICAgIHRoaXMuX2Zvcm1hdHRl clNvdXJjZU1hcCA9IG51bGw7CkBAIC0xMzQsOSArMTM1LDEwIEBAIFdlYkluc3BlY3Rvci5UZXh0 RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuX3JldmVhbFBlbmRpbmdQb3Np dGlvbklmUG9zc2libGUoKTsKICAgICAgICAgfQogCi0gICAgICAgIHRoaXMuX2lnbm9yZUNvZGVN aXJyb3JDb250ZW50RGlkQ2hhbmdlRXZlbnQgPSB0cnVlOworICAgICAgICB0aGlzLl9pZ25vcmVD b2RlTWlycm9yQ29udGVudERpZENoYW5nZUV2ZW50Kys7CiAgICAgICAgIHRoaXMuX2NvZGVNaXJy b3Iub3BlcmF0aW9uKHVwZGF0ZS5iaW5kKHRoaXMpKTsKLSAgICAgICAgZGVsZXRlIHRoaXMuX2ln bm9yZUNvZGVNaXJyb3JDb250ZW50RGlkQ2hhbmdlRXZlbnQ7CisgICAgICAgIHRoaXMuX2lnbm9y ZUNvZGVNaXJyb3JDb250ZW50RGlkQ2hhbmdlRXZlbnQtLTsKKyAgICAgICAgY29uc29sZS5hc3Nl cnQodGhpcy5faWdub3JlQ29kZU1pcnJvckNvbnRlbnREaWRDaGFuZ2VFdmVudCA+PSAwKTsKICAg ICB9LAogCiAgICAgZ2V0IHJlYWRPbmx5KCkKQEAgLTE2Myw5ICsxNjUsMTAgQEAgV2ViSW5zcGVj dG9yLlRleHRFZGl0b3IucHJvdG90eXBlID0gewogICAgICAgICBpZiAoZm9ybWF0dGVkICYmICF0 aGlzLmNhbkJlRm9ybWF0dGVkKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdGhp cy5faWdub3JlQ29kZU1pcnJvckNvbnRlbnREaWRDaGFuZ2VFdmVudCA9IHRydWU7CisgICAgICAg IHRoaXMuX2lnbm9yZUNvZGVNaXJyb3JDb250ZW50RGlkQ2hhbmdlRXZlbnQrKzsKICAgICAgICAg dGhpcy5fcHJldHR5UHJpbnQoZm9ybWF0dGVkKTsKLSAgICAgICAgZGVsZXRlIHRoaXMuX2lnbm9y ZUNvZGVNaXJyb3JDb250ZW50RGlkQ2hhbmdlRXZlbnQ7CisgICAgICAgIHRoaXMuX2lnbm9yZUNv ZGVNaXJyb3JDb250ZW50RGlkQ2hhbmdlRXZlbnQtLTsKKyAgICAgICAgY29uc29sZS5hc3NlcnQo dGhpcy5faWdub3JlQ29kZU1pcnJvckNvbnRlbnREaWRDaGFuZ2VFdmVudCA+PSAwKTsKIAogICAg ICAgICB0aGlzLl9mb3JtYXR0ZWQgPSBmb3JtYXR0ZWQ7CiAKQEAgLTU5Miw3ICs1OTUsNyBAQCBX ZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUgPSB7CiAKICAgICBfY29udGVudENoYW5n ZWQ6IGZ1bmN0aW9uKGNvZGVNaXJyb3IsIGNoYW5nZSkKICAgICB7Ci0gICAgICAgIGlmICh0aGlz Ll9pZ25vcmVDb2RlTWlycm9yQ29udGVudERpZENoYW5nZUV2ZW50KQorICAgICAgICBpZiAodGhp cy5faWdub3JlQ29kZU1pcnJvckNvbnRlbnREaWRDaGFuZ2VFdmVudCA+IDApCiAgICAgICAgICAg ICByZXR1cm47CiAKICAgICAgICAgaWYgKHRoaXMuX2Zvcm1hdHRlZCkgewo=