123563 2013-10-31 02:02:06 -0700 Remove #include from test input of the *Messages.in processing scripts 2013-11-11 15:27:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gbalogh.u-szeged webkit-unassigned andersca benjamin commit-queue darin kling ossy oldest_to_newest 945461 0 gbalogh.u-szeged 2013-10-31 02:02:06 -0700 There is some #include line left in the *.in files which could be safely removed. 945463 1 215633 gbalogh.u-szeged 2013-10-31 02:07:58 -0700 Created attachment 215633 patch 945511 2 andersca 2013-10-31 07:23:33 -0700 Won't this break the unit test? 945628 3 gbalogh.u-szeged 2013-10-31 12:14:27 -0700 No, the parser.py do not process #include lines only #if and #endif lines. (In reply to comment #2) > Won't this break the unit test? 946591 4 ossy 2013-11-04 02:36:53 -0800 The title of the bug is misleading, because there aren't any includes in *.messages.in files. The only useless include is in the example input in messages_unittest.py. It can be safely removed, because parser.py doesn't process includes at all, as you mentioned. The patch looks good to me, but please fix the misleading title. 949288 5 216571 gbalogh.u-szeged 2013-11-11 07:18:59 -0800 Created attachment 216571 patch Only the patch description changed. 949289 6 ossy 2013-11-11 07:20:48 -0800 LGTM, but it needs a WK2 owner review. 949468 7 216571 commit-queue 2013-11-11 15:27:16 -0800 Comment on attachment 216571 patch Clearing flags on attachment: 216571 Committed r159075: <http://trac.webkit.org/changeset/159075> 949469 8 commit-queue 2013-11-11 15:27:18 -0800 All reviewed patches have been landed. Closing bug. 215633 2013-10-31 02:07:58 -0700 2013-11-11 07:18:59 -0800 patch f2448.diff text/plain 1177 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MDQ2MWE4Li41Njk1NmI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMTAtMzEgIEdlcmdvIEJhbG9naCAgPGdlcnl4eXpAaW5mLnUtc3plZ2VkLmh1Pgor CisgICAgICAgIFRoZXJlIGlzIHNvbWUgI2luY2x1ZGUgbGluZSBsZWZ0IGluIHRoZSAqLmluIGZp bGVzIHdoaWNoIGNvdWxkIGJlIHNhZmVseSByZW1vdmVkLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNfdW5p dHRlc3QucHk6CisKIDIwMTMtMTAtMzAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29t PgogCiAgICAgICAgIElEQiBEYXRhYmFzZSB2ZXJzaW9ucyBhcmUgdWludDY0X3QsIG5vdCBpbnQ2 NF90CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNf dW5pdHRlc3QucHkgYi9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRzL3dlYmtpdDIvbWVzc2FnZXNfdW5p dHRlc3QucHkKaW5kZXggMzcyYmM1OC4uMGJhYzdjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvU2NyaXB0cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5CisrKyBiL1NvdXJjZS9XZWJL aXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191bml0dGVzdC5weQpAQCAtNDgsOCArNDgsNiBA QCBfbWVzc2FnZXNfZmlsZV9jb250ZW50cyA9ICIiIiMgQ29weXJpZ2h0IChDKSAyMDEwIEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZAogIyBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElHRU5D RSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLgogCi0jaW5jbHVkZSAiY29uZmlnLmgiCi0KICNpZiBFTkFCTEUoV0VCS0lUMikKIAog bWVzc2FnZXMgLT4gV2ViUGFnZSBMZWdhY3lSZWNlaXZlciB7Cg== 216571 2013-11-11 07:18:59 -0800 2013-11-11 15:27:15 -0800 patch f2448.diff text/plain 1167 gbalogh.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MDQ2MWE4Li41Njk1NmI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTMtMTAtMzEgIEdlcmdvIEJhbG9naCAgPGdlcnl4eXpAaW5mLnUtc3plZ2VkLmh1Pgor CisgICAgICAgIFJlbW92ZSAjaW5jbHVkZSBmcm9tIHRlc3QgaW5wdXQgb2YgdGhlICpNZXNzYWdl cy5pbiBwcm9jZXNzaW5nIHNjcmlwdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjM1NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191bml0dGVzdC5weToK KwogMjAxMy0xMC0zMCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAg ICAgSURCIERhdGFiYXNlIHZlcnNpb25zIGFyZSB1aW50NjRfdCwgbm90IGludDY0X3QKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191bml0dGVzdC5w eSBiL1NvdXJjZS9XZWJLaXQyL1NjcmlwdHMvd2Via2l0Mi9tZXNzYWdlc191bml0dGVzdC5weQpp bmRleCAzNzJiYzU4Li4wYmFjN2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TY3JpcHRz L3dlYmtpdDIvbWVzc2FnZXNfdW5pdHRlc3QucHkKKysrIGIvU291cmNlL1dlYktpdDIvU2NyaXB0 cy93ZWJraXQyL21lc3NhZ2VzX3VuaXR0ZXN0LnB5CkBAIC00OCw4ICs0OCw2IEBAIF9tZXNzYWdl c19maWxlX2NvbnRlbnRzID0gIiIiIyBDb3B5cmlnaHQgKEMpIDIwMTAgQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkCiAjIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVS V0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCiAjIE9GIFRISVMgU09GVFdB UkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAK LSNpbmNsdWRlICJjb25maWcuaCIKLQogI2lmIEVOQUJMRShXRUJLSVQyKQogCiBtZXNzYWdlcyAt PiBXZWJQYWdlIExlZ2FjeVJlY2VpdmVyIHsK