123562 2013-10-31 01:42:54 -0700 REGRESSION(r158348): Breaks Debug build 2013-10-31 12:15:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis webkit-unassigned alecflett beidson commit-queue jsbell oldest_to_newest 945452 0 naginenis 2013-10-31 01:42:54 -0700 Compilation fails in debug due to 'comparison of unsigned expression >= 0 is always true'. WebKit/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp: In member function ‘virtual bool WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion(WebCore::IDBBackingStoreInterface::Transaction&, int64_t, uint64_t)’: WebKit/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:599:25: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] The following assert is causing the failure. > http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp#L599 ASSERT_WITH_MESSAGE(version >= 0, "version was %llu", static_cast<unsigned long long>(version)); the assert can probably just be dropped, since the database versions are uint64_t now. 945459 1 215632 naginenis 2013-10-31 01:55:38 -0700 Created attachment 215632 Patch 945631 2 215632 commit-queue 2013-10-31 12:15:57 -0700 Comment on attachment 215632 Patch Clearing flags on attachment: 215632 Committed r158383: <http://trac.webkit.org/changeset/158383> 945632 3 commit-queue 2013-10-31 12:15:59 -0700 All reviewed patches have been landed. Closing bug. 215632 2013-10-31 01:55:38 -0700 2013-10-31 12:15:57 -0700 Patch 123562.patch text/plain 1576 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MWU4MWVhLi40M2RjNjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMTAtMzEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTU4MzQ4KTogQnJlYWtzIERlYnVnIGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM1 NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmUgYW4gdW5uZWNlc3NhcnkgY2hlY2sgdGhhdCBjYXVzZSBjb21waWxhdGlvbiBmYWlsdXJlLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIGp1c3QgZml4ZXMgdGhlIGJ1aWxkIGZh aWx1cmUuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9sZXZlbGRiL0lEQkJhY2tpbmdT dG9yZUxldmVsREIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCQmFja2luZ1N0b3JlTGV2ZWxE Qjo6dXBkYXRlSURCRGF0YWJhc2VWZXJzaW9uKToKKwogMjAxMy0xMC0zMSAgUnl1YW4gQ2hvaSAg PHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bR0xFU10gT3BlbkdMIHNo b3VsZCBiZSBvcHRpb25hbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRl eGVkZGIvbGV2ZWxkYi9JREJCYWNraW5nU3RvcmVMZXZlbERCLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvaW5kZXhlZGRiL2xldmVsZGIvSURCQmFja2luZ1N0b3JlTGV2ZWxEQi5jcHAKaW5k ZXggZTVhMzI1Ni4uYWE2MDI0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9p bmRleGVkZGIvbGV2ZWxkYi9JREJCYWNraW5nU3RvcmVMZXZlbERCLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9sZXZlbGRiL0lEQkJhY2tpbmdTdG9yZUxldmVsREIu Y3BwCkBAIC01OTYsNyArNTk2LDYgQEAgYm9vbCBJREJCYWNraW5nU3RvcmVMZXZlbERCOjp1cGRh dGVJREJEYXRhYmFzZVZlcnNpb24oSURCQmFja2luZ1N0b3JlSW50ZXJmYWNlOjoKIHsKICAgICBp ZiAodmVyc2lvbiA9PSBJREJEYXRhYmFzZU1ldGFkYXRhOjpOb0ludFZlcnNpb24pCiAgICAgICAg IHZlcnNpb24gPSBJREJEYXRhYmFzZU1ldGFkYXRhOjpEZWZhdWx0SW50VmVyc2lvbjsKLSAgICBB U1NFUlRfV0lUSF9NRVNTQUdFKHZlcnNpb24gPj0gMCwgInZlcnNpb24gd2FzICVsbHUiLCBzdGF0 aWNfY2FzdDx1bnNpZ25lZCBsb25nIGxvbmc+KHZlcnNpb24pKTsKICAgICBwdXRWYXJJbnQoVHJh bnNhY3Rpb246OmxldmVsREJUcmFuc2FjdGlvbkZyb20odHJhbnNhY3Rpb24pLCBEYXRhYmFzZU1l dGFEYXRhS2V5OjplbmNvZGUocm93SWQsIERhdGFiYXNlTWV0YURhdGFLZXk6OlVzZXJJbnRWZXJz aW9uKSwgdmVyc2lvbik7CiAgICAgcmV0dXJuIHRydWU7CiB9Cg==