123557 2013-10-30 22:31:23 -0700 WebPageCreationParameters should be consistent in Window.open 2013-10-31 10:46:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned oldest_to_newest 945388 0 barraclough 2013-10-30 22:31:23 -0700 When Window.open in called in WebKit2 the WebProcess sends a synchronous request to open a page (WebPageProxy::createNewPage). The UIProcess creates a WebpageProxy, and responds with instructions to the WebProcess to create the WebPage. The initial creation state of the WebPage is communicated to the WebProcess via two routes (firstly an asynchronous WebProcess::CreateWebPage message, and secondly in the synchronous response from WebPageProxy::createNewPage). Unfortunately these responses are inconsistent with each other. The creationParameters() for the page are calculated twice, and since the WKView will be added to a window between the async message being sent and the synchronous reply being returned the visibility state of the page can change. To fix the inconsistency we can set the creation parameters at the point that the WebPageProxy is instantiated. This will result in a functional change that is web visible, since the page will initially be opened in a hidden/blurred state, and may later become visible/focussed. This change is consistent with the direction we want to evolve in. Whilst we will still probably require a synchronous message from the WebProcess to the UIProcess on Window.open, we'll probably make this return much earlier – having just created the WebPageProxy, but avoiding blocking the WebProcess over the client delegate callback that opens the new window. This fix results in a layout test result change, due to the change in behavior (page is created blurred, and becomes focussed, resulting in a focus event being fired – rather than the window opening directly into a focussed state). This is reported as a progression (test is broken in WebKit1, fixed in WebKit2 after this change). In reality the test is actually slightly broken in DRT/test-runner – the test runs differently than in browser, since there is is no visible main window. In-browser this patch results in no change in behavior on dom/Window/mozilla-focus-blur.html (the affected test). 945397 1 215619 barraclough 2013-10-30 23:01:26 -0700 Created attachment 215619 Fix 945579 2 215619 sam 2013-10-31 10:36:58 -0700 Comment on attachment 215619 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=215619&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3838 > + WebPageCreationParameters& parameters = m_creationParameters; You should not do this and instead just use m_creationParameters. 945583 3 barraclough 2013-10-31 10:46:58 -0700 Fixed in r158369 215619 2013-10-30 23:01:26 -0700 2013-10-31 10:36:58 -0700 Fix 123557.patch text/plain 10360 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODM0NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ3IEBACisyMDEzLTEwLTMwICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJQYWdlQ3Jl YXRpb25QYXJhbWV0ZXJzIHNob3VsZCBiZSBjb25zaXN0ZW50IGluIFdpbmRvdy5vcGVuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM1NTcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIFdpbmRvdy5v cGVuIGluIGNhbGxlZCBpbiBXZWJLaXQyIHRoZSBXZWJQcm9jZXNzIHNlbmRzIGEgc3luY2hyb25v dXMgcmVxdWVzdCB0byBvcGVuCisgICAgICAgIGEgcGFnZSAoV2ViUGFnZVByb3h5OjpjcmVhdGVO ZXdQYWdlKS4gVGhlIFVJUHJvY2VzcyBjcmVhdGVzIGEgV2VicGFnZVByb3h5LCBhbmQgcmVzcG9u ZHMKKyAgICAgICAgd2l0aCBpbnN0cnVjdGlvbnMgdG8gdGhlIFdlYlByb2Nlc3MgdG8gY3JlYXRl IHRoZSBXZWJQYWdlLiBUaGUgaW5pdGlhbCBjcmVhdGlvbiBzdGF0ZSBvZgorICAgICAgICB0aGUg V2ViUGFnZSBpcyBjb21tdW5pY2F0ZWQgdG8gdGhlIFdlYlByb2Nlc3MgdmlhIHR3byByb3V0ZXMg KGZpcnN0bHkgYW4gYXN5bmNocm9ub3VzCisgICAgICAgIFdlYlByb2Nlc3M6OkNyZWF0ZVdlYlBh Z2UgbWVzc2FnZSwgYW5kIHNlY29uZGx5IGluIHRoZSBzeW5jaHJvbm91cyByZXNwb25zZSBmcm9t CisgICAgICAgIFdlYlBhZ2VQcm94eTo6Y3JlYXRlTmV3UGFnZSkuIFVuZm9ydHVuYXRlbHkgdGhl c2UgcmVzcG9uc2VzIGFyZSBpbmNvbnNpc3RlbnQgd2l0aCBlYWNoCisgICAgICAgIG90aGVyLiBU aGUgY3JlYXRpb25QYXJhbWV0ZXJzKCkgZm9yIHRoZSBwYWdlIGFyZSBjYWxjdWxhdGVkIHR3aWNl LCBhbmQgc2luY2UgdGhlIFdLVmlldworICAgICAgICB3aWxsIGJlIGFkZGVkIHRvIGEgd2luZG93 IGJldHdlZW4gdGhlIGFzeW5jIG1lc3NhZ2UgYmVpbmcgc2VudCBhbmQgdGhlIHN5bmNocm9ub3Vz IHJlcGx5CisgICAgICAgIGJlaW5nIHJldHVybmVkIHRoZSB2aXNpYmlsaXR5IHN0YXRlIG9mIHRo ZSBwYWdlIGNhbiBjaGFuZ2UuCisKKyAgICAgICAgVG8gZml4IHRoZSBpbmNvbnNpc3RlbmN5IHdl IGNhbiBzZXQgdGhlIGNyZWF0aW9uIHBhcmFtZXRlcnMgYXQgdGhlIHBvaW50IHRoYXQgdGhlCisg ICAgICAgIFdlYlBhZ2VQcm94eSBpcyBpbnN0YW50aWF0ZWQuIFRoaXMgd2lsbCByZXN1bHQgaW4g YSBmdW5jdGlvbmFsIGNoYW5nZSB0aGF0IGlzIHdlYgorICAgICAgICB2aXNpYmxlLCBzaW5jZSB0 aGUgcGFnZSB3aWxsIGluaXRpYWxseSBiZSBvcGVuZWQgaW4gYSBoaWRkZW4vYmx1cnJlZCBzdGF0 ZSwgYW5kIG1heQorICAgICAgICBsYXRlciBiZWNvbWUgdmlzaWJsZS9mb2N1c3NlZC4gVGhpcyBj aGFuZ2UgaXMgY29uc2lzdGVudCB3aXRoIHRoZSBkaXJlY3Rpb24gd2Ugd2FudCB0bworICAgICAg ICBldm9sdmUgaW4uIFdoaWxzdCB3ZSB3aWxsIHN0aWxsIHByb2JhYmx5IHJlcXVpcmUgYSBzeW5j aHJvbm91cyBtZXNzYWdlIGZyb20gdGhlCisgICAgICAgIFdlYlByb2Nlc3MgdG8gdGhlIFVJUHJv Y2VzcyBvbiBXaW5kb3cub3Blbiwgd2UnbGwgcHJvYmFibHkgbWFrZSB0aGlzIHJldHVybiBtdWNo IGVhcmxpZXIKKyAgICAgICAg4oCTIGhhdmluZyBqdXN0IGNyZWF0ZWQgdGhlIFdlYlBhZ2VQcm94 eSwgYnV0IGF2b2lkaW5nIGJsb2NraW5nIHRoZSBXZWJQcm9jZXNzIG92ZXIgdGhlCisgICAgICAg IGNsaWVudCBkZWxlZ2F0ZSBjYWxsYmFjayB0aGF0IG9wZW5zIHRoZSBuZXcgd2luZG93LgorCisg ICAgICAgIFRoaXMgZml4IHJlc3VsdHMgaW4gYSBsYXlvdXQgdGVzdCByZXN1bHQgY2hhbmdlLCBk dWUgdG8gdGhlIGNoYW5nZSBpbiBiZWhhdmlvciAocGFnZSBpcworICAgICAgICBjcmVhdGVkIGJs dXJyZWQsIGFuZCBiZWNvbWVzIGZvY3Vzc2VkLCByZXN1bHRpbmcgaW4gYSBmb2N1cyBldmVudCBi ZWluZyBmaXJlZCDigJMgcmF0aGVyCisgICAgICAgIHRoYW4gdGhlIHdpbmRvdyBvcGVuaW5nIGRp cmVjdGx5IGludG8gYSBmb2N1c3NlZCBzdGF0ZSkuIFRoaXMgaXMgcmVwb3J0ZWQgYXMgYQorICAg ICAgICBwcm9ncmVzc2lvbiAodGVzdCBpcyBicm9rZW4gaW4gV2ViS2l0MSwgZml4ZWQgaW4gV2Vi S2l0MiBhZnRlciB0aGlzIGNoYW5nZSkuIEluIHJlYWxpdHkKKyAgICAgICAgdGhlIHRlc3QgaXMg YWN0dWFsbHkgc2xpZ2h0bHkgYnJva2VuIGluIERSVC90ZXN0LXJ1bm5lciDigJMgdGhlIHRlc3Qg cnVucyBkaWZmZXJlbnRseSB0aGFuCisgICAgICAgIGluIGJyb3dzZXIsIHNpbmNlIHRoZXJlIGlz IGlzIG5vIHZpc2libGUgbWFpbiB3aW5kb3cuIEluLWJyb3dzZXIgdGhpcyBwYXRjaCByZXN1bHRz IGluCisgICAgICAgIG5vIGNoYW5nZSBpbiBiZWhhdmlvciBvbiBkb20vV2luZG93L21vemlsbGEt Zm9jdXMtYmx1ci5odG1sICh0aGUgYWZmZWN0ZWQgdGVzdCkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojppbml0 aWFsaXplV2ViUGFnZSk6CisgICAgICAgICAgICAtIGNhbGwgaW5pdGlhbGl6ZUNyZWF0aW9uUGFy YW1ldGVycworICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmluaXRpYWxpemVDcmVhdGlv blBhcmFtZXRlcnMpOgorICAgICAgICAgICAgLSBjYWxjdWxhdGUgbV9jcmVhdGlvblBhcmFtZXRl cnMKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2VQcm94eTo6Y3JlYXRpb25QYXJhbWV0ZXJzKToKKyAgICAgICAgICAgIC0gQWRkZWQg bV9jcmVhdGlvblBhcmFtZXRlcnMsIGluaXRpYWxpemVDcmVhdGlvblBhcmFtZXRlcnMsCisgICAg ICAgICAgICAgIGNyZWF0aW9uUGFyYW1ldGVycyByZXR1cm5zIG1fY3JlYXRpb25QYXJhbWV0ZXJz CisKIDIwMTMtMTAtMzAgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXhlZCBhIHBvdGVudGlhbCByYWNlIGNvbmRpdGlvbiBhcm91bmQgdGhlIGluaXRpYWxpenRp b24gb2YgV0tPYmplY3TigJlzIHRhcmdldC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAxNTgyMDkpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIyLDcgKzUyMiw4 IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojppbml0aWFsaXplV2ViUGFnZSgpCiAgICAgICAgIGluc3Bl Y3RvcigpLT5lbmFibGVSZW1vdGVJbnNwZWN0aW9uKCk7CiAjZW5kaWYKIAotICAgIG1fcHJvY2Vz cy0+c2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzczo6Q3JlYXRlV2ViUGFnZShtX3BhZ2VJRCwgY3Jl YXRpb25QYXJhbWV0ZXJzKCkpLCAwKTsKKyAgICBpbml0aWFsaXplQ3JlYXRpb25QYXJhbWV0ZXJz KCk7CisgICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpXZWJQcm9jZXNzOjpDcmVhdGVXZWJQ YWdlKG1fcGFnZUlELCBtX2NyZWF0aW9uUGFyYW1ldGVycyksIDApOwogCiAjaWYgRU5BQkxFKFBB R0VfVklTSUJJTElUWV9BUEkpCiAgICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdl OjpTZXRWaXNpYmlsaXR5U3RhdGUobV92aXNpYmlsaXR5U3RhdGUsIC8qIGlzSW5pdGlhbFN0YXRl ICovIHRydWUpLCBtX3BhZ2VJRCk7CkBAIC0zODMyLDkgKzM4MzMsOSBAQCB2b2lkIFdlYlBhZ2VQ cm94eTo6cmVzZXRTdGF0ZUFmdGVyUHJvY2VzCiAjZW5kaWYKIH0KIAotV2ViUGFnZUNyZWF0aW9u UGFyYW1ldGVycyBXZWJQYWdlUHJveHk6OmNyZWF0aW9uUGFyYW1ldGVycygpIGNvbnN0Cit2b2lk IFdlYlBhZ2VQcm94eTo6aW5pdGlhbGl6ZUNyZWF0aW9uUGFyYW1ldGVycygpCiB7Ci0gICAgV2Vi UGFnZUNyZWF0aW9uUGFyYW1ldGVycyBwYXJhbWV0ZXJzOworICAgIFdlYlBhZ2VDcmVhdGlvblBh cmFtZXRlcnMmIHBhcmFtZXRlcnMgPSBtX2NyZWF0aW9uUGFyYW1ldGVyczsKIAogICAgIHBhcmFt ZXRlcnMudmlld1NpemUgPSBtX3BhZ2VDbGllbnQtPnZpZXdTaXplKCk7CiAgICAgcGFyYW1ldGVy cy5pc0FjdGl2ZSA9IG1fcGFnZUNsaWVudC0+aXNWaWV3V2luZG93QWN0aXZlKCk7CkBAIC0zODcx LDggKzM4NzIsNiBAQCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzIFdlYlBhZ2VQcm94eTo6CiAg ICAgcGFyYW1ldGVycy5sYXllckhvc3RpbmdNb2RlID0gbV9sYXllckhvc3RpbmdNb2RlOwogICAg IHBhcmFtZXRlcnMuY29sb3JTcGFjZSA9IG1fcGFnZUNsaWVudC0+Y29sb3JTcGFjZSgpOwogI2Vu ZGlmCi0KLSAgICByZXR1cm4gcGFyYW1ldGVyczsKIH0KIAogI2lmIFVTRShBQ0NFTEVSQVRFRF9D T01QT1NJVElORykKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgJ KHJldmlzaW9uIDE1ODIwOSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuaAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQAogI2luY2x1ZGUgIldlYkhpdFRl c3RSZXN1bHQuaCIKICNpbmNsdWRlICJXZWJMb2FkZXJDbGllbnQuaCIKICNpbmNsdWRlICJXZWJQ YWdlQ29udGV4dE1lbnVDbGllbnQuaCIKKyNpbmNsdWRlICJXZWJQYWdlQ3JlYXRpb25QYXJhbWV0 ZXJzLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9BbHRlcm5hdGl2ZVRleHRDbGllbnQuaD4gLy8gRklY TUU6IE5lZWRlZCBieSBXZWJQYWdlUHJveHlNZXNzYWdlcy5oIGZvciBESUNUQVRJT05fQUxURVJO QVRJVkVTLgogI2luY2x1ZGUgIldlYlBhZ2VQcm94eU1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiV2Vi UG9saWN5Q2xpZW50LmgiCkBAIC0xNDgsNyArMTQ5LDYgQEAgc3RydWN0IERpY3Rpb25hcnlQb3B1 cEluZm87CiBzdHJ1Y3QgRWRpdG9yU3RhdGU7CiBzdHJ1Y3QgUGxhdGZvcm1Qb3B1cE1lbnVEYXRh Owogc3RydWN0IFByaW50SW5mbzsKLXN0cnVjdCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzOwog c3RydWN0IFdlYlBvcHVwSXRlbTsKIAogI2lmIEVOQUJMRShWSUJSQVRJT04pCkBAIC02MjgsNyAr NjI4LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIGRpZENob29zZUZpbGVzRm9yT3BlblBhbmVsKGNv bnN0IFZlY3RvcjxTdHJpbmc+Jik7CiAgICAgdm9pZCBkaWRDYW5jZWxGb3JPcGVuUGFuZWwoKTsK IAotICAgIFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgY3JlYXRpb25QYXJhbWV0ZXJzKCkgY29u c3Q7CisgICAgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyBjcmVhdGlvblBhcmFtZXRlcnMoKSBj b25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIG1fY3JlYXRpb25QYXJhbWV0ZXJzOworICAgIH0K IAogI2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykKICAgICB2b2lkIGZpbmRab29tYWJsZUFy ZWFGb3JQb2ludChjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYsIGNvbnN0IFdlYkNvcmU6OkludFNp emUmKTsKQEAgLTc1MSw2ICs3NTQsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIFdlYlBhZ2VQ cm94eShQYWdlQ2xpZW50KiwgUGFzc1JlZlB0cjxXZWJQcm9jZXNzUHJveHk+LCBXZWJQYWdlR3Jv dXAqLCB1aW50NjRfdCBwYWdlSUQpOwogICAgIHZvaWQgcGxhdGZvcm1Jbml0aWFsaXplKCk7Cisg ICAgdm9pZCBpbml0aWFsaXplQ3JlYXRpb25QYXJhbWV0ZXJzKCk7CiAKICAgICB2b2lkIHJlc2V0 U3RhdGUoKTsKICAgICB2b2lkIHJlc2V0U3RhdGVBZnRlclByb2Nlc3NFeGl0ZWQoKTsKQEAgLTEy NDYsNiArMTI1MCw4IEBAIHByaXZhdGU6CiAjZW5kaWYKICAgICAgICAgCiAgICAgV2ViQ29yZTo6 U2Nyb2xsUGlubmluZ0JlaGF2aW9yIG1fc2Nyb2xsUGlubmluZ0JlaGF2aW9yOworCisgICAgV2Vi UGFnZUNyZWF0aW9uUGFyYW1ldGVycyBtX2NyZWF0aW9uUGFyYW1ldGVyczsKIH07CiAKIH0gLy8g bmFtZXNwYWNlIFdlYktpdApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4MzQ2KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNDEgQEAKKzIwMTMtMTAtMzAg IEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFdl YlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMgc2hvdWxkIGJlIGNvbnNpc3RlbnQgaW4gV2luZG93Lm9w ZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzU1 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4g V2luZG93Lm9wZW4gaW4gY2FsbGVkIGluIFdlYktpdDIgdGhlIFdlYlByb2Nlc3Mgc2VuZHMgYSBz eW5jaHJvbm91cyByZXF1ZXN0IHRvIG9wZW4KKyAgICAgICAgYSBwYWdlIChXZWJQYWdlUHJveHk6 OmNyZWF0ZU5ld1BhZ2UpLiBUaGUgVUlQcm9jZXNzIGNyZWF0ZXMgYSBXZWJwYWdlUHJveHksIGFu ZCByZXNwb25kcworICAgICAgICB3aXRoIGluc3RydWN0aW9ucyB0byB0aGUgV2ViUHJvY2VzcyB0 byBjcmVhdGUgdGhlIFdlYlBhZ2UuIFRoZSBpbml0aWFsIGNyZWF0aW9uIHN0YXRlIG9mCisgICAg ICAgIHRoZSBXZWJQYWdlIGlzIGNvbW11bmljYXRlZCB0byB0aGUgV2ViUHJvY2VzcyB2aWEgdHdv IHJvdXRlcyAoZmlyc3RseSBhbiBhc3luY2hyb25vdXMKKyAgICAgICAgV2ViUHJvY2Vzczo6Q3Jl YXRlV2ViUGFnZSBtZXNzYWdlLCBhbmQgc2Vjb25kbHkgaW4gdGhlIHN5bmNocm9ub3VzIHJlc3Bv bnNlIGZyb20KKyAgICAgICAgV2ViUGFnZVByb3h5OjpjcmVhdGVOZXdQYWdlKS4gVW5mb3J0dW5h dGVseSB0aGVzZSByZXNwb25zZXMgYXJlIGluY29uc2lzdGVudCB3aXRoIGVhY2gKKyAgICAgICAg b3RoZXIuIFRoZSBjcmVhdGlvblBhcmFtZXRlcnMoKSBmb3IgdGhlIHBhZ2UgYXJlIGNhbGN1bGF0 ZWQgdHdpY2UsIGFuZCBzaW5jZSB0aGUgV0tWaWV3CisgICAgICAgIHdpbGwgYmUgYWRkZWQgdG8g YSB3aW5kb3cgYmV0d2VlbiB0aGUgYXN5bmMgbWVzc2FnZSBiZWluZyBzZW50IGFuZCB0aGUgc3lu Y2hyb25vdXMgcmVwbHkKKyAgICAgICAgYmVpbmcgcmV0dXJuZWQgdGhlIHZpc2liaWxpdHkgc3Rh dGUgb2YgdGhlIHBhZ2UgY2FuIGNoYW5nZS4KKworICAgICAgICBUbyBmaXggdGhlIGluY29uc2lz dGVuY3kgd2UgY2FuIHNldCB0aGUgY3JlYXRpb24gcGFyYW1ldGVycyBhdCB0aGUgcG9pbnQgdGhh dCB0aGUKKyAgICAgICAgV2ViUGFnZVByb3h5IGlzIGluc3RhbnRpYXRlZC4gVGhpcyB3aWxsIHJl c3VsdCBpbiBhIGZ1bmN0aW9uYWwgY2hhbmdlIHRoYXQgaXMgd2ViCisgICAgICAgIHZpc2libGUs IHNpbmNlIHRoZSBwYWdlIHdpbGwgaW5pdGlhbGx5IGJlIG9wZW5lZCBpbiBhIGhpZGRlbi9ibHVy cmVkIHN0YXRlLCBhbmQgbWF5CisgICAgICAgIGxhdGVyIGJlY29tZSB2aXNpYmxlL2ZvY3Vzc2Vk LiBUaGlzIGNoYW5nZSBpcyBjb25zaXN0ZW50IHdpdGggdGhlIGRpcmVjdGlvbiB3ZSB3YW50IHRv CisgICAgICAgIGV2b2x2ZSBpbi4gV2hpbHN0IHdlIHdpbGwgc3RpbGwgcHJvYmFibHkgcmVxdWly ZSBhIHN5bmNocm9ub3VzIG1lc3NhZ2UgZnJvbSB0aGUKKyAgICAgICAgV2ViUHJvY2VzcyB0byB0 aGUgVUlQcm9jZXNzIG9uIFdpbmRvdy5vcGVuLCB3ZSdsbCBwcm9iYWJseSBtYWtlIHRoaXMgcmV0 dXJuIG11Y2ggZWFybGllcgorICAgICAgICDigJMgaGF2aW5nIGp1c3QgY3JlYXRlZCB0aGUgV2Vi UGFnZVByb3h5LCBidXQgYXZvaWRpbmcgYmxvY2tpbmcgdGhlIFdlYlByb2Nlc3Mgb3ZlciB0aGUK KyAgICAgICAgY2xpZW50IGRlbGVnYXRlIGNhbGxiYWNrIHRoYXQgb3BlbnMgdGhlIG5ldyB3aW5k b3cuCisKKyAgICAgICAgVGhpcyBmaXggcmVzdWx0cyBpbiBhIGxheW91dCB0ZXN0IHJlc3VsdCBj aGFuZ2UsIGR1ZSB0byB0aGUgY2hhbmdlIGluIGJlaGF2aW9yIChwYWdlIGlzCisgICAgICAgIGNy ZWF0ZWQgYmx1cnJlZCwgYW5kIGJlY29tZXMgZm9jdXNzZWQsIHJlc3VsdGluZyBpbiBhIGZvY3Vz IGV2ZW50IGJlaW5nIGZpcmVkIOKAkyByYXRoZXIKKyAgICAgICAgdGhhbiB0aGUgd2luZG93IG9w ZW5pbmcgZGlyZWN0bHkgaW50byBhIGZvY3Vzc2VkIHN0YXRlKS4gVGhpcyBpcyByZXBvcnRlZCBh cyBhCisgICAgICAgIHByb2dyZXNzaW9uICh0ZXN0IGlzIGJyb2tlbiBpbiBXZWJLaXQxLCBmaXhl ZCBpbiBXZWJLaXQyIGFmdGVyIHRoaXMgY2hhbmdlKS4gSW4gcmVhbGl0eQorICAgICAgICB0aGUg dGVzdCBpcyBhY3R1YWxseSBzbGlnaHRseSBicm9rZW4gaW4gRFJUL3Rlc3QtcnVubmVyIOKAkyB0 aGUgdGVzdCBydW5zIGRpZmZlcmVudGx5IHRoYW4KKyAgICAgICAgaW4gYnJvd3Nlciwgc2luY2Ug dGhlcmUgaXMgaXMgbm8gdmlzaWJsZSBtYWluIHdpbmRvdy4gSW4tYnJvd3NlciB0aGlzIHBhdGNo IHJlc3VsdHMgaW4KKyAgICAgICAgbm8gY2hhbmdlIGluIGJlaGF2aW9yIG9uIGRvbS9XaW5kb3cv bW96aWxsYS1mb2N1cy1ibHVyLmh0bWwgKHRoZSBhZmZlY3RlZCB0ZXN0KS4KKworICAgICAgICAq IHBsYXRmb3JtL21hYy13azIvZmFzdC9kb20vV2luZG93OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMtd2syL2Zhc3QvZG9tL1dpbmRvdy9tb3ppbGxhLWZvY3VzLWJsdXItZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgICAgIC0gVGhpcyB0ZXN0IG5vdyByZXBvcnRzIGEgcGFzcyBv biBXZWJLaXQyCisKIDIwMTMtMTAtMzAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgQWRkIHR3byBjcmFzaCBleHBlY3RhdGlvbnMgcGVyIGJ1ZyAxMjM1NTUuCklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL2Zhc3QvZG9tL1dpbmRvdy9tb3ppbGxh LWZvY3VzLWJsdXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRm b3JtL21hYy13azIvZmFzdC9kb20vV2luZG93L21vemlsbGEtZm9jdXMtYmx1ci1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL2Zhc3QvZG9t L1dpbmRvdy9tb3ppbGxhLWZvY3VzLWJsdXItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMTEgQEAKK0NoZWNrIHRoYXQgd2luZG93LmJsdXIoKSBkb2VzIG5vdGhpbmcsIGFu ZCB3aW5kb3cuZm9jdXMoKSBvbmx5IHdvcmtzIGlmIGl0IGlzIGludm9rZWQgZnJvbSB0aGUgd2lu ZG93IHRoYXQgb3BlbmVkIHRoZSBmb3JtZXIuIElmIHRoZSB0ZXN0IHBhc3NlcywgeW91IHNob3Vs ZCBzZWUgYSBzZXJpZXMgb2YgUEFTUyBtZXNzYWdlcyB3aXRoIHRoZSBsYXN0IGJlaW5nICdBbGwg dGVzdHMgZmluaXNoZWQnLgorCitUaGlzIHRlc3QgaXMgYWRvcHRlZCBmcm9tIG1vemlsbGEncyB0 ZXN0cy4KKworUEFTUzogVGhlIGZvY3VzIHNob3VsZCBub3QgaGF2ZSBiZWVuIGNoYW5nZWQhCitQ QVNTOiBUaGUgZm9jdXMgc2hvdWxkIG5vdCBoYXZlIGJlZW4gY2hhbmdlZCEKK1BBU1M6IFRoZSBm b2N1cyBzaG91bGQgbm90IGhhdmUgYmVlbiBjaGFuZ2VkIHdpdGggVVJMPWRhdGE6dGV4dC9odG1s LDxzY3JpcHQ+b3BlbmVyLmZvY3VzKCk7b3BlbmVyLnBvc3RNZXNzYWdlKCIiLCAiKiIpOzwvc2Ny aXB0PgorUEFTUzogVGhlIGZvY3VzIHNob3VsZCBub3QgaGF2ZSBiZWVuIGNoYW5nZWQgd2l0aCBV Ukw9ZGF0YTp0ZXh0L2h0bWwsPHNjcmlwdD5ibHVyKCk7b3BlbmVyLnBvc3RNZXNzYWdlKCIiLCAi KiIpOzwvc2NyaXB0PgorUEFTUzogVGhlIGxhc3Qgb3BlbmVkIHdpbmRvdyBzaG91bGQgYmUgYWJs ZSB0byBnZXQgZm9jdXMKK1BBU1M6IEFsbCB0ZXN0cyBmaW5pc2hlZAorCg==