123555 2013-10-30 21:50:33 -0700 REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions 2013-11-04 17:31:21 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 rniwa eric.carlson commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble oldest_to_newest 945370 0 rniwa 2013-10-30 21:50:33 -0700 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fmedia-fragments%2FTC0054.html%2Cmedia%2Fmedia-fragments%2FTC0061.html e.g. http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r158339%20(13794)/results.html 945373 1 rniwa 2013-10-30 22:01:57 -0700 Added test expectations in http://trac.webkit.org/changeset/158344. 945521 2 eric.carlson 2013-10-31 08:18:04 -0700 0 WTFCrash + 42 (Assertions.cpp:342) 1 WebCore::MediaFragmentURIParser::parseTimeFragment() + 316 (MediaFragmentURIParser.cpp:172) 2 WebCore::MediaFragmentURIParser::startTime() + 74 (MediaFragmentURIParser.cpp:92) MediaFragmentURIParser.cpp:172 is: ASSERT(fragment.second.is8Bit()); This has been in the code since it was checked in almost two years ago. Why is it asserting now? 945582 3 rniwa 2013-10-31 10:45:37 -0700 Maybe we're not creating a string in 16-bit mode? 946885 4 215969 eric.carlson 2013-11-04 16:37:54 -0800 Created attachment 215969 Proposed patch 946889 5 rniwa 2013-11-04 16:44:08 -0800 Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ? 946898 6 215973 eric.carlson 2013-11-04 16:52:34 -0800 Created attachment 215973 Updated patch 946899 7 eric.carlson 2013-11-04 16:52:54 -0800 (In reply to comment #5) > Could you also removed the test expectation I added in http://trac.webkit.org/changeset/158344 ? Oops, removed in the updated patch. 946911 8 215973 darin 2013-11-04 17:21:03 -0800 Comment on attachment 215973 Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=215973&action=review > Source/WebCore/ChangeLog:12 > + they will not processed. not be processed 946926 9 215973 commit-queue 2013-11-04 17:31:19 -0800 Comment on attachment 215973 Updated patch Clearing flags on attachment: 215973 Committed r158624: <http://trac.webkit.org/changeset/158624> 946927 10 commit-queue 2013-11-04 17:31:21 -0800 All reviewed patches have been landed. Closing bug. 215969 2013-11-04 16:37:54 -0800 2013-11-04 16:52:34 -0800 Proposed patch media-fragments-fix.txt text/plain 2396 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODU5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTA0ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1 ODMxMSk6IG1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwNTQuaHRtbCBhbmQgVEMwMDYxLmh0bWwg aGl0IGFzc2VydGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMzU1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIGh0bWwvTWVkaWFGcmFnbWVudFVSSVBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYUZyYWdtZW50VVJJUGFyc2VyOjpwYXJzZUZyYWdtZW50cyk6IERvbid0IGFkZCBhIGZyYWdt ZW50IHdpdGggZW1wdHkga2V5IG9yIHZhbHVlIGFzCisgICAgICAgICAgICB0aGV5IHdpbGwgbm90 IHByb2Nlc3NlZC4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRnJhZ21lbnRVUklQYXJzZXI6OnBh cnNlTlBURnJhZ21lbnQpOiBSZW1vdmUgZXhjZXNzIHdoaXRlc3BhY2UuCisKIDIwMTMtMTEtMDQg IEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgTGl2ZU5v ZGVMaXN0QmFzZSB1c2UgRWxlbWVudHMgaW5zdGVhZCBvZiBOb2RlcwpJbmRleDogU291cmNlL1dl YkNvcmUvaHRtbC9NZWRpYUZyYWdtZW50VVJJUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9odG1sL01lZGlhRnJhZ21lbnRVUklQYXJzZXIuY3BwCShyZXZpc2lvbiAxNTgz MDMpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRnJhZ21lbnRVUklQYXJzZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMzksMTQgKzEzOSwxNSBAQCB2b2lkIE1lZGlhRnJhZ21lbnRVUklQ YXJzZXI6OnBhcnNlRnJhZ21lCiAgICAgICAgIAogICAgICAgICAvLyAgYi4gQ29udmVydCBuYW1l IGFuZCB2YWx1ZSB0byBVbmljb2RlIHN0cmluZ3MgYnkgaW50ZXJwcmV0aW5nIHRoZW0gYXMgVVRG LTguIElmIGVpdGhlcgogICAgICAgICAvLyAgICAgbmFtZSBvciB2YWx1ZSBhcmUgbm90IHZhbGlk IFVURi04IHN0cmluZ3MsIHRoZW4gcmVtb3ZlIHRoZSBuYW1lLXZhbHVlIHBhaXIgZnJvbSB0aGUg bGlzdC4KLSAgICAgICAgYm9vbCB2YWxpZFVURjggPSB0cnVlOwotICAgICAgICBpZiAoIW5hbWUu aXNFbXB0eSgpKSB7CisgICAgICAgIGJvb2wgdmFsaWRVVEY4ID0gZmFsc2U7CisgICAgICAgIGlm ICghbmFtZS5pc0VtcHR5KCkgJiYgIXZhbHVlLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgbmFt ZSA9IG5hbWUudXRmOChTdHJpY3RDb252ZXJzaW9uKS5kYXRhKCk7CiAgICAgICAgICAgICB2YWxp ZFVURjggPSAhbmFtZS5pc0VtcHR5KCk7Ci0gICAgICAgIH0KLSAgICAgICAgaWYgKHZhbGlkVVRG OCAmJiAhdmFsdWUuaXNFbXB0eSgpKSB7Ci0gICAgICAgICAgICB2YWx1ZSA9IHZhbHVlLnV0Zjgo U3RyaWN0Q29udmVyc2lvbikuZGF0YSgpOwotICAgICAgICAgICAgdmFsaWRVVEY4ID0gIXZhbHVl LmlzRW1wdHkoKTsKKworICAgICAgICAgICAgaWYgKHZhbGlkVVRGOCkgeworICAgICAgICAgICAg ICAgIHZhbHVlID0gdmFsdWUudXRmOChTdHJpY3RDb252ZXJzaW9uKS5kYXRhKCk7CisgICAgICAg ICAgICAgICAgdmFsaWRVVEY4ID0gIXZhbHVlLmlzRW1wdHkoKTsKKyAgICAgICAgICAgIH0KICAg ICAgICAgfQogICAgICAgICAKICAgICAgICAgaWYgKHZhbGlkVVRGOCkKQEAgLTIwNSw3ICsyMDYs NyBAQCBib29sIE1lZGlhRnJhZ21lbnRVUklQYXJzZXI6OnBhcnNlTlBURnJhCiB7CiAgICAgdW5z aWduZWQgb2Zmc2V0ID0gMDsKICAgICBpZiAobGVuZ3RoID49IG5wdElkZW50aWZlckxlbmd0aCAm JiB0aW1lU3RyaW5nWzBdID09ICduJyAmJiB0aW1lU3RyaW5nWzFdID09ICdwJyAmJiB0aW1lU3Ry aW5nWzJdID09ICd0JyAmJiB0aW1lU3RyaW5nWzNdID09ICc6JykKLSAgICAgICAgICAgIG9mZnNl dCArPSBucHRJZGVudGlmZXJMZW5ndGg7CisgICAgICAgIG9mZnNldCArPSBucHRJZGVudGlmZXJM ZW5ndGg7CiAKICAgICBpZiAob2Zmc2V0ID09IGxlbmd0aCkKICAgICAgICAgcmV0dXJuIGZhbHNl Owo= 215973 2013-11-04 16:52:34 -0800 2013-11-04 17:31:19 -0800 Updated patch media-fragments-fix_2.txt text/plain 3710 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODYxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTA0ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1 ODMxMSk6IG1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwNTQuaHRtbCBhbmQgVEMwMDYxLmh0bWwg aGl0IGFzc2VydGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMzU1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIGh0bWwvTWVkaWFGcmFnbWVudFVSSVBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpN ZWRpYUZyYWdtZW50VVJJUGFyc2VyOjpwYXJzZUZyYWdtZW50cyk6IERvbid0IGFkZCBhIGZyYWdt ZW50IHdpdGggZW1wdHkga2V5IG9yIHZhbHVlIGFzCisgICAgICAgICAgICB0aGV5IHdpbGwgbm90 IHByb2Nlc3NlZC4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRnJhZ21lbnRVUklQYXJzZXI6OnBh cnNlTlBURnJhZ21lbnQpOiBSZW1vdmUgZXhjZXNzIHdoaXRlc3BhY2UuCisKIDIwMTMtMTEtMDQg IENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogTWFp bCBhdHRhY2htZW50cyBhdCB0aGUgc3RhcnQgb2YgYW4gZW1haWwgYXJlIG5vdCBvdXRwdXQgYnkg Vm9pY2VPdmVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRnJhZ21lbnRVUklQYXJz ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFGcmFnbWVudFVS SVBhcnNlci5jcHAJKHJldmlzaW9uIDE1ODMwMykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvTWVk aWFGcmFnbWVudFVSSVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOSwxNCArMTM5LDE1 IEBAIHZvaWQgTWVkaWFGcmFnbWVudFVSSVBhcnNlcjo6cGFyc2VGcmFnbWUKICAgICAgICAgCiAg ICAgICAgIC8vICBiLiBDb252ZXJ0IG5hbWUgYW5kIHZhbHVlIHRvIFVuaWNvZGUgc3RyaW5ncyBi eSBpbnRlcnByZXRpbmcgdGhlbSBhcyBVVEYtOC4gSWYgZWl0aGVyCiAgICAgICAgIC8vICAgICBu YW1lIG9yIHZhbHVlIGFyZSBub3QgdmFsaWQgVVRGLTggc3RyaW5ncywgdGhlbiByZW1vdmUgdGhl IG5hbWUtdmFsdWUgcGFpciBmcm9tIHRoZSBsaXN0LgotICAgICAgICBib29sIHZhbGlkVVRGOCA9 IHRydWU7Ci0gICAgICAgIGlmICghbmFtZS5pc0VtcHR5KCkpIHsKKyAgICAgICAgYm9vbCB2YWxp ZFVURjggPSBmYWxzZTsKKyAgICAgICAgaWYgKCFuYW1lLmlzRW1wdHkoKSAmJiAhdmFsdWUuaXNF bXB0eSgpKSB7CiAgICAgICAgICAgICBuYW1lID0gbmFtZS51dGY4KFN0cmljdENvbnZlcnNpb24p LmRhdGEoKTsKICAgICAgICAgICAgIHZhbGlkVVRGOCA9ICFuYW1lLmlzRW1wdHkoKTsKLSAgICAg ICAgfQotICAgICAgICBpZiAodmFsaWRVVEY4ICYmICF2YWx1ZS5pc0VtcHR5KCkpIHsKLSAgICAg ICAgICAgIHZhbHVlID0gdmFsdWUudXRmOChTdHJpY3RDb252ZXJzaW9uKS5kYXRhKCk7Ci0gICAg ICAgICAgICB2YWxpZFVURjggPSAhdmFsdWUuaXNFbXB0eSgpOworCisgICAgICAgICAgICBpZiAo dmFsaWRVVEY4KSB7CisgICAgICAgICAgICAgICAgdmFsdWUgPSB2YWx1ZS51dGY4KFN0cmljdENv bnZlcnNpb24pLmRhdGEoKTsKKyAgICAgICAgICAgICAgICB2YWxpZFVURjggPSAhdmFsdWUuaXNF bXB0eSgpOworICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBpZiAo dmFsaWRVVEY4KQpAQCAtMjA1LDcgKzIwNiw3IEBAIGJvb2wgTWVkaWFGcmFnbWVudFVSSVBhcnNl cjo6cGFyc2VOUFRGcmEKIHsKICAgICB1bnNpZ25lZCBvZmZzZXQgPSAwOwogICAgIGlmIChsZW5n dGggPj0gbnB0SWRlbnRpZmVyTGVuZ3RoICYmIHRpbWVTdHJpbmdbMF0gPT0gJ24nICYmIHRpbWVT dHJpbmdbMV0gPT0gJ3AnICYmIHRpbWVTdHJpbmdbMl0gPT0gJ3QnICYmIHRpbWVTdHJpbmdbM10g PT0gJzonKQotICAgICAgICAgICAgb2Zmc2V0ICs9IG5wdElkZW50aWZlckxlbmd0aDsKKyAgICAg ICAgb2Zmc2V0ICs9IG5wdElkZW50aWZlckxlbmd0aDsKIAogICAgIGlmIChvZmZzZXQgPT0gbGVu Z3RoKQogICAgICAgICByZXR1cm4gZmFsc2U7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTg2MTcpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAor MjAxMy0xMS0wNCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OKHIxNTgzMTEpOiBtZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDU0Lmh0 bWwgYW5kIFRDMDA2MS5odG1sIGhpdCBhc3NlcnRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM1NTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZSBtZWRp YS9tZWRpYS1mcmFnbWVudHMvVEMwMDU0Lmh0bWwgYW5kIG1lZGlhL21lZGlhLWZyYWdtZW50cy9U QzAwNjEuaHRtbC4KKwogMjAxMy0xMS0wNCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBw bGUuY29tPgogCiAgICAgICAgIEFYOiBNYWlsIGF0dGFjaG1lbnRzIGF0IHRoZSBzdGFydCBvZiBh biBlbWFpbCBhcmUgbm90IG91dHB1dCBieSBWb2ljZU92ZXIKSW5kZXg6IExheW91dFRlc3RzL1Rl c3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9u cwkocmV2aXNpb24gMTU4NjE3KQorKysgTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwkod29y a2luZyBjb3B5KQpAQCAtNzEsNyArNzEsNCBAQCBmYXN0L21lZGlhc3RyZWFtL01lZGlhU3RyZWFt LWNsb25lLmh0bWwgCiAjIFNraXBwaW5nIGl0IGZvciBub3csIHRoZW4gcHV0IGl0IGFnYWluIHdo ZW4gdGhlIHNwZWMgZGVjaWRlcyBpdAogZmFzdC9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS1vbmVu ZGVkLmh0bWwgWyBTa2lwIF0KIAotd2Via2l0Lm9yZy9iLzEyMzU1NSBbIERlYnVnIF0gbWVkaWEv bWVkaWEtZnJhZ21lbnRzL1RDMDA1NC5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzEyMzU1 NSBbIERlYnVnIF0gbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDA2MS5odG1sIFsgQ3Jhc2ggXQot CiB3ZWJraXQub3JnL2IvMTIzNzY1IHBsdWdpbnMvcmVmY291bnQtbGVha3MuaHRtbCBbIEZhaWx1 cmUgXQo=