123545 2013-10-30 17:33:53 -0700 [Win] Legible Output callbacks should be on notification queue 2013-10-30 17:48:35 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue eric.carlson glenn jer.noble webkit-bug-importer oldest_to_newest 945266 0 bfulgham 2013-10-30 17:33:53 -0700 We should register our Legible Output notifications to run on the notification queue, rather than the main queue. If we don't we can sometimes run into shutdown problems where video playback does not end when we release the media resource because the main dispatch queue continues to run as long as the application those. This causes these resources to be held onto, resulting in media not stopping and preventing WebKit from exiting when the program is shut down. 945268 1 webkit-bug-importer 2013-10-30 17:34:21 -0700 <rdar://problem/15358129> 945270 2 215585 bfulgham 2013-10-30 17:41:21 -0700 Created attachment 215585 Patch 945274 3 bfulgham 2013-10-30 17:48:35 -0700 Committed r158334: <http://trac.webkit.org/changeset/158334> 215585 2013-10-30 17:41:21 -0700 2013-10-30 17:45:38 -0700 Patch bug-123545-20131030174134.patch text/plain 5578 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODMzMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDEzLTEwLTMwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIExlZ2libGUgT3V0 cHV0IGNhbGxiYWNrcyBzaG91bGQgaGFwcGVuIG9uIG5vdGlmaWNhdGlvbiBxdWV1ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTQ1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW9kaWZ5IHRoZSBjYWxs YmFjayBjcmVhdGlvbiBmb3IgTGVnaWJsZSBPdXRwdXQgaXRlbXMgc28gdGhhdCB0aGV5CisgICAg ICAgIGFyZSBtYWRlIG9uIG91ciBub3RpZmljYXRpb24gcXVldWUuIFRoZSB1c2Ugb2YgdGhlIG1h aW4gcXVldWUgd2FzIGEKKyAgICAgICAgaG9sZG92ZXIgZnJvbSBzb21lIHRlbXBvcmFyeSBjb2Rl IHVzZWQgZHVyaW5nIGVhcmxpZXIgZGV2ZWxvcG1lbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0Yu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6QVZGV3JhcHBlcjo6QVZGV3JhcHBlcik6IEFzc2VydCB0 aGlzIGhhcHBlbnMgb24gdGhlIG1haW4gdGhyZWFkLgorICAgICAgICAoV2ViQ29yZTo6QVZGV3Jh cHBlcjo6fkFWRldyYXBwZXIpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OmRlc3Ryb3lBVkZX cmFwcGVyKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpBVkZXcmFwcGVyOjpjcmVhdGVQbGF5 ZXIpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkFWRldyYXBwZXI6OmNyZWF0ZVBsYXllckl0 ZW0pOiBEaXR0by4KKyAgICAgICAgQWxzbywgaW5zdHJ1Y3QgTGVnaWJsZU91dHB1dCBjYWxsYmFj a3MgdG8gaGFwcGVuIG9uIG91ciBub3RpZmljYXRpb24KKyAgICAgICAgcXVldWUsIHJhdGhlciB0 aGFuIHRoZSBtYWluIHRocmVhZC4KKyAgICAgICAgKFdlYkNvcmU6OkFWRldyYXBwZXI6OmNyZWF0 ZUFWQ0ZWaWRlb0xheWVyKTogQXNzZXJ0IHRoaXMgaGFwcGVucyBvbiB0aGUgbWFpbiB0aHJlYWQu CisgICAgICAgIChXZWJDb3JlOjpBVkZXcmFwcGVyOjpkZXN0cm95VmlkZW9MYXllcik6IERpdHRv LgorICAgICAgICAoV2ViQ29yZTo6QVZGV3JhcHBlcjo6Y3JlYXRlSW1hZ2VHZW5lcmF0b3IpOiBE aXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkFWRldyYXBwZXI6OmRlc3Ryb3lJbWFnZUdlbmVyYXRv cik6IERpdHRvLgorCiAyMDEzLTEwLTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIFhIUi5yZXNwb25zZSBpcyBudWxsIHdoZW4gcmVxdWVzdGluZyBlbXB0 eSBmaWxlIGFzIGFycmF5YnVmZmVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRh dGlvbi9jZi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRi5jcHAJKHJldmlzaW9uIDE1 ODI5OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9j Zi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRi5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTExNjIsNiArMTE2Miw3IEBAIEFWRldyYXBwZXI6OkFWRldyYXBwZXIoTWVkaWFQbGF5ZXJQcml2 YXQKICAgICAsIG1fY3VycmVudFRyYWNrKDApCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgp KTsKKyAgICBBU1NFUlQoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSA9PSBkaXNwYXRjaF9nZXRf Y3VycmVudF9xdWV1ZSgpKTsKICAgICBMT0coTWVkaWEsICJBVkZXcmFwcGVyOjpBVkZXcmFwcGVy KCVwKSIsIHRoaXMpOwogCiAgICAgbV9ub3RpZmljYXRpb25RdWV1ZSA9IGRpc3BhdGNoX3F1ZXVl X2NyZWF0ZSgiTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0Yubm90aWZpY2F0aW9uUXVl dWUiLCAwKTsKQEAgLTExNzEsNiArMTE3Miw3IEBAIEFWRldyYXBwZXI6OkFWRldyYXBwZXIoTWVk aWFQbGF5ZXJQcml2YXQKIEFWRldyYXBwZXI6On5BVkZXcmFwcGVyKCkKIHsKICAgICBBU1NFUlQo aXNNYWluVGhyZWFkKCkpOworICAgIEFTU0VSVChkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpID09 IGRpc3BhdGNoX2dldF9jdXJyZW50X3F1ZXVlKCkpOwogICAgIExPRyhNZWRpYSwgIkFWRldyYXBw ZXI6On5BVkZXcmFwcGVyKCVwICVkKSIsIHRoaXMsIG1fb2JqZWN0SUQpOwogCiAgICAgZGVzdHJv eVZpZGVvTGF5ZXIoKTsKQEAgLTEyNTEsNiArMTI1Myw4IEBAIHZvaWQgQVZGV3JhcHBlcjo6c2No ZWR1bGVEaXNjb25uZWN0QW5kRGUKIAogc3RhdGljIHZvaWQgZGVzdHJveUFWRldyYXBwZXIodm9p ZCogY29udGV4dCkKIHsKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworICAgIEFTU0VSVChk aXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpID09IGRpc3BhdGNoX2dldF9jdXJyZW50X3F1ZXVlKCkp OwogICAgIEFWRldyYXBwZXIqIGF2ZldyYXBwZXIgPSBzdGF0aWNfY2FzdDxBVkZXcmFwcGVyKj4o Y29udGV4dCk7CiAgICAgaWYgKCFhdmZXcmFwcGVyKQogICAgICAgICByZXR1cm47CkBAIC0xMzA2 LDYgKzEzMTAsOCBAQCB2b2lkIEFWRldyYXBwZXI6OmNyZWF0ZUFzc2V0Rm9yVVJMKGNvbnN0CiAK IHZvaWQgQVZGV3JhcHBlcjo6Y3JlYXRlUGxheWVyKElEaXJlY3QzRERldmljZTkqIGQzZERldmlj ZSkKIHsKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworICAgIEFTU0VSVChkaXNwYXRjaF9n ZXRfbWFpbl9xdWV1ZSgpID09IGRpc3BhdGNoX2dldF9jdXJyZW50X3F1ZXVlKCkpOwogICAgIEFT U0VSVCghYXZQbGF5ZXIoKSAmJiBhdlBsYXllckl0ZW0oKSk7CiAKICAgICBSZXRhaW5QdHI8Q0ZN dXRhYmxlRGljdGlvbmFyeVJlZj4gb3B0aW9uc1JlZiA9IGFkb3B0Q0YoQ0ZEaWN0aW9uYXJ5Q3Jl YXRlTXV0YWJsZShrQ0ZBbGxvY2F0b3JEZWZhdWx0LCAxLCAma0NGVHlwZURpY3Rpb25hcnlLZXlD YWxsQmFja3MsICZrQ0ZUeXBlRGljdGlvbmFyeVZhbHVlQ2FsbEJhY2tzKSk7CkBAIC0xMzQ3LDYg KzEzNTMsOCBAQCB2b2lkIEFWRldyYXBwZXI6OmNyZWF0ZVBsYXllcihJRGlyZWN0M0RECiAKIHZv aWQgQVZGV3JhcHBlcjo6Y3JlYXRlUGxheWVySXRlbSgpCiB7CisgICAgQVNTRVJUKGlzTWFpblRo cmVhZCgpKTsKKyAgICBBU1NFUlQoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSA9PSBkaXNwYXRj aF9nZXRfY3VycmVudF9xdWV1ZSgpKTsKICAgICBBU1NFUlQoIWF2UGxheWVySXRlbSgpICYmIGF2 QXNzZXQoKSk7CiAKICAgICAvLyBDcmVhdGUgdGhlIHBsYXllciBpdGVtIHNvIHdlIGJlZ2luIGxv YWRpbmcgbWVkaWEgZGF0YS4KQEAgLTEzODIsNyArMTM5MCw3IEBAIHZvaWQgQVZGV3JhcHBlcjo6 Y3JlYXRlUGxheWVySXRlbSgpCiAgICAgY2FsbGJhY2tJbmZvLmNvbnRleHQgPSBjYWxsYmFja0Nv bnRleHQoKTsKICAgICBjYWxsYmFja0luZm8ubGVnaWJsZU91dHB1dENhbGxiYWNrID0gQVZGV3Jh cHBlcjo6bGVnaWJsZU91dHB1dENhbGxiYWNrOwogCi0gICAgQVZDRlBsYXllckl0ZW1MZWdpYmxl T3V0cHV0U2V0Q2FsbGJhY2tzKG1fbGVnaWJsZU91dHB1dC5nZXQoKSwgJmNhbGxiYWNrSW5mbywg ZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSk7CisgICAgQVZDRlBsYXllckl0ZW1MZWdpYmxlT3V0 cHV0U2V0Q2FsbGJhY2tzKG1fbGVnaWJsZU91dHB1dC5nZXQoKSwgJmNhbGxiYWNrSW5mbywgZGlz cGF0Y2hRdWV1ZSgpKTsKICAgICBBVkNGUGxheWVySXRlbUxlZ2libGVPdXRwdXRTZXRBZHZhbmNl SW50ZXJ2YWxGb3JDYWxsYmFja0ludm9jYXRpb24obV9sZWdpYmxlT3V0cHV0LmdldCgpLCBsZWdp YmxlT3V0cHV0QWR2YW5jZUludGVydmFsKTsKICAgICBBVkNGUGxheWVySXRlbUxlZ2libGVPdXRw dXRTZXRUZXh0U3R5bGluZ1Jlc29sdXRpb24obV9sZWdpYmxlT3V0cHV0LmdldCgpLCBBVkNGUGxh eWVySXRlbUxlZ2libGVPdXRwdXRUZXh0U3R5bGluZ1Jlc29sdXRpb25Tb3VyY2VBbmRSdWxlc09u bHkpOwogICAgIEFWQ0ZQbGF5ZXJJdGVtQWRkT3V0cHV0KG1fYXZQbGF5ZXJJdGVtLmdldCgpLCBt X2xlZ2libGVPdXRwdXQuZ2V0KCkpOwpAQCAtMTYwOCw2ICsxNjE2LDggQEAgUGxhdGZvcm1MYXll ciogQVZGV3JhcHBlcjo6cGxhdGZvcm1MYXllcgogCiB2b2lkIEFWRldyYXBwZXI6OmNyZWF0ZUFW Q0ZWaWRlb0xheWVyKCkKIHsKKyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworICAgIEFTU0VS VChkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpID09IGRpc3BhdGNoX2dldF9jdXJyZW50X3F1ZXVl KCkpOwogICAgIGlmICghYXZQbGF5ZXIoKSB8fCBtX2F2Q0ZWaWRlb0xheWVyKQogICAgICAgICBy ZXR1cm47CiAKQEAgLTE2MTgsNiArMTYyOCw4IEBAIHZvaWQgQVZGV3JhcHBlcjo6Y3JlYXRlQVZD RlZpZGVvTGF5ZXIoKQogCiB2b2lkIEFWRldyYXBwZXI6OmRlc3Ryb3lWaWRlb0xheWVyKCkKIHsK KyAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOworICAgIEFTU0VSVChkaXNwYXRjaF9nZXRfbWFp bl9xdWV1ZSgpID09IGRpc3BhdGNoX2dldF9jdXJyZW50X3F1ZXVlKCkpOwogICAgIExPRyhNZWRp YSwgIkFWRldyYXBwZXI6OmRlc3Ryb3lWaWRlb0xheWVyKCVwKSIsIHRoaXMpOwogICAgIG1fbGF5 ZXJDbGllbnQgPSBudWxscHRyOwogICAgIG1fY2FWaWRlb0xheWVyID0gMDsKQEAgLTE2NDMsNiAr MTY1NSw4IEBAIHZvaWQgQVZGV3JhcHBlcjo6c2V0VmlkZW9MYXllckhpZGRlbihib28KIAogdm9p ZCBBVkZXcmFwcGVyOjpjcmVhdGVJbWFnZUdlbmVyYXRvcigpCiB7CisgICAgQVNTRVJUKGlzTWFp blRocmVhZCgpKTsKKyAgICBBU1NFUlQoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSA9PSBkaXNw YXRjaF9nZXRfY3VycmVudF9xdWV1ZSgpKTsKICAgICBpZiAoIWF2QXNzZXQoKSB8fCBtX2ltYWdl R2VuZXJhdG9yKQogICAgICAgICByZXR1cm47CiAKQEAgLTE2NTgsNiArMTY3Miw4IEBAIHZvaWQg QVZGV3JhcHBlcjo6Y3JlYXRlSW1hZ2VHZW5lcmF0b3IoKQogCiB2b2lkIEFWRldyYXBwZXI6OmRl c3Ryb3lJbWFnZUdlbmVyYXRvcigpCiB7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKKyAg ICBBU1NFUlQoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSA9PSBkaXNwYXRjaF9nZXRfY3VycmVu dF9xdWV1ZSgpKTsKICAgICBMT0coTWVkaWEsICJBVkZXcmFwcGVyOjpkZXN0cm95SW1hZ2VHZW5l cmF0b3IoJXApIiwgdGhpcyk7CiAgICAgbV9pbWFnZUdlbmVyYXRvciA9IDA7CiB9Cg==