123537 2013-10-30 16:10:57 -0700 Lots of layers get solid color but transparent contents layers now 2013-11-07 17:41:30 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser noam simon.fraser thorton oldest_to_newest 945214 0 simon.fraser 2013-10-30 16:10:57 -0700 After making layers with contents layers have pink borders, we can see from http://www.webkit.org/blog-files/3d-transforms/poster-circle.html that we're making color contents layers for lots of things now, but setting a transparent color on them. RenderLayerBacking::updateDirectlyCompositedBackgroundColor() is getting rendererBackgroundColor(), which returns a valid (but transparent) color. 945217 1 noam 2013-10-30 16:24:40 -0700 At least for TextureMapper this is not a problem, I'm not familiar with the implications of this for CA. 945220 2 simon.fraser 2013-10-30 16:30:42 -0700 Do you avoid contentsLayers for the transparent color? 945222 3 noam 2013-10-30 16:33:33 -0700 Content layers are really more of a CA concept... In TextureMapper we just mark those layers as having a solid color and no backing store and they're rendered that way. But in general it should be safe to treat "transparent" solid color as a sign to delete the content layer, as an optimization inside GraphicsLayerCA and friends. 948480 4 216343 simon.fraser 2013-11-07 17:30:40 -0800 Created attachment 216343 Patch 948482 5 216343 thorton 2013-11-07 17:32:26 -0800 Comment on attachment 216343 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216343&action=review > Source/WebCore/ChangeLog:13 > + Fix only making a background-color layer if the color is not transparent (zero alpha). fix only making. 948487 6 simon.fraser 2013-11-07 17:41:30 -0800 https://trac.webkit.org/r158889 216343 2013-11-07 17:30:40 -0800 2013-11-07 17:32:26 -0800 Patch bug-123537-20131107173022.patch text/plain 6094 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4ODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjZjMzYyMjMyYWQ2MzUz ZmExNTMxMGVjMTBmNGRiNzQxMGYzODgzZi4uMWMzODliMmRhMDU3MzU2M2Y3OGNmOTg2OWU1Yzc2 NjVjNGE4MmM3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTExLTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIExvdHMgb2YgbGF5 ZXJzIGdldCBzb2xpZCBjb2xvciBidXQgdHJhbnNwYXJlbnQgY29udGVudHMgbGF5ZXJzIG5vdwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTM3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBX ZSBjYWxsIHJlbmRlcmVyQmFja2dyb3VuZENvbG9yKCkgdG8gZGV0ZXJtaW5lIHRoZSBsYXllcidz IGJhY2tncm91bmQgY29sb3IsCisgICAgICAgIGJ1dCBvbiBtb3N0IGVsZW1lbnRzIHRoaXMgcmV0 dXJucyB0aGUgdHJhbnNwYXJlbnQgY29sb3IgKGEgdmFsaWQgY29sb3IpLgorICAgICAgICBUaGlz IGNhdXNlZCB1cyB0byBhbGxvY2F0ZSBhIGNvbnRlbnRzTGF5ZXIsIGFuZCB1c2UgdGhlIHRyYW5z cGFyZW50IGNvbG9yIGFzIGl0cworICAgICAgICBiYWNrZ3JvdW5kQ29sb3IsIHdoaWNoIHdhcyB3 YXN0ZWZ1bC4KKyAgICAgICAgCisgICAgICAgIEZpeCBvbmx5IG1ha2luZyBhIGJhY2tncm91bmQt Y29sb3IgbGF5ZXIgaWYgdGhlIGNvbG9yIGlzIG5vdCB0cmFuc3BhcmVudCAoemVybyBhbHBoYSku CisgICAgICAgIAorICAgICAgICBBbHNvIGF2b2lkIG1ha2luZyBhIG5ldyBjb250ZW50cyBsYXll ciBvbiBldmVyeSBjb2xvciBjaGFuZ2UsIGFuZCBtYWtlIHN1cmUgdGhhdAorICAgICAgICB3ZSBk b24ndCBkbyBpbXBsaWNpdCBhbmltYXRpb25zIGZvciBiYWNrZ3JvdW5kQ29sb3IsIGFuZCBzb21l IG90aGVyIHByb3BlcnRpZXMKKyAgICAgICAgdGhhdCB3ZXJlIG9taXR0ZWQgYnkgbWlzdGFrZS4K KworICAgICAgICBMYXllciB0cmVlIGR1bXBzIGRvbid0IGR1bXAgY29udGVudCBsYXllcnMsIHNv IG5vIHdheSB0byB0ZXN0IGVhc2lseS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nh L0dyYXBoaWNzTGF5ZXJDQS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ0E6 OnNldENvbnRlbnRzVG9Tb2xpZENvbG9yKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j YS9tYWMvUGxhdGZvcm1DQUxheWVyTWFjLm1tOgorICAgICAgICAobnVsbEFjdGlvbnNEaWN0aW9u YXJ5KToKKwogMjAxMy0xMS0wNyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBET01Ub2tlbkxpc3Q6OmFkZCBjYW4gYWRkIGR1cGxpY2F0ZWQgdmFsdWVzIGlmIGFy Z3VtZW50cyBoYWQgZHVwbGljYXRlZCB2YWx1ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBiNWI0ZmJlNjhmOGFl NWU4NDM1YjQ5MzI1ODgxZTRlMzEwZTIxYjI4Li4xMGY5MzJhMzhmMjliOWYzODdjNzEwZGUzNTdj YzA0NWE3YjhjMWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTEtMDcgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgTG90cyBvZiBs YXllcnMgZ2V0IHNvbGlkIGNvbG9yIGJ1dCB0cmFuc3BhcmVudCBjb250ZW50cyBsYXllcnMgbm93 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM1MzcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJl ZC9tYWMvUmVtb3RlTGF5ZXJUcmVlUHJvcGVydHlBcHBsaWVyLm1tOgorICAgICAgICAoV2ViS2l0 OjpSZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXI6OmRpc2FibGVBY3Rpb25zRm9yTGF5ZXIp OgorCiAyMDEzLTExLTA3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIG1vcmUgZGVhZCBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAppbmRleCA2NTkyZjg3 Zjk4NjlmMGQ1NTUxMWM2ODVhODVjM2IwZDk0NjhhNTdlLi41MjFhNjE4MjI5OGVkZDZiZjdiMjU4 MjczNmM0NjE3YTllZmQzNWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKQEAgLTgxOCwxOSArODE4LDI3IEBA IHZvaWQgR3JhcGhpY3NMYXllckNBOjpzZXRDb250ZW50c1RvU29saWRDb2xvcihjb25zdCBDb2xv ciYgY29sb3IpCiAgICAgICAgIHJldHVybjsKIAogICAgIG1fY29udGVudHNTb2xpZENvbG9yID0g Y29sb3I7CisgICAgCisgICAgYm9vbCBjb250ZW50c0xheWVyQ2hhbmdlZCA9IGZhbHNlOwogCi0g ICAgaWYgKG1fY29udGVudHNTb2xpZENvbG9yLmlzVmFsaWQoKSkgewotICAgICAgICBtX2NvbnRl bnRzTGF5ZXJQdXJwb3NlID0gQ29udGVudHNMYXllckZvckJhY2tncm91bmRDb2xvcjsKLSAgICAg ICAgbV9jb250ZW50c0xheWVyID0gY3JlYXRlUGxhdGZvcm1DQUxheWVyKFBsYXRmb3JtQ0FMYXll cjo6TGF5ZXJUeXBlTGF5ZXIsIHRoaXMpOworICAgIGlmIChtX2NvbnRlbnRzU29saWRDb2xvci5p c1ZhbGlkKCkgJiYgbV9jb250ZW50c1NvbGlkQ29sb3IuYWxwaGEoKSkgeworICAgICAgICBpZiAo IW1fY29udGVudHNMYXllciB8fCBtX2NvbnRlbnRzTGF5ZXJQdXJwb3NlICE9IENvbnRlbnRzTGF5 ZXJGb3JCYWNrZ3JvdW5kQ29sb3IpIHsKKyAgICAgICAgICAgIG1fY29udGVudHNMYXllclB1cnBv c2UgPSBDb250ZW50c0xheWVyRm9yQmFja2dyb3VuZENvbG9yOworICAgICAgICAgICAgbV9jb250 ZW50c0xheWVyID0gY3JlYXRlUGxhdGZvcm1DQUxheWVyKFBsYXRmb3JtQ0FMYXllcjo6TGF5ZXJU eXBlTGF5ZXIsIHRoaXMpOwogI2lmbmRlZiBOREVCVUcKLSAgICAgICAgbV9jb250ZW50c0xheWVy LT5zZXROYW1lKCJCYWNrZ3JvdW5kIENvbG9yIExheWVyIik7CisgICAgICAgICAgICBtX2NvbnRl bnRzTGF5ZXItPnNldE5hbWUoIkJhY2tncm91bmQgQ29sb3IgTGF5ZXIiKTsKICNlbmRpZgorICAg ICAgICAgICAgY29udGVudHNMYXllckNoYW5nZWQgPSB0cnVlOworICAgICAgICB9CiAgICAgfSBl bHNlIHsKKyAgICAgICAgY29udGVudHNMYXllckNoYW5nZWQgPSBtX2NvbnRlbnRzTGF5ZXI7CiAg ICAgICAgIG1fY29udGVudHNMYXllclB1cnBvc2UgPSBOb0NvbnRlbnRzTGF5ZXI7CiAgICAgICAg IG1fY29udGVudHNMYXllciA9IDA7CiAgICAgfQogCi0gICAgbm90ZVN1YmxheWVyc0NoYW5nZWQo KTsKKyAgICBpZiAoY29udGVudHNMYXllckNoYW5nZWQpCisgICAgICAgIG5vdGVTdWJsYXllcnND aGFuZ2VkKCk7CisKICAgICBub3RlTGF5ZXJQcm9wZXJ0eUNoYW5nZWQoQ29udGVudHNDb2xvckxh eWVyQ2hhbmdlZCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBTGF5ZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9tYWMvUGxhdGZvcm1DQUxheWVyTWFjLm1tCmluZGV4IGZjOWJjMzJk NWRmNmU1YjhkNTYzOGY1YjIyNzNhYzRjMTA3MzgwNWIuLjVlMDFjZDYwZWQyMGZjMGQxZDZkMTg4 OTZlOTNhM2U1MGZiZmFjNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhL21hYy9QbGF0Zm9ybUNBTGF5ZXJNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1BsYXRmb3JtQ0FMYXllck1hYy5tbQpAQCAtMTQ3LDkg KzE0NywxNCBAQCBzdGF0aWMgTlNEaWN0aW9uYXJ5ICpudWxsQWN0aW9uc0RpY3Rpb25hcnkoKQog ICAgIE5TRGljdGlvbmFyeSAqYWN0aW9ucyA9IFtOU0RpY3Rpb25hcnkgZGljdGlvbmFyeVdpdGhP YmplY3RzQW5kS2V5czoKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbFZhbHVlLCBA ImFuY2hvclBvaW50IiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbFZhbHVlLCBA ImFuY2hvclBvaW50WiIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG51bGxWYWx1ZSwg QCJiYWNrZ3JvdW5kQ29sb3IiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBudWxsVmFs dWUsIEAiYm9yZGVyQ29sb3IiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBudWxsVmFs dWUsIEAiYm9yZGVyV2lkdGgiLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBudWxsVmFs dWUsIEAiYm91bmRzIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbFZhbHVlLCBA ImNvbnRlbnRzIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbFZhbHVlLCBAImNv bnRlbnRzUmVjdCIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG51bGxWYWx1ZSwgQCJj b250ZW50c1NjYWxlIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbFZhbHVlLCBA ImNvcm5lclJhZGl1cyIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG51bGxWYWx1ZSwg QCJvcGFjaXR5IiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbFZhbHVlLCBAInBv c2l0aW9uIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbnVsbFZhbHVlLCBAInNoYWRv d0NvbG9yIiwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvUmVtb3RlTGF5 ZXJUcmVlUHJvcGVydHlBcHBsaWVyLm1tIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1v dGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIubW0KaW5kZXggODZkMzM0OTQ3NDczZDkzYjkwZWYw ZWZlZjI0NjI1NTdmZDQ0ZTBjOC4uODE1YTEyZDUwMDRmNWNmYTdiOWJiNjZlYjU3MDhkZjcwNDE1 MWIyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1vdGVMYXllclRy ZWVQcm9wZXJ0eUFwcGxpZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9SZW1v dGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIubW0KQEAgLTE2MSw5ICsxNjEsMTQgQEAgdm9pZCBS ZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXI6OmRpc2FibGVBY3Rpb25zRm9yTGF5ZXIoQ0FM YXllciAqbGF5ZXIpCiAgICAgICAgIEAiYWN0aW9ucyIgOiBAewogICAgICAgICAgICAgQCJhbmNo b3JQb2ludCIgOiBudWxsVmFsdWUsCiAgICAgICAgICAgICBAImFuY2hvclBvaW50WiIgOiBudWxs VmFsdWUsCisgICAgICAgICAgICBAImJhY2tncm91bmRDb2xvciIgOiBudWxsVmFsdWUsCisgICAg ICAgICAgICBAImJvcmRlckNvbG9yIiA6IG51bGxWYWx1ZSwKKyAgICAgICAgICAgIEAiYm9yZGVy V2lkdGgiIDogbnVsbFZhbHVlLAogICAgICAgICAgICAgQCJib3VuZHMiIDogbnVsbFZhbHVlLAog ICAgICAgICAgICAgQCJjb250ZW50cyIgOiBudWxsVmFsdWUsCiAgICAgICAgICAgICBAImNvbnRl bnRzUmVjdCIgOiBudWxsVmFsdWUsCisgICAgICAgICAgICBAImNvbnRlbnRzU2NhbGUiIDogbnVs bFZhbHVlLAorICAgICAgICAgICAgQCJjb3JuZXJSYWRpdXMiIDogbnVsbFZhbHVlLAogICAgICAg ICAgICAgQCJvcGFjaXR5IiA6IG51bGxWYWx1ZSwKICAgICAgICAgICAgIEAicG9zaXRpb24iIDog bnVsbFZhbHVlLAogICAgICAgICAgICAgQCJzaGFkb3dDb2xvciIgOiBudWxsVmFsdWUsCg==