123517 2013-10-30 11:12:02 -0700 Remote Layer Tree: Lots of ASSERT(m_children.isEmpty()); on Poster Circle 2013-10-30 11:58:06 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 945045 0 thorton 2013-10-30 11:12:02 -0700 A recently added assertion discovered a bug where our dependence on undefined behavior in CA was causing the layer tree to get into a bad state. We depend on adding a sublayer which already has a parent to another layer, the sublayer is first removed from its parent layer. CA headers say this is undefined behavior (that layers should always have a nil superlayer when being added as a sublayer), but we heavily depend on it being the case. Most of PlatformCALayerRemote behaved correctly, but setSublayers() failed to unparent the incoming layers. 945047 1 215533 thorton 2013-10-30 11:14:17 -0700 Created attachment 215533 patch 945086 2 215542 thorton 2013-10-30 11:50:24 -0700 Created attachment 215542 no reason not to fold it into the existing loop 945098 3 thorton 2013-10-30 11:58:06 -0700 http://trac.webkit.org/changeset/158297 215533 2013-10-30 11:14:17 -0700 2013-10-30 11:50:24 -0700 patch remove.diff text/plain 1381 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NzlmMjhhLi4xYzM1Y2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMTAtMzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3RlIExheWVyIFRyZWU6IExvdHMgb2YgQVNTRVJUKG1fY2hpbGRyZW4uaXNF bXB0eSgpKTsgb24gUG9zdGVyIENpcmNsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXll clJlbW90ZS5jcHA6CisgICAgICAgIChQbGF0Zm9ybUNBTGF5ZXJSZW1vdGU6OnNldFN1YmxheWVy cyk6CisgICAgICAgIFdoZW4gc2V0dGluZyBvdXIgbGlzdCBvZiBzdWJsYXllcnMsIHJlbW92ZSBh bGwgb2YgdGhlIG5ldyBsYXllcnMgZnJvbQorICAgICAgICB0aGVpciBwYXJlbnRzIGZpcnN0Lgor CiAyMDEzLTEwLTI5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAg IFtNU0VdIFtNYWNdIEVuYWJsZSBNZWRpYVNvdXJjZSBvbiB0aGUgTWFjCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90 ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FM YXllclJlbW90ZS5jcHAKaW5kZXggOTU4Zjg3Ni4uMTk1MDllNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxh eWVyUmVtb3RlLmNwcApAQCAtMTY1LDYgKzE2NSwxMCBAQCB2b2lkIFBsYXRmb3JtQ0FMYXllclJl bW90ZTo6cmVtb3ZlU3VibGF5ZXIoUGxhdGZvcm1DQUxheWVyUmVtb3RlKiBsYXllcikKIHZvaWQg UGxhdGZvcm1DQUxheWVyUmVtb3RlOjpzZXRTdWJsYXllcnMoY29uc3QgUGxhdGZvcm1DQUxheWVy TGlzdCYgbGlzdCkKIHsKICAgICByZW1vdmVBbGxTdWJsYXllcnMoKTsKKworICAgIGZvciAoY29u c3QgYXV0byYgbGF5ZXIgOiBsaXN0KQorICAgICAgICBsYXllci0+cmVtb3ZlRnJvbVN1cGVybGF5 ZXIoKTsKKwogICAgIG1fY2hpbGRyZW4gPSBsaXN0OwogCiAgICAgZm9yIChjb25zdCBhdXRvJiBs YXllciA6IGxpc3QpCg== 215542 2013-10-30 11:50:24 -0700 2013-10-30 11:52:04 -0700 no reason not to fold it into the existing loop remove.diff text/plain 1468 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NzlmMjhhLi4xYzM1Y2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMTAtMzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3RlIExheWVyIFRyZWU6IExvdHMgb2YgQVNTRVJUKG1fY2hpbGRyZW4uaXNF bXB0eSgpKTsgb24gUG9zdGVyIENpcmNsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXll clJlbW90ZS5jcHA6CisgICAgICAgIChQbGF0Zm9ybUNBTGF5ZXJSZW1vdGU6OnNldFN1YmxheWVy cyk6CisgICAgICAgIFdoZW4gc2V0dGluZyBvdXIgbGlzdCBvZiBzdWJsYXllcnMsIHJlbW92ZSBh bGwgb2YgdGhlIG5ldyBsYXllcnMgZnJvbQorICAgICAgICB0aGVpciBwYXJlbnRzIGZpcnN0Lgor CiAyMDEzLTEwLTI5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAg IFtNU0VdIFtNYWNdIEVuYWJsZSBNZWRpYVNvdXJjZSBvbiB0aGUgTWFjCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FMYXllclJlbW90 ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BsYXRmb3JtQ0FM YXllclJlbW90ZS5jcHAKaW5kZXggOTU4Zjg3Ni4uZWU5YzU4NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvUGxhdGZvcm1DQUxh eWVyUmVtb3RlLmNwcApAQCAtMTY3LDggKzE2NywxMCBAQCB2b2lkIFBsYXRmb3JtQ0FMYXllclJl bW90ZTo6c2V0U3VibGF5ZXJzKGNvbnN0IFBsYXRmb3JtQ0FMYXllckxpc3QmIGxpc3QpCiAgICAg cmVtb3ZlQWxsU3VibGF5ZXJzKCk7CiAgICAgbV9jaGlsZHJlbiA9IGxpc3Q7CiAKLSAgICBmb3Ig KGNvbnN0IGF1dG8mIGxheWVyIDogbGlzdCkKKyAgICBmb3IgKGNvbnN0IGF1dG8mIGxheWVyIDog bGlzdCkgeworICAgICAgICBsYXllci0+cmVtb3ZlRnJvbVN1cGVybGF5ZXIoKTsKICAgICAgICAg dG9QbGF0Zm9ybUNBTGF5ZXJSZW1vdGUobGF5ZXIuZ2V0KCkpLT5tX3N1cGVybGF5ZXIgPSB0aGlz OworICAgIH0KIAogICAgIG1fcHJvcGVydGllcy5ub3RlUHJvcGVydGllc0NoYW5nZWQoUmVtb3Rl TGF5ZXJUcmVlVHJhbnNhY3Rpb246OkNoaWxkcmVuQ2hhbmdlZCk7CiB9Cg==