123496 2013-10-29 23:49:15 -0700 Unguard Element::childShouldCreateRenderer 2013-10-30 10:19:26 -0700 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 changseok changseok cmarcelo commit-queue esprehn+autocc kangil.han kling oldest_to_newest 944796 0 changseok 2013-10-29 23:49:15 -0700 The declaration of 1Element::childShouldCreateRenderer is guarded with MATHML and SVG. But it causes a link error when disabling svg because of missing MATHML flag for the definition of Element::childShouldCreateRenderer. Even we add a MATHML flag for it, you would face a compile error caused by SVGNames. we could avoid it like following but I think it's an abuse of flags. #if ENABLE(SVG) || ENABLE(MATHML) bool Element::childShouldCreateRenderer(const Node* child) const { #if ENABLE(SVG) // Only create renderers for SVG elements whose parents are SVG elements, or for proper <svg xmlns="svgNS"> subdocuments. if (child->isSVGElement()) return child->hasTagName(SVGNames::svgTag) || isSVGElement(); #endif return ContainerNode::childShouldCreateRenderer(child); } So I propose removing the two guards from Element::childShouldCreateRenderer. I believe there would be no harm. 944809 1 215477 changseok 2013-10-30 00:47:13 -0700 Created attachment 215477 Patch 944964 2 215477 commit-queue 2013-10-30 10:19:24 -0700 Comment on attachment 215477 Patch Clearing flags on attachment: 215477 Committed r158275: <http://trac.webkit.org/changeset/158275> 944965 3 commit-queue 2013-10-30 10:19:26 -0700 All reviewed patches have been landed. Closing bug. 215477 2013-10-30 00:47:13 -0700 2013-10-30 10:19:24 -0700 Patch bug-123496-20131030164711.patch text/plain 2352 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4MjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQwY2ExNzQ1ZWFiNjQ0 OTk3NWVhZmEwZDJhZjM2NjdhNmY3ZjdhOC4uZGFiY2Y2ZDAxMzMwYjIwNTIxNjMwNTJkODk0ZGFi MmU0ZDZiMjc0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEwLTMwICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBVbmd1YXJk IEVsZW1lbnQ6OmNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVyZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzQ5NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVh dGVSZW5kZXJlciBub3JtYWxseSBhY2Nlc3NpYmxlLiBHdWFyZGluZyBpdCB3aXRoIGZsYWdzCisg ICAgICAgIGp1c3QgbGVhdmVzIHBvdGVudGlhbCBidWlsZCBpc3N1ZXMuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzIHNpbmNlIG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIGRv bS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVsZW1lbnQ6OmNoaWxkU2hvdWxkQ3Jl YXRlUmVuZGVyZXIpOgorICAgICAgICAqIGRvbS9FbGVtZW50Lmg6CisKIDIwMTMtMTAtMjkgIEFu ZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEVsZW1lbnREYXRhIGNv bnN0cnVjdGlvbiBoZWxwZXJzIHNob3VsZCByZXR1cm4gUGFzc1JlZi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50 LmNwcAppbmRleCAxOGMxZWQ1MjZhZmI0M2E2MWFmN2U2ZTAyZjQwOWFlYTFlODA3ZjFmLi44OWZh ZGYyNzI3ODM1NDJiY2ViYmM3ZThhMmQ5YTliZjg0NDY0YTIzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQu Y3BwCkBAIC0yNjE5LDE3ICsyNjE5LDE1IEBAIGNvbnN0IEF0b21pY1N0cmluZyYgRWxlbWVudDo6 VUlBY3Rpb25zKCkgY29uc3QKIH0KICNlbmRpZgogCi0gICAgCi0jaWYgRU5BQkxFKFNWRykKIGJv b2wgRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVhdGVSZW5kZXJlcihjb25zdCBOb2RlKiBjaGlsZCkg Y29uc3QKIHsKKyNpZiBFTkFCTEUoU1ZHKQogICAgIC8vIE9ubHkgY3JlYXRlIHJlbmRlcmVycyBm b3IgU1ZHIGVsZW1lbnRzIHdob3NlIHBhcmVudHMgYXJlIFNWRyBlbGVtZW50cywgb3IgZm9yIHBy b3BlciA8c3ZnIHhtbG5zPSJzdmdOUyI+IHN1YmRvY3VtZW50cy4KICAgICBpZiAoY2hpbGQtPmlz U1ZHRWxlbWVudCgpKQogICAgICAgICByZXR1cm4gY2hpbGQtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6 OnN2Z1RhZykgfHwgaXNTVkdFbGVtZW50KCk7Ci0KKyNlbmRpZgogICAgIHJldHVybiBDb250YWlu ZXJOb2RlOjpjaGlsZFNob3VsZENyZWF0ZVJlbmRlcmVyKGNoaWxkKTsKIH0KLSNlbmRpZgogCiAj aWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogdm9pZCBFbGVtZW50Ojp3ZWJraXRSZXF1ZXN0RnVs bHNjcmVlbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCBlZjRjZDQxODgxMzRjYzQ0NTA4OTdiYTU3 MDVlNjEzYzM1ZmIwZTkyLi5kNzczZThiYTVjZWI0ODVmNmJlYWFmNjczZWFmNzg1NjZjNzcxN2Qy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAgLTQ3OSwxMCArNDc5LDggQEAgcHVibGljOgogICAgIC8v IHRvIGV2ZW50IGxpc3RlbmVycywgYW5kIHByZXZlbnRzIERPTUFjdGl2YXRlIGV2ZW50cyBmcm9t IGJlaW5nIHNlbnQgYXQgYWxsLgogICAgIHZpcnR1YWwgYm9vbCBpc0Rpc2FibGVkRm9ybUNvbnRy b2woKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogCi0KLSNpZiBFTkFCTEUoU1ZHKSB8fCBFTkFC TEUoTUFUSE1MKQogICAgIHZpcnR1YWwgYm9vbCBjaGlsZFNob3VsZENyZWF0ZVJlbmRlcmVyKGNv bnN0IE5vZGUqKSBjb25zdCBPVkVSUklERTsKLSNlbmRpZgorCiAjaWYgRU5BQkxFKFNWRykKICAg ICBib29sIGhhc1BlbmRpbmdSZXNvdXJjZXMoKSBjb25zdDsKICAgICB2b2lkIHNldEhhc1BlbmRp bmdSZXNvdXJjZXMoKTsK