123488 2013-10-29 20:08:48 -0700 Mavericks: 128 tests are failing due to pixel differences 2013-10-30 11:16:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa ap ap mitz simon.fraser thorton oldest_to_newest 944737 0 rniwa 2013-10-29 20:08:48 -0700 http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r158244%20(215)/results.html We're missing some black border on this one: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r158244%20(215)/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004-diffs.html Similarly, http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r158244%20(215)/css2.1/20110323/overflow-applies-to-010-diffs.html 944744 1 thorton 2013-10-29 20:31:26 -0700 This looks a lot like the issue that led to http://trac.webkit.org/changeset/155683 and related patches again... 944753 2 rniwa 2013-10-29 21:14:09 -0700 So these failures don't exist on debug builder: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29 I'm not sure why these failure are only visible on release builds. 944984 3 215522 ap 2013-10-30 10:31:35 -0700 Created attachment 215522 proposed fix 945029 4 ap 2013-10-30 11:03:04 -0700 Committed <http://trac.webkit.org/r158290>. 945048 5 ap 2013-10-30 11:16:22 -0700 Oh, and I threw AppleLanguages into the mix because I happened to know that it's also read during NSApplication initialization, and some effects of that are persistent. 215522 2013-10-30 10:31:35 -0700 2013-10-30 10:54:12 -0700 proposed fix CFPreferences.txt text/plain 4968 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1ODI3NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDEzLTEwLTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE1hdmVyaWNrczogMTI4IHRlc3RzIGFyZSBmYWlsaW5nIGR1ZSB0byBwaXhl bCBkaWZmZXJlbmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIzNDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXBwbGUgZm9udCBwcmVmZXJlbmNlcyBjYW5ub3QgYmUgZnVsbHkgcmVzZXQgYWZ0ZXIg dGhleSd2ZSBiZWVuIHJlYWQsIHNvIHdlCisgICAgICAgIG5lZWQgdG8gc2V0IHRoZW0gdXNpbmcg Q0ZQcmVmZXJlbmNlcyBiZWZvcmUgaW5pdGlhbGl6aW5nIE5TQXBwbGljYXRpb24uCisKKyAgICAg ICAgSW4gdGhlb3J5LCB0aGlzIHNob3VsZCBiZSBhbiBpc3N1ZSBvbiBXZWJLaXQyIGFzIHdlbGws IGJ1dCBzb21laG93IGl0IGRvZXNuJ3QKKyAgICAgICAgYXBwZWFyIHRvIGJlLiBJIGd1ZXNzIHdl IGNhbiBmaWd1cmUgb3V0IHRoZSByZWFzb25zIGZvciB0aGlzIGRpZmZlcmVuY2Ugd2hlbi9pZgor ICAgICAgICBhbnkgb2JzZXJ2YWJsZSBwcm9ibGVtcyBzdGFydCB0byBvY2N1ci4KKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbToKKyAgICAgICAgKHNldERl ZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzRm9yVGVzdGluZyk6IE9ubHkgc2V0IGRlZmF1bHRzIGhl cmUsIG1vdmUgb3RoZXIgd29yaworICAgICAgICB0byBwcmVwYXJlQ29uc2lzdGVudFRlc3RpbmdF bnZpcm9ubWVudCgpLgorICAgICAgICAobWFpbik6IENhbGwgc2V0RGVmYXVsdHNUb0NvbnNpc3Rl bnRWYWx1ZXNGb3JUZXN0aW5nIGJlZm9yZSBbTlNBcHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlv bl0KKyAgICAgICAgKHdoaWNoIGlzIHVubmVjZXNzYXJ5IGFueXdheSBzaW5jZSBOU1VzZXJEZWZh dWx0cyB3aWxsIGltcGxpY2l0bHkgY2FsbCBpdCwgYnV0IHNlZW1zCisgICAgICAgIHVzZWZ1bCB0 byBrZWVwIGluIGNhc2Ugd2UgY2hhbmdlIG91dCBhcHByb2FjaCB0byBkZWZhdWx0cyBhZ2Fpbiku CisKIDIwMTMtMTAtMzAgIFJvYmVydCBQbG9jaWVubmlrICA8ci5wbG9jaWVubmlrQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFtFRkxdIGFjY2Vzc2liaWxpdHkvdGV4dGFyZWEtc2VsZWN0ZWQtdGV4 dC1yYW5nZS5odG1sIGlzIGZhaWxpbmcKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9E dW1wUmVuZGVyVHJlZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMv RHVtcFJlbmRlclRyZWUubW0JKHJldmlzaW9uIDE1ODIzNykKKysrIFRvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQkod29ya2luZyBjb3B5KQpAQCAtNjc2LDEyICs2NzYs MTUgQEAgc3RhdGljIHZvaWQgcmVzZXRXZWJQcmVmZXJlbmNlc1RvQ29uc2lzdAogLy8gQ2FsbGVk IG9uY2Ugb24gRHVtcFJlbmRlclRyZWUgc3RhcnR1cC4KIHN0YXRpYyB2b2lkIHNldERlZmF1bHRz VG9Db25zaXN0ZW50VmFsdWVzRm9yVGVzdGluZygpCiB7Ci0gICAgLy8gRklYTUU6IFdlJ2QgbGlr ZSB0byBzdGFydCB3aXRoIGEgY2xlYW4gc3RhdGUgZm9yIGV2ZXJ5IHRlc3QsIGJ1dCB0aGlzIGZ1 bmN0aW9uIGNhbid0IGJlIHVzZWQgbW9yZSB0aGFuIG9uY2UgeWV0LgotICAgIFtXZWJQcmVmZXJl bmNlcyBfc3dpdGNoTmV0d29ya0xvYWRlclRvTmV3VGVzdGluZ1Nlc3Npb25dOwotCiAgICAgc3Rh dGljIGNvbnN0IGludCBOb0ZvbnRTbW9vdGhpbmcgPSAwOwogICAgIHN0YXRpYyBjb25zdCBpbnQg Qmx1ZVRpbnRlZEFwcGVhcmFuY2UgPSAxOwogCisgICAgLy8gVGhlc2UgZGVmYXVsdHMgYXJlIHJl YWQgYXQgTlNBcHBsaWNhdGlvbiBpbml0aWFsaXphdGlvbiB0aW1lLCBhbmQgdGhlcmUgaXMgbm8g d2F5IHRvIGZ1bGx5IHJlc2V0IHRoZW0gYWZ0ZXJ3YXJkcy4KKyAgICAvLyBXZSBoYXZlIHRvIHVz ZSBDRlByZWZlcmVuY2VzLCBiZWNhdXNlIFtOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZh dWx0c10gaW5kaXJlY3RseSBpbml0aWFsaXplcyBOU0FwcGxpY2F0aW9uLgorICAgIENGUHJlZmVy ZW5jZXNTZXRBcHBWYWx1ZShDRlNUUigiQXBwbGVGb250U21vb3RoaW5nIiksIChDRk51bWJlclJl ZilAKE5vRm9udFNtb290aGluZyksIGtDRlByZWZlcmVuY2VzQ3VycmVudEFwcGxpY2F0aW9uKTsK KyAgICBDRlByZWZlcmVuY2VzU2V0QXBwVmFsdWUoQ0ZTVFIoIkFwcGxlQW50aUFsaWFzaW5nVGhy ZXNob2xkIiksIChDRk51bWJlclJlZilANCwga0NGUHJlZmVyZW5jZXNDdXJyZW50QXBwbGljYXRp b24pOworICAgIENGUHJlZmVyZW5jZXNTZXRBcHBWYWx1ZShDRlNUUigiQXBwbGVMYW5ndWFnZXMi KSwgKENGQXJyYXlSZWYpQFsgQCJlbiIgXSwga0NGUHJlZmVyZW5jZXNDdXJyZW50QXBwbGljYXRp b24pOworCiAgICAgTlNTdHJpbmcgKmxpYnJhcnlQYXRoID0gbGlicmFyeVBhdGhGb3JEdW1wUmVu ZGVyVHJlZSgpOwogCiAgICAgTlNEaWN0aW9uYXJ5ICpkaWN0ID0gQHsKQEAgLTcxMywxNyArNzE2 LDYgQEAgc3RhdGljIHZvaWQgc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZQogICAgIH07CiAK ICAgICBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBzZXRWb2xhdGlsZURv bWFpbjpkaWN0IGZvck5hbWU6TlNBcmd1bWVudERvbWFpbl07Ci0KLSAgICAvLyBVbmRlcmx5aW5n IGZyYW1ld29ya3MgaGF2ZSBhbHJlYWR5IHJlYWQgQXBwbGVBbnRpQWxpYXNpbmdUaHJlc2hvbGQg ZGVmYXVsdCBiZWZvcmUgd2UgY2hhbmdlZCBpdC4KLSAgICAvLyBBIGRpc3RyaWJ1dGVkIG5vdGlm aWNhdGlvbiBpcyBkZWxpdmVyZWQgdG8gYWxsIGFwcGxpY2F0aW9ucywgYnV0IGl0IHNob3VsZCBi ZSBoYXJtbGVzcywgYW5kIGl0J3MgdGhlIG9ubHkgd2F5IHRvIHVwZGF0ZSBhbGwgdW5kZXJseWlu ZyBmcmFtZXdvcmtzIGFueXdheS4KLSAgICBbW05TRGlzdHJpYnV0ZWROb3RpZmljYXRpb25DZW50 ZXIgZGVmYXVsdENlbnRlcl0gcG9zdE5vdGlmaWNhdGlvbk5hbWU6QCJBcHBsZUFxdWFBbnRpQWxp YXNpbmdDaGFuZ2VkIiBvYmplY3Q6bmlsIHVzZXJJbmZvOm5pbCBkZWxpdmVySW1tZWRpYXRlbHk6 WUVTXTsKLQotICAgIE5TVVJMQ2FjaGUgKnNoYXJlZENhY2hlID0KLSAgICAgICAgW1tOU1VSTENh Y2hlIGFsbG9jXSBpbml0V2l0aE1lbW9yeUNhcGFjaXR5OjEwMjQgKiAxMDI0Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRpc2tDYXBhY2l0eTowCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXNrUGF0aDpbbGlicmFyeVBhdGggc3RyaW5n QnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OkAiVVJMQ2FjaGUiXV07Ci0gICAgW05TVVJMQ2FjaGUg c2V0U2hhcmVkVVJMQ2FjaGU6c2hhcmVkQ2FjaGVdOwotICAgIFtzaGFyZWRDYWNoZSByZWxlYXNl XTsKIH0KIAogc3RhdGljIHZvaWQgcnVuVGhyZWFkKHZvaWQqIGFyZykKQEAgLTg0Nyw3ICs4Mzks MTYgQEAgc3RhdGljIHZvaWQgcHJlcGFyZUNvbnNpc3RlbnRUZXN0aW5nRW52aQogICAgIHBvc2VB c0NsYXNzKCJEdW1wUmVuZGVyVHJlZVBhc3RlYm9hcmQiLCAiTlNQYXN0ZWJvYXJkIik7CiAgICAg cG9zZUFzQ2xhc3MoIkR1bXBSZW5kZXJUcmVlRXZlbnQiLCAiTlNFdmVudCIpOwogCi0gICAgc2V0 RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXNGb3JUZXN0aW5nKCk7CisgICAgLy8gRklYTUU6IFdl J2QgbGlrZSB0byBzdGFydCB3aXRoIGEgY2xlYW4gc3RhdGUgZm9yIGV2ZXJ5IHRlc3QsIGJ1dCB0 aGlzIGZ1bmN0aW9uIGNhbid0IGJlIHVzZWQgbW9yZSB0aGFuIG9uY2UgeWV0LgorICAgIFtXZWJQ cmVmZXJlbmNlcyBfc3dpdGNoTmV0d29ya0xvYWRlclRvTmV3VGVzdGluZ1Nlc3Npb25dOworCisg ICAgTlNVUkxDYWNoZSAqc2hhcmVkQ2FjaGUgPQorICAgICAgICBbW05TVVJMQ2FjaGUgYWxsb2Nd IGluaXRXaXRoTWVtb3J5Q2FwYWNpdHk6MTAyNCAqIDEwMjQKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZGlza0NhcGFjaXR5OjAKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGRpc2tQYXRoOltsaWJyYXJ5UGF0aEZvckR1bXBSZW5kZXJUcmVl KCkgc3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OkAiVVJMQ2FjaGUiXV07CisgICAgW05T VVJMQ2FjaGUgc2V0U2hhcmVkVVJMQ2FjaGU6c2hhcmVkQ2FjaGVdOworICAgIFtzaGFyZWRDYWNo ZSByZWxlYXNlXTsKKwogICAgIGFkanVzdEZvbnRzKCk7CiAgICAgcmVnaXN0ZXJNb2NrU2Nyb2xs YmFycygpOwogICAgIApAQCAtOTI5LDYgKzkzMCw5IEBAIHZvaWQgZHVtcFJlbmRlclRyZWUoaW50 IGFyZ2MsIGNvbnN0IGNoYXIKIGludCBtYWluKGludCBhcmdjLCBjb25zdCBjaGFyICphcmd2W10p CiB7CiAgICAgTlNBdXRvcmVsZWFzZVBvb2wgKnBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29sIGFs bG9jXSBpbml0XTsKKworICAgIHNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzRm9yVGVzdGlu ZygpOyAvLyBNdXN0IGJlIGNhbGxlZCBiZWZvcmUgTlNBcHBsaWNhdGlvbiBpbml0aWFsaXphdGlv bi4KKwogICAgIFtEdW1wUmVuZGVyVHJlZUFwcGxpY2F0aW9uIHNoYXJlZEFwcGxpY2F0aW9uXTsg Ly8gRm9yY2UgQXBwS2l0IHRvIGluaXQgaXRzZWxmCiAKICAgICBkdW1wUmVuZGVyVHJlZShhcmdj LCBhcmd2KTsK