123468 2013-10-29 14:19:13 -0700 Web Inspector: font-family names interpreted as color 2015-06-11 13:52:04 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Mac (Intel) Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andreas.eldh webkit-unassigned commit-queue joepeck timothy webkit-bug-importer oldest_to_newest 944606 0 andreas.eldh 2013-10-29 14:19:13 -0700 I had "Crimson Text" as the font-family on body, and the word "Crimson" was treated as a color, with a red (crimson?) square next to it. Using Safari 7.0 (9537.71) on OS X Mavericks. 944607 1 webkit-bug-importer 2013-10-29 14:19:38 -0700 <rdar://problem/15345003> 944608 2 215427 andreas.eldh 2013-10-29 14:20:07 -0700 Created attachment 215427 Screenshot 944644 3 joepeck 2013-10-29 15:18:15 -0700 Heh. Well, to extend the "short term fix" we have in CSSStyleDeclarationTextEditor we have: // Act as a negative look-behind and disallow the color from being prefixing with certain characters. if (match.index > 0 && /[-.]/.test(lineContent[match.index - 1])) { match = colorRegex.exec(lineContent); continue; } We could include ['"] in that list of negative look-behind characters. But that wouldn't help "Foo Red Bar". 944645 4 joepeck 2013-10-29 15:20:49 -0700 Now that I think about it, we have CodeMirror's tokenizer right now, but we are still regex checking lines: var lineContent = this._codeMirror.getLine(i); var match = colorRegex.exec(lineContent); … I think we be could just iterate over tokens instead of running the regex on the line? 944669 5 timothy 2013-10-29 16:24:07 -0700 (In reply to comment #4) > Now that I think about it, we have CodeMirror's tokenizer right now, but we are still regex checking lines: > > var lineContent = this._codeMirror.getLine(i); > var match = colorRegex.exec(lineContent); > … > > I think we be could just iterate over tokens instead of running the regex on the line? That would work for color words and hex, but will need to have extra logic for rgb, etc. 1101097 6 254674 hi 2015-06-10 13:31:43 -0700 Created attachment 254674 Patch 1101404 7 254674 commit-queue 2015-06-11 13:52:00 -0700 Comment on attachment 254674 Patch Clearing flags on attachment: 254674 Committed r185471: <http://trac.webkit.org/changeset/185471> 1101405 8 commit-queue 2015-06-11 13:52:04 -0700 All reviewed patches have been landed. Closing bug. 215427 2013-10-29 14:20:07 -0700 2013-10-29 14:20:07 -0700 Screenshot Screenshot 2013-10-29 22.08.59.png image/png 0 andreas.eldh 254674 2015-06-10 13:31:43 -0700 2015-06-11 13:52:00 -0700 Patch bug-123468-20150610133115.patch text/plain 1623 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY0M2M3ZWE2MjkwOTRhNjc2M2Y0OGFlODBjMWYz Y2QzODcyMzVmNzcuLjZjMDViNWUzNWExMzllMWY0MTA0ZDBjNWI2NDJjMTRiYWQ2ODFmMzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA2LTEwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBm b250LWZhbWlseSBuYW1lcyBpbnRlcnByZXRlZCBhcyBjb2xvcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDY4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVN aXJyb3JBZGRpdGlvbnMuanM6IEFkZGVkIGxvZ2ljIHRvIHByZXZlbnQgY29sb3IgcGlja2VyIGJ1 dHRvbnMgZnJvbSBhcHBlYXJpbmcgYmVmb3JlIGNvbG9ycyB0aGF0IGNvbWUgYWZ0ZXIgYSBxdW90 ZSBjaGFyYWN0ZXIgKGJvdGggIiBhbmQgJykuCisKIDIwMTUtMDYtMDggIE1hdHQgQmFrZXIgIDxt YXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsZWFyaW5nIGFj dGl2ZSBUaW1lbGluZSByZWNvcmRpbmcgc2hvdWxkIHN0b3AgY2FwdHVyaW5nCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yQWRk aXRpb25zLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29k ZU1pcnJvckFkZGl0aW9ucy5qcwppbmRleCBiMmJiMTc4MDUyYWQ0NDVhMmFkZDBiYWFiM2U1ZjJi Y2JiNmVlNjQwLi44NjQ3YzRmMWJiYjhkZjdkM2FjZDQzODI4MGFlMWQ5NGQyMjkxNzgzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWly cm9yQWRkaXRpb25zLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvZGVNaXJyb3JBZGRpdGlvbnMuanMKQEAgLTUxMSw3ICs1MTEsNyBAQAogICAgICAg ICAgICAgd2hpbGUgKG1hdGNoKSB7CiAKICAgICAgICAgICAgICAgICAvLyBBY3QgYXMgYSBuZWdh dGl2ZSBsb29rLWJlaGluZCBhbmQgZGlzYWxsb3cgdGhlIGNvbG9yIGZyb20gYmVpbmcgcHJlZml4 aW5nIHdpdGggY2VydGFpbiBjaGFyYWN0ZXJzLgotICAgICAgICAgICAgICAgIGlmIChtYXRjaC5p bmRleCA+IDAgJiYgL1stLl0vLnRlc3QobGluZUNvbnRlbnRbbWF0Y2guaW5kZXggLSAxXSkpIHsK KyAgICAgICAgICAgICAgICBpZiAobWF0Y2guaW5kZXggPiAwICYmIC9bLS5cIlwnXS8udGVzdChs aW5lQ29udGVudFttYXRjaC5pbmRleCAtIDFdKSkgewogICAgICAgICAgICAgICAgICAgICBtYXRj aCA9IGNvbG9yUmVnZXguZXhlYyhsaW5lQ29udGVudCk7CiAgICAgICAgICAgICAgICAgICAgIGNv bnRpbnVlOwogICAgICAgICAgICAgICAgIH0K