123465 2013-10-29 13:58:49 -0700 Use left/right instead of left/width for simple text runs 2023-04-04 03:45:49 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned ahmad.saleem792 commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 944591 0 koivisto 2013-10-29 13:58:49 -0700 This simplifies the code a bit. 944595 1 215423 koivisto 2013-10-29 14:01:04 -0700 Created attachment 215423 patch 1946489 2 ahmad.saleem792 2023-04-04 03:45:49 -0700 Landed - https://github.com/WebKit/WebKit/commit/07f341ee42533dce30402155e482a79c0bf87827 215423 2013-10-29 14:01:04 -0700 2013-10-29 14:19:35 -0700 patch simple-line-right.patch text/plain 4089 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODIyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTEwLTI5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgbGVmdC9yaWdodCBpbnN0 ZWFkIG9mIGxlZnQvd2lkdGggZm9yIHNpbXBsZSB0ZXh0IHJ1bnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzQ2NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgc2ltcGxpZmllcyB0aGUgY29kZSBh IGJpdC4KKworICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OmFkanVzdFJ1bk9mZnNldHMpOgorICAgICAg ICAoV2ViQ29yZTo6U2ltcGxlTGluZUxheW91dDo6Y3JlYXRlKToKKyAgICAgICAgKiByZW5kZXJp bmcvU2ltcGxlTGluZUxheW91dC5oOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlTGluZUxheW91 dDo6UnVuOjpSdW4pOgorICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0UmVzb2x2 ZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OlJ1blJlc29sdmVyOjpS dW46OnJlY3QpOgorCiAyMDEzLTEwLTI5ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgogCiAgICAgICAgIFtNYWMgTWVkaWFTdHJlYW1dIGltcGxlbWVudCBBVkZvdW5kYXRp b24gYmFja2VkIE1lZGlhU3RyZWFtU291cmNlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvU2ltcGxlTGluZUxheW91dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCShyZXZpc2lvbiAxNTgyMTQpCisrKyBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIyNywxMCArMjI3LDggQEAgc3RhdGljIHZvaWQgYWRqdXN0UnVuT2Zmc2V0cyhWZWN0b3I8UnVu LAogewogICAgIGZsb2F0IGxpbmVMZWZ0ID0gY29tcHV0ZUxpbmVMZWZ0KHRleHRBbGlnbiwgYXZh aWxhYmxlV2lkdGggLSBsaW5lV2lkdGgpOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBs aW5lUnVucy5zaXplKCk7ICsraSkgewotICAgICAgICBmbG9hdCBhZGp1c3RlZExlZnQgPSBmbG9v cihsaW5lTGVmdCArIGxpbmVSdW5zW2ldLmxlZnQpOwotICAgICAgICBmbG9hdCBhZGp1c3RlZFJp Z2h0ID0gY2VpbChsaW5lTGVmdCArIGxpbmVSdW5zW2ldLmxlZnQgKyBsaW5lUnVuc1tpXS53aWR0 aCk7Ci0gICAgICAgIGxpbmVSdW5zW2ldLmxlZnQgPSBhZGp1c3RlZExlZnQ7Ci0gICAgICAgIGxp bmVSdW5zW2ldLndpZHRoID0gYWRqdXN0ZWRSaWdodCAtIGFkanVzdGVkTGVmdDsKKyAgICAgICAg bGluZVJ1bnNbaV0ubGVmdCA9IGZsb29yKGxpbmVMZWZ0ICsgbGluZVJ1bnNbaV0ubGVmdCk7Cisg ICAgICAgIGxpbmVSdW5zW2ldLnJpZ2h0ID0gY2VpbChsaW5lTGVmdCArIGxpbmVSdW5zW2ldLnJp Z2h0KTsKICAgICB9CiB9CiAKQEAgLTI5MywxNSArMjkxLDE1IEBAIHN0ZDo6dW5pcXVlX3B0cjxM YXlvdXQ+IGNyZWF0ZShSZW5kZXJCbG8KICAgICAgICAgICAgICAgICBBU1NFUlQocHJldmlvdXNX YXNTcGFjZUJldHdlZW5Xb3Jkcyk7CiAgICAgICAgICAgICAgICAgLy8gSW5jbHVkZSBzcGFjZSB0 byB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cyBydW4uCiAgICAgICAgICAgICAgICAgbGluZVJ1bnMu bGFzdCgpLnRleHRMZW5ndGgrKzsKLSAgICAgICAgICAgICAgICBsaW5lUnVucy5sYXN0KCkud2lk dGggKz0gd29yZFRyYWlsaW5nU3BhY2VXaWR0aDsKKyAgICAgICAgICAgICAgICBsaW5lUnVucy5s YXN0KCkucmlnaHQgKz0gd29yZFRyYWlsaW5nU3BhY2VXaWR0aDsKICAgICAgICAgICAgICAgICAv LyBTdGFydCBhIG5ldyBydW4gb24gdGhlIHNhbWUgbGluZS4KLSAgICAgICAgICAgICAgICBmbG9h dCBwcmV2aW91c1JpZ2h0ID0gbGluZVJ1bnMubGFzdCgpLmxlZnQgKyBsaW5lUnVucy5sYXN0KCku d2lkdGg7CisgICAgICAgICAgICAgICAgZmxvYXQgcHJldmlvdXNSaWdodCA9IGxpbmVSdW5zLmxh c3QoKS5yaWdodDsKICAgICAgICAgICAgICAgICBsaW5lUnVucy5hcHBlbmQoUnVuKHdvcmRTdGFy dE9mZnNldCArIDEsIHByZXZpb3VzUmlnaHQpKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAg ICAgbGluZVdpZHRoLmNvbW1pdCgpOwogCi0gICAgICAgICAgICBsaW5lUnVucy5sYXN0KCkud2lk dGggPSBsaW5lV2lkdGguY29tbWl0dGVkV2lkdGgoKSAtIGxpbmVSdW5zLmxhc3QoKS5sZWZ0Owor ICAgICAgICAgICAgbGluZVJ1bnMubGFzdCgpLnJpZ2h0ID0gbGluZVdpZHRoLmNvbW1pdHRlZFdp ZHRoKCk7CiAgICAgICAgICAgICBsaW5lUnVucy5sYXN0KCkudGV4dExlbmd0aCA9IHdvcmRFbmRP ZmZzZXQgLSBsaW5lUnVucy5sYXN0KCkudGV4dE9mZnNldDsKIAogICAgICAgICAgICAgbGluZUVu ZE9mZnNldCA9IHdvcmRFbmRPZmZzZXQ7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv U2ltcGxlTGluZUxheW91dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9TaW1wbGVMaW5lTGF5b3V0LmgJKHJldmlzaW9uIDE1ODIxNCkKKysrIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDE0ICs0 OCwxNCBAQCBzdHJ1Y3QgUnVuIHsKICAgICAgICAgLCB0ZXh0TGVuZ3RoKDApCiAgICAgICAgICwg aXNFbmRPZkxpbmUoZmFsc2UpCiAgICAgICAgICwgbGVmdChsZWZ0KQotICAgICAgICAsIHdpZHRo KDApCisgICAgICAgICwgcmlnaHQobGVmdCkKICAgICB7IH0KIAogICAgIHVuc2lnbmVkIHRleHRP ZmZzZXQ7CiAgICAgdW5zaWduZWQgdGV4dExlbmd0aCA6IDMxOwogICAgIHVuc2lnbmVkIGlzRW5k T2ZMaW5lIDogMTsKICAgICBmbG9hdCBsZWZ0OwotICAgIGZsb2F0IHdpZHRoOworICAgIGZsb2F0 IHJpZ2h0OwogfTsKIAogc3RydWN0IExheW91dCB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvU2ltcGxlTGluZUxheW91dFJlc29sdmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXRSZXNvbHZlci5oCShyZXZpc2lvbiAxNTgy MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dFJlc29sdmVy LmgJKHdvcmtpbmcgY29weSkKQEAgLTEzMSw3ICsxMzEsNyBAQCBpbmxpbmUgTGF5b3V0UmVjdCBS dW5SZXNvbHZlcjo6UnVuOjpyZWN0CiAgICAgYXV0byYgcnVuID0gbV9pdGVyYXRvci5zaW1wbGVS dW4oKTsKIAogICAgIExheW91dFBvaW50IGxpbmVQb3NpdGlvbihydW4ubGVmdCwgcmVzb2x2ZXIu bV9saW5lSGVpZ2h0ICogbV9pdGVyYXRvci5saW5lSW5kZXgoKSArIHJlc29sdmVyLm1fYmFzZWxp bmUgLSByZXNvbHZlci5tX2FzY2VudCk7Ci0gICAgTGF5b3V0U2l6ZSBsaW5lU2l6ZShydW4ud2lk dGgsIHJlc29sdmVyLm1fYXNjZW50ICsgcmVzb2x2ZXIubV9kZXNjZW50KTsKKyAgICBMYXlvdXRT aXplIGxpbmVTaXplKHJ1bi5yaWdodCAtIHJ1bi5sZWZ0LCByZXNvbHZlci5tX2FzY2VudCArIHJl c29sdmVyLm1fZGVzY2VudCk7CiAgICAgcmV0dXJuIExheW91dFJlY3QobGluZVBvc2l0aW9uICsg cmVzb2x2ZXIubV9jb250ZW50T2Zmc2V0LCBsaW5lU2l6ZSk7CiB9CiAK