123454 2013-10-29 11:35:40 -0700 SessionState.h should not include WebBackForwardList.h 2013-10-29 12:41:48 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough commit-queue oldest_to_newest 944500 0 barraclough 2013-10-29 11:35:40 -0700 WebBackForwardList is a UIProcess type, SessionState is in shared code. Also, WebBackForwardListItemVector should be in WebBackForwardListItem.h, not WebBackForwardList.h (the vector type is used in the WebProcess, the item header is shared but the list type is in the UIProcess). 944505 1 215406 barraclough 2013-10-29 11:38:48 -0700 Created attachment 215406 Fix 944508 2 215406 ggaren 2013-10-29 11:39:30 -0700 Comment on attachment 215406 Fix r=me 944511 3 commit-queue 2013-10-29 11:40:57 -0700 Attachment 215406 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/SessionState.cpp', u'Source/WebKit2/Shared/SessionState.h', u'Source/WebKit2/Shared/WebBackForwardListItem.h', u'Source/WebKit2/Shared/WebPageCreationParameters.h', u'Source/WebKit2/UIProcess/WebBackForwardList.h', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1 Source/WebKit2/WebProcess/WebPage/WebPage.cpp:88: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 944538 4 barraclough 2013-10-29 12:41:48 -0700 Fixed in r158210 215406 2013-10-29 11:38:48 -0700 2013-10-29 11:39:30 -0700 Fix 123454.patch text/plain 5325 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODIwMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEzLTEwLTI5ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBTZXNzaW9uU3Rh dGUuaCBzaG91bGQgbm90IGluY2x1ZGUgV2ViQmFja0ZvcndhcmRMaXN0LmgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzQ1NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkJhY2tGb3J3YXJkTGlzdCBp cyBhIFVJUHJvY2VzcyB0eXBlLCBTZXNzaW9uU3RhdGUgaXMgaW4gc2hhcmVkIGNvZGUuCisgICAg ICAgIEFsc28sIFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW1WZWN0b3Igc2hvdWxkIGJlIGluIFdlYkJh Y2tGb3J3YXJkTGlzdEl0ZW0uaCwgbm90IFdlYkJhY2tGb3J3YXJkTGlzdC5oCisgICAgICAgICh0 aGUgdmVjdG9yIHR5cGUgaXMgdXNlZCBpbiB0aGUgV2ViUHJvY2VzcywgdGhlIGl0ZW0gaGVhZGVy IGlzIHNoYXJlZCBidXQgdGhlIGxpc3QgdHlwZSBpcyBpbiB0aGUgVUlQcm9jZXNzKS4KKworICAg ICAgICAqIFNoYXJlZC9TZXNzaW9uU3RhdGUuY3BwOgorICAgICAgICAgICAgLSBmaXhlZCBpbmNs dWRlcworICAgICAgICAqIFNoYXJlZC9TZXNzaW9uU3RhdGUuaDoKKyAgICAgICAgICAgIC0gV2Vi QmFja0ZvcndhcmRMaXN0LmggLT4gV2ViQmFja0ZvcndhcmRMaXN0SXRlbS5oCisgICAgICAgICog U2hhcmVkL1dlYkJhY2tGb3J3YXJkTGlzdEl0ZW0uaDoKKyAgICAgICAgICAgIC0gTW92ZWQgV2Vi QmFja0ZvcndhcmRMaXN0VmVjdG9yIGZyb20gV2ViQmFja0ZvcndhcmRMaXN0LmgKKyAgICAgICAg KiBTaGFyZWQvV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5oOgorICAgICAgICAgICAgLSBmaXhl ZCBpbmNsdWRlcworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuaDoKKyAg ICAgICAgICAgIC0gTW92ZWQgV2ViQmFja0ZvcndhcmRMaXN0VmVjdG9yIHRvIFdlYkJhY2tGb3J3 YXJkTGlzdEl0ZW0uaAorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5j cHA6CisgICAgICAgICAgICAtIGZpeGVkIGluY2x1ZGVzCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAgICAgLSBmaXhlZCBpbmNsdWRlcworCiAyMDEz LTEwLTI5ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkIE1hYyBkZWJ1ZyBidWlsZCBmaXggYWZ0ZXIgcjE1ODE4My4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9TZXNzaW9uU3RhdGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9TZXNzaW9uU3RhdGUuY3BwCShyZXZpc2lvbiAxNTgwMzQpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvU2Vzc2lvblN0YXRlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUs NiArMjUsNyBAQAogCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiU2Vzc2lvblN0YXRl LmgiCisjaW5jbHVkZSAiV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgiCiAKIG5hbWVzcGFjZSBDb3Jl SVBDIHsKIApJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL1Nlc3Npb25TdGF0ZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9TZXNzaW9uU3RhdGUuaAkocmV2aXNpb24g MTU4MDM0KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1Nlc3Npb25TdGF0ZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNiw3ICsyNiw3IEBACiAjaWZuZGVmIFNlc3Npb25TdGF0ZV9oCiAjZGVmaW5l IFNlc3Npb25TdGF0ZV9oCiAKLSNpbmNsdWRlICJXZWJCYWNrRm9yd2FyZExpc3QuaCIKKyNpbmNs dWRlICJXZWJCYWNrRm9yd2FyZExpc3RJdGVtLmgiCiAKIG5hbWVzcGFjZSBDb3JlSVBDIHsKICAg ICBjbGFzcyBBcmd1bWVudERlY29kZXI7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2Vi QmFja0ZvcndhcmRMaXN0SXRlbS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9XZWJCYWNrRm9yd2FyZExpc3RJdGVtLmgJKHJldmlzaW9uIDE1ODAzNCkKKysrIFNvdXJjZS9X ZWJLaXQyL1NoYXJlZC9XZWJCYWNrRm9yd2FyZExpc3RJdGVtLmgJKHdvcmtpbmcgY29weSkKQEAg LTc1LDYgKzc1LDggQEAgcHJpdmF0ZToKICAgICBWZWN0b3I8dWludDhfdD4gbV9iYWNrRm9yd2Fy ZERhdGE7CiB9OwogCit0eXBlZGVmIFZlY3RvcjxSZWZQdHI8V2ViQmFja0ZvcndhcmRMaXN0SXRl bT4+IEJhY2tGb3J3YXJkTGlzdEl0ZW1WZWN0b3I7CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAog CiAjZW5kaWYgLy8gV2ViQmFja0ZvcndhcmRMaXN0SXRlbV9oCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzLmgJKHJldmlzaW9uIDE1 ODAzNCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJz LmgJKHdvcmtpbmcgY29weSkKQEAgLTI3LDEwICsyNywxNSBAQAogI2RlZmluZSBXZWJQYWdlQ3Jl YXRpb25QYXJhbWV0ZXJzX2gKIAogI2luY2x1ZGUgIkRyYXdpbmdBcmVhSW5mby5oIgorI2luY2x1 ZGUgIkxheWVyVHJlZUNvbnRleHQuaCIKICNpbmNsdWRlICJTZXNzaW9uU3RhdGUuaCIKKyNpbmNs dWRlICJXZWJDb3JlQXJndW1lbnRDb2RlcnMuaCIKICNpbmNsdWRlICJXZWJQYWdlR3JvdXBEYXRh LmgiCiAjaW5jbHVkZSAiV2ViUHJlZmVyZW5jZXNTdG9yZS5oIgorI2luY2x1ZGUgPFdlYkNvcmUv Q29sb3IuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0ludFNpemUuaD4KKyNpbmNsdWRlIDxXZWJDb3Jl L1BhZ2luYXRpb24uaD4KKyNpbmNsdWRlIDxXZWJDb3JlL1Njcm9sbFR5cGVzLmg+CiAjaW5jbHVk ZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKICNpZiBQTEFURk9STShNQUMpCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQmFja0ZvcndhcmRMaXN0LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5oCShyZXZpc2lvbiAx NTgwMzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQmFja0ZvcndhcmRMaXN0LmgJ KHdvcmtpbmcgY29weSkKQEAgLTM5LDggKzM5LDYgQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAK LXR5cGVkZWYgVmVjdG9yPFJlZlB0cjxXZWJCYWNrRm9yd2FyZExpc3RJdGVtPj4gQmFja0Zvcndh cmRMaXN0SXRlbVZlY3RvcjsKLQogLyoKICAqICAgICAgICAgIEN1cnJlbnQKICAqICAgfC0tLS0t LS0tLSotLS0tLS0tLS0tLS0tLXwgRW50cmllcwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuY3BwCShyZXZpc2lvbiAxNTgwMzQpCisr KyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNSw2ICsyNSw3IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJEcmF3aW5nQXJlYS5oIgorI2luY2x1ZGUgPHd0Zi9GdW5jdGlvbmFsLmg+CiAKIC8vIFN1 YmNsYXNzZXMKICNpZiBQTEFURk9STShNQUMpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShyZXZpc2lvbiAxNTgwMzQpCisrKyBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTMxLDggKzMxLDEwIEBACiAjaW5jbHVkZSAiQXJndW1lbnRzLmgiCiAjaW5jbHVkZSAiRGF0YVJl ZmVyZW5jZS5oIgogI2luY2x1ZGUgIkRlY29kZXJBZGFwdGVyLmgiCisjaW5jbHVkZSAiRHJhZ0Nv bnRyb2xsZXJBY3Rpb24uaCIKICNpbmNsdWRlICJEcmF3aW5nQXJlYS5oIgogI2luY2x1ZGUgIkRy YXdpbmdBcmVhTWVzc2FnZXMuaCIKKyNpbmNsdWRlICJFZGl0b3JTdGF0ZS5oIgogI2luY2x1ZGUg IkV2ZW50RGlzcGF0Y2hlci5oIgogI2luY2x1ZGUgIkluamVjdGVkQnVuZGxlLmgiCiAjaW5jbHVk ZSAiSW5qZWN0ZWRCdW5kbGVCYWNrRm9yd2FyZExpc3QuaCIKQEAgLTUwLDcgKzUyLDYgQEAKICNp bmNsdWRlICJTZXNzaW9uU3RhdGUuaCIKICNpbmNsdWRlICJTaGFyZWFibGVCaXRtYXAuaCIKICNp bmNsdWRlICJXZWJBbHRlcm5hdGl2ZVRleHRDbGllbnQuaCIKLSNpbmNsdWRlICJXZWJCYWNrRm9y d2FyZExpc3QuaCIKICNpbmNsdWRlICJXZWJCYWNrRm9yd2FyZExpc3RJdGVtLmgiCiAjaW5jbHVk ZSAiV2ViQmFja0ZvcndhcmRMaXN0UHJveHkuaCIKICNpbmNsdWRlICJXZWJDaHJvbWVDbGllbnQu aCIKQEAgLTg0LDYgKzg1LDcgQEAKICNpbmNsdWRlICJXZWJQcmVmZXJlbmNlc1N0b3JlLmgiCiAj aW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3NQcm94eU1lc3NhZ2Vz LmgiCisjaW5jbHVkZSAiV0tTaGFyZWRBUElDYXN0LmgiCiAjaW5jbHVkZSA8SmF2YVNjcmlwdENv cmUvQVBJQ2FzdC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvQXJjaGl2ZVJlc291cmNlLmg+CiAjaW5j bHVkZSA8V2ViQ29yZS9DaHJvbWUuaD4K