123450 2013-10-29 10:59:29 -0700 WebKit2 bots don't exit after 50 failures or timeouts 2013-10-29 12:24:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap lforschler beidson commit-queue lforschler rniwa simon.fraser oldest_to_newest 944480 0 ap 2013-10-29 10:59:29 -0700 So when there are lots of timeouts, they get really late. Looks like we just don't pass exit-after-n-crashes-or-timeouts option, should be a config file fix I hope. 944483 1 lforschler 2013-10-29 11:12:01 -0700 These are currently set to NOT abort early. Simply changing this to True should set the timeout same as the Webkit1 tests. class RunWebKit2Tests(RunWebKitTests): def start(self): self.setProperty("shouldAbortEarly", False) self.setCommand(self.command + ["--webkit-test-runner"]) return RunWebKitTests.start(self) 944485 2 215400 lforschler 2013-10-29 11:14:45 -0700 Created attachment 215400 set shouldAbortEarly to True 944503 3 215400 ap 2013-10-29 11:36:43 -0700 Comment on attachment 215400 set shouldAbortEarly to True This was changed in bug 94506, apparently because WK2 used to have lots and lots of flaky tests, so letting these run to completion still gave you some information about non-flakily failing tests. We are not there any more with respect to how horrible tests are, and allowing an unlimited number of crashes or timeouts grinds bots to a halt after a bad commit that crashes everywhere. Alternatively to landing this change, we could roll out the one from bug 94506. What do you think? 944509 4 lforschler 2013-10-29 11:39:36 -0700 I don't think we should roll out the previous one. It is nice that it adds this property. Let's keep the shouldAbortEarly property, and just set it to False with this change. 944519 5 lforschler 2013-10-29 11:47:44 -0700 That should read, set it to True :) 944530 6 215400 commit-queue 2013-10-29 12:18:36 -0700 Comment on attachment 215400 set shouldAbortEarly to True Clearing flags on attachment: 215400 Committed r158207: <http://trac.webkit.org/changeset/158207> 944531 7 commit-queue 2013-10-29 12:18:39 -0700 All reviewed patches have been landed. Closing bug. 944532 8 lforschler 2013-10-29 12:24:29 -0700 restarted master. This should be live. 215400 2013-10-29 11:14:45 -0700 2013-10-29 12:18:36 -0700 set shouldAbortEarly to True 123450.patch text/plain 1274 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1ODIwMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTEwLTI5ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBUZWFjaCB0aGUgV2ViS2l0MiB0ZXN0ZXJzIHRvIGFib3J0IGVhcmx5 IGJ5IHNldHRpbmcgdGhlIHNob3VsZEFib3J0RWFybHkgcHJvcGVydHkgdG8gVHJ1ZS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzQ1MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKFJ1bldl YktpdDJUZXN0cy5zdGFydCk6CisKIDIwMTMtMTAtMjkgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gUmF0aW9uYWxpemUgdXNlciBkZWZhdWx0cyBv dmVycmlkZSBjb2RlCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHJldmlzaW9uIDE1ODIwMSkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rl ci5jZmcJKHdvcmtpbmcgY29weSkKQEAgLTYxNiw3ICs2MTYsNyBAQCBjbGFzcyBSdW5XZWJLaXRM ZWFrVGVzdHMoUnVuV2ViS2l0VGVzdHMpCiAKIGNsYXNzIFJ1bldlYktpdDJUZXN0cyhSdW5XZWJL aXRUZXN0cyk6CiAgICAgZGVmIHN0YXJ0KHNlbGYpOgotICAgICAgICBzZWxmLnNldFByb3BlcnR5 KCJzaG91bGRBYm9ydEVhcmx5IiwgRmFsc2UpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoInNo b3VsZEFib3J0RWFybHkiLCBUcnVlKQogICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21t YW5kICsgWyItLXdlYmtpdC10ZXN0LXJ1bm5lciJdKQogCiAgICAgICAgIHJldHVybiBSdW5XZWJL aXRUZXN0cy5zdGFydChzZWxmKQo=