123445 2013-10-29 07:51:47 -0700 [Curl] Cookies are sometimes not set in download request. 2013-10-30 10:29:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue galpeter oldest_to_newest 944427 0 peavo 2013-10-29 07:51:47 -0700 Sometimes downloads are failing for me. I have traced this down to be caused by missing cookies in the download request. I believe the reason for this is that when the download tries to read from the cookie file, it fails to open it, because it is already opened for writing by the ResourceHandleManager. This can be fixed by using the share handle in the ResourceHandleManager to get the cookies, instead for reading the cookie file. This will also be a performance improvement, as there is no need to read and parse the cookie file all over again for each download. The multithreading issues are already handled by the ResourceHandleManager. 944428 1 215388 peavo 2013-10-29 07:58:21 -0700 Created attachment 215388 Patch 944952 2 215388 bfulgham 2013-10-30 10:04:43 -0700 Comment on attachment 215388 Patch r=me 944974 3 peavo 2013-10-30 10:26:40 -0700 (In reply to comment #2) > (From update of attachment 215388 [details]) > r=me Thanks for reviewing! 944980 4 215388 commit-queue 2013-10-30 10:29:54 -0700 Comment on attachment 215388 Patch Clearing flags on attachment: 215388 Committed r158277: <http://trac.webkit.org/changeset/158277> 944981 5 commit-queue 2013-10-30 10:29:55 -0700 All reviewed patches have been landed. Closing bug. 215388 2013-10-29 07:58:21 -0700 2013-10-30 10:29:54 -0700 Patch bug-123445-20131029155720.patch text/plain 2060 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODE5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEwLTI5ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBDb29raWVz IGFyZSBzb21ldGltZXMgbm90IHNldCBpbiBkb3dubG9hZCByZXF1ZXN0LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZXRpbWVzIGNvb2tpZXMgYXJl IG5vdCBzZXQgaW4gdGhlIGRvd25sb2FkIHJlcXVlc3QgYmVjYXVzZSB0aGUgY29va2llIGZpbGUg Y2Fubm90IGJlIG9wZW5lZCwKKyAgICAgICAgaXQncyBhbHJlYWR5IGJlZW4gb3BlbmVkIGJ5IHRo ZSBSZXNvdXJjZUhhbmRsZU1hbmFnZXIgZm9yIHdyaXRpbmcuCisgICAgICAgIFRoaXMgY2FuIGJl IGZpeGVkIGJ5IGdldHRpbmcgdGhlIGNvb2tpZSBsaXN0IGZyb20gdGhlIHNoYXJlIGhhbmRsZSBp biBSZXNvdXJjZUhhbmRsZU1hbmFnZXIgaW5zdGVhZC4KKyAgICAgICAgVGhpcyB3aWxsIGFsc28g aW1wcm92ZSBwZXJmb3JtYW5jZSwgYXMgdGhlcmUgaXMgbm8gbmVlZCB0byByZWFkIGFuZCBwYXJz ZSB0aGUgY29va2llIGZpbGUgZm9yIGVhY2ggZG93bmxvYWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxE b3dubG9hZDo6aW5pdCk6IFVzZSBzaGFyZSBoYW5kbGUgdG8gZ2V0IGNvb2tpZSBsaXN0LgorCiAy MDEzLTEwLTI5ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAg ICAgICBSZS1lbmFibGUgc2ltcGxlIGxpbmUgbGF5b3V0IGZvciBFRkwKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsRG93bmxvYWQuY3Bw CShyZXZpc2lvbiAxNTgxOTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvQ3VybERvd25sb2FkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQAogCiAj aW5jbHVkZSAiSFRUUFBhcnNlcnMuaCIKICNpbmNsdWRlICJNYWluVGhyZWFkVGFzay5oIgorI2lu Y2x1ZGUgIlJlc291cmNlSGFuZGxlTWFuYWdlci5oIgogI2luY2x1ZGUgIlJlc291cmNlUmVxdWVz dC5oIgogI2luY2x1ZGUgPHd0Zi9NYWluVGhyZWFkLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0 cmluZy5oPgpAQCAtMjc0LDkgKzI3NSw5IEBAIHZvaWQgQ3VybERvd25sb2FkOjppbml0KEN1cmxE b3dubG9hZExpc3QKICAgICBpZiAoY2VydFBhdGgpCiAgICAgICAgIGN1cmxfZWFzeV9zZXRvcHQo bV9jdXJsSGFuZGxlLCBDVVJMT1BUX0NBSU5GTywgY2VydFBhdGgpOwogCi0gICAgY29uc3QgY2hh ciogY29va2llSmFyUGF0aCA9IGdldGVudigiQ1VSTF9DT09LSUVfSkFSX1BBVEgiKTsKLSAgICBp ZiAoY29va2llSmFyUGF0aCkKLSAgICAgICAgY3VybF9lYXN5X3NldG9wdChtX2N1cmxIYW5kbGUs IENVUkxPUFRfQ09PS0lFRklMRSwgY29va2llSmFyUGF0aCk7CisgICAgQ1VSTFNIKiBjdXJsc2gg PSBSZXNvdXJjZUhhbmRsZU1hbmFnZXI6OnNoYXJlZEluc3RhbmNlKCktPmdldEN1cmxTaGFyZUhh bmRsZSgpOworICAgIGlmIChjdXJsc2gpCisgICAgICAgIGN1cmxfZWFzeV9zZXRvcHQobV9jdXJs SGFuZGxlLCBDVVJMT1BUX1NIQVJFLCBjdXJsc2gpOwogCiAgICAgbV9saXN0ZW5lciA9IGxpc3Rl bmVyOwogfQo=