123429 2013-10-28 17:58:45 -0700 Add tooltips to the platform icons in Dashboard 2013-11-08 11:29:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ap simon.fraser timothy oldest_to_newest 944283 0 simon.fraser 2013-10-28 17:58:45 -0700 Add tooltips to the platform icons in Dashboard 944286 1 215356 simon.fraser 2013-10-28 17:59:32 -0700 Created attachment 215356 Patch 944295 2 215356 ap 2013-10-28 18:28:26 -0700 Comment on attachment 215356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215356&action=review r=me I would personally prefer the text to be just always visible, but even a tooltip is an improvement. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:44 > + MacOSXMavericks: { name: "mac-os-x-mavericks", readablename: "Mac OS X Mavericks", order: 10 }, Does "readablename" match the style in this file? Should be readableName otherwise. Please remove "Mac", it's just "OS X Mavericks". > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:46 > + MacOSXMountainLion: { name: "mac-os-x-mountain-lion", readablename: "Mac OS X MountainLion", order: 20 }, > + MacOSXLion: { name : "mac-os-x-lion", readablename: "Mac OS X MountainLion", order: 30 }, Please add a space in "Mountain Lion", and remove "Mac". 948758 3 simon.fraser 2013-11-08 11:29:21 -0800 http://trac.webkit.org/changeset/158151 215356 2013-10-28 17:59:32 -0700 2013-10-28 18:28:26 -0700 Patch bug-123429-20131028175918.patch text/plain 3607 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4MTQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWJkZjI2MTEzNmI0ZDE3Y2IyY2I2MGE3ZGZlOTc4ZTM2 Yzc1ODliNS4uYzk4ZmFmZjEzOWViNWRkN2ZjZTIzNWFmMzdhODhhNDYzZDE1ODc4NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEzLTEwLTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgog CisgICAgICAgIEFkZCB0b29sdGlwcyB0byB0aGUgcGxhdGZvcm0gaWNvbnMgaW4gRGFzaGJvYXJk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0MjkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IEFkZCBhIGh1bWFuIHJlYWRhYmxlIG5hbWUgdG8gQnVpbGRib3QuUGxhdGZvcm0gZW50cmllcywg YW5kIHVzZSBpdCB0bworICAgICAgICBzaG93IGEgdG9vbHRpcCBvbiB0aGUgcmluZyBpbWFnZS4K KworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90LmpzOgorICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TY3JpcHRzL01haW4uanM6CisgICAgICAgIChkb2N1bWVudFJlYWR5KToKKworMjAxMy0xMC0y OCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBBbGxv dyBleHBsaWNpdCBzb3J0IG9yZGVyIGZvciBEYXNoYm9hcmQgcGxhdGZvcm1zCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0MTkKIApkaWZmIC0tZ2l0 IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3QuanMgYi9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9CdWlsZGJvdC5qcwppbmRleCA4ZjBhZTdiNGU2NGRlNmE1ZjhkYTMzOWQ1MzA4YjE4NTU4MGZh ZjA0Li4yZTcxYTZlNzZhMWI1YmZlYTI5MTU2YTU2NzU2NThiNjY0NTgyZmUwIDEwMDY0NAotLS0g YS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNf aHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdC5qcworKysgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9CdWlsZGJvdC5qcwpAQCAtNDEsMTUgKzQxLDE1IEBAIEJhc2VPYmplY3QuYWRkQ29uc3Ry dWN0b3JGdW5jdGlvbnMoQnVpbGRib3QpOwogCiAvLyBPcmRlcmVkIGltcG9ydGFuY2UvcmVjZW5j eS4KIEJ1aWxkYm90LlBsYXRmb3JtID0gewotICAgIE1hY09TWE1hdmVyaWNrczogeyBuYW1lOiAi bWFjLW9zLXgtbWF2ZXJpY2tzIiwgb3JkZXI6IDEwIH0sCi0gICAgTWFjT1NYTW91bnRhaW5MaW9u OiB7IG5hbWU6ICJtYWMtb3MteC1tb3VudGFpbi1saW9uIiwgb3JkZXI6IDIwIH0sCi0gICAgTWFj T1NYTGlvbjogeyBuYW1lIDogIm1hYy1vcy14LWxpb24iLCBvcmRlcjogMzAgfSwKLSAgICBXaW5k b3dzODogeyBuYW1lOiAid2luZG93cy04Iiwgb3JkZXI6IDQwIH0sCi0gICAgV2luZG93czc6IHsg bmFtZTogIndpbmRvd3MtNyIsIG9yZGVyOiA1MCB9LAotICAgIFdpbmRvd3NYUDogeyBuYW1lOiAi d2luZG93cy14cCIsIG9yZGVyOiA2MCB9LAotICAgIExpbnV4UXQ6IHsgbmFtZSA6ICJsaW51eC1x dCIsIG9yZGVyOiA3MCB9LAotICAgIExpbnV4R1RLOiB7IG5hbWUgOiAibGludXgtZ3RrIiwgb3Jk ZXI6IDgwIH0sCi0gICAgTGludXhFRkw6IHsgbmFtZTogImxpbnV4LWVmbCIsIG9yZGVyIDogOTAg fQorICAgIE1hY09TWE1hdmVyaWNrczogeyBuYW1lOiAibWFjLW9zLXgtbWF2ZXJpY2tzIiwgcmVh ZGFibGVuYW1lOiAiTWFjIE9TIFggTWF2ZXJpY2tzIiwgb3JkZXI6IDEwIH0sCisgICAgTWFjT1NY TW91bnRhaW5MaW9uOiB7IG5hbWU6ICJtYWMtb3MteC1tb3VudGFpbi1saW9uIiwgcmVhZGFibGVu YW1lOiAiTWFjIE9TIFggTW91bnRhaW5MaW9uIiwgb3JkZXI6IDIwIH0sCisgICAgTWFjT1NYTGlv bjogeyBuYW1lIDogIm1hYy1vcy14LWxpb24iLCByZWFkYWJsZW5hbWU6ICJNYWMgT1MgWCBNb3Vu dGFpbkxpb24iLCBvcmRlcjogMzAgfSwKKyAgICBXaW5kb3dzODogeyBuYW1lOiAid2luZG93cy04 IiwgcmVhZGFibGVuYW1lOiAiV2luZG93cyA4Iiwgb3JkZXI6IDQwIH0sCisgICAgV2luZG93czc6 IHsgbmFtZTogIndpbmRvd3MtNyIsIHJlYWRhYmxlbmFtZTogIldpbmRvd3MgNyIsIG9yZGVyOiA1 MCB9LAorICAgIFdpbmRvd3NYUDogeyBuYW1lOiAid2luZG93cy14cCIsIHJlYWRhYmxlbmFtZTog IldpbmRvd3MgWFAiLCBvcmRlcjogNjAgfSwKKyAgICBMaW51eFF0OiB7IG5hbWUgOiAibGludXgt cXQiLCByZWFkYWJsZW5hbWU6ICJMaW51eCBRdCIsIG9yZGVyOiA3MCB9LAorICAgIExpbnV4R1RL OiB7IG5hbWUgOiAibGludXgtZ3RrIiwgcmVhZGFibGVuYW1lOiAiTGludXggR1RLIiwgb3JkZXI6 IDgwIH0sCisgICAgTGludXhFRkw6IHsgbmFtZTogImxpbnV4LWVmbCIsIHJlYWRhYmxlbmFtZTog IkxpbnV4IEVGTCIsIG9yZGVyIDogOTAgfQogfTsKIAogLy8gT3JkZXJlZCBpbXBvcnRhbmNlLgpk aWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvTWFpbi5qcyBiL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL01haW4uanMKaW5kZXggYWZiNWJhYWQ5YWE4NmMwMmVlMDNhNTIzMWFhM2EyNjNiNjRh Mjc3ZC4uNjU5NjQzOTk2NTVmYjQ2ZWY3YmEwMjY5ZjEyYWNiZDZmN2U4Y2NmNCAxMDA2NDQKLS0t IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvTWFpbi5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9NYWluLmpzCkBAIC0xMTUsNiArMTE1LDcgQEAgZnVuY3Rpb24gZG9jdW1lbnRSZWFkeSgpCiAK ICAgICAgICAgdmFyIHJpbmdJbWFnZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImltZyIpOwog ICAgICAgICByaW5nSW1hZ2UuY2xhc3NMaXN0LmFkZCgicmluZyIpOworICAgICAgICByaW5nSW1h Z2UudGl0bGUgPSBwbGF0Zm9ybS5yZWFkYWJsZW5hbWU7CiAgICAgICAgIGNlbGwuYXBwZW5kQ2hp bGQocmluZ0ltYWdlKTsKIAogICAgICAgICB2YXIgbG9nb0ltYWdlID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiaW1nIik7Cg==