123408 2013-10-28 09:52:49 -0700 Clean up ScopedEventQueue 2013-10-29 00:41:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue esprehn+autocc kangil.han oldest_to_newest 944127 0 zan 2013-10-28 09:52:49 -0700 Clean up ScopedEventQueue 944131 1 215316 zan 2013-10-28 09:59:21 -0700 Created attachment 215316 Patch 944135 2 215316 darin 2013-10-28 10:08:57 -0700 Comment on attachment 215316 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215316&action=review > Source/WebCore/dom/ScopedEventQueue.cpp:77 > + Vector<RefPtr<Event>> queuedEvents; > + queuedEvents.swap(m_queuedEvents); We should use move instead of swap here: Vector<RefPtr<Event>> queuedEvents = std::move(m_queuedEvents); 944342 3 zan 2013-10-29 00:41:04 -0700 Committed r158182: <http://trac.webkit.org/changeset/158182> 215316 2013-10-28 09:59:21 -0700 2013-10-28 10:08:57 -0700 Patch bug-123408-20131028095920.patch text/plain 6335 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4MTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI2ZGFjN2FjMDhhNmRm MWMyYmZiNGU5Njc1MjdiZDg4MDBmYTZlNS4uMjhmOGNmYTc2ZDQ0ZjkzN2RlOWJmZTE0MTI0YWM5 MGQ3Y2MxYTk5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTEwLTI4ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBTY29w ZWRFdmVudFF1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjM0MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDbGVhbiB1cCB0aGUgU2NvcGVkRXZlbnRRdWV1ZSBpbXBsZW1lbnRhdGlvbi4gU2NvcGVk RXZlbnRRdWV1ZTo6aW5zdGFuY2UoKSBzaG91bGQgcmV0dXJuIGEgcmVmZXJlbmNlIHRvIGEKKyAg ICAgICAgTmV2ZXJEZXN0cm95ZWQ8U2NvcGVkRXZlbnRRdWV1ZT4gb2JqZWN0LiBUaGUgc3RhdGlj IFNjb3BlZEV2ZW50UXVldWU6OnNfaW5zdGFuY2UgcG9pbnRlciBpcyByZW1vdmVkLgorCisgICAg ICAgIFRoZSBTY29wZWRFdmVudFF1ZXVlIGRlc3RydWN0b3IsIHRoZSBkaXNwYXRjaEFsbEV2ZW50 cyBtZXRob2QgYW5kIHRoZSBzY29wZSBsZXZlbCBpbmNyZW1lbnRhdGlvbi9kZWNyZW1lbnRhdGlv bgorICAgICAgICBtZXRob2RzIGFyZSBtYWRlIHByaXZhdGUuIE5ldmVyRGVzdHJveWVkPFNjb3Bl ZEV2ZW50UXVldWU+IGFuZCBFdmVudFF1ZXVlU2NvcGUgYXJlIG1hZGUgZnJpZW5kcyBvZiB0aGUK KyAgICAgICAgU2NvcGVkRXZlbnRRdWV1ZSBjbGFzcyBzbyB0aGV5IGNhbiBhY2Nlc3MgdGhlIGNv bnN0cnVjdG9yIGFuZCB0aGUgaW5jcmVtZW50YXRpb24vZGVjcmVtZW50YXRpb24gbWV0aG9kcywg cmVzcGVjdGl2ZWx5LgorCisgICAgICAgIFNjb3BlZEV2ZW50UXVldWUgbWV0aG9kIGRlZmluaXRp b25zIGFyZSByZW9yZGVyZWQgdG8gZm9sbG93IHRoZSBvcmRlciBvZiB0aGVpciBkZWNsYXJhdGlv bnMgaW4gdGhlIGhlYWRlciBmaWxlLgorCisgICAgICAgICogZG9tL0V2ZW50RGlzcGF0Y2hlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudERpc3BhdGNoZXI6OmRpc3BhdGNoU2NvcGVkRXZl bnQpOgorICAgICAgICAqIGRvbS9TY29wZWRFdmVudFF1ZXVlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNjb3BlZEV2ZW50UXVldWU6Omluc3RhbmNlKToKKyAgICAgICAgKFdlYkNvcmU6OlNjb3Bl ZEV2ZW50UXVldWU6OmRpc3BhdGNoQWxsRXZlbnRzKToKKyAgICAgICAgKiBkb20vU2NvcGVkRXZl bnRRdWV1ZS5oOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRRdWV1ZVNjb3BlOjpFdmVudFF1ZXVl U2NvcGUpOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRRdWV1ZVNjb3BlOjp+RXZlbnRRdWV1ZVNj b3BlKToKKwogMjAxMy0xMC0yNyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IDQgYXNzZXJ0aW5nIFNWRyB0ZXN0cyBhZnRlciByMTU4MDk3LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAppbmRleCBlYWZlMWEyMDc4ZTVmYjI2MDA0MTc3 OGFkYzNlZjllZjY3YjBjMGQ4Li4xMWY3MTJmMDA3MWFiNTU5NmYxMTdhMGRkMmZmZDQzZjllMDE3 YzJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcApAQCAtMjA3LDcgKzIw Nyw3IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRjaFNjb3BlZEV2ZW50KE5vZGUmIG5v ZGUsIFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50KQogewogICAgIC8vIFdlIG5lZWQgdG8gc2V0IHRo ZSB0YXJnZXQgaGVyZSBiZWNhdXNlIGl0IGNhbiBnbyBhd2F5IGJ5IHRoZSB0aW1lIHdlIGFjdHVh bGx5IGZpcmUgdGhlIGV2ZW50LgogICAgIGV2ZW50LT5zZXRUYXJnZXQoJmV2ZW50VGFyZ2V0UmVz cGVjdGluZ1RhcmdldFJ1bGVzKG5vZGUpKTsKLSAgICBTY29wZWRFdmVudFF1ZXVlOjppbnN0YW5j ZSgpLT5lbnF1ZXVlRXZlbnQoZXZlbnQpOworICAgIFNjb3BlZEV2ZW50UXVldWU6Omluc3RhbmNl KCkuZW5xdWV1ZUV2ZW50KGV2ZW50KTsKIH0KIAogdm9pZCBFdmVudERpc3BhdGNoZXI6OmRpc3Bh dGNoU2ltdWxhdGVkQ2xpY2soRWxlbWVudCogZWxlbWVudCwgRXZlbnQqIHVuZGVybHlpbmdFdmVu dCwgU2ltdWxhdGVkQ2xpY2tNb3VzZUV2ZW50T3B0aW9ucyBtb3VzZUV2ZW50T3B0aW9ucywgU2lt dWxhdGVkQ2xpY2tWaXN1YWxPcHRpb25zIHZpc3VhbE9wdGlvbnMpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vU2NvcGVkRXZlbnRRdWV1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v U2NvcGVkRXZlbnRRdWV1ZS5jcHAKaW5kZXggOWUxZGVkYzY1Y2UyODEyMzUxOTQ3MjI4NGQ0YTIz MjU3ZTFiNzQ3My4uOGYwZWU5NzNkZWFiNTcwMjg2OTBhM2ZjZDQ0NjlkOGIwNWQ1YTMyMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVudFF1ZXVlLmNwcApAQCAtMzQsMTMgKzM0LDEwIEBA CiAjaW5jbHVkZSAiRXZlbnQuaCIKICNpbmNsdWRlICJFdmVudERpc3BhdGNoZXIuaCIKICNpbmNs dWRlICJFdmVudFRhcmdldC5oIgotI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KICNpbmNsdWRlIDx3 dGYvUmVmUHRyLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotU2NvcGVkRXZlbnRRdWV1ZSog U2NvcGVkRXZlbnRRdWV1ZTo6c19pbnN0YW5jZSA9IDA7Ci0KIFNjb3BlZEV2ZW50UXVldWU6OlNj b3BlZEV2ZW50UXVldWUoKQogICAgIDogbV9zY29waW5nTGV2ZWwoMCkKIHsKQEAgLTUyLDExICs0 OSwxMCBAQCBTY29wZWRFdmVudFF1ZXVlOjp+U2NvcGVkRXZlbnRRdWV1ZSgpCiAgICAgQVNTRVJU KCFtX3F1ZXVlZEV2ZW50cy5zaXplKCkpOwogfQogCi12b2lkIFNjb3BlZEV2ZW50UXVldWU6Omlu aXRpYWxpemUoKQorU2NvcGVkRXZlbnRRdWV1ZSYgU2NvcGVkRXZlbnRRdWV1ZTo6aW5zdGFuY2Uo KQogewotICAgIEFTU0VSVCghc19pbnN0YW5jZSk7Ci0gICAgT3duUHRyPFNjb3BlZEV2ZW50UXVl dWU+IGluc3RhbmNlID0gYWRvcHRQdHIobmV3IFNjb3BlZEV2ZW50UXVldWUpOwotICAgIHNfaW5z dGFuY2UgPSBpbnN0YW5jZS5sZWFrUHRyKCk7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFNj b3BlZEV2ZW50UXVldWU+IHNjb3BlZEV2ZW50UXVldWU7CisgICAgcmV0dXJuIHNjb3BlZEV2ZW50 UXVldWU7CiB9CiAKIHZvaWQgU2NvcGVkRXZlbnRRdWV1ZTo6ZW5xdWV1ZUV2ZW50KFBhc3NSZWZQ dHI8RXZlbnQ+IGV2ZW50KQpAQCAtNjcsMTUgKzYzLDYgQEAgdm9pZCBTY29wZWRFdmVudFF1ZXVl OjplbnF1ZXVlRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gZXZlbnQpCiAgICAgICAgIGRpc3BhdGNo RXZlbnQoZXZlbnQpOwogfQogCi12b2lkIFNjb3BlZEV2ZW50UXVldWU6OmRpc3BhdGNoQWxsRXZl bnRzKCkKLXsKLSAgICBWZWN0b3I8UmVmUHRyPEV2ZW50Pj4gcXVldWVkRXZlbnRzOwotICAgIHF1 ZXVlZEV2ZW50cy5zd2FwKG1fcXVldWVkRXZlbnRzKTsKLQotICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgcXVldWVkRXZlbnRzLnNpemUoKTsgaSsrKQotICAgICAgICBkaXNwYXRjaEV2ZW50KHF1 ZXVlZEV2ZW50c1tpXS5yZWxlYXNlKCkpOwotfQotCiB2b2lkIFNjb3BlZEV2ZW50UXVldWU6OmRp c3BhdGNoRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gZXZlbnQpIGNvbnN0CiB7CiAgICAgQVNTRVJU KGV2ZW50LT50YXJnZXQoKSk7CkBAIC04NCwxMiArNzEsMTMgQEAgdm9pZCBTY29wZWRFdmVudFF1 ZXVlOjpkaXNwYXRjaEV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50KSBjb25zdAogICAgIEV2 ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudChub2RlLCBldmVudCk7CiB9CiAKLVNjb3BlZEV2 ZW50UXVldWUqIFNjb3BlZEV2ZW50UXVldWU6Omluc3RhbmNlKCkKK3ZvaWQgU2NvcGVkRXZlbnRR dWV1ZTo6ZGlzcGF0Y2hBbGxFdmVudHMoKQogewotICAgIGlmICghc19pbnN0YW5jZSkKLSAgICAg ICAgaW5pdGlhbGl6ZSgpOworICAgIFZlY3RvcjxSZWZQdHI8RXZlbnQ+PiBxdWV1ZWRFdmVudHM7 CisgICAgcXVldWVkRXZlbnRzLnN3YXAobV9xdWV1ZWRFdmVudHMpOwogCi0gICAgcmV0dXJuIHNf aW5zdGFuY2U7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBxdWV1ZWRFdmVudHMuc2l6ZSgp OyBpKyspCisgICAgICAgIGRpc3BhdGNoRXZlbnQocXVldWVkRXZlbnRzW2ldLnJlbGVhc2UoKSk7 CiB9CiAKIHZvaWQgU2NvcGVkRXZlbnRRdWV1ZTo6aW5jcmVtZW50U2NvcGluZ0xldmVsKCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVudFF1ZXVlLmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vU2NvcGVkRXZlbnRRdWV1ZS5oCmluZGV4IGVlNjNlOWMzMDdiOWFkNWFhMGIz ZGMwZDE2NjU0ZWUyZTViMjliNDAuLjA5N2I0YjQ3YWI5ZGZjNjZkMDk3ZmNiYzFiMjk0YmVhYjVk NmJkNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVudFF1ZXVlLmgK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuaApAQCAtMzEsNiArMzEs NyBAQAogI2lmbmRlZiBTY29wZWRFdmVudFF1ZXVlX2gKICNkZWZpbmUgU2NvcGVkRXZlbnRRdWV1 ZV9oCiAKKyNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYvTm9u Y29weWFibGUuaD4KICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9S ZWZQdHIuaD4KQEAgLTM5LDM2ICs0MCwzNSBAQAogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFz cyBFdmVudDsKK2NsYXNzIEV2ZW50UXVldWVTY29wZTsKIAogY2xhc3MgU2NvcGVkRXZlbnRRdWV1 ZSB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoU2NvcGVkRXZlbnRRdWV1ZSk7IFdURl9NQUtF X0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgotICAgIH5TY29wZWRFdmVudFF1ZXVlKCk7Ci0KKyAg ICBzdGF0aWMgU2NvcGVkRXZlbnRRdWV1ZSYgaW5zdGFuY2UoKTsKICAgICB2b2lkIGVucXVldWVF dmVudChQYXNzUmVmUHRyPEV2ZW50Pik7Ci0gICAgdm9pZCBkaXNwYXRjaEFsbEV2ZW50cygpOwot ICAgIHN0YXRpYyBTY29wZWRFdmVudFF1ZXVlKiBpbnN0YW5jZSgpOwotCi0gICAgdm9pZCBpbmNy ZW1lbnRTY29waW5nTGV2ZWwoKTsKLSAgICB2b2lkIGRlY3JlbWVudFNjb3BpbmdMZXZlbCgpOwog CiBwcml2YXRlOgogICAgIFNjb3BlZEV2ZW50UXVldWUoKTsKLSAgICBzdGF0aWMgdm9pZCBpbml0 aWFsaXplKCk7CisgICAgflNjb3BlZEV2ZW50UXVldWUoKTsKKwogICAgIHZvaWQgZGlzcGF0Y2hF dmVudChQYXNzUmVmUHRyPEV2ZW50PikgY29uc3Q7CisgICAgdm9pZCBkaXNwYXRjaEFsbEV2ZW50 cygpOworICAgIHZvaWQgaW5jcmVtZW50U2NvcGluZ0xldmVsKCk7CisgICAgdm9pZCBkZWNyZW1l bnRTY29waW5nTGV2ZWwoKTsKIAogICAgIFZlY3RvcjxSZWZQdHI8RXZlbnQ+PiBtX3F1ZXVlZEV2 ZW50czsKICAgICB1bnNpZ25lZCBtX3Njb3BpbmdMZXZlbDsKIAotICAgIHN0YXRpYyBTY29wZWRF dmVudFF1ZXVlKiBzX2luc3RhbmNlOworICAgIGZyaWVuZCBOZXZlckRlc3Ryb3llZDxTY29wZWRF dmVudFF1ZXVlPjsKKyAgICBmcmllbmQgRXZlbnRRdWV1ZVNjb3BlOwogfTsKIAogY2xhc3MgRXZl bnRRdWV1ZVNjb3BlIHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShFdmVudFF1ZXVlU2NvcGUp OwotCiBwdWJsaWM6Ci0gICAgRXZlbnRRdWV1ZVNjb3BlKCkgeyBTY29wZWRFdmVudFF1ZXVlOjpp bnN0YW5jZSgpLT5pbmNyZW1lbnRTY29waW5nTGV2ZWwoKTsgfQotICAgIH5FdmVudFF1ZXVlU2Nv cGUoKSB7IFNjb3BlZEV2ZW50UXVldWU6Omluc3RhbmNlKCktPmRlY3JlbWVudFNjb3BpbmdMZXZl bCgpOyB9CisgICAgRXZlbnRRdWV1ZVNjb3BlKCkgeyBTY29wZWRFdmVudFF1ZXVlOjppbnN0YW5j ZSgpLmluY3JlbWVudFNjb3BpbmdMZXZlbCgpOyB9CisgICAgfkV2ZW50UXVldWVTY29wZSgpIHsg U2NvcGVkRXZlbnRRdWV1ZTo6aW5zdGFuY2UoKS5kZWNyZW1lbnRTY29waW5nTGV2ZWwoKTsgfQog fTsKIAogfQo=