123407 2013-10-28 09:16:30 -0700 RunLoop::dispatch should take an std::function 2013-10-28 13:09:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 944111 0 andersca 2013-10-28 09:16:30 -0700 RunLoop::dispatch should take an std::function 944112 1 215312 andersca 2013-10-28 09:17:19 -0700 Created attachment 215312 Patch 944114 2 215312 kling 2013-10-28 09:18:46 -0700 Comment on attachment 215312 Patch Sweet! 944116 3 commit-queue 2013-10-28 09:19:38 -0700 Attachment 215312 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FunctionDispatcher.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/platform/RunLoop.cpp', u'Source/WebCore/platform/RunLoop.h']" exit_code: 1 Source/WebCore/platform/RunLoop.cpp:123: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/platform/RunLoop.h:60: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/platform/RunLoop.h:136: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/FunctionDispatcher.h:38: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 944189 4 andersca 2013-10-28 13:09:13 -0700 Committed r158123: <http://trac.webkit.org/changeset/158123> 215312 2013-10-28 09:17:19 -0700 2013-10-28 09:18:46 -0700 Patch bug-123407-20131028091724.patch text/plain 4385 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4MTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJkYzQ5ZmQ5ZjYwMTFkNzliMjNjYzZk N2UxMmE0MzQ3MDFjMzRlNmEuLmQyMGUxNGQ0YWUxMjMwNjRhZTNlYjBjZTA4NGExNzA2MmQ4ZmY5 ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMTAtMjggIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSdW5Mb29wOjpkaXNwYXRjaCBzaG91bGQgdGFr ZSBhbiBzdGQ6OmZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjM0MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHd0Zi9GdW5jdGlvbkRpc3BhdGNoZXIuaDoKKwogMjAxMy0xMC0yOCAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZC4gRml4IG1ha2UgZGlzdGNoZWNrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGRhYzNkMjhmMzA4NTczMWFj NmIwYmVkNDhiZGRhNjFlYjM5ZmExOTQuLmRkMTU4YTVhYzBjNDFiOTAxNGYxMGUzMGJlODAzOWZk YzU4NzQxNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0xMC0yOCAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIFJ1bkxvb3A6OmRpc3Bh dGNoIHNob3VsZCB0YWtlIGFuIHN0ZDo6ZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzQwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5leHAuaW46CisgICAgICAgICogcGxh dGZvcm0vUnVuTG9vcC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSdW5Mb29wOjpwZXJmb3JtV29y ayk6CisgICAgICAgIChXZWJDb3JlOjpSdW5Mb29wOjpkaXNwYXRjaCk6CisgICAgICAgICogcGxh dGZvcm0vUnVuTG9vcC5oOgorCiAyMDEzLTEwLTI4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggbWFrZSBkaXN0Y2hl Y2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9GdW5jdGlvbkRpc3BhdGNoZXIuaCBiL1Nv dXJjZS9XVEYvd3RmL0Z1bmN0aW9uRGlzcGF0Y2hlci5oCmluZGV4IDFkN2VjMGI3NmM2YjViYWM0 YzAwYjdlZTA2ZDNiY2E4MDJhYTQ5N2IuLjRlMjAyMzQ1ZDZmY2I1Yzk3NDBkYzE0MGYyODQwMzZi OTliZGM3NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Z1bmN0aW9uRGlzcGF0Y2hlci5o CisrKyBiL1NvdXJjZS9XVEYvd3RmL0Z1bmN0aW9uRGlzcGF0Y2hlci5oCkBAIC0yMyw3ICsyMyw3 IEBACiAgKiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotI2luY2x1ZGUg PHd0Zi9Gb3J3YXJkLmg+CisjaW5jbHVkZSA8ZnVuY3Rpb25hbD4KICNpbmNsdWRlIDx3dGYvVGhy ZWFkU2FmZVJlZkNvdW50ZWQuaD4KIAogbmFtZXNwYWNlIFdURiB7CkBAIC0zNSw3ICszNSw3IEBA IGNsYXNzIEZ1bmN0aW9uRGlzcGF0Y2hlciA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxG dW5jdGlvbkRpc3BhdGNoZXI+IHsKIHB1YmxpYzoKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdmly dHVhbCB+RnVuY3Rpb25EaXNwYXRjaGVyKCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2go Y29uc3QgRnVuY3Rpb248dm9pZCAoKT4mKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNo KHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4pID0gMDsKIAogcHJvdGVjdGVkOgogICAgIFdURl9FWFBP UlRfUFJJVkFURSBGdW5jdGlvbkRpc3BhdGNoZXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZXhwLmluIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KaW5kZXgg MDljZGNkZjI4MmE0MzE3ZDJlYzkzMDBmNWQyZWZkYzZhYjZlNTI1My4uMzM5YmVlZjA2MTJkYzFh MDk4NzZkMzFmZDNkNzUxZTBjMmM5N2M1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5leHAuaW4KKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4KQEAgLTExMDUs NyArMTEwNSw2IEBAIF9fWk43V2ViQ29yZTdSdW5Mb29wNHN0b3BFdgogX19aTjdXZWJDb3JlN1J1 bkxvb3A2aXNNYWluRXYKIF9fWk43V2ViQ29yZTdSdW5Mb29wNndha2VVcEV2CiBfX1pON1dlYkNv cmU3UnVuTG9vcDdjdXJyZW50RXYKLV9fWk43V2ViQ29yZTdSdW5Mb29wOGRpc3BhdGNoRVJLTjNX VEY4RnVuY3Rpb25JRnZ2RUVFCiBfX1pON1dlYkNvcmU3UnVuTG9vcDlUaW1lckJhc2U0c3RvcEV2 CiBfX1pON1dlYkNvcmU3UnVuTG9vcDlUaW1lckJhc2U1c3RhcnRFZGIKIF9fWk43V2ViQ29yZTdS dW5Mb29wOVRpbWVyQmFzZUMyRVBTMF8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1J1bkxvb3AuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5jcHAKaW5k ZXggM2E0ZWRkNTY4OWY3MThjZTI1NjBhNDBjYjI3M2I3N2Q3NzUzYzkwYS4uMDU1NDE3Y2M0MzZm OGZhY2ZlY2I2MzUzOTlmM2Y2MTliMTMzZGI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vUnVuTG9vcC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9v cC5jcHAKQEAgLTg4LDcgKzg4LDcgQEAgdm9pZCBSdW5Mb29wOjpwZXJmb3JtV29yaygpCiAgICAg Ly8gQnkgb25seSBoYW5kbGluZyB1cCB0byB0aGUgbnVtYmVyIG9mIGZ1bmN0aW9ucyB0aGF0IHdl cmUgaW4gdGhlIHF1ZXVlIHdoZW4gcGVyZm9ybVdvcmsoKSBpcyBjYWxsZWQKICAgICAvLyB3ZSBn dWFyYW50ZWUgdG8gb2NjYXNpb25hbGx5IHJldHVybiBmcm9tIHRoZSBydW4gbG9vcCBzbyBvdGhl ciBldmVudCBzb3VyY2VzIHdpbGwgYmUgYWxsb3dlZCB0byBzcGluLgogCi0gICAgRnVuY3Rpb248 dm9pZCgpPiBmdW5jdGlvbjsKKyAgICBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4gZnVuY3Rpb247CiAg ICAgc2l6ZV90IGZ1bmN0aW9uc1RvSGFuZGxlID0gMDsKIAogICAgIHsKQEAgLTEyMCwxMCArMTIw LDEwIEBAIHZvaWQgUnVuTG9vcDo6cGVyZm9ybVdvcmsoKQogICAgIH0KIH0KIAotdm9pZCBSdW5M b29wOjpkaXNwYXRjaChjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiBmdW5jdGlvbikKK3ZvaWQgUnVu TG9vcDo6ZGlzcGF0Y2goc3RkOjpmdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlvbikKIHsKICAgICBN dXRleExvY2tlciBsb2NrZXIobV9mdW5jdGlvblF1ZXVlTG9jayk7Ci0gICAgbV9mdW5jdGlvblF1 ZXVlLmFwcGVuZChmdW5jdGlvbik7CisgICAgbV9mdW5jdGlvblF1ZXVlLmFwcGVuZChzdGQ6Om1v dmUoZnVuY3Rpb24pKTsKIAogICAgIHdha2VVcCgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9v cC5oCmluZGV4IDgzMjcxNjQyZTFjODI0MWY3YjNkZmQ1YTc1NTU5MTE5MGZjMDRlMzAuLmM3OTM0 OTBiNTY1ZjBkNTY3Mzk1MGJlODAyZmY0MDIzMzVlOWFlZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1J1bkxvb3AuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9S dW5Mb29wLmgKQEAgLTU3LDcgKzU3LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBib29sIGlzTWFp bigpOwogICAgIH5SdW5Mb29wKCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQgZGlzcGF0Y2goY29uc3Qg RnVuY3Rpb248dm9pZCgpPiYpIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9pZCBkaXNwYXRjaChz dGQ6OmZ1bmN0aW9uPHZvaWQgKCk+KSBPVkVSUklERTsKIAogICAgIHN0YXRpYyB2b2lkIHJ1bigp OwogICAgIHZvaWQgc3RvcCgpOwpAQCAtMTMzLDcgKzEzMyw3IEBAIHByaXZhdGU6CiAgICAgdm9p ZCBwZXJmb3JtV29yaygpOwogCiAgICAgTXV0ZXggbV9mdW5jdGlvblF1ZXVlTG9jazsKLSAgICBE ZXF1ZTxGdW5jdGlvbjx2b2lkKCk+PiBtX2Z1bmN0aW9uUXVldWU7CisgICAgRGVxdWU8c3RkOjpm dW5jdGlvbjx2b2lkICgpPj4gbV9mdW5jdGlvblF1ZXVlOwogCiAjaWYgUExBVEZPUk0oV0lOKQog ICAgIHN0YXRpYyBib29sIHJlZ2lzdGVyUnVuTG9vcE1lc3NhZ2VXaW5kb3dDbGFzcygpOwo=