123403 2013-10-28 07:55:06 -0700 MediaStreamTrackPrivate's m_client uninitialized 2013-10-28 08:23:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned commit-queue eric.carlson glenn hta jer.noble pnormand thiago.lacerda tommyw oldest_to_newest 944081 0 pnormand 2013-10-28 07:55:06 -0700 This leads to a segfault, the member variable should be initialized in the constructor I think. Trivial patch incoming. #0 0x00007fc66cfd50f9 in WebCore::MediaStreamTrackPrivate::setReadyState (this=0x21d1e90, state=WebCore::MediaStreamSource::Live) at ../../Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:191 #1 0x00007fc66cfd4c4e in WebCore::MediaStreamTrackPrivate::setSource (this=0x21d1e90, source=0x2257710) at ../../Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:80 #2 0x00007fc66cfd4bbd in WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate ( this=0x21d1e90, source=0x2257710) at ../../Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:69 #3 0x00007fc66cfd49fc in WebCore::MediaStreamTrackPrivate::create (source=...) at ../../Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:39 #4 0x00007fc66cfd1a0b in WebCore::MediaStreamDescriptor::MediaStreamDescriptor (this=0x2125b60, id="2bd7aee2-a71a-4f68-847f-fe8bba59dca2", audioSources=WTF::Vector of length 1, capacity 16 = {...}, videoSources=WTF::Vector of length 1, capacity 16 = {...}, ended=false) at ../../Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp:109 #5 0x00007fc66cfd1645 in WebCore::MediaStreamDescriptor::create ( audioSources=WTF::Vector of length 1, capacity 16 = {...}, videoSources=WTF::Vector of length 1, capacity 16 = {...}, flag=WebCore::MediaStreamDescriptor::IsNotEnded) at ../../Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp:49 #6 0x00007fc66cfdcbfd in WebCore::MediaStreamCenterGStreamer::createMediaStream (this=0x22d99e0, prpQueryClient=..., audioConstraints=..., videoConstraints=...) at ../../Source/WebCore/platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:102 #7 0x00007fc66d0c9525 in WebCore::UserMediaRequest::createMediaStream (this=0x21c4500) at ../../Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:151 #8 0x00007fc66d0caf97 in WTF::FunctionWrapper<void (WebCore::UserMediaRequest::*)()>::operator() (this=0x1f77100, c=0x21c4500) at ../../Source/WTF/wtf/Functional.h:218 #9 0x00007fc66d0cada0 in WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (WebCore::UserMediaRequest::*)()>, void (WebCore::UserMediaRequest*)>::operator()() (this=0x1f770f0) at ../../Source/WTF/wtf/Functional.h:496 #10 0x00007fc67140d93f in WTF::Function<void ()>::operator()() const (this=0x21cb5e0) at ../../Source/WTF/wtf/Functional.h:704 #11 0x00007fc67140d005 in std::_Function_handler<void (), WTF::Function<void ()> >::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/include/c++/4.8/functional:2071 #12 0x00007fc67140c338 in std::function<void ()>::operator()() const (this=0x1f833c0) at /usr/include/c++/4.8/functional:2468 #13 0x00007fc67140b910 in WTF::callFunctionObject (context=0x1f833c0) at ../../Source/WTF/wtf/MainThread.cpp:236 #14 0x00007fc67140b592 in WTF::dispatchFunctionsFromMainThread () at ../../Source/WTF/wtf/MainThread.cpp:167 #15 0x00007fc67143020d in WTF::timeoutFired () at ../../Source/WTF/wtf/gtk/MainThreadGtk.cpp:43 #16 0x00007fc6693e3c63 in g_timeout_dispatch (source=source@entry=0x1f579e0, callback=<optimized out>, user_data=<optimized out>) at gmain.c:4450 #17 0x00007fc6693e3106 in g_main_dispatch (context=0x1d2e1e0) at gmain.c:3065 #18 g_main_context_dispatch (context=context@entry=0x1d2e1e0) at gmain.c:3641 #19 0x00007fc6693e3458 in g_main_context_iterate (context=0x1d2e1e0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3712 #20 0x00007fc6693e385a in g_main_loop_run (loop=0x1dd2e80) at gmain.c:3906 #21 0x00007fc66d5c6f7a in WebCore::RunLoop::run () at ../../Source/WebCore/platform/gtk/RunLoopGtk.cpp:61 #22 0x00007fc66be6209b in WebKit::WebProcessMainGtk (argc=2, argv=0x7fff45a87888) at ../../Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:78 #23 0x000000000040095d in main (argc=2, argv=0x7fff45a87888) at ../../Source/WebKit2/gtk/MainGtk.cpp:31 (gdb) f 0 #0 0x00007fc66cfd50f9 in WebCore::MediaStreamTrackPrivate::setReadyState (this=0x21d1e90, state=WebCore::MediaStreamSource::Live) at ../../Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:191 191 m_client->trackReadyStateChanged(); (gdb) p m_client $1 = (WebCore::MediaStreamTrackPrivateClient *) 0x40 944082 1 215308 pnormand 2013-10-28 07:58:27 -0700 Created attachment 215308 fix TrackPrivate 944083 2 215308 eric.carlson 2013-10-28 08:07:31 -0700 Comment on attachment 215308 fix TrackPrivate I guess I can pull this fix out of my patch for 123316 :-) 944084 3 pnormand 2013-10-28 08:12:28 -0700 Ah, thank you :) 944085 4 thiago.lacerda 2013-10-28 08:13:56 -0700 (In reply to comment #1) > Created an attachment (id=215308) [details] > fix TrackPrivate Sorry to let that pass :( Also set the MediaStreamTrackPrivate MediaStreamTrack constructor 944086 5 pnormand 2013-10-28 08:14:59 -0700 Committed r158109: <http://trac.webkit.org/changeset/158109> 944087 6 pnormand 2013-10-28 08:16:28 -0700 (In reply to comment #4) > (In reply to comment #1) > > Created an attachment (id=215308) [details] [details] > > fix TrackPrivate > > Sorry to let that pass :( No problem :) > Also set the MediaStreamTrackPrivate MediaStreamTrack constructor Hum? I didn't notice that issue, perhaps we can deal with it in a new bug? 944090 7 thiago.lacerda 2013-10-28 08:21:13 -0700 (In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #1) > > > Created an attachment (id=215308) [details] [details] [details] > > > fix TrackPrivate > > > > Sorry to let that pass :( > > No problem :) > > > Also set the MediaStreamTrackPrivate MediaStreamTrack constructor > > Hum? I didn't notice that issue, perhaps we can deal with it in a new bug? I mean set the MediaStreamTrackPrivate's client inside MediaStreamTrack constructor. By looking quickly at the code I could not see it being set. Maybe Eric can put in his bug too 944091 8 eric.carlson 2013-10-28 08:23:06 -0700 (In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #1) > > > Created an attachment (id=215308) [details] [details] [details] > > > fix TrackPrivate > > > > Sorry to let that pass :( > > No problem :) > > > Also set the MediaStreamTrackPrivate MediaStreamTrack constructor > > Hum? I didn't notice that issue, perhaps we can deal with it in a new bug? (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #4) > > > (In reply to comment #1) > > > > Created an attachment (id=215308) [details] [details] [details] [details] > > > > fix TrackPrivate > > > > > > Sorry to let that pass :( > > > > No problem :) > > > > > Also set the MediaStreamTrackPrivate MediaStreamTrack constructor > > > > Hum? I didn't notice that issue, perhaps we can deal with it in a new bug? > > I mean set the MediaStreamTrackPrivate's client inside MediaStreamTrack constructor. By looking quickly at the code I could not see it being set. Maybe Eric can put in his bug too Yes, I have done that in bug 123316 as well. 215308 2013-10-28 07:58:27 -0700 2013-10-28 08:07:30 -0700 fix TrackPrivate fix-TrackPrivate.patch text/plain 1687 pnormand RnJvbSA4MjNjYzcyNzY5MzdiNTM3ZjQ1NmUzYTNkOWZkYmRmODU3ZDVjNGMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDI4IE9jdCAyMDEzIDE1OjQ4OjQwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g Zml4IFRyYWNrUHJpdmF0ZQoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEzICsrKysrKysrKysrKysKIC4uLi9wbGF0Zm9y bS9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZS5jcHAgICAgICAgIHwgIDEgKwog MiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQ0M2QxMjUu LjkxN2Y4ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMy0xMC0yOCAgUGhpbGlw cGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKKyAgICAgICAgTWVkaWFTdHJlYW1U cmFja1ByaXZhdGUncyBtX2NsaWVudCB1bmluaXRpYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0MDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBpbiBm dW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vTWVkaWFTdHJl YW1UcmFja1ByaXZhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1UcmFja1By aXZhdGU6Ok1lZGlhU3RyZWFtVHJhY2tQcml2YXRlKToKKyAgICAgICAgSW5pdGlhbGl6ZSB0aGUg bV9jbGllbnQgbWVtYmVyIHZhcmlhYmxlLgorCisyMDEzLTEwLTI4ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwogICAgICAgICBbV0syXSBVc2VyTWVkaWFDbGllbnQg c3VwcG9ydAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIzMTU4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2tQcml2YXRlLmNwcAppbmRleCBmZDMxYWEyLi44MDc4 YmM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9NZWRp YVN0cmVhbVRyYWNrUHJpdmF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFja1ByaXZhdGUuY3BwCkBAIC02NSw2ICs2NSw3IEBAIE1l ZGlhU3RyZWFtVHJhY2tQcml2YXRlOjpNZWRpYVN0cmVhbVRyYWNrUHJpdmF0ZShNZWRpYVN0cmVh bVNvdXJjZSogc291cmNlKQogICAgICwgbV9tdXRlZChmYWxzZSkKICAgICAsIG1fZW5hYmxlZCh0 cnVlKQogICAgICwgbV9zdG9wcGVkKGZhbHNlKQorICAgICwgbV9jbGllbnQoMCkKIHsKICAgICBz ZXRTb3VyY2Uoc291cmNlKTsKIH0KLS0gCjEuOC40LnJjMw==