123393 2013-10-26 15:28:57 -0700 New flakiness dashboard should support substring matching 2013-10-26 17:46:48 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ap commit-queue lforschler simon.fraser thorton zan oldest_to_newest 943920 0 rniwa 2013-10-26 15:28:57 -0700 10/25/13 1:58 PM Alexey Proskuryakov: One thing I frequently use with the old flakiness dashboard is matching tests by substring. Two use cases: 1. Type a part of file name manually, as it could be easier than copying/pasting the entire path (or maybe someone just told you the test name). 2. Paste a directory path to see how all the test in it are doing. That's very useful when there are many similar tests that all may or may not randomly fail for the same reason, like tests in webgl/conformance/ogles/GL/swizzlers used to. <rdar://problem/15323038> 943921 1 215261 rniwa 2013-10-26 15:35:02 -0700 Created attachment 215261 Added the requested features 943936 2 rniwa 2013-10-26 17:22:47 -0700 Thanks for reviewing all these patches! 943939 3 215261 commit-queue 2013-10-26 17:46:46 -0700 Comment on attachment 215261 Added the requested features Clearing flags on attachment: 215261 Committed r158094: <http://trac.webkit.org/changeset/158094> 943940 4 commit-queue 2013-10-26 17:46:48 -0700 All reviewed patches have been landed. Closing bug. 215261 2013-10-26 15:35:02 -0700 2013-10-26 17:46:46 -0700 Added the requested features fix123393 text/plain 3613 rniwa SW5kZXg6IFdlYnNpdGVzL3Rlc3QtcmVzdWx0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi c2l0ZXMvdGVzdC1yZXN1bHRzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU4MDkyKQorKysgV2Vic2l0 ZXMvdGVzdC1yZXN1bHRzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDEzLTEwLTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IE5ldyBmbGFraW5lc3MgZGFzaGJvYXJkIHNob3VsZCBzdXBwb3J0IHN1YnN0cmluZyBtYXRjaGlu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMzkz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkcmVz c2VkIHRoZSB1c2UgY2FzZXMgYnkKKyAgICAgICAgMS4gQWx3YXlzIHNob3dpbmcgdGhlIGNhbmRp ZGF0ZSBldmVuIHdoZW4gdGhlcmUgaXMgZXhhY3RseSBvbmUgdGVzdCBtYXRjaGluZyB0aGUgY3Vy cmVudCB2YWx1ZS4KKyAgICAgICAgMi4gQWRkaW5nIGFsbCB0ZXN0cyB0aGF0IG1hdGNoIHRoZSBj dXJyZW50IHZhbHVlIHVwb24gdGhlIHVzZXIgcHJlc3NpbmcgZW50ZXIga2V5LgorCisgICAgICAg ICogcHVibGljL2luZGV4Lmh0bWw6CisgICAgICAgIChmZXRjaE1hbmlmZXN0KTogQWRkIGFsbCB0 ZXN0cyB0aGF0IG1hdGNoIHRoZSBjdXJyZW50IHZhbHVlLiBDb25maXJtIHdoZXRoZXIgdGhlIHVz ZXIgcmVhbGx5CisgICAgICAgIHdhbnQgdG8gYWRkIGFsbCB0aGUgdGVzdHMgd2hlbiB0aGVyZSBh cmUgbW9yZSB0aGFuIDE1IHRlc3RzIHRvIGFkZC4KKyAgICAgICAgKiBwdWJsaWMvanMvYXV0b2Nv bXBsZXRlci5qczoKKyAgICAgICAgKEF1dG9jb21wbGV0ZXIucHJvdG90eXBlLmZpbHRlckNhbmRp ZGF0ZXMpOiBFeHRyYWN0ZWQgZnJvbSBfdXBkYXRlQ2FuZGlkYXRlcy4KKyAgICAgICAgKEF1dG9j b21wbGV0ZXIucHJvdG90eXBlLl91cGRhdGVDYW5kaWRhdGVzKTogU2hvdyB0aGUgY2FuZGlkYXRl IHdpbmRvdyBldmVuIHdoZW4gdGhlcmUgaXMKKyAgICAgICAgZXhhY3RseSBvbmUgdGVzdCB0aGF0 IG1hdGNoZXMgdGhlIGNyaXRlcmlhIHNvIHRoYXQgdGhlIHVzZXIgY2FuIHNlbGVjdCB0aGlzIHRl c3QuCisKIDIwMTMtMTAtMjUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgQnVpbGQgZml4LiBUaGUgcXVlcnkgcmVzdWx0cyB3ZXJlbid0IHNvcnRlZCBieSB0aGUg bGF0ZXN0IGNvbW1pdCB0aW1lLApJbmRleDogV2Vic2l0ZXMvdGVzdC1yZXN1bHRzL3B1YmxpYy9p bmRleC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3Rlc3QtcmVzdWx0cy9wdWJsaWMvaW5k ZXguaHRtbAkocmV2aXNpb24gMTU4MDkyKQorKysgV2Vic2l0ZXMvdGVzdC1yZXN1bHRzL3B1Ymxp Yy9pbmRleC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC01MTgsNiArNTI2LDIzIEBACiAgICAgdmFy IGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3ROYW1lJyk7CiAgICAgaW5wdXQu YXV0b2NvbXBsZXRlciA9IG5ldyBBdXRvY29tcGxldGVyKGlucHV0LCB0ZXN0TmFtZXMpOwogCisg ICAgaW5wdXQuZm9ybS5vbnN1Ym1pdCA9IGZ1bmN0aW9uIChldmVudCkgeworICAgICAgICBhZGRU ZXN0cyhpbnB1dC52YWx1ZSk7CisgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBhZGRUZXN0cyhmaWx0ZXIp IHsKKyAgICAgICAgdmFyIGNhbmRpZGF0ZXMgPSBpbnB1dC5hdXRvY29tcGxldGVyLmZpbHRlckNh bmRpZGF0ZXMoZmlsdGVyKTsKKyAgICAgICAgaWYgKGNhbmRpZGF0ZXMubGVuZ3RoID4gMTUpIHsK KyAgICAgICAgICAgIGlmICghY29uZmlybSgnQXJlIHlvdSBzdXJlIHlvdSB3YW50IHRvIGFkZCAn ICsgY2FuZGlkYXRlcy5sZW5ndGggKyAnIHRlc3RzIHRoYXQgbWF0Y2ggdGhpcyBzdWJzdHJpbmc/ JykpCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIGZvciAodmFy IGkgPSAwOyBpIDwgY2FuZGlkYXRlcy5sZW5ndGg7IGkrKykKKyAgICAgICAgICAgIFRlc3RSZXN1 bHRzVmlldy5mZXRjaFRlc3QoY2FuZGlkYXRlc1tpXSk7CisgICAgICAgIFRlc3RSZXN1bHRzVmll dy51cGRhdGVMb2NhdGlvbkhhc2goKTsKKyAgICB9CisKICAgICB2YXIgYnVpbGRlckxpc3RWaWV3 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2J1aWxkZXJMaXN0VmlldycpOwogICAgIFRlc3RS ZXN1bHRzVmlldy5fc29ydE9iamVjdHNCeU5hbWUocmVzcG9uc2VbJ2J1aWxkZXJzJ10pLmZvckVh Y2goZnVuY3Rpb24gKGJ1aWxkZXIpIHsKICAgICAgICAgYnVpbGRlckxpc3RWaWV3LmFwcGVuZENo aWxkKGVsZW1lbnQoJ29wdGlvbicsIFtidWlsZGVyLm5hbWVdKSk7CkluZGV4OiBXZWJzaXRlcy90 ZXN0LXJlc3VsdHMvcHVibGljL2pzL2F1dG9jb21wbGV0ZXIuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi c2l0ZXMvdGVzdC1yZXN1bHRzL3B1YmxpYy9qcy9hdXRvY29tcGxldGVyLmpzCShyZXZpc2lvbiAx NTgwOTIpCisrKyBXZWJzaXRlcy90ZXN0LXJlc3VsdHMvcHVibGljL2pzL2F1dG9jb21wbGV0ZXIu anMJKHdvcmtpbmcgY29weSkKQEAgLTEyLDYgKzEyLDEwIEBACiAgICAgaW5wdXRFbGVtZW50LmFk ZEV2ZW50TGlzdGVuZXIoJ2tleWRvd24nLCB0aGlzLm5hdmlnYXRlLmJpbmQodGhpcykpOwogfQog CitBdXRvY29tcGxldGVyLnByb3RvdHlwZS5maWx0ZXJDYW5kaWRhdGVzID0gZnVuY3Rpb24gKGZp bHRlcikgeworICAgIHJldHVybiB0aGlzLl9saXN0LmZpbHRlcihmdW5jdGlvbiAodGVzdE5hbWUp IHsgcmV0dXJuIHRlc3ROYW1lLmluZGV4T2YoZmlsdGVyKSA+PSAwOyB9KTsKK30KKwogQXV0b2Nv bXBsZXRlci5wcm90b3R5cGUuX2Vuc3VyZUNhbmRpZGF0ZVdpbmRvdyA9IGZ1bmN0aW9uICgpIHsK ICAgICBpZiAodGhpcy5fY2FuZGlkYXRlV2luZG93KQogICAgICAgICByZXR1cm47CkBAIC0yOCw4 ICszMiw4IEBACiAgICAgaWYgKHRoaXMuX2N1cnJlbnRGaWx0ZXIgPT0gZmlsdGVyKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKLSAgICB2YXIgY2FuZGlkYXRlcyA9IHRoaXMuX2xpc3QuZmlsdGVy KGZ1bmN0aW9uICh0ZXN0TmFtZSkgeyByZXR1cm4gdGVzdE5hbWUuaW5kZXhPZihmaWx0ZXIpID49 IDA7IH0pOwotICAgIGlmIChjYW5kaWRhdGVzLmxlbmd0aCA+IDUwIHx8IGNhbmRpZGF0ZXMubGVu Z3RoID09IDEpCisgICAgdmFyIGNhbmRpZGF0ZXMgPSB0aGlzLmZpbHRlckNhbmRpZGF0ZXMoZmls dGVyKTsKKyAgICBpZiAoY2FuZGlkYXRlcy5sZW5ndGggPiA1MCkKICAgICAgICAgY2FuZGlkYXRl cyA9IFtdOwogICAgIHRoaXMuX2NhbmRpZGF0ZXMgPSBjYW5kaWRhdGVzOwogICAgIHRoaXMuX2N1 cnJlbnRGaWx0ZXIgPSBmaWx0ZXI7Cg==