123364 2013-10-25 15:11:55 -0700 Web Inspector: Single click on links in non-read-only TextEditors should not follow links 2019-04-03 14:04:05 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy hi commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 943782 0 timothy 2013-10-25 15:11:55 -0700 We should make command-click be required for link following in all non-read-only TextEditors. Note: See SourceCodeTextEditor's tokenTrackingControllerHighlightedRangeWasClicked, TextEditor's _openClickedLinks and CSSStyleDeclarationTextEditor's tokenTrackingControllerHighlightedRangeWasClicked. 943783 1 webkit-bug-importer 2013-10-25 15:12:19 -0700 <rdar://problem/15323913> 1523864 2 366634 hi 2019-04-03 13:17:32 -0700 Created attachment 366634 Patch 1523907 3 366634 commit-queue 2019-04-03 14:04:03 -0700 Comment on attachment 366634 Patch Clearing flags on attachment: 366634 Committed r243826: <https://trac.webkit.org/changeset/243826> 1523908 4 commit-queue 2019-04-03 14:04:05 -0700 All reviewed patches have been landed. Closing bug. 366634 2019-04-03 13:17:32 -0700 2019-04-03 14:04:03 -0700 Patch bug-123364-20190403131731.patch text/plain 5738 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlmYjYwZjUzMmI4NTIwMTJkOTNiODA1M2NlYjRh YWQ3YjBhNTQ4OGQuLjc4YzYxZThjNDQxYzVjNGE1MWJmZTZhNTNkY2U4M2QwMzFhYzc4MTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTA0LTAzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBT aW5nbGUgY2xpY2sgb24gbGlua3MgaW4gbm9uLXJlYWQtb25seSBUZXh0RWRpdG9ycyBzaG91bGQg bm90IGZvbGxvdyBsaW5rcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIzMzY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNTMyMzkxMz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV0kuX3VwZGF0ZU1vZGlmaWVyS2V5cyk6CisgICAg ICAgIEFkZCBjbGFzc2VzIHRvIHRoZSBib2R5IHdoZW5ldmVyIGFsdCwgc2hpZnQsIG9yIGN0cmwg YXJlIHByZXNzZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JF ZGl0b3IuanM6CisgICAgICAgIChXSS5Db2RlTWlycm9yRWRpdG9yLmNyZWF0ZSk6CisgICAgICAg IEFkZCBhIGByZWFkLW9ubHlgIGNsYXNzIGlmIHRoZSBgQ29kZU1pcnJvcmAgaXMgcmVhZG9ubHku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1N5bnRheEhpZ2hsaWdodGluZ0RlZmF1 bHRUaGVtZS5jc3M6CisgICAgICAgICguY20tcy1kZWZhdWx0IC5jbS1saW5rLCk6CisgICAgICAg ICgucmVhZC1vbmx5LmNtLXMtZGVmYXVsdCAuY20tbGluazpob3ZlciwpOgorICAgICAgICAoLmNt LXMtZGVmYXVsdCAuY20tbGluazpob3ZlciwpOiBEZWxldGVkLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzOgorICAgICAgICAoV0kuVGV4dEVkaXRvci5wcm90 b3R5cGUuc2V0IHJlYWRPbmx5KToKKyAgICAgICAgKFdJLlRleHRFZGl0b3IucHJvdG90eXBlLl9v cGVuQ2xpY2tlZExpbmtzKToKKwogMjAxOS0wNC0wMiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRWxlbWVudHM6IERPTSBicmVha3Bv aW50IGljb24gc2hvdWxkIHN0cm9rZSB3aGVuIGhvdmVyaW5nIHNlbGVjdGlvbiBhcmVhCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXgg YWE2N2RjZWQ4Y2QwYzcwNmYwOTcwYmY4ZTcwM2IyYTc4OWJlZTgwNS4uMDRjZjU0MzFiNTNjOGFm YTU3NjE2ODAxZWRmYzdjN2ZjYTVkY2M5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTY1MSwxNSArMTY1MSwyMyBAQCBXSS5f d2luZG93UmVzaXplZCA9IGZ1bmN0aW9uKGV2ZW50KQogCiBXSS5fdXBkYXRlTW9kaWZpZXJLZXlz ID0gZnVuY3Rpb24oZXZlbnQpCiB7Ci0gICAgbGV0IG1ldGFLZXlEaWRDaGFuZ2UgPSB0aGlzLm1v ZGlmaWVyS2V5cy5tZXRhS2V5ICE9PSBldmVudC5tZXRhS2V5OwotICAgIGxldCBkaWRDaGFuZ2Ug PSB0aGlzLm1vZGlmaWVyS2V5cy5hbHRLZXkgIT09IGV2ZW50LmFsdEtleSB8fCBtZXRhS2V5RGlk Q2hhbmdlIHx8IHRoaXMubW9kaWZpZXJLZXlzLnNoaWZ0S2V5ICE9PSBldmVudC5zaGlmdEtleTsK KyAgICBsZXQga2V5cyA9IHsKKyAgICAgICAgYWx0S2V5OiBldmVudC5hbHRLZXksCisgICAgICAg IG1ldGFLZXk6IGV2ZW50Lm1ldGFLZXksCisgICAgICAgIGN0cmxLZXk6IGV2ZW50LmN0cmxLZXks CisgICAgICAgIHNoaWZ0S2V5OiBldmVudC5zaGlmdEtleSwKKyAgICB9OwogCi0gICAgdGhpcy5t b2RpZmllcktleXMgPSB7YWx0S2V5OiBldmVudC5hbHRLZXksIG1ldGFLZXk6IGV2ZW50Lm1ldGFL ZXksIHNoaWZ0S2V5OiBldmVudC5zaGlmdEtleX07CisgICAgbGV0IGNoYW5nZWQgPSAhT2JqZWN0 LnNoYWxsb3dFcXVhbCh0aGlzLm1vZGlmaWVyS2V5cywga2V5cyk7CiAKLSAgICBpZiAobWV0YUtl eURpZENoYW5nZSkKLSAgICAgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QudG9nZ2xlKCJtZXRh LWtleS1wcmVzc2VkIiwgdGhpcy5tb2RpZmllcktleXMubWV0YUtleSk7CisgICAgdGhpcy5tb2Rp ZmllcktleXMgPSBrZXlzOwogCi0gICAgaWYgKGRpZENoYW5nZSkKKyAgICBkb2N1bWVudC5ib2R5 LmNsYXNzTGlzdC50b2dnbGUoImFsdC1rZXktcHJlc3NlZCIsIHRoaXMubW9kaWZpZXJLZXlzLmFs dEtleSk7CisgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QudG9nZ2xlKCJjdHJsLWtleS1wcmVz c2VkIiwgdGhpcy5tb2RpZmllcktleXMuY3RybEtleSk7CisgICAgZG9jdW1lbnQuYm9keS5jbGFz c0xpc3QudG9nZ2xlKCJtZXRhLWtleS1wcmVzc2VkIiwgdGhpcy5tb2RpZmllcktleXMubWV0YUtl eSk7CisgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QudG9nZ2xlKCJzaGlmdC1rZXktcHJlc3Nl ZCIsIHRoaXMubW9kaWZpZXJLZXlzLnNoaWZ0S2V5KTsKKworICAgIGlmIChjaGFuZ2VkKQogICAg ICAgICB0aGlzLm5vdGlmaWNhdGlvbnMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLk5vdGlm aWNhdGlvbi5HbG9iYWxNb2RpZmllcktleXNEaWRDaGFuZ2UsIGV2ZW50KTsKIH07CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJy b3JFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D b2RlTWlycm9yRWRpdG9yLmpzCmluZGV4IDY2ZTQ3ZWViMDFkNTYyYzQ5M2M1M2QwYTM2NzljNDk1 NDRhNzFkYWIuLmY0NTNjYzcxOGRlZWMzNzg3MDQ5ZjliOWJiNGVmM2ZjNzRjNzRhMjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJy b3JFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ29kZU1pcnJvckVkaXRvci5qcwpAQCAtMzEsNiArMzEsNyBAQCBXSS5Db2RlTWlycm9yRWRp dG9yID0gY2xhc3MgQ29kZU1pcnJvckVkaXRvcgogICAgICAgICAvLyBub3IgZG9lcyBpdCBoYW5k bGUgYnJhY2VzIGFuZCBicmFja2V0cyB3ZWxsLCBzbyBkZWZhdWx0IHRvIHVzaW5nIExUUi4KICAg ICAgICAgLy8gQ2xpZW50cyBjYW4gb3ZlcnJpZGUgdGhpcyBpZiBjdXN0b20gbGF5b3V0IGZvciBS VEwgaXMgYXZhaWxhYmxlLgogICAgICAgICBlbGVtZW50LnNldEF0dHJpYnV0ZSgiZGlyIiwgImx0 ciIpOworICAgICAgICBlbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoInJlYWQtb25seSIsIG9wdGlv bnMucmVhZE9ubHkpOwogCiAgICAgICAgIGxldCBjb2RlTWlycm9yID0gbmV3IENvZGVNaXJyb3Io ZWxlbWVudCwgb3B0aW9ucyk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1N5bnRheEhpZ2hsaWdodGluZ0RlZmF1bHRUaGVtZS5jc3MgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TeW50YXhIaWdobGlnaHRp bmdEZWZhdWx0VGhlbWUuY3NzCmluZGV4IDNiYjQ0MzJmYTRhMGMxOWU1Y2U2MTQ1OGQ3MmM0NzM5 YmVjNzAwZDIuLmY0NTlkZTE0M2QyZTgwYzg0OThmNDAxYjllOTJiNzdlZGZkMjg3ZDMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N5bnRheEhp Z2hsaWdodGluZ0RlZmF1bHRUaGVtZS5jc3MKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvU3ludGF4SGlnaGxpZ2h0aW5nRGVmYXVsdFRoZW1lLmNzcwpAQCAt ODIsMTIgKzgyLDE0IEBACiAuY20tcy1kZWZhdWx0IC5jbS1saW5rLAogLnN5bnRheC1oaWdobGln aHRlZCBhIHsKICAgICB0ZXh0LWRlY29yYXRpb246IG5vbmU7Ci0gICAgY3Vyc29yOiBwb2ludGVy OwogfQogCi0uY20tcy1kZWZhdWx0IC5jbS1saW5rOmhvdmVyLAorLnJlYWQtb25seS5jbS1zLWRl ZmF1bHQgLmNtLWxpbms6aG92ZXIsCisubWFjLXBsYXRmb3JtLm1ldGEta2V5LXByZXNzZWQgOm5v dCgucmVhZC1vbmx5KS5jbS1zLWRlZmF1bHQgLmNtLWxpbms6aG92ZXIsCis6bm90KC5tYWMtcGxh dGZvcm0pLmNvbnRyb2wta2V5LXByZXNzZWQgOm5vdCgucmVhZC1vbmx5KS5jbS1zLWRlZmF1bHQg LmNtLWxpbms6aG92ZXIsCiAuc3ludGF4LWhpZ2hsaWdodGVkIGE6aG92ZXIgewogICAgIHRleHQt ZGVjb3JhdGlvbjogdW5kZXJsaW5lOworICAgIGN1cnNvcjogcG9pbnRlcjsKIH0KIAogLnN1cHBv cnRzLWZpbmQtYmFubmVyLnNob3dpbmctZmluZC1iYW5uZXIuc3ludGF4LWhpZ2hsaWdodGVkIC5z ZWFyY2gtcmVzdWx0LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5kZXggN2VhYzFlZjdkMzFjNzA0MDcxMmI3NGEw NmEzMDUxZjU4OTk1ZjQyYy4uODE0ZjI0YjdlMDhjMDY4ZjBkYzM2ZjU0MWExMmFiM2NkMjA0ZWI3 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UZXh0RWRpdG9yLmpzCkBAIC0xODAsNiArMTgwLDcgQEAgV0kuVGV4dEVkaXRvciA9IGNs YXNzIFRleHRFZGl0b3IgZXh0ZW5kcyBXSS5WaWV3CiAgICAgc2V0IHJlYWRPbmx5KHJlYWRPbmx5 KQogICAgIHsKICAgICAgICAgdGhpcy5fY29kZU1pcnJvci5zZXRPcHRpb24oInJlYWRPbmx5Iiwg cmVhZE9ubHkpOworICAgICAgICB0aGlzLl9jb2RlTWlycm9yLmdldFdyYXBwZXJFbGVtZW50KCku Y2xhc3NMaXN0LnRvZ2dsZSgicmVhZC1vbmx5IiwgISFyZWFkT25seSk7CiAgICAgfQogCiAgICAg Z2V0IGZvcm1hdHRlZCgpCkBAIC0xNjg3LDYgKzE2ODgsOSBAQCBXSS5UZXh0RWRpdG9yID0gY2xh c3MgVGV4dEVkaXRvciBleHRlbmRzIFdJLlZpZXcKIAogICAgIF9vcGVuQ2xpY2tlZExpbmtzKGV2 ZW50KQogICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLnJlYWRPbmx5ICYmICFldmVudC5jb21tYW5k T3JDb250cm9sS2V5KQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIC8vIEdldCB0aGUg cG9zaXRpb24gaW4gdGhlIHRleHQgYW5kIHRoZSB0b2tlbiBhdCB0aGF0IHBvc2l0aW9uLgogICAg ICAgICB2YXIgcG9zaXRpb24gPSB0aGlzLl9jb2RlTWlycm9yLmNvb3Jkc0NoYXIoe2xlZnQ6IGV2 ZW50LnBhZ2VYLCB0b3A6IGV2ZW50LnBhZ2VZfSk7CiAgICAgICAgIHZhciB0b2tlbkluZm8gPSB0 aGlzLl9jb2RlTWlycm9yLmdldFRva2VuQXQocG9zaXRpb24pOwo=