123362 2013-10-25 14:49:33 -0700 Web Inspector: Command+Click on url(…) should go to image not source line 2013-10-25 15:21:38 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 943763 0 joepeck 2013-10-25 14:49:33 -0700 TEST: <style>body { background: url(x.png)</style> <body>Test</body> STEPS TO REPRODUCE: 1. Inspect <body> on test page 2. Command + Click "x.png" in the styles sidebar => expected to go to the image, instead it went to the html resource's source code NOTES: • This is a regression, we had this working at one point! 943764 1 webkit-bug-importer 2013-10-25 14:49:47 -0700 <rdar://problem/15323658> 943766 2 215216 joepeck 2013-10-25 14:51:02 -0700 Created attachment 215216 [PATCH] Proposed Fix 943787 3 215216 commit-queue 2013-10-25 15:21:37 -0700 Comment on attachment 215216 [PATCH] Proposed Fix Clearing flags on attachment: 215216 Committed r158061: <http://trac.webkit.org/changeset/158061> 943788 4 commit-queue 2013-10-25 15:21:38 -0700 All reviewed patches have been landed. Closing bug. 215216 2013-10-25 14:51:02 -0700 2013-10-25 15:21:37 -0700 [PATCH] Proposed Fix p.patch text/plain 1437 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkwNTY1NmQwLi41NzlkOWNhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0xMC0yNSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbW1h bmQrQ2xpY2sgb24gdXJsKOKApikgc2hvdWxkIGdvIHRvIGltYWdlIG5vdCBzb3VyY2UgbGluZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMzYyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29kZU1pcnJv ciBjaGFuZ2VkICJ1cmwiIGZyb20gYmVpbmcgdHlwZSAidmFyaWFibGUtMiIgdG8gInN0cmluZy0y Ii4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29kZU1pcnJvckFkZGl0aW9ucy5qczoKKwog MjAxMy0xMC0yNSAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJhbiB1cGRhdGUtbG9jYWxpemFibGUtc3RyaW5ncyBhZnRlciBjaGFuZ2VzIG1hZGUgaW4gcjE1 Nzk0Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv ZGVNaXJyb3JBZGRpdGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Db2RlTWlycm9yQWRkaXRpb25zLmpzCmluZGV4IGY4NzQ5OTcuLjY2YzA4ZjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvZGVNaXJyb3JBZGRpdGlv bnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29kZU1pcnJv ckFkZGl0aW9ucy5qcwpAQCAtMTg3LDcgKzE4Nyw3IEBACiAgICAgICAgIHZhciBzdHlsZSA9IHRo aXMuX3Rva2VuKHN0cmVhbSwgc3RhdGUpOwogCiAgICAgICAgIGlmIChzdHlsZSkgewotICAgICAg ICAgICAgaWYgKHN0eWxlID09PSAidmFyaWFibGUtMiIgJiYgc3RyZWFtLmN1cnJlbnQoKSA9PT0g InVybCIpIHsKKyAgICAgICAgICAgIGlmIChzdHlsZSA9PT0gInN0cmluZy0yIiAmJiBzdHJlYW0u Y3VycmVudCgpID09PSAidXJsIikgewogICAgICAgICAgICAgICAgIC8vIElmIHRoZSBjdXJyZW50 IHRleHQgaXMgInVybCIgdGhlbiB3ZSBzaG91bGQgZXhwZWN0IHRoZSBuZXh0IHN0cmluZyB0b2tl biB0byBiZSBhIGxpbmsuCiAgICAgICAgICAgICAgICAgc3RhdGUuX2V4cGVjdExpbmsgPSB0cnVl OwogICAgICAgICAgICAgfSBlbHNlIGlmIChzdGF0ZS5fZXhwZWN0TGluayAmJiBzdHlsZSA9PT0g InN0cmluZyIpIHsK