123361 2013-10-25 14:45:07 -0700 Web Inspector: CSS Regions: Add layout tests for the new events in the DOMTreeManager 2013-10-25 15:23:11 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 achicu achicu commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 943759 0 achicu 2013-10-25 14:45:07 -0700 Create tests for WebInspector.DOMTree.Event.ContentFlowWasAdded and WebInspector.DOMTree.Event.ContentFlowWasRemoved. 943760 1 webkit-bug-importer 2013-10-25 14:45:38 -0700 <rdar://problem/15323616> 943765 2 215215 achicu 2013-10-25 14:50:04 -0700 Created attachment 215215 Patch V1 943768 3 215215 timothy 2013-10-25 14:52:07 -0700 Comment on attachment 215215 Patch V1 I'm liking these tests! And I normally don't like tests. 943789 4 215215 commit-queue 2013-10-25 15:23:09 -0700 Comment on attachment 215215 Patch V1 Clearing flags on attachment: 215215 Committed r158062: <http://trac.webkit.org/changeset/158062> 943790 5 commit-queue 2013-10-25 15:23:11 -0700 All reviewed patches have been landed. Closing bug. 215215 2013-10-25 14:50:04 -0700 2013-10-25 15:23:09 -0700 Patch V1 bug123361.patch text/plain 6228 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OGY3Y2JlLi44OGY2ZDE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTMtMTAt MjUgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IENTUyBSZWdpb25zOiBBZGQgbGF5b3V0IHRlc3RzIGZvciB0aGUgbmV3IGV2 ZW50cyBpbiB0aGUgRE9NVHJlZU1hbmFnZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMzM2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENyZWF0ZWQgYSB0ZXN0IHRvIGNoZWNrIHRoYXQgV2ViSW5zcGVj dG9yLkRPTVRyZWUuRXZlbnQuQ29udGVudEZsb3dXYXNBZGRlZCBhbmQKKyAgICAgICAgV2ViSW5z cGVjdG9yLkRPTVRyZWUuRXZlbnQuQ29udGVudEZsb3dXYXNSZW1vdmVkIGFyZSBkaXNwYXRjaGVk IHdoZW4gYSBmbG93IGlzIGFkZGVkCisgICAgICAgIGFuZCByZW1vdmVkLgorCisgICAgICAgICog aHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3VyY2VzL0luc3BlY3RvclRlc3QuanM6 CisgICAgICAgIChJbnNwZWN0b3JUZXN0LmFzc2VydCk6IFNpbWlsYXIgdG8gSW5zcGVjdG9yVGVz dC5sb2csIGJ1dCBhbHNvIHRha2VzIGEgYm9vbGVhbiBhbmQgcHJlZml4ZXMgdGhlIG1lc3NhZ2Ug CisgICAgICAgIHdpdGggIkZBSUwiIG9yICJQQVNTIiBkZXBlbmRpbmcgb24gdGhlIHZhbHVlLgor ICAgICAgICAoSW5zcGVjdG9yVGVzdC5pbXBvcnRJbnNwZWN0b3JTY3JpcHRzKTogQWRkZWQgdGhl IHJlcXVpcmVkIENTUyBBZ2VudCBzY3JpcHRzIHRvIGVuYWJsZSB0aGUgZmxvdyB0aHJlYWQgZXZl bnRzLgorICAgICAgICAqIGluc3BlY3Rvci1wcm90b2NvbC9tb2RlbC9jb250ZW50LWZsb3ctbGlz dC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci1wcm90b2NvbC9tb2Rl bC9jb250ZW50LWZsb3ctbGlzdC5odG1sOiBBZGRlZC4KKwogMjAxMy0xMC0yNSAgTWFudWVsIFJl Z28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIFJlZ2lvbnNd IFJlbmFtZSBDU1MgY2xhc3NlcyBhbmQgSlMgbWV0aG9kcyBpbiB2ZXJ0aWNhbCBsYXlvdXQgdGVz dHMgYWJvdXQgc2VsZWN0aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2lu c3BlY3Rvci1wcm90b2NvbC9yZXNvdXJjZXMvSW5zcGVjdG9yVGVzdC5qcyBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9JbnNwZWN0b3JUZXN0Lmpz CmluZGV4IGY0OTYzNjQuLjhlMGZiNmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9JbnNwZWN0b3JUZXN0LmpzCisrKyBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9JbnNwZWN0 b3JUZXN0LmpzCkBAIC03NSw2ICs3NSwxNyBAQCBJbnNwZWN0b3JUZXN0LmxvZyA9IGZ1bmN0aW9u KG1lc3NhZ2UpCiB9CiAKIC8qKgorKiBMb2dzIGFuIGFzc2VydCBtZXNzYWdlIHRvIGRvY3VtZW50 LgorKiBAcGFyYW0ge2Jvb2xlYW59IGNvbmRpdGlvbgorKiBAcGFyYW0ge3N0cmluZ30gbWVzc2Fn ZQorKi8KK0luc3BlY3RvclRlc3QuYXNzZXJ0ID0gZnVuY3Rpb24oY29uZGl0aW9uLCBtZXNzYWdl KQoreworICAgIHZhciBzdGF0dXMgPSBjb25kaXRpb24gPyAiUEFTUyIgOiAiRkFJTCI7CisgICAg dGhpcy5zZW5kQ29tbWFuZCgiUnVudGltZS5ldmFsdWF0ZSIsIHsgImV4cHJlc3Npb24iOiAibG9n KCIgKyBKU09OLnN0cmluZ2lmeShzdGF0dXMgKyAiOiAiICsgbWVzc2FnZSkgKyAiKSIgfSApOwor fQorCisvKioKICogTG9ncyBtZXNzYWdlIGRpcmVjdGx5IHRvIHByb2Nlc3Mgc3Rkb3V0IHZpYSBh bGVydCBmdW5jdGlvbiAoaG9wZWZ1bGx5IGZvbGxvd2VkIGJ5IGZsdXNoIGNhbGwpLgogKiBUaGlz IG1lc3NhZ2Ugc2hvdWxkIHN1cnZpdmUgcHJvY2VzcyBjcmFzaCBvciBraWxsIGJ5IHRpbWVvdXQu CiAqIEBwYXJhbSB7c3RyaW5nfSBtZXNzYWdlCkBAIC0xMzAsNiArMTQxLDcgQEAgSW5zcGVjdG9y VGVzdC5pbXBvcnRJbnNwZWN0b3JTY3JpcHRzID0gZnVuY3Rpb24oKQogICAgICAgICAiU2V0dGlu ZyIsCiAgICAgICAgICJQYWdlT2JzZXJ2ZXIiLAogICAgICAgICAiRE9NT2JzZXJ2ZXIiLAorICAg ICAgICAiQ1NTT2JzZXJ2ZXIiLAogICAgICAgICAiRnJhbWVSZXNvdXJjZU1hbmFnZXIiLAogICAg ICAgICAiUnVudGltZU1hbmFnZXIiLAogICAgICAgICAiRnJhbWUiLApAQCAtMTQzLDcgKzE1NSw5 IEBAIEluc3BlY3RvclRlc3QuaW1wb3J0SW5zcGVjdG9yU2NyaXB0cyA9IGZ1bmN0aW9uKCkKICAg ICAgICAgIkNvbnRlbnRGbG93IiwKICAgICAgICAgIkRPTVRyZWUiLAogICAgICAgICAiRXhlY3V0 aW9uQ29udGV4dCIsCi0gICAgICAgICJFeGVjdXRpb25Db250ZXh0TGlzdCIKKyAgICAgICAgIkV4 ZWN1dGlvbkNvbnRleHRMaXN0IiwKKyAgICAgICAgIkNTU1N0eWxlTWFuYWdlciIsCisgICAgICAg ICJDb2xvciIKICAgICBdOwogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgaW5zcGVjdG9yU2NyaXB0 cy5sZW5ndGg7ICsraSkKICAgICAgICAgSW5zcGVjdG9yVGVzdC5pbXBvcnRTY3JpcHQoIi4uLy4u Ly4uLy4uLy4uL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlLyIgKyBpbnNwZWN0 b3JTY3JpcHRzW2ldICsgIi5qcyIpOwpAQCAtMTU0LDkgKzE2OCwxMSBAQCBJbnNwZWN0b3JUZXN0 LmltcG9ydEluc3BlY3RvclNjcmlwdHMgPSBmdW5jdGlvbigpCiAKICAgICBJbnNwZWN0b3JCYWNr ZW5kLnJlZ2lzdGVyUGFnZURpc3BhdGNoZXIobmV3IFdlYkluc3BlY3Rvci5QYWdlT2JzZXJ2ZXIp OwogICAgIEluc3BlY3RvckJhY2tlbmQucmVnaXN0ZXJET01EaXNwYXRjaGVyKG5ldyBXZWJJbnNw ZWN0b3IuRE9NT2JzZXJ2ZXIpOworICAgIEluc3BlY3RvckJhY2tlbmQucmVnaXN0ZXJDU1NEaXNw YXRjaGVyKG5ldyBXZWJJbnNwZWN0b3IuQ1NTT2JzZXJ2ZXIpOwogCiAgICAgV2ViSW5zcGVjdG9y LmZyYW1lUmVzb3VyY2VNYW5hZ2VyID0gbmV3IFdlYkluc3BlY3Rvci5GcmFtZVJlc291cmNlTWFu YWdlcjsKICAgICBXZWJJbnNwZWN0b3IuZG9tVHJlZU1hbmFnZXIgPSBuZXcgV2ViSW5zcGVjdG9y LkRPTVRyZWVNYW5hZ2VyOworICAgIFdlYkluc3BlY3Rvci5jc3NTdHlsZU1hbmFnZXIgPSBuZXcg V2ViSW5zcGVjdG9yLkNTU1N0eWxlTWFuYWdlcjsKIAogICAgIEluc3BlY3RvckZyb250ZW5kSG9z dC5sb2FkZWQoKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2Nv bC9tb2RlbC9jb250ZW50LWZsb3ctbGlzdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNw ZWN0b3ItcHJvdG9jb2wvbW9kZWwvY29udGVudC1mbG93LWxpc3QtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjVhMTUwYzIKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvbW9kZWwvY29udGVudC1mbG93LWxpc3Qt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorVGVzdGluZyB0aGF0IHRoZSBDb250ZW50Rmxv d3MgZXZlbnRzIGFyZSBjb3JyZWN0bHkgZGlzcGF0Y2hlZCB3aGVuIG5ldyBmbG93cyBhcmUgY3Jl YXRlZC9yZW1vdmVkLgorCitQQVNTOiBDb250ZW50RmxvdyB3YXMgYWRkZWQKK1BBU1M6IEZsb3cg Y291bnQgaXMgMQorUEFTUzogQ29udGVudEZsb3cgd2FzIHJlbW92ZWQKK1BBU1M6IEZsb3cgY291 bnQgaXMgMAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvbW9k ZWwvY29udGVudC1mbG93LWxpc3QuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2Nv bC9tb2RlbC9jb250ZW50LWZsb3ctbGlzdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLmEyNzNlYjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0 b3ItcHJvdG9jb2wvbW9kZWwvY29udGVudC1mbG93LWxpc3QuaHRtbApAQCAtMCwwICsxLDU2IEBA Cis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisjZmxvdzEKK3sKKyAg ICAtd2Via2l0LWZsb3ctaW50bzogZmxvdzE7Cit9Cis8L3N0eWxlPgorPHNjcmlwdCB0eXBlPSJ0 ZXh0L2phdmFzY3JpcHQiIHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wv cmVzb3VyY2VzL3Byb3RvY29sLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9u IHJlbW92ZUZsb3coKQoreworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJmbG93MSIpLnJl bW92ZSgpOworfQorCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBJbnNwZWN0b3JUZXN0LmltcG9y dEluc3BlY3RvclNjcmlwdHMoKTsKKworICAgIFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFu YWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5GcmFtZVJlc291cmNlTWFuYWdlci5F dmVudC5NYWluRnJhbWVEaWRDaGFuZ2UsIGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgIHZhciBk b21UcmVlID0gV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3VyY2VNYW5hZ2VyLm1haW5GcmFtZS5kb21U cmVlOworICAgICAgICBkb21UcmVlLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRPTVRy ZWUuRXZlbnQuUm9vdERPTU5vZGVJbnZhbGlkYXRlZCwgb25Sb290RE9NTm9kZUludmFsaWRhdGVk LCBudWxsKTsKKyAgICAgICAgZG9tVHJlZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5E T01UcmVlLkV2ZW50LkNvbnRlbnRGbG93V2FzQWRkZWQsIG9uQ29udGVudEZsb3dXYXNBZGRlZCwg bnVsbCk7CisgICAgICAgIGRvbVRyZWUuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRE9N VHJlZS5FdmVudC5Db250ZW50Rmxvd1dhc1JlbW92ZWQsIG9uQ29udGVudEZsb3dXYXNSZW1vdmVk LCBudWxsKTsKKyAgICAgICAgZG9tVHJlZS5yZXF1ZXN0Q29udGVudEZsb3dMaXN0KCk7CisgICAg fSk7CisKKyAgICBmdW5jdGlvbiBvblJvb3RET01Ob2RlSW52YWxpZGF0ZWQoKQorICAgIHsKKyAg ICAgICAgV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3VyY2VNYW5hZ2VyLm1haW5GcmFtZS5kb21UcmVl LnJlcXVlc3RDb250ZW50Rmxvd0xpc3QoKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBvbkNvbnRl bnRGbG93V2FzQWRkZWQoZXZlbnQpCisgICAgeworICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2Vy dChldmVudC5kYXRhLmZsb3cubmFtZSA9PT0gImZsb3cxIiwgIkNvbnRlbnRGbG93IHdhcyBhZGRl ZCIpOworICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydChXZWJJbnNwZWN0b3IuZnJhbWVSZXNv dXJjZU1hbmFnZXIubWFpbkZyYW1lLmRvbVRyZWUuZmxvd3NDb3VudCA9PT0gMSwgIkZsb3cgY291 bnQgaXMgMSIpOworICAgICAgICAKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29tbWFuZCgi UnVudGltZS5ldmFsdWF0ZSIsIHtleHByZXNzaW9uOiAicmVtb3ZlRmxvdygpIn0pOworICAgIH0K KyAgICAKKyAgICBmdW5jdGlvbiBvbkNvbnRlbnRGbG93V2FzUmVtb3ZlZChldmVudCkKKyAgICB7 CisgICAgICAgIEluc3BlY3RvclRlc3QuYXNzZXJ0KGV2ZW50LmRhdGEuZmxvdy5uYW1lID09PSAi ZmxvdzEiLCAiQ29udGVudEZsb3cgd2FzIHJlbW92ZWQiKTsKKyAgICAgICAgSW5zcGVjdG9yVGVz dC5hc3NlcnQoV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3VyY2VNYW5hZ2VyLm1haW5GcmFtZS5kb21U cmVlLmZsb3dzQ291bnQgPT09IDAsICJGbG93IGNvdW50IGlzIDAiKTsKKyAgICAgICAgSW5zcGVj dG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKKyAgICB9Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKyAgICA8cD5UZXN0aW5nIHRoYXQgdGhlIENvbnRlbnRG bG93cyBldmVudHMgYXJlIGNvcnJlY3RseSBkaXNwYXRjaGVkIHdoZW4gbmV3IGZsb3dzIGFyZSBj cmVhdGVkL3JlbW92ZWQuPC9wPgorICAgIAorICAgIDxkaXYgaWQ9ImZsb3cxIj48L2Rpdj4KKzwv Ym9keT4KKzwvaHRtbD4K