123342 2013-10-25 08:00:39 -0700 Faster way for simple line layout to check if text has fallback fonts 2013-10-25 08:57:39 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 943586 0 koivisto 2013-10-25 08:00:39 -0700 The current strategy of calling RenderText::knownToHaveNoOverflowAndNoFallbackFonts is slow. 943591 1 215176 koivisto 2013-10-25 08:10:19 -0700 Created attachment 215176 patch 943599 2 215176 kling 2013-10-25 08:47:07 -0700 Comment on attachment 215176 patch Clever! 943605 3 koivisto 2013-10-25 08:57:39 -0700 https://trac.webkit.org/r158012 215176 2013-10-25 08:10:19 -0700 2013-10-25 08:47:07 -0700 patch simple-line-font-fallback-test.patch text/plain 4034 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODAxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEzLTEwLTI1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBGYXN0ZXIgd2F5IGZvciBzaW1w bGUgbGluZSBsYXlvdXQgdG8gY2hlY2sgaWYgdGV4dCBoYXMgZmFsbGJhY2sgZm9udHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzM0MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgRG9uJ3Qg dXNlIFJlbmRlclRleHQ6Omtub3duVG9IYXZlTm9PdmVyZmxvd0FuZE5vRmFsbGJhY2tGb250cyBh cyBpdCBpcyBzbG93LgorCisgICAgICAgIFNpbXBsZSB0ZXh0IGNvZGUgcGF0aCB0ZXN0IGFscmVh ZHkgZ3VhcmFudGVlcyB0aGVyZSBpcyBubyBvdmVyZmxvdy4gVGVzdCBmb3IgZmFsbGJhY2sKKyAg ICAgICAgZm9udHMgZXhwbGljaXRseS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1Np bXBsZUZvbnREYXRhLmg6CisgICAgICAgIAorICAgICAgICAgICAgTWFrZSBGSU5BTC4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyVGV4dC5oOgorICAgICAgICAKKyAgICAgICAgICAgIFJlbW92ZSBrbm93blRvSGF2ZU5vT3Zl cmZsb3dBbmROb0ZhbGxiYWNrRm9udHMoKSBhcyBpdCBoYXMgbm8gY2xpZW50cy4KKworICAgICAg ICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNp bXBsZUxpbmVMYXlvdXQ6OmNhblVzZUZvcik6CisgICAgICAgIAorICAgICAgICAgICAgQ2hlY2sg aWYgYWxsIGNoYXJhY3RlcnMgY2FuIGJlIGZvdW5kIGZyb20gdGhlIHByaW1hcnkgZm9udC4KKwog MjAxMy0xMC0yNSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAg U1ZHUmVzb3VyY2VzQ2FjaGU6OmNsaWVudERlc3Ryb3llZCgpIHNob3VsZCB0YWtlIGEgUmVuZGVy RWxlbWVudCYuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TaW1wbGVG b250RGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L1NpbXBsZUZvbnREYXRhLmgJKHJldmlzaW9uIDE1Nzk5NikKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1NpbXBsZUZvbnREYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDcg KzY1LDcgQEAgc3RydWN0IFdpZHRoSXRlcmF0b3I7CiBlbnVtIEZvbnREYXRhVmFyaWFudCB7IEF1 dG9WYXJpYW50LCBOb3JtYWxWYXJpYW50LCBTbWFsbENhcHNWYXJpYW50LCBFbXBoYXNpc01hcmtW YXJpYW50LCBCcm9rZW5JZGVvZ3JhcGhWYXJpYW50IH07CiBlbnVtIFBpdGNoIHsgVW5rbm93blBp dGNoLCBGaXhlZFBpdGNoLCBWYXJpYWJsZVBpdGNoIH07CiAKLWNsYXNzIFNpbXBsZUZvbnREYXRh IDogcHVibGljIEZvbnREYXRhIHsKK2NsYXNzIFNpbXBsZUZvbnREYXRhIEZJTkFMIDogcHVibGlj IEZvbnREYXRhIHsKIHB1YmxpYzoKICAgICBjbGFzcyBBZGRpdGlvbmFsRm9udERhdGEgewogICAg ICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGV4dC5jcHAJKHJldmlzaW9uIDE1Nzk5NikKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEwLDE0ICs1MTAsNiBA QCBmbG9hdCBSZW5kZXJUZXh0OjptYXhMb2dpY2FsV2lkdGgoKSBjb25zCiAgICAgcmV0dXJuIG1f bWF4V2lkdGg7CiB9CiAKLWJvb2wgUmVuZGVyVGV4dDo6a25vd25Ub0hhdmVOb092ZXJmbG93QW5k Tm9GYWxsYmFja0ZvbnRzKCkgY29uc3QKLXsKLSAgICBpZiAocHJlZmVycmVkTG9naWNhbFdpZHRo c0RpcnR5KCkpCi0gICAgICAgIGNvbnN0X2Nhc3Q8UmVuZGVyVGV4dCo+KHRoaXMpLT5jb21wdXRl UHJlZmVycmVkTG9naWNhbFdpZHRocygwKTsKLQotICAgIHJldHVybiBtX2tub3duVG9IYXZlTm9P dmVyZmxvd0FuZE5vRmFsbGJhY2tGb250czsKLX0KLQogdm9pZCBSZW5kZXJUZXh0Ojpjb21wdXRl UHJlZmVycmVkTG9naWNhbFdpZHRocyhmbG9hdCBsZWFkV2lkdGgpCiB7CiAgICAgSGFzaFNldDxj b25zdCBTaW1wbGVGb250RGF0YSo+IGZhbGxiYWNrRm9udHM7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0LmgJKHJldmlzaW9uIDE1Nzk5NikKKysrIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUZXh0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE0MCw3ICsxNDAsNiBA QCBwdWJsaWM6CiAgICAgYm9vbCBpc0FsbENvbGxhcHNpYmxlV2hpdGVzcGFjZSgpIGNvbnN0Owog CiAgICAgYm9vbCBjYW5Vc2VTaW1wbGVGb250Q29kZVBhdGgoKSBjb25zdCB7IHJldHVybiBtX2Nh blVzZVNpbXBsZUZvbnRDb2RlUGF0aDsgfQotICAgIGJvb2wga25vd25Ub0hhdmVOb092ZXJmbG93 QW5kTm9GYWxsYmFja0ZvbnRzKCkgY29uc3Q7CiAKICAgICB2b2lkIHJlbW92ZUFuZERlc3Ryb3lU ZXh0Qm94ZXMoKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVM YXlvdXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVM aW5lTGF5b3V0LmNwcAkocmV2aXNpb24gMTU4MDA3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDgsOCArMTQ4LDgg QEAgYm9vbCBjYW5Vc2VGb3IoY29uc3QgUmVuZGVyQmxvY2tGbG93JiBmbAogICAgICAgICByZXR1 cm4gZmFsc2U7CiAgICAgaWYgKHN0eWxlLmZvbnQoKS5jb2RlUGF0aChUZXh0UnVuKHRleHRSZW5k ZXJlci50ZXh0KCkpKSAhPSBGb250OjpTaW1wbGUpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAg ICBpZiAoIXRleHRSZW5kZXJlci5rbm93blRvSGF2ZU5vT3ZlcmZsb3dBbmROb0ZhbGxiYWNrRm9u dHMoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgYXV0byBwcmltYXJ5Rm9udERhdGEg PSBzdHlsZS5mb250KCkucHJpbWFyeUZvbnQoKTsKIAogICAgIHVuc2lnbmVkIGxlbmd0aCA9IHRl eHRSZW5kZXJlci50ZXh0TGVuZ3RoKCk7CiAgICAgdW5zaWduZWQgY29uc2VjdXRpdmVTcGFjZUNv dW50ID0gMDsKQEAgLTE3OCw2ICsxNzgsOCBAQCBib29sIGNhblVzZUZvcihjb25zdCBSZW5kZXJC bG9ja0Zsb3cmIGZsCiAgICAgICAgICAgICAgICAgfHwgZGlyZWN0aW9uID09IFVfTEVGVF9UT19S SUdIVF9FTUJFRERJTkcgfHwgZGlyZWN0aW9uID09IFVfTEVGVF9UT19SSUdIVF9PVkVSUklERSkK ICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KKyAgICAgICAgaWYgKCFw cmltYXJ5Rm9udERhdGEtPmdseXBoRm9yQ2hhcmFjdGVyKGNoYXJhY3RlcikpCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgfQogICAgIHJldHVybiB0cnVlOwogfQo=