123338 2013-10-25 06:43:05 -0700 Re-enable simple line layout on non-Mac platforms 2014-02-06 09:25:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 123388 123402 1 koivisto ossy commit-queue esprehn+autocc glenn kondapallykalyan ossy roger_fong svillar zan oldest_to_newest 943571 0 koivisto 2013-10-25 06:43:05 -0700 It hits ASSERT(run.charactersLength() >= run.length()) in textWidth(). for example: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20WK1/builds/4983 http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK1/builds/2321 943576 1 koivisto 2013-10-25 06:48:37 -0700 Some 943577 2 koivisto 2013-10-25 06:49:30 -0700 It is not obvious from code what the difference is between Mac and other platforms. 943691 3 zan 2013-10-25 12:28:28 -0700 Non-Mac platforms don't define ENABLE_8BIT_TEXTRUN to 1, so the TextRun constructor implicitly converts the character data to a WTF::String. The length parameter that's passed to the TextRun constructor is then ignored, and the length of the complete string is used. 943876 4 zan 2013-10-26 05:34:16 -0700 (In reply to comment #3) > The length parameter that's passed to the TextRun constructor is then ignored, and the length of the complete string is used. The length parameter is actually used as the xpos value rather than the length. Anyway, enabling the 8-bit text runs works for the GTK port. Modifying the TextRun construction in the textWidth function would likely work equally well. The 8-bit TextRun was introduced in bug #96979, but was only enabled for the Mac port because code of other platforms needed additional modifications to properly support the introduced optimization. https://bugs.webkit.org/show_bug.cgi?id=96979#c9 The GTK port doesn't seem affected when running the tests with the support for 8-bit text runs enabled, so simply enabling the feature define would work. I'd also like to see people test out the feature on other ports and provide the proper changes so the define can be removed entirely. 944080 5 koivisto 2013-10-28 07:54:50 -0700 Ah ok. Thanks for looking into this. We should really make String(const char*) explicit to avoid bugs like this. 977351 6 ossy 2014-02-06 08:37:20 -0800 ENABLE_8BIT_TEXTRUN guards were removed by https://trac.webkit.org/changeset/163478 So let's go ahead. 977354 7 223334 ossy 2014-02-06 08:39:13 -0800 Created attachment 223334 Patch 977378 8 223334 ossy 2014-02-06 09:24:57 -0800 Comment on attachment 223334 Patch Clearing flags on attachment: 223334 Committed r163537: <http://trac.webkit.org/changeset/163537> 977379 9 ossy 2014-02-06 09:25:03 -0800 All reviewed patches have been landed. Closing bug. 223334 2014-02-06 08:39:13 -0800 2014-02-06 09:24:57 -0800 Patch bug-123338-20140206173911.patch text/plain 1646 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVlZWU0MjllZTVkM2Zk NmFlZDliZDVhODZjNmMzNzI3NGUyYTg5Zi4uMjJhMDMwN2U3NTI3MjFhNTlkNmJjMjE0NjFmYzQw ZTY2MmYwNWQyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTA2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmUtZW5hYmxlIHNp bXBsZSBsaW5lIGxheW91dCBvbiBub24tTWFjIHBsYXRmb3JtcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMzM4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvU2ltcGxlTGluZUxheW91 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3IpOgor CiAyMDE0LTAyLTA2ICBMw6FzemzDsyBMYW5nw7MgIDxsbGFuZ28udS1zemVnZWRAcGFydG5lci5z YW1zdW5nLmNvbT4KIAogICAgICAgICBDcmVhdGUgYSBIVE1MVW5rbm93bkVsZW1lbnQgd2hlbiB1 c2luZyBjcmVhdGVFbGVtZW50KCdpbWFnZScpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv U2ltcGxlTGluZUxheW91dC5jcHAKaW5kZXggMGNlYzMwNzY5NTM4ZWNlZTUyMThhMjVlYmEyYjcw MTNjZDBjZDY1Yy4uMzhiNTkyODI3ODc4NWUzMDIxODU2ZjA2NGM1MjA2NjlhOTZlZjVkMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcApAQCAtODks MTEgKzg5LDYgQEAgc3RhdGljIGJvb2wgY2FuVXNlRm9yVGV4dChjb25zdCBSZW5kZXJUZXh0JiB0 ZXh0UmVuZGVyZXIsIGNvbnN0IFNpbXBsZUZvbnREYXRhJgogCiBib29sIGNhblVzZUZvcihjb25z dCBSZW5kZXJCbG9ja0Zsb3cmIGZsb3cpCiB7Ci0jaWYgIVBMQVRGT1JNKE1BQykgJiYgIVBMQVRG T1JNKEdUSykgJiYgIVBMQVRGT1JNKEVGTCkKLSAgICAvLyBGSVhNRTogTm9uLW1hYyBwbGF0Zm9y bXMgYXJlIGhpdHRpbmcgQVNTRVJUKHJ1bi5jaGFyYWN0ZXJzTGVuZ3RoKCkgPj0gcnVuLmxlbmd0 aCgpKQotICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMz MzgKLSAgICByZXR1cm4gZmFsc2U7Ci0jZWxzZQogICAgIGlmICghZmxvdy5mcmFtZSgpLnNldHRp bmdzKCkuc2ltcGxlTGluZUxheW91dEVuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIGlmICghZmxvdy5maXJzdENoaWxkKCkpCkBAIC0yMDAsNyArMTk1LDYgQEAgYm9vbCBjYW5V c2VGb3IoY29uc3QgUmVuZGVyQmxvY2tGbG93JiBmbG93KQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKICAgICByZXR1cm4gdHJ1ZTsKLSNlbmRpZgogfQogCiBzdHJ1Y3QgU3R5bGUgewo=