123330 2013-10-25 02:49:02 -0700 Fix the ENABLE(CSS_FILTERS) && USE(COORDINATED_GRAPHICS) build after r157803 2013-10-25 23:35:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 123139 1 ossy ossy andersca commit-queue ossy sergio thorton oldest_to_newest 943507 0 ossy 2013-10-25 02:49:02 -0700 SSIA. Patch is coming. 943511 1 215158 ossy 2013-10-25 03:08:45 -0700 Created attachment 215158 Patch Coordinated Graphics already has its own implementation for encoding/decoding FilterOperations in Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp and it works with FilterOperation::VALIDATED_CUSTOM typed filter operations too. r157803 caused build failure on USE(COORDINATED_GRAPHICS) platforms if ENABLE(CSS_FILTERS) is true due to duplicated encoder/decoder implementation. 943512 2 ossy 2013-10-25 03:14:38 -0700 An ideal fix would be to merge the two code paths ... but I don't know if Apple wants FilterOperation::VALIDATED_CUSTOM or Coordinated Graphics platforms could live without it. So the proposed fix is the most conservative way for the fix without any behavioural change on any platform. 943859 3 215158 commit-queue 2013-10-25 23:35:40 -0700 Comment on attachment 215158 Patch Clearing flags on attachment: 215158 Committed r158081: <http://trac.webkit.org/changeset/158081> 943860 4 commit-queue 2013-10-25 23:35:41 -0700 All reviewed patches have been landed. Closing bug. 215158 2013-10-25 03:08:45 -0700 2013-10-25 23:35:40 -0700 Patch bug-123330-20131025030918.patch text/plain 2366 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3OTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTZiYjQyY2NmNWYxMzE0 MTg0OWJjYzcyNDk2Zjc1ZTI1MWFkZmJkMC4uZDY5ZjFlNDUxNWEzMzE1YTRlZjQ2YjkwODYxODhm MmQ3YTI0ZjYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEwLTI1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBFTkFC TEUoQ1NTX0ZJTFRFUlMpICYmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykgYnVpbGQgYWZ0ZXIg cjE1NzgwMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIzMzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcDoKKyAgICAgICAgKiBTaGFyZWQvV2Vi Q29yZUFyZ3VtZW50Q29kZXJzLmg6CisKIDIwMTMtMTAtMjUgIFJ5dWFuIENob2kgIDxyeXVhbi5j aG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0gQnVpbGQgYnJlYWsgYWZ0ZXIg cjE1Nzk2NyBhbmQgcjE1Nzk3MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dl YkNvcmVBcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFy Z3VtZW50Q29kZXJzLmNwcAppbmRleCAwMjllZjNkMTliYTcxY2RhN2E4MzRhODdjNTE5NGM3NjU0 MzdmZTNjLi40NGZiNGI5Y2Q2Yzk0NTU3M2U2ZTc3ZjRiOTY2YjljMjNiZWYzYjBkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcApAQCAtMTE2 NCw3ICsxMTY0LDcgQEAgYm9vbCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OlVzZXJTY3JpcHQ+Ojpk ZWNvZGUoQXJndW1lbnREZWNvZGVyJiBkZWNvZGVyLCBXZWJDb3IKICAgICByZXR1cm4gdHJ1ZTsK IH0KIAotI2lmIEVOQUJMRShDU1NfRklMVEVSUykKKyNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpICYm ICFVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1MpCiBzdGF0aWMgdm9pZCBlbmNvZGVGaWx0ZXJPcGVy YXRpb24oQXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBGaWx0ZXJPcGVyYXRpb24mIGZp bHRlcikKIHsKICAgICBlbmNvZGVyLmVuY29kZUVudW0oZmlsdGVyLnR5cGUoKSk7CkBAIC0xMzA1 LDYgKzEzMDUsNiBAQCBib29sIEFyZ3VtZW50Q29kZXI8RmlsdGVyT3BlcmF0aW9ucz46OmRlY29k ZShBcmd1bWVudERlY29kZXImIGRlY29kZXIsIEZpbHRlck9wZQogCiAgICAgcmV0dXJuIHRydWU7 CiB9Ci0jZW5kaWYgLy8gRU5BQkxFKENTU19GSUxURVJTKQorI2VuZGlmIC8vIEVOQUJMRShDU1Nf RklMVEVSUykgJiYgIVVTRShDT09SRElOQVRFRF9HUkFQSElDUykKIAogfSAvLyBuYW1lc3BhY2Ug Q29yZUlQQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVu dENvZGVycy5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5o CmluZGV4IDY2MjgzY2I0YTQ4ZmVlODc2OWY4OWI3YmIxOTdkY2YzODczOTMzNGIuLjE4ZGJjZjg5 YzkwNDVhZWY3YTExMmQ0NTAyYWNmZjliZmUzNTVlMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgKQEAgLTI5MSwxMSArMjkxLDEyIEBAIHRlbXBs YXRlPD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8V2ViQ29yZTo6VXNlclNjcmlwdD4gewogICAgIHN0 YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29kZXImLCBXZWJDb3JlOjpVc2VyU2NyaXB0Jik7 CiB9OwogCisjaWYgRU5BQkxFKENTU19GSUxURVJTKSAmJiAhVVNFKENPT1JESU5BVEVEX0dSQVBI SUNTKQogdGVtcGxhdGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpGaWx0ZXJPcGVy YXRpb25zPiB7CiAgICAgc3RhdGljIHZvaWQgZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYsIGNvbnN0 IFdlYkNvcmU6OkZpbHRlck9wZXJhdGlvbnMmKTsKICAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJn dW1lbnREZWNvZGVyJiwgV2ViQ29yZTo6RmlsdGVyT3BlcmF0aW9ucyYpOwogfTsKLQorI2VuZGlm CiAKIH0gLy8gbmFtZXNwYWNlIENvcmVJUEMKIAo=