123299 2013-10-24 16:10:46 -0700 The GetById->GetByOffset AI-based optimization should actually do things 2013-10-28 10:18:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 943341 0 fpizlo 2013-10-24 16:10:46 -0700 Somehow or another, we ended up turning this optimization off by making GetByIdStatus not set m_state to Simple. The result was that we'd return a GetByIdStatus advertising that it has NoInformation, and the abstract interpreter would assume that it can't optimize the GetById. Lol. 943344 1 215118 fpizlo 2013-10-24 16:12:54 -0700 Created attachment 215118 the patch 944139 2 fpizlo 2013-10-28 10:18:36 -0700 Landed in http://trac.webkit.org/changeset/158114 215118 2013-10-24 16:12:54 -0700 2013-10-24 16:18:26 -0700 the patch blah.patch text/plain 1304 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3OTU4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEwLTI0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg VGhlIEdldEJ5SWQtPkdldEJ5T2Zmc2V0IEFJLWJhc2VkIG9wdGltaXphdGlvbiBzaG91bGQgYWN0 dWFsbHkgZG8gdGhpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjMyOTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGJ5dGVjb2RlL0dldEJ5SWRTdGF0dXMuY3BwOgorICAgICAgICAoSlNDOjpHZXRC eUlkU3RhdHVzOjpjb21wdXRlRm9yKTogQWN0dWFsbHkgZmluaXNoIGZpbGxpbmcgaW4gdGhlIFN0 YXR1cyBieSBzZXR0aW5nIHRoZSBzdGF0ZS4gUHJldmlvdXNseSBpdCB3b3VsZCByZW1haW4gc2V0 IHRvIE5vSW5mb3JtYXRpb24sIG1lYW5pbmcgdGhhdCB0aGlzIHdob2xlIG1ldGhvZCB3YXMgYSBu by1vcC4KKwogMjAxMy0xMC0yNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAg ICAgICAgQmV0dGVyIHdheSB0byBmaXggcGFydCBvZiBicm9rZW4gQyBMb29wIExMSU5UIGJ1aWxk LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5SWRTdGF0dXMuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9HZXRCeUlkU3Rh dHVzLmNwcAkocmV2aXNpb24gMTU3OTA0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL0dldEJ5SWRTdGF0dXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODAsNiArMjgwLDcgQEAg R2V0QnlJZFN0YXR1cyBHZXRCeUlkU3RhdHVzOjpjb21wdXRlRm9yKAogICAgICAgICBzcGVjaWZp Y1ZhbHVlID0gMDsKICAgICByZXN1bHQubV9zdHJ1Y3R1cmVTZXQuYWRkKHN0cnVjdHVyZSk7CiAg ICAgcmVzdWx0Lm1fc3BlY2lmaWNWYWx1ZSA9IEpTVmFsdWUoc3BlY2lmaWNWYWx1ZSk7CisgICAg cmVzdWx0Lm1fc3RhdGUgPSBTaW1wbGU7CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAo=