123298 2013-10-24 16:06:43 -0700 Cache line layout path 2013-10-25 02:49:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 943339 0 koivisto 2013-10-24 16:06:43 -0700 Avoid testing repeatedly 943342 1 215116 koivisto 2013-10-24 16:11:41 -0700 Created attachment 215116 patch 943348 2 kling 2013-10-24 16:26:32 -0700 Maybe we should call this "code path" rather than "path" since paths can be something else entirely in (SVG) layout context. 943414 3 215116 commit-queue 2013-10-24 19:31:29 -0700 Comment on attachment 215116 patch Clearing flags on attachment: 215116 Committed r157985: <http://trac.webkit.org/changeset/157985> 943415 4 commit-queue 2013-10-24 19:31:31 -0700 All reviewed patches have been landed. Closing bug. 215116 2013-10-24 16:11:41 -0700 2013-10-24 19:31:28 -0700 patch cache-layout-path.patch text/plain 7030 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Nzk1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBACisyMDEzLTEwLTI0ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBDYWNoZSBsaW5lIGxheW91dCBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMy OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIERldGVybWluaW5nIHRoZSBwYXRoIGNhbiBiZSBub24tdHJpdmlhbC4gQXZvaWQgY29tcHV0 aW5nIGl0IHJlcGVhdGVkbHkgb24gcmVsYXlvdXRzLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpSZW5kZXJCbG9j ayk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6YWRkQ2hpbGRJZ25vcmluZ0Fub255 bW91c0NvbHVtbkJsb2Nrcyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6aW52YWxp ZGF0ZUxpbmVMYXlvdXRQYXRoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpyZW1v dmVDaGlsZCk6CisgICAgICAgIAorICAgICAgICAgICAgSW52YWxpZGF0ZSB0aGUgcGF0aCB3aGVu IGNoaWxkcmVuIGNoYW5nZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyQmxvY2tGbG93OjpsYXlvdXRJbmxpbmVDaGlsZHJlbik6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJCbG9ja0Zsb3c6OnN0eWxlRGlkQ2hhbmdlKToKKyAgICAgICAgCisgICAgICAg ICAgICBJbnZhbGlkYXRlIHRoZSBwYXRoIHdoZW4gc3R5bGUgY2hhbmdlcy4KKworICAgICAgICAo V2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjpkZWxldGVMaW5lQm94ZXNCZWZvcmVTaW1wbGVMaW5l TGF5b3V0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6ZW5zdXJlTGluZUJv eGVzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJUZXh0OjpzZXRUZXh0KToKKyAgICAgICAgCisgICAgICAgICAgICBJbnZhbGlk YXRlIHRoZSBwYXRoIHdoZW4gdGV4dCBjaGFuZ2VzLgorCiAyMDEzLTEwLTI0ICBUaGlhZ28gZGUg QmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAg IFtNZWRpYVN0cmVhbSBBUEldIGFsbG93IGEgc3RyZWFtIHNvdXJjZSB0byBiZSBzaGFyZWQKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gMTU3 OTUwKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTUyLDcgKzE1Miw3IEBAIFJlbmRlckJsb2NrOjpSZW5kZXJCbG9jayhFbGVt ZW50JiBlbGVtZW4KICAgICAsIG1fYmVpbmdEZXN0cm95ZWQoZmFsc2UpCiAgICAgLCBtX2hhc01h cmt1cFRydW5jYXRpb24oZmFsc2UpCiAgICAgLCBtX2hhc0JvcmRlck9yUGFkZGluZ0xvZ2ljYWxX aWR0aENoYW5nZWQoZmFsc2UpCi0gICAgLCBtX2ZvcmNlTGluZUJveExheW91dChmYWxzZSkKKyAg ICAsIG1fbGluZUxheW91dFBhdGgoVW5kZXRlcm1pbmVkUGF0aCkKICNpZiBFTkFCTEUoSU9TX1RF WFRfQVVUT1NJWklORykKICAgICAsIG1fd2lkdGhGb3JUZXh0QXV0b3NpemluZygtMSkKICAgICAs IG1fbGluZUNvdW50Rm9yVGV4dEF1dG9zaXppbmcoTk9UX1NFVCkKQEAgLTE2OCw3ICsxNjgsNyBA QCBSZW5kZXJCbG9jazo6UmVuZGVyQmxvY2soRG9jdW1lbnQmIGRvY3VtCiAgICAgLCBtX2JlaW5n RGVzdHJveWVkKGZhbHNlKQogICAgICwgbV9oYXNNYXJrdXBUcnVuY2F0aW9uKGZhbHNlKQogICAg ICwgbV9oYXNCb3JkZXJPclBhZGRpbmdMb2dpY2FsV2lkdGhDaGFuZ2VkKGZhbHNlKQotICAgICwg bV9mb3JjZUxpbmVCb3hMYXlvdXQoZmFsc2UpCisgICAgLCBtX2xpbmVMYXlvdXRQYXRoKFVuZGV0 ZXJtaW5lZFBhdGgpCiAjaWYgRU5BQkxFKElPU19URVhUX0FVVE9TSVpJTkcpCiAgICAgLCBtX3dp ZHRoRm9yVGV4dEF1dG9zaXppbmcoLTEpCiAgICAgLCBtX2xpbmVDb3VudEZvclRleHRBdXRvc2l6 aW5nKE5PVF9TRVQpCkBAIC04MjIsNiArODIyLDggQEAgdm9pZCBSZW5kZXJCbG9jazo6YWRkQ2hp bGRJZ25vcmluZ0Fub255bQogICAgICAgICB9CiAgICAgfQogCisgICAgaW52YWxpZGF0ZUxpbmVM YXlvdXRQYXRoKCk7CisKICAgICBSZW5kZXJCb3g6OmFkZENoaWxkKG5ld0NoaWxkLCBiZWZvcmVD aGlsZCk7CiAgCiAgICAgLy8gSGFuZGxlIHBsYWNlbWVudCBvZiBydW4taW5zLgpAQCAtODk0LDYg Kzg5NiwxMyBAQCB2b2lkIFJlbmRlckJsb2NrOjpkZWxldGVMaW5lcygpCiAgICAgICAgIGNhY2hl LT5yZWNvbXB1dGVJc0lnbm9yZWQodGhpcyk7CiB9CiAKK3ZvaWQgUmVuZGVyQmxvY2s6OmludmFs aWRhdGVMaW5lTGF5b3V0UGF0aCgpCit7CisgICAgaWYgKG1fbGluZUxheW91dFBhdGggPT0gRm9y Y2VMaW5lQm94ZXNQYXRoKQorICAgICAgICByZXR1cm47CisgICAgbV9saW5lTGF5b3V0UGF0aCA9 IFVuZGV0ZXJtaW5lZFBhdGg7Cit9CisKIHZvaWQgUmVuZGVyQmxvY2s6Om1ha2VDaGlsZHJlbk5v bklubGluZShSZW5kZXJPYmplY3QqIGluc2VydGlvblBvaW50KQogeyAgICAKICAgICAvLyBtYWtl Q2hpbGRyZW5Ob25JbmxpbmUgdGFrZXMgYSBibG9jayB3aG9zZSBjaGlsZHJlbiBhcmUgKmFsbCog aW5saW5lIGFuZCBpdApAQCAtMTExNSw2ICsxMTI0LDggQEAgdm9pZCBSZW5kZXJCbG9jazo6cmVt b3ZlQ2hpbGQoUmVuZGVyT2JqZQogICAgICAgICB9CiAgICAgfQogCisgICAgaW52YWxpZGF0ZUxp bmVMYXlvdXRQYXRoKCk7CisKICAgICBSZW5kZXJCb3g6OnJlbW92ZUNoaWxkKG9sZENoaWxkKTsK IAogICAgIFJlbmRlck9iamVjdCogY2hpbGQgPSBwcmV2ID8gcHJldiA6IG5leHQ7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAkocmV2aXNpb24gMTU3OTUwKQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAg LTExNyw2ICsxMTcsOCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0QmxvY2so Ym9vbCByZWxheW91dENoaWxkcmVuLCBMYXlvdXRVbml0IHBhZ2VMb2dpY2FsSGVpZ2h0ID0gMCk7 CiAKKyAgICB2b2lkIGludmFsaWRhdGVMaW5lTGF5b3V0UGF0aCgpOworCiAgICAgdm9pZCBpbnNl cnRQb3NpdGlvbmVkT2JqZWN0KFJlbmRlckJveCYpOwogICAgIHN0YXRpYyB2b2lkIHJlbW92ZVBv c2l0aW9uZWRPYmplY3QoUmVuZGVyQm94Jik7CiAgICAgdm9pZCByZW1vdmVQb3NpdGlvbmVkT2Jq ZWN0cyhSZW5kZXJCbG9jayosIENvbnRhaW5pbmdCbG9ja1N0YXRlID0gU2FtZUNvbnRhaW5pbmdC bG9jayk7CkBAIC03NTEsMTMgKzc1MywxNCBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAgT3du UHRyPFJlbmRlckJsb2NrUmFyZURhdGE+IG1fcmFyZURhdGE7CiAKLSAgICBtdXRhYmxlIHNpZ25l ZCBtX2xpbmVIZWlnaHQgOiAyNjsKKyAgICBtdXRhYmxlIHNpZ25lZCBtX2xpbmVIZWlnaHQgOiAy NTsKICAgICB1bnNpZ25lZCBtX2hhc01hcmdpbkJlZm9yZVF1aXJrIDogMTsgLy8gTm90ZSB0aGVz ZSBxdWlyayB2YWx1ZXMgY2FuJ3QgYmUgcHV0IGluIFJlbmRlckJsb2NrUmFyZURhdGEgc2luY2Ug dGhleSBhcmUgc2V0IHRvbyBmcmVxdWVudGx5LgogICAgIHVuc2lnbmVkIG1faGFzTWFyZ2luQWZ0 ZXJRdWlyayA6IDE7CiAgICAgdW5zaWduZWQgbV9iZWluZ0Rlc3Ryb3llZCA6IDE7CiAgICAgdW5z aWduZWQgbV9oYXNNYXJrdXBUcnVuY2F0aW9uIDogMTsKICAgICB1bnNpZ25lZCBtX2hhc0JvcmRl ck9yUGFkZGluZ0xvZ2ljYWxXaWR0aENoYW5nZWQgOiAxOwotICAgIHVuc2lnbmVkIG1fZm9yY2VM aW5lQm94TGF5b3V0IDogMTsKKyAgICBlbnVtIExpbmVMYXlvdXRQYXRoIHsgVW5kZXRlcm1pbmVk UGF0aCwgU2ltcGxlTGluZXNQYXRoLCBMaW5lQm94ZXNQYXRoLCBGb3JjZUxpbmVCb3hlc1BhdGgg fTsKKyAgICB1bnNpZ25lZCBtX2xpbmVMYXlvdXRQYXRoIDogMjsKIAogI2lmIEVOQUJMRShJT1Nf VEVYVF9BVVRPU0laSU5HKQogICAgIGludCBtX3dpZHRoRm9yVGV4dEF1dG9zaXppbmc7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAkocmV2aXNp b24gMTU3OTUwKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTUyMiw4ICs1MjIsMTAgQEAgdm9pZCBSZW5kZXJCbG9ja0Zs b3c6OmxheW91dEJsb2NrQ2hpbGRyZQogCiB2b2lkIFJlbmRlckJsb2NrRmxvdzo6bGF5b3V0SW5s aW5lQ2hpbGRyZW4oYm9vbCByZWxheW91dENoaWxkcmVuLCBMYXlvdXRVbml0JiByZXBhaW50TG9n aWNhbFRvcCwgTGF5b3V0VW5pdCYgcmVwYWludExvZ2ljYWxCb3R0b20pCiB7Ci0gICAgYm9vbCBj YW5Vc2VTaW1wbGVMaW5lTGF5b3V0ID0gIW1fZm9yY2VMaW5lQm94TGF5b3V0ICYmIFNpbXBsZUxp bmVMYXlvdXQ6OmNhblVzZUZvcigqdGhpcyk7Ci0gICAgaWYgKGNhblVzZVNpbXBsZUxpbmVMYXlv dXQpIHsKKyAgICBpZiAobV9saW5lTGF5b3V0UGF0aCA9PSBVbmRldGVybWluZWRQYXRoKQorICAg ICAgICBtX2xpbmVMYXlvdXRQYXRoID0gU2ltcGxlTGluZUxheW91dDo6Y2FuVXNlRm9yKCp0aGlz KSA/IFNpbXBsZUxpbmVzUGF0aCA6IExpbmVCb3hlc1BhdGg7CisKKyAgICBpZiAobV9saW5lTGF5 b3V0UGF0aCA9PSBTaW1wbGVMaW5lc1BhdGgpIHsKICAgICAgICAgZGVsZXRlTGluZUJveGVzQmVm b3JlU2ltcGxlTGluZUxheW91dCgpOwogICAgICAgICBsYXlvdXRTaW1wbGVMaW5lcyhyZXBhaW50 TG9naWNhbFRvcCwgcmVwYWludExvZ2ljYWxCb3R0b20pOwogICAgICAgICByZXR1cm47CkBAIC0x NjI3LDYgKzE2MjksOSBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6c3R5bGVEaWRDaGFuZ2UoU3R5 CiAKICAgICBpZiAocmVuZGVyTmFtZWRGbG93RnJhZ21lbnQoKSkKICAgICAgICAgcmVuZGVyTmFt ZWRGbG93RnJhZ21lbnQoKS0+c2V0U3R5bGVGb3JOYW1lZEZsb3dGcmFnbWVudChzdHlsZSgpKTsK KworICAgIGlmIChkaWZmID49IFN0eWxlRGlmZmVyZW5jZVJlcGFpbnQpCisgICAgICAgIGludmFs aWRhdGVMaW5lTGF5b3V0UGF0aCgpOwogfQogCiB2b2lkIFJlbmRlckJsb2NrRmxvdzo6c3R5bGVX aWxsQ2hhbmdlKFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogbmV3U3R5 bGUpCkBAIC0zMDIwLDE0ICszMDI1LDE0IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93OjpsYXlvdXRT aW1wbGVMaW5lcygKIAogdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmRlbGV0ZUxpbmVCb3hlc0JlZm9y ZVNpbXBsZUxpbmVMYXlvdXQoKQogewotICAgIEFTU0VSVCghbV9mb3JjZUxpbmVCb3hMYXlvdXQp OworICAgIEFTU0VSVChtX2xpbmVMYXlvdXRQYXRoID09IFNpbXBsZUxpbmVzUGF0aCk7CiAgICAg bGluZUJveGVzKCkuZGVsZXRlTGluZUJveGVzKHJlbmRlckFyZW5hKCkpOwogICAgIHRvUmVuZGVy VGV4dChmaXJzdENoaWxkKCkpLT5kZWxldGVMaW5lQm94ZXNCZWZvcmVTaW1wbGVMaW5lTGF5b3V0 KCk7CiB9CiAKIHZvaWQgUmVuZGVyQmxvY2tGbG93OjplbnN1cmVMaW5lQm94ZXMoKQogewotICAg IG1fZm9yY2VMaW5lQm94TGF5b3V0ID0gdHJ1ZTsKKyAgICBtX2xpbmVMYXlvdXRQYXRoID0gRm9y Y2VMaW5lQm94ZXNQYXRoOwogCiAgICAgaWYgKCFtX3NpbXBsZUxpbmVzKQogICAgICAgICByZXR1 cm47CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCShyZXZpc2lv biAxNTc5NTApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEwMTAsNiArMTAxMCw5IEBAIHZvaWQgUmVuZGVyVGV4dDo6c2V0VGV4 dChjb25zdCBTdHJpbmcmIHQKICAgICBzZXRUZXh0SW50ZXJuYWwodGV4dCk7CiAgICAgc2V0TmVl ZHNMYXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxjKCk7CiAgICAgbV9rbm93blRvSGF2ZU5vT3ZlcmZs b3dBbmROb0ZhbGxiYWNrRm9udHMgPSBmYWxzZTsKKworICAgIGlmIChwYXJlbnQoKS0+aXNSZW5k ZXJCbG9ja0Zsb3coKSkKKyAgICAgICAgdG9SZW5kZXJCbG9ja0Zsb3cocGFyZW50KCkpLT5pbnZh bGlkYXRlTGluZUxheW91dFBhdGgoKTsKICAgICAKICAgICBpZiAoQVhPYmplY3RDYWNoZSogY2Fj aGUgPSBkb2N1bWVudCgpLmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpKQogICAgICAgICBjYWNoZS0+ dGV4dENoYW5nZWQodGhpcyk7Cg==