123297 2013-10-24 16:05:19 -0700 Web Inspector: Allow editing CSS resources after they have been pretty printed 2013-10-24 17:13:58 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 943338 0 timothy 2013-10-24 16:05:19 -0700 Currently all pretty printed resources are made readOnly. However, this doesn't need to be the case, and it makes for weird inconsistency when CSS resources are sometimes editable and sometimes not (when pretty printed). CSS resources should always be editable. <rdar://problem/13563198> 943340 1 215115 timothy 2013-10-24 16:08:09 -0700 Created attachment 215115 Patch 943355 2 215115 joepeck 2013-10-24 16:51:37 -0700 Comment on attachment 215115 Patch r=me! 943361 3 215115 commit-queue 2013-10-24 17:13:56 -0700 Comment on attachment 215115 Patch Clearing flags on attachment: 215115 Committed r157966: <http://trac.webkit.org/changeset/157966> 943362 4 commit-queue 2013-10-24 17:13:58 -0700 All reviewed patches have been landed. Closing bug. 215115 2013-10-24 16:08:09 -0700 2013-10-24 17:13:56 -0700 Patch pretty-edit.patch text/plain 3289 timothy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJkNGRiYTguLjQ1NTZhOGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEwLTI0ICBUaW1vdGh5IEhhdGNo ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBBbGxvdyBlZGl0aW5nIENTUyByZXNv dXJjZXMgYWZ0ZXIgdGhleSBoYXZlIGJlZW4gcHJldHR5IHByaW50ZWQuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzI5NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9UZXh0 RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IpOiBSZW1vdmUgdGhl IG5lZWQgZm9yIF9yZWFkT25seS4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnBy b3RvdHlwZS5zZXQgcmVhZE9ubHkpOiBTZXQgQ29kZU1pcnJvciByZWFkT25seSBkaXJlY3RseS4K KyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5zZXQgZm9ybWF0dGVk KTogRG9uJ3QgY2FsbCBfdXBkYXRlQ29kZU1pcnJvclJlYWRPbmx5LgorICAgICAgICAoV2ViSW5z cGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLl91cGRhdGVDb2RlTWlycm9yUmVhZE9ubHkpOiBS ZW1vdmVkLgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLl9jb250 ZW50Q2hhbmdlZCk6IENsZWFyIF9mb3JtYXR0ZWQgYW5kIF9mb3JtYXR0ZXJTb3VyY2VNYXAKKyAg ICAgICAgb24gZWRpdCBhbmQgbm90aWZ5IHRoZSBkZWxlZ2F0ZSBhbmQgZmlyZSB0aGUgRm9ybWF0 dGluZ0RpZENoYW5nZSBldmVudC4KKwogMjAxMy0xMC0yMSAgQWxleGFuZHJ1IENoaWN1bGl0YSAg PGFjaGljdUBhZG9iZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW0NTUyBSZWdpb25z XSBGbG93cyBhcmUgbm90IGxvYWRpbmcgaWYgeW91IHJlZnJlc2ggdGhlIHBhZ2Ugc2V2ZXJhbCB0 aW1lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGV4 dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1RleHRFZGl0 b3IuanMKaW5kZXggOTUxYjE4NC4uNGRhNjJjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9UZXh0RWRpdG9yLmpzCkBAIC0zMiwxMCArMzIsOCBAQCBXZWJJ bnNwZWN0b3IuVGV4dEVkaXRvciA9IGZ1bmN0aW9uKGVsZW1lbnQsIG1pbWVUeXBlLCBkZWxlZ2F0 ZSkKICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTGlzdC5hZGQoV2ViSW5zcGVjdG9yLlRleHRFZGl0 b3IuU3R5bGVDbGFzc05hbWUpOwogICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZChXZWJJ bnNwZWN0b3IuU3ludGF4SGlnaGxpZ2h0ZWRTdHlsZUNsYXNzTmFtZSk7CiAKLSAgICB0aGlzLl9y ZWFkT25seSA9IHRydWU7Ci0KICAgICB0aGlzLl9jb2RlTWlycm9yID0gQ29kZU1pcnJvcih0aGlz LmVsZW1lbnQsIHsKLSAgICAgICAgcmVhZE9ubHk6IHRoaXMuX3JlYWRPbmx5LAorICAgICAgICBy ZWFkT25seTogdHJ1ZSwKICAgICAgICAgaW5kZW50V2l0aFRhYnM6IHRydWUsCiAgICAgICAgIGlu ZGVudFVuaXQ6IDQsCiAgICAgICAgIGxpbmVOdW1iZXJzOiB0cnVlLApAQCAtMTQ4LDggKzE0Niw3 IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKIAogICAgIHNldCByZWFk T25seShyZWFkT25seSkKICAgICB7Ci0gICAgICAgIHRoaXMuX3JlYWRPbmx5ID0gcmVhZE9ubHk7 Ci0gICAgICAgIHRoaXMuX3VwZGF0ZUNvZGVNaXJyb3JSZWFkT25seSgpOworICAgICAgICB0aGlz Ll9jb2RlTWlycm9yLnNldE9wdGlvbigicmVhZE9ubHkiLCByZWFkT25seSk7CiAgICAgfSwKIAog ICAgIGdldCBmb3JtYXR0ZWQoKQpAQCAtMTcxLDcgKzE2OCw2IEBAIFdlYkluc3BlY3Rvci5UZXh0 RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgZGVsZXRlIHRoaXMuX2lnbm9yZUNvZGVNaXJy b3JDb250ZW50RGlkQ2hhbmdlRXZlbnQ7CiAKICAgICAgICAgdGhpcy5fZm9ybWF0dGVkID0gZm9y bWF0dGVkOwotICAgICAgICB0aGlzLl91cGRhdGVDb2RlTWlycm9yUmVhZE9ubHkoKTsKIAogICAg ICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuVGV4dEVkaXRv ci5FdmVudC5Gb3JtYXR0aW5nRGlkQ2hhbmdlKTsKICAgICB9LApAQCAtNTk0LDE1ICs1OTAsMjEg QEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlID0gewogCiAgICAgLy8gUHJpdmF0 ZQogCi0gICAgX3VwZGF0ZUNvZGVNaXJyb3JSZWFkT25seTogZnVuY3Rpb24oKQotICAgIHsKLSAg ICAgICAgdGhpcy5fY29kZU1pcnJvci5zZXRPcHRpb24oInJlYWRPbmx5IiwgdGhpcy5fcmVhZE9u bHkgfHwgdGhpcy5fZm9ybWF0dGVkKTsKLSAgICB9LAotCiAgICAgX2NvbnRlbnRDaGFuZ2VkOiBm dW5jdGlvbihjb2RlTWlycm9yLCBjaGFuZ2UpCiAgICAgewogICAgICAgICBpZiAodGhpcy5faWdu b3JlQ29kZU1pcnJvckNvbnRlbnREaWRDaGFuZ2VFdmVudCkKICAgICAgICAgICAgIHJldHVybjsK KworICAgICAgICBpZiAodGhpcy5fZm9ybWF0dGVkKSB7CisgICAgICAgICAgICB0aGlzLl9mb3Jt YXR0ZXJTb3VyY2VNYXAgPSBudWxsOworICAgICAgICAgICAgdGhpcy5fZm9ybWF0dGVkID0gZmFs c2U7CisKKyAgICAgICAgICAgIGlmICh0aGlzLl9kZWxlZ2F0ZSAmJiB0eXBlb2YgdGhpcy5fZGVs ZWdhdGUudGV4dEVkaXRvclVwZGF0ZWRGb3JtYXR0aW5nID09PSAiZnVuY3Rpb24iKQorICAgICAg ICAgICAgICAgIHRoaXMuX2RlbGVnYXRlLnRleHRFZGl0b3JVcGRhdGVkRm9ybWF0dGluZyh0aGlz KTsKKworICAgICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVj dG9yLlRleHRFZGl0b3IuRXZlbnQuRm9ybWF0dGluZ0RpZENoYW5nZSk7CisgICAgICAgIH0KKwog ICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuVGV4dEVk aXRvci5FdmVudC5Db250ZW50RGlkQ2hhbmdlKTsKICAgICB9LAogCg==